[GitHub] [hbase] virajjasani commented on pull request #3303: HBASE-25906 UI of master-status to show recent history of balancer de…

2021-05-24 Thread GitBox
virajjasani commented on pull request #3303: URL: https://github.com/apache/hbase/pull/3303#issuecomment-847555722 @GeorryHuang There is no header.jsp change in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hbase] virajjasani merged pull request #3296: HBASE-25906 UI of master-status to show recent history of balancer de…

2021-05-24 Thread GitBox
virajjasani merged pull request #3296: URL: https://github.com/apache/hbase/pull/3296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-847548849 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-847547207 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3304: Backport "HBASE-25534 Honor TableDescriptor settings earlier in normalization (#2917)" to branch-2

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3304: URL: https://github.com/apache/hbase/pull/3304#issuecomment-847533758 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25534) Honor TableDescriptor settings earlier in normalization

2021-05-24 Thread Baiqiang Zhao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350784#comment-17350784 ] Baiqiang Zhao commented on HBASE-25534: --- Put up a PR for branch-2. > Honor TableDescriptor

[GitHub] [hbase] ZhaoBQ opened a new pull request #3304: Backport "HBASE-25534 Honor TableDescriptor settings earlier in normalization (#2917)" to branch-2

2021-05-24 Thread GitBox
ZhaoBQ opened a new pull request #3304: URL: https://github.com/apache/hbase/pull/3304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] ZhaoBQ commented on pull request #3139: HBASE-25745 Deprecate/Rename config `hbase.normalizer.min.region.coun…

2021-05-24 Thread GitBox
ZhaoBQ commented on pull request #3139: URL: https://github.com/apache/hbase/pull/3139#issuecomment-847517956 Thanks @ndimiduk, let me do the backport. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] sunhelly commented on a change in pull request #3297: HBASE-25905 Limit the shutdown time of WAL

2021-05-24 Thread GitBox
sunhelly commented on a change in pull request #3297: URL: https://github.com/apache/hbase/pull/3297#discussion_r638439826 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java ## @@ -986,14 +996,43 @@ public void shutdown()

[jira] [Commented] (HBASE-25898) RS getting aborted due to NPE in Replication WALEntryStream

2021-05-24 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350778#comment-17350778 ] Hudson commented on HBASE-25898: Results for branch branch-2 [build #259 on

[jira] [Commented] (HBASE-25899) Improve efficiency of SnapshotHFileCleaner

2021-05-24 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350777#comment-17350777 ] Hudson commented on HBASE-25899: Results for branch branch-2 [build #259 on

[jira] [Commented] (HBASE-25873) Refactor and cleanup the code for CostFunction

2021-05-24 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350776#comment-17350776 ] Hudson commented on HBASE-25873: Results for branch branch-2 [build #259 on

[GitHub] [hbase] sunhelly commented on a change in pull request #3297: HBASE-25905 Limit the shutdown time of WAL

2021-05-24 Thread GitBox
sunhelly commented on a change in pull request #3297: URL: https://github.com/apache/hbase/pull/3297#discussion_r638437219 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java ## @@ -145,6 +148,10 @@ public static final

[GitHub] [hbase] Apache-HBase commented on pull request #3303: HBASE-25906 UI of master-status to show recent history of balancer de…

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3303: URL: https://github.com/apache/hbase/pull/3303#issuecomment-847509014 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] GeorryHuang opened a new pull request #3303: HBASE-25906 UI of master-status to show recent history of balancer de…

2021-05-24 Thread GitBox
GeorryHuang opened a new pull request #3303: URL: https://github.com/apache/hbase/pull/3303 …sicion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase] Apache-HBase commented on pull request #3206: HBASE-25818 Move StochasticLoadBalancer to hbase-balancer module

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3206: URL: https://github.com/apache/hbase/pull/3206#issuecomment-847503489 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25914) Provide slow/large logs on RegionServer UI

2021-05-24 Thread Zhuoyue Huang (Jira)
Zhuoyue Huang created HBASE-25914: - Summary: Provide slow/large logs on RegionServer UI Key: HBASE-25914 URL: https://issues.apache.org/jira/browse/HBASE-25914 Project: HBase Issue Type:

[jira] [Commented] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350761#comment-17350761 ] Andrew Kyle Purtell commented on HBASE-24440: - One early A/B test worth doing is A=spin

[jira] [Commented] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350759#comment-17350759 ] Andrew Kyle Purtell commented on HBASE-24440: - That worst case could be possible but it’s

[jira] [Commented] (HBASE-25906) UI of master-status to show recent history of balancer desicion

2021-05-24 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350756#comment-17350756 ] Bharath Vissapragada commented on HBASE-25906: -- Thanks for the patch, useful addition. >

[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-847491257 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25906) UI of master-status to show recent history of balancer desicion

2021-05-24 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350750#comment-17350750 ] Zhuoyue Huang commented on HBASE-25906: --- No problem, I would like to provide UI on RegionServer >

[jira] [Commented] (HBASE-25906) UI of master-status to show recent history of balancer desicion

2021-05-24 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350751#comment-17350751 ] Zhuoyue Huang commented on HBASE-25906: --- [~zhangduo] [~vjasani] Thanks for reviewing. > UI of

[jira] [Commented] (HBASE-25906) UI of master-status to show recent history of balancer desicion

2021-05-24 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350749#comment-17350749 ] Zhuoyue Huang commented on HBASE-25906: --- [~vjasani] Thanks!  > UI of master-status to show recent

[jira] [Commented] (HBASE-25666) Explain why balancer is skipping runs

2021-05-24 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350747#comment-17350747 ] Zhuoyue Huang commented on HBASE-25666: --- If there are no other suggestions, this issue could be

[jira] [Updated] (HBASE-25666) Explain why balancer is skipping runs

2021-05-24 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang updated HBASE-25666: -- Fix Version/s: 2.4.4 2.5.0 3.0.0-alpha-1 > Explain why

[jira] [Commented] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick

2021-05-24 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350742#comment-17350742 ] Bharath Vissapragada commented on HBASE-24440: -- Ok, looking forward to the performance

[jira] [Commented] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350736#comment-17350736 ] Andrew Kyle Purtell commented on HBASE-24440: - Also as I said for batches the advancing time

[jira] [Commented] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350729#comment-17350729 ] Andrew Kyle Purtell commented on HBASE-24440: - No this will not be pluggable. It is a new

[jira] [Updated] (HBASE-25894) Improve the performance for region load and region count related cost functions

2021-05-24 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25894: -- Release Note: In CostFromRegionLoadFunction, now we will only recompute the cost for a given region

[jira] [Commented] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick

2021-05-24 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350726#comment-17350726 ] Bharath Vissapragada commented on HBASE-24440: -- > new EnvironmentEdge#currentTimeAdvancing

[jira] [Comment Edited] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350718#comment-17350718 ] Andrew Kyle Purtell edited comment on HBASE-25913 at 5/25/21, 1:46 AM:

[jira] [Comment Edited] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350718#comment-17350718 ] Andrew Kyle Purtell edited comment on HBASE-25913 at 5/25/21, 1:45 AM:

[jira] [Commented] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350718#comment-17350718 ] Andrew Kyle Purtell commented on HBASE-25913: - {quote}Clients must simply not submit

[jira] [Comment Edited] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350711#comment-17350711 ] Andrew Kyle Purtell edited comment on HBASE-24440 at 5/25/21, 1:39 AM:

[jira] [Updated] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25913: Description: Introduce new {{EnvironmentEdge#currentTimeAdvancing}} which ensures

[jira] [Updated] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25913: Description: Introduce new {{EnvironmentEdge#currentTimeAdvancing}} which ensures

[jira] [Commented] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-24 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350713#comment-17350713 ] Duo Zhang commented on HBASE-25913: --- +1 > Introduce EnvironmentEdge.currentTimeAdvancing >

[jira] [Updated] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25913: Description: Introduce new {{EnvironmentEdge#currentTimeAdvancing}} which ensures

[GitHub] [hbase] Apache9 commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-24 Thread GitBox
Apache9 commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-847463261 What about System.nanoTime? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Comment Edited] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350711#comment-17350711 ] Andrew Kyle Purtell edited comment on HBASE-24440 at 5/25/21, 1:28 AM:

[jira] [Assigned] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell reassigned HBASE-25913: --- Assignee: Andrew Kyle Purtell > Introduce

[jira] [Updated] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25913: Description: Introduce new {{EnvironmentEdge#currentTimeAdvancing}} which ensures

[jira] [Created] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-24 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-25913: --- Summary: Introduce EnvironmentEdge.currentTimeAdvancing Key: HBASE-25913 URL: https://issues.apache.org/jira/browse/HBASE-25913 Project: HBase

[jira] [Work started] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24440 started by Andrew Kyle Purtell. --- > Prevent temporal misordering on timescales smaller than one

[jira] [Updated] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24440: Fix Version/s: 2.5.0 3.0.0-alpha-1 > Prevent temporal

[jira] [Commented] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350711#comment-17350711 ] Andrew Kyle Purtell commented on HBASE-24440: - I'm considering something simple: * Ensure

[jira] [Updated] (HBASE-25911) Fix uses of System.currentTimeMillis (should be EnvironmentEdgeManager.currentTime)

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25911: Status: Patch Available (was: Open) > Fix uses of System.currentTimeMillis

[GitHub] [hbase] apurtell opened a new pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-24 Thread GitBox
apurtell opened a new pull request #3302: URL: https://github.com/apache/hbase/pull/3302 We introduced EnvironmentEdgeManager a long time ago as a way to inject alternate clocks (gettimeofday() aka System.currentTimeMillis()) for unit tests. In order for this to be effective, all

[jira] [Resolved] (HBASE-25513) When the table is turned on normalize, the first region may not be merged even the size is 0

2021-05-24 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-25513. -- Resolution: Fixed > When the table is turned on normalize, the first region may not be merged

[jira] [Updated] (HBASE-25513) When the table is turned on normalize, the first region may not be merged even the size is 0

2021-05-24 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25513: - Fix Version/s: 2.5.0 > When the table is turned on normalize, the first region may not be

[GitHub] [hbase] ndimiduk merged pull request #3301: Backport "HBASE-25513 When the table is turned on normalize, the first region may not be merged even the size is 0" to branch-2

2021-05-24 Thread GitBox
ndimiduk merged pull request #3301: URL: https://github.com/apache/hbase/pull/3301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Created] (HBASE-25912) Ban System.currentTimeMillis with a build enforcer

2021-05-24 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-25912: --- Summary: Ban System.currentTimeMillis with a build enforcer Key: HBASE-25912 URL: https://issues.apache.org/jira/browse/HBASE-25912 Project: HBase

[jira] [Updated] (HBASE-25911) Fix uses of System.currentTimeMillis (should be EnvironmentEdgeManager.currentTime)

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25911: Summary: Fix uses of System.currentTimeMillis (should be

[jira] [Created] (HBASE-25911) Replace uses of System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-24 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-25911: --- Summary: Replace uses of System.currentTimeMillis with EnvironmentEdgeManager.currentTime Key: HBASE-25911 URL: https://issues.apache.org/jira/browse/HBASE-25911

[GitHub] [hbase] Apache-HBase commented on pull request #3301: Backport "HBASE-25513 When the table is turned on normalize, the first region may not be merged even the size is 0" to branch-2

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3301: URL: https://github.com/apache/hbase/pull/3301#issuecomment-847430846 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Assigned] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick

2021-05-24 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell reassigned HBASE-24440: --- Assignee: Andrew Kyle Purtell > Prevent temporal misordering on timescales

[GitHub] [hbase] Apache-HBase commented on pull request #3301: Backport "HBASE-25513 When the table is turned on normalize, the first region may not be merged even the size is 0" to branch-2

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3301: URL: https://github.com/apache/hbase/pull/3301#issuecomment-847430262 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-25910) Fix TestClusterPortAssignment.testClusterPortAssignment test and re-enable it.

2021-05-24 Thread Victor Li (Jira)
Victor Li created HBASE-25910: - Summary: Fix TestClusterPortAssignment.testClusterPortAssignment test and re-enable it. Key: HBASE-25910 URL: https://issues.apache.org/jira/browse/HBASE-25910 Project:

[GitHub] [hbase] Apache-HBase commented on pull request #3300: HBASE-25898 RS getting aborted due to NPE in Replication WALEntryStream

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3300: URL: https://github.com/apache/hbase/pull/3300#issuecomment-847387579 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 15m

[GitHub] [hbase] Apache-HBase commented on pull request #3301: Backport "HBASE-25513 When the table is turned on normalize, the first region may not be merged even the size is 0" to branch-2

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3301: URL: https://github.com/apache/hbase/pull/3301#issuecomment-847368526 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Reopened] (HBASE-25534) Honor TableDescriptor settings earlier in normalization

2021-05-24 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-25534: -- Reopen for backport to branch-2. > Honor TableDescriptor settings earlier in normalization >

[GitHub] [hbase] ndimiduk opened a new pull request #3301: Backport "HBASE-25513 When the table is turned on normalize, the first region may not be merged even the size is 0" to branch-2

2021-05-24 Thread GitBox
ndimiduk opened a new pull request #3301: URL: https://github.com/apache/hbase/pull/3301 Signed-off-by: Nick Dimiduk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[jira] [Reopened] (HBASE-25513) When the table is turned on normalize, the first region may not be merged even the size is 0

2021-05-24 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-25513: -- Missed backport to branch-2. > When the table is turned on normalize, the first region may not

[jira] [Commented] (HBASE-25888) Backup tests are categorically flakey

2021-05-24 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350608#comment-17350608 ] Nick Dimiduk commented on HBASE-25888: -- Thank you [~rda3mon] for the contribution, and [~zhangduo]

[GitHub] [hbase] Apache-HBase commented on pull request #3206: HBASE-25818 Move StochasticLoadBalancer to hbase-balancer module

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3206: URL: https://github.com/apache/hbase/pull/3206#issuecomment-847314388 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] joshelser commented on a change in pull request #3298: HBASE-25907 Move StoreFlushContext out of HStore and make it pluggable

2021-05-24 Thread GitBox
joshelser commented on a change in pull request #3298: URL: https://github.com/apache/hbase/pull/3298#discussion_r638244458 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFlushContext.java ## @@ -0,0 +1,183 @@ +/* + * Review

[GitHub] [hbase] Apache-HBase commented on pull request #3206: HBASE-25818 Move StochasticLoadBalancer to hbase-balancer module

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3206: URL: https://github.com/apache/hbase/pull/3206#issuecomment-847310645 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25909) Improve logging in "packaging and integration" stage

2021-05-24 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-25909: Summary: Improve logging in "packaging and integration" stage Key: HBASE-25909 URL: https://issues.apache.org/jira/browse/HBASE-25909 Project: HBase Issue

[jira] [Updated] (HBASE-25745) Deprecate/Rename config `hbase.normalizer.min.region.count` to `hbase.normalizer.merge.min.region.count`

2021-05-24 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25745: - Status: Patch Available (was: Open) > Deprecate/Rename config

[GitHub] [hbase] ndimiduk commented on pull request #3139: HBASE-25745 Deprecate/Rename config `hbase.normalizer.min.region.coun…

2021-05-24 Thread GitBox
ndimiduk commented on pull request #3139: URL: https://github.com/apache/hbase/pull/3139#issuecomment-847307159 @ZhaoBQ the master patch has conflicts when I backport it to branch-2. I'm guessing there's a patch on master that's missing on branch-2, because branch-2 doesn't have the

[jira] [Updated] (HBASE-25745) Deprecate/Rename config `hbase.normalizer.min.region.count` to `hbase.normalizer.merge.min.region.count`

2021-05-24 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25745: - Fix Version/s: 3.0.0-alpha-1 > Deprecate/Rename config `hbase.normalizer.min.region.count` to

[GitHub] [hbase] ben-manes commented on a change in pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-05-24 Thread GitBox
ben-manes commented on a change in pull request #3215: URL: https://github.com/apache/hbase/pull/3215#discussion_r638239220 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/TinyLfuBlockCache.java ## @@ -158,7 +158,13 @@ public boolean

[GitHub] [hbase] ndimiduk merged pull request #3139: HBASE-25745 Deprecate/Rename config `hbase.normalizer.min.region.coun…

2021-05-24 Thread GitBox
ndimiduk merged pull request #3139: URL: https://github.com/apache/hbase/pull/3139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (HBASE-25888) Backup tests are categorically flakey

2021-05-24 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350596#comment-17350596 ] Hudson commented on HBASE-25888: Results for branch master [build #302 on

[GitHub] [hbase] Apache-HBase commented on pull request #3298: HBASE-25907 Move StoreFlushContext out of HStore and make it pluggable

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3298: URL: https://github.com/apache/hbase/pull/3298#issuecomment-847296624 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on a change in pull request #3139: HBASE-25745 Deprecate/Rename config `hbase.normalizer.min.region.coun…

2021-05-24 Thread GitBox
ndimiduk commented on a change in pull request #3139: URL: https://github.com/apache/hbase/pull/3139#discussion_r638234965 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -540,24 +546,34 @@ public boolean

[GitHub] [hbase] saintstack commented on a change in pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-05-24 Thread GitBox
saintstack commented on a change in pull request #3215: URL: https://github.com/apache/hbase/pull/3215#discussion_r638224781 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/TinyLfuBlockCache.java ## @@ -158,7 +158,13 @@ public boolean

[GitHub] [hbase] ben-manes commented on a change in pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-05-24 Thread GitBox
ben-manes commented on a change in pull request #3215: URL: https://github.com/apache/hbase/pull/3215#discussion_r638213661 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/TinyLfuBlockCache.java ## @@ -158,7 +158,13 @@ public boolean

[GitHub] [hbase] Apache-HBase commented on pull request #3276: HBASE-25894 Improve the performance for region load and region count related cost functions

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3276: URL: https://github.com/apache/hbase/pull/3276#issuecomment-847255393 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] anoopsjohn opened a new pull request #3300: HBASE-25898 RS getting aborted due to NPE in Replication WALEntryStream

2021-05-24 Thread GitBox
anoopsjohn opened a new pull request #3300: URL: https://github.com/apache/hbase/pull/3300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase] Apache-HBase commented on pull request #3298: HBASE-25907 Move StoreFlushContext out of HStore and make it pluggable

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3298: URL: https://github.com/apache/hbase/pull/3298#issuecomment-847243958 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] pankaj72981 commented on a change in pull request #3297: HBASE-25905 Limit the shutdown time of WAL

2021-05-24 Thread GitBox
pankaj72981 commented on a change in pull request #3297: URL: https://github.com/apache/hbase/pull/3297#discussion_r638171667 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java ## @@ -145,6 +148,10 @@ public static final

[GitHub] [hbase] anoopsjohn merged pull request #3292: HBASE-25898 RS getting aborted due to NPE in Replication WALEntryStream

2021-05-24 Thread GitBox
anoopsjohn merged pull request #3292: URL: https://github.com/apache/hbase/pull/3292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #3295: HBASE-25890 [Addendum] create profiles for different jdk version

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3295: URL: https://github.com/apache/hbase/pull/3295#issuecomment-847230392 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] anoopsjohn commented on pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-05-24 Thread GitBox
anoopsjohn commented on pull request #3215: URL: https://github.com/apache/hbase/pull/3215#issuecomment-847220592 Ref count is used in all cases now. This has become a part of the ByteBuff which holds the block data. Ya this was added so as to unify the code. We needed refCount at

[GitHub] [hbase] virajjasani commented on pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-05-24 Thread GitBox
virajjasani commented on pull request #3215: URL: https://github.com/apache/hbase/pull/3215#issuecomment-847217261 Okk looks like refCount was introduced with ByteBuff only, checking HBASE-22005 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] virajjasani commented on pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-05-24 Thread GitBox
virajjasani commented on pull request #3215: URL: https://github.com/apache/hbase/pull/3215#issuecomment-847215393 > Will open an issue to address once an idea on how to address perf (this is secondary to fixing refcounting exceptions). refCount is not used for just L1 cache right?

[GitHub] [hbase] Apache-HBase commented on pull request #3276: HBASE-25894 Improve the performance for region load and region count related cost functions

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3276: URL: https://github.com/apache/hbase/pull/3276#issuecomment-847214523 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3297: HBASE-25905 Limit the shutdown time of WAL

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3297: URL: https://github.com/apache/hbase/pull/3297#issuecomment-847213651 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3297: HBASE-25905 Limit the shutdown time of WAL

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3297: URL: https://github.com/apache/hbase/pull/3297#issuecomment-847207839 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3206: HBASE-25818 Move StochasticLoadBalancer to hbase-balancer module

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3206: URL: https://github.com/apache/hbase/pull/3206#issuecomment-847207147 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25893) Corruption in recovered WAL in WALSplitter

2021-05-24 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350548#comment-17350548 ] Rushabh Shah commented on HBASE-25893: -- > Applicable only for branch-1? [~anoop.hbase] Yes. could

[GitHub] [hbase] saintstack commented on a change in pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-05-24 Thread GitBox
saintstack commented on a change in pull request #3215: URL: https://github.com/apache/hbase/pull/3215#discussion_r638134220 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/TinyLfuBlockCache.java ## @@ -158,7 +158,13 @@ public boolean

[GitHub] [hbase] Apache-HBase commented on pull request #3299: HBASE-25908 Exclude jakarta.activation-api

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3299: URL: https://github.com/apache/hbase/pull/3299#issuecomment-847204515 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3299: HBASE-25908 Exclude jakarta.activation-api

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3299: URL: https://github.com/apache/hbase/pull/3299#issuecomment-847202415 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25901) Replication may lose data during regionserver restart when multiwal is in use

2021-05-24 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350536#comment-17350536 ] Hudson commented on HBASE-25901: Results for branch branch-2.3 [build #223 on

[GitHub] [hbase] Apache-HBase commented on pull request #3299: HBASE-25908 Exclude jakarta.activation-api

2021-05-24 Thread GitBox
Apache-HBase commented on pull request #3299: URL: https://github.com/apache/hbase/pull/3299#issuecomment-847199527 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-05-24 Thread GitBox
virajjasani commented on a change in pull request #3215: URL: https://github.com/apache/hbase/pull/3215#discussion_r638125789 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/TinyLfuBlockCache.java ## @@ -158,7 +158,13 @@ public boolean

[GitHub] [hbase] jojochuang opened a new pull request #3299: HBASE-25908 Exclude jakarta.activation-api

2021-05-24 Thread GitBox
jojochuang opened a new pull request #3299: URL: https://github.com/apache/hbase/pull/3299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

  1   2   >