[GitHub] [hbase] Apache9 commented on pull request #3324: HBASE-25931 Move FavoredNodeManager to hbase-balancer module

2021-05-27 Thread GitBox
Apache9 commented on pull request #3324: URL: https://github.com/apache/hbase/pull/3324#issuecomment-850158380 The failed UT is introduced by https://issues.apache.org/jira/browse/HBASE-25924 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] Apache-HBase commented on pull request #3324: HBASE-25931 Move FavoredNodeManager to hbase-balancer module

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3324: URL: https://github.com/apache/hbase/pull/3324#issuecomment-850156590 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3326: HBASE-25930 Add doAs support for Thrift Server

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3326: URL: https://github.com/apache/hbase/pull/3326#issuecomment-850149797 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3326: HBASE-25930 Add doAs support for Thrift Server

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3326: URL: https://github.com/apache/hbase/pull/3326#issuecomment-850147596 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3326: HBASE-25930 Add doAs support for Thrift Server

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3326: URL: https://github.com/apache/hbase/pull/3326#issuecomment-850146194 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3320: HBASE-25928 TestHBaseConfiguration#testDeprecatedConfigurations is broken with Hadoop 3.3

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3320: URL: https://github.com/apache/hbase/pull/3320#issuecomment-85011 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3320: HBASE-25928 TestHBaseConfiguration#testDeprecatedConfigurations is broken with Hadoop 3.3

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3320: URL: https://github.com/apache/hbase/pull/3320#issuecomment-850141206 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] tomscut commented on a change in pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-05-27 Thread GitBox
tomscut commented on a change in pull request #3325: URL: https://github.com/apache/hbase/pull/3325#discussion_r641273820 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -486,7 +488,9 @@ boolean incNextCallSeq(long

[GitHub] [hbase] Apache-HBase commented on pull request #3320: HBASE-25928 TestHBaseConfiguration#testDeprecatedConfigurations is broken with Hadoop 3.3

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3320: URL: https://github.com/apache/hbase/pull/3320#issuecomment-850137220 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3266: URL: https://github.com/apache/hbase/pull/3266#issuecomment-850135296 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Haoning-Sun opened a new pull request #3326: HBASE-25930 Add doAs support for Thrift Server

2021-05-27 Thread GitBox
Haoning-Sun opened a new pull request #3326: URL: https://github.com/apache/hbase/pull/3326 Add doAs support for Thrift Server -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] frostruan commented on pull request #3261: HBASE-25880 remove files from filesCompacting when clear compaction queue

2021-05-27 Thread GitBox
frostruan commented on pull request #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-850129971 @Apache9 @guangxuCheng hi, any questions here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hbase] saintstack commented on pull request #3320: HBASE-25928 TestHBaseConfiguration#testDeprecatedConfigurations is broken with Hadoop 3.3

2021-05-27 Thread GitBox
saintstack commented on pull request #3320: URL: https://github.com/apache/hbase/pull/3320#issuecomment-850125863 The build failed a dependency download. Retrying. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (HBASE-25914) Provide slow/large logs on RegionServer UI

2021-05-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352958#comment-17352958 ] Michael Stack commented on HBASE-25914: --- Please say more on this feature [~GeorryHuang]. It looks

[GitHub] [hbase] Apache-HBase commented on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-850122158 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-05-27 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352478#comment-17352478 ] Viraj Jasani edited comment on HBASE-25902 at 5/28/21, 4:09 AM:

[GitHub] [hbase] hehuanshu closed pull request #3322: HBASE-25930 Add doAs support for Thrift Server

2021-05-27 Thread GitBox
hehuanshu closed pull request #3322: URL: https://github.com/apache/hbase/pull/3322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] saintstack commented on a change in pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-05-27 Thread GitBox
saintstack commented on a change in pull request #3325: URL: https://github.com/apache/hbase/pull/3325#discussion_r641240369 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -486,7 +488,9 @@ boolean incNextCallSeq(long

[jira] [Commented] (HBASE-25758) Move MetaTableAccessor out of hbase-balancer module

2021-05-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352942#comment-17352942 ] Michael Stack commented on HBASE-25758: --- bq. Finally we have done the moving back of

[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3266: URL: https://github.com/apache/hbase/pull/3266#issuecomment-850087440 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] tomscut opened a new pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-05-27 Thread GitBox
tomscut opened a new pull request #3325: URL: https://github.com/apache/hbase/pull/3325 JIRA: [HBASE-25934](https://issues.apache.org/jira/browse/HBASE-25934) This JIRA [HBASE-25542](https://issues.apache.org/jira/browse/HBASE-25542) has added part of the client information before,

[jira] [Created] (HBASE-25934) Add username for RegionScannerHolder

2021-05-27 Thread tomscut (Jira)
tomscut created HBASE-25934: --- Summary: Add username for RegionScannerHolder Key: HBASE-25934 URL: https://issues.apache.org/jira/browse/HBASE-25934 Project: HBase Issue Type: Wish

[jira] [Commented] (HBASE-25894) Improve the performance for region load and region count related cost functions

2021-05-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352934#comment-17352934 ] Andrew Kyle Purtell commented on HBASE-25894: - Sounds good, thanks. > Improve the

[GitHub] [hbase] Apache-HBase commented on pull request #3324: HBASE-25931 Move FavoredNodeManager to hbase-balancer module

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3324: URL: https://github.com/apache/hbase/pull/3324#issuecomment-850070721 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Comment Edited] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352925#comment-17352925 ] Andrew Kyle Purtell edited comment on HBASE-25913 at 5/28/21, 2:32 AM:

[jira] [Comment Edited] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352925#comment-17352925 ] Andrew Kyle Purtell edited comment on HBASE-25913 at 5/28/21, 2:30 AM:

[jira] [Updated] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25913: Attachment: jmh-HBASE-25913.tar.gz > Introduce

[jira] [Commented] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352925#comment-17352925 ] Andrew Kyle Purtell commented on HBASE-25913: - I've put together a JMH based harness,

[GitHub] [hbase] Apache9 opened a new pull request #3324: HBASE-25931 Move FavoredNodeManager to hbase-balancer module

2021-05-27 Thread GitBox
Apache9 opened a new pull request #3324: URL: https://github.com/apache/hbase/pull/3324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Updated] (HBASE-25908) Exclude jakarta.activation-api

2021-05-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25908: -- Fix Version/s: 2.4.4 > Exclude jakarta.activation-api > -- > >

[jira] [Commented] (HBASE-25908) Exclude jakarta.activation-api

2021-05-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352919#comment-17352919 ] Michael Stack commented on HBASE-25908: --- nvm... just simple excludes. Harmless. Backported to 2.4.

[jira] [Comment Edited] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352918#comment-17352918 ] Bharath Vissapragada edited comment on HBASE-25932 at 5/28/21, 1:27 AM:

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352918#comment-17352918 ] Bharath Vissapragada commented on HBASE-25932: -- Wrote a quick patch to test an approach and

[jira] [Updated] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-25932: - Attachment: HBASE-25932-test-approach.patch >

[jira] [Commented] (HBASE-25758) Move MetaTableAccessor out of hbase-balancer module

2021-05-27 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352917#comment-17352917 ] Duo Zhang commented on HBASE-25758: --- [~stack] FYI. Finally we have done the moving back of

[jira] [Resolved] (HBASE-25908) Exclude jakarta.activation-api

2021-05-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25908. --- Fix Version/s: 2.5.0 3.0.0-alpha-1 Hadoop Flags: Reviewed

[jira] [Resolved] (HBASE-25758) Move MetaTableAccessor out of hbase-balancer module

2021-05-27 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25758. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to master. Thanks [~niuyulin] for reviewing.

[GitHub] [hbase] Apache9 merged pull request #3309: HBASE-25758 Move MetaTableAccessor out of hbase-balancer module

2021-05-27 Thread GitBox
Apache9 merged pull request #3309: URL: https://github.com/apache/hbase/pull/3309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] Apache9 commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-27 Thread GitBox
Apache9 commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-850043118 > > What about System.nanoTime? > > @Apache9 System.nanotime is not used to get the system clock. I don't mind bringing it into EnvironmentEdge but I don't care about it

[GitHub] [hbase] saintstack merged pull request #3299: HBASE-25908 Exclude jakarta.activation-api

2021-05-27 Thread GitBox
saintstack merged pull request #3299: URL: https://github.com/apache/hbase/pull/3299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3308: URL: https://github.com/apache/hbase/pull/3308#issuecomment-850026675 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3308: URL: https://github.com/apache/hbase/pull/3308#issuecomment-850023007 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352872#comment-17352872 ] Bharath Vissapragada edited comment on HBASE-25932 at 5/27/21, 11:11 PM:

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352872#comment-17352872 ] Bharath Vissapragada commented on HBASE-25932: -- Yes, I agree there is a race with AsyncWAL

[GitHub] [hbase] Apache-HBase commented on pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3308: URL: https://github.com/apache/hbase/pull/3308#issuecomment-849924157 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-27 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352729#comment-17352729 ] Rushabh Shah commented on HBASE-25924: -- [~apurtell] let's wait until tomorrow. If  unable to find a

[jira] [Comment Edited] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352720#comment-17352720 ] Andrew Kyle Purtell edited comment on HBASE-25924 at 5/27/21, 7:54 PM:

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352721#comment-17352721 ] Andrew Kyle Purtell commented on HBASE-25932: - I have reopened HBASE-25924. We shouldn't

[jira] [Commented] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352720#comment-17352720 ] Andrew Kyle Purtell commented on HBASE-25924: - The test failure is being tracked by

[jira] [Work started] (HBASE-25910) Fix TestClusterPortAssignment.testClusterPortAssignment test and re-enable it.

2021-05-27 Thread Victor Li (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25910 started by Victor Li. - > Fix TestClusterPortAssignment.testClusterPortAssignment test and re-enable it. >

[jira] [Commented] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352715#comment-17352715 ] Hudson commented on HBASE-25924: Results for branch branch-2.4 [build #128 on

[jira] [Updated] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-27 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-25924: -- Fix Version/s: (was: 1.7.0) 1.7.1 > Seeing a spike in uncleanlyClosedWALs

[GitHub] [hbase] Apache-HBase commented on pull request #3323: HBASE-25933 Log trace raw exception, instead of cause message in Nett…

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3323: URL: https://github.com/apache/hbase/pull/3323#issuecomment-849873885 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] apurtell edited a comment on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-27 Thread GitBox
apurtell edited a comment on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-849872794 > What about System.nanoTime? @Apache9 System.nanotime is not used to get the system clock. I don't mind bringing it into EnvironmentEdge but I don't care about it

[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-27 Thread GitBox
apurtell commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-849872794 > What about System.nanoTime? @Apache9 System.nanotime is not used to get the system clock. I don't mind bringing it into EnvironmentEdge but I don't care about it here.

[jira] [Commented] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-27 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352708#comment-17352708 ] Rushabh Shah commented on HBASE-25924: -- [~apurtell] I created this ticket

[jira] [Updated] (HBASE-25933) Log trace raw exception, instead of cause message in NettyRpcServerRequestDecoder

2021-05-27 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25933: - Fix Version/s: 2.4.4 2.3.6 2.5.0

[jira] [Resolved] (HBASE-25933) Log trace raw exception, instead of cause message in NettyRpcServerRequestDecoder

2021-05-27 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-25933. -- Resolution: Fixed Thanks for reviewing [~rushabh.shah] [~psomogyi] [~elserj]!

[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-27 Thread GitBox
apurtell commented on pull request #3302: URL: https://github.com/apache/hbase/pull/3302#issuecomment-849871673 TestWALEntryStream failure is not related. It is because of HBASE-25924, which I have reopened. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Reopened] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-27 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell reopened HBASE-25924: - This change causes a consistent test failure on master branch (at least). It's

[jira] [Updated] (HBASE-25933) Log trace raw exception, instead of cause message in NettyRpcServerRequestDecoder

2021-05-27 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25933: - Affects Version/s: 2.5.0 > Log trace raw exception, instead of cause message in

[GitHub] [hbase] wchevreuil merged pull request #3323: HBASE-25933 Log trace raw exception, instead of cause message in Nett…

2021-05-27 Thread GitBox
wchevreuil merged pull request #3323: URL: https://github.com/apache/hbase/pull/3323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Comment Edited] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352693#comment-17352693 ] Rushabh Shah edited comment on HBASE-25932 at 5/27/21, 6:47 PM: > When I

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352693#comment-17352693 ] Rushabh Shah commented on HBASE-25932: -- > When I tried locally with above changes in place on

[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3266: URL: https://github.com/apache/hbase/pull/3266#issuecomment-849839743 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3323: HBASE-25933 Log trace raw exception, instead of cause message in Nett…

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3323: URL: https://github.com/apache/hbase/pull/3323#issuecomment-849826069 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 12m

[GitHub] [hbase] Apache-HBase commented on pull request #3063: HBASE-25651: NORMALIZER_TARGET_REGION_SIZE needs a unit in its name

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3063: URL: https://github.com/apache/hbase/pull/3063#issuecomment-849824109 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3063: HBASE-25651: NORMALIZER_TARGET_REGION_SIZE needs a unit in its name

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3063: URL: https://github.com/apache/hbase/pull/3063#issuecomment-849822591 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3308: URL: https://github.com/apache/hbase/pull/3308#issuecomment-849822109 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3063: HBASE-25651: NORMALIZER_TARGET_REGION_SIZE needs a unit in its name

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3063: URL: https://github.com/apache/hbase/pull/3063#issuecomment-849818977 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352635#comment-17352635 ] Viraj Jasani edited comment on HBASE-25932 at 5/27/21, 5:41 PM:

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352635#comment-17352635 ] Viraj Jasani commented on HBASE-25932: -- {code:java} if (!isFirst) { // Re-compute the file

[jira] [Commented] (HBASE-25926) Cleanup MetaTableAccessor references in FavoredNodeBalancer related code

2021-05-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352633#comment-17352633 ] Hudson commented on HBASE-25926: Results for branch branch-2 [build #262 on

[jira] [Commented] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352632#comment-17352632 ] Hudson commented on HBASE-25924: Results for branch branch-2 [build #262 on

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352630#comment-17352630 ] Rushabh Shah commented on HBASE-25932: -- > Btw if you revert reading wal size in ProtobufLogReader,

[jira] [Comment Edited] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352628#comment-17352628 ] Viraj Jasani edited comment on HBASE-25932 at 5/27/21, 5:05 PM: Hmm, let

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352628#comment-17352628 ] Viraj Jasani commented on HBASE-25932: -- Hmm, let me take a detailed look tomorrow. Btw if you

[GitHub] [hbase] Apache-HBase commented on pull request #3063: HBASE-25651: NORMALIZER_TARGET_REGION_SIZE needs a unit in its name

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3063: URL: https://github.com/apache/hbase/pull/3063#issuecomment-849795328 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3063: HBASE-25651: NORMALIZER_TARGET_REGION_SIZE needs a unit in its name

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3063: URL: https://github.com/apache/hbase/pull/3063#issuecomment-849794004 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3063: HBASE-25651: NORMALIZER_TARGET_REGION_SIZE needs a unit in its name

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3063: URL: https://github.com/apache/hbase/pull/3063#issuecomment-849790733 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352610#comment-17352610 ] Rushabh Shah commented on HBASE-25932: -- But what the EOF exceptions that we might encounter in

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352590#comment-17352590 ] Viraj Jasani commented on HBASE-25932: -- I meant test case only since we can't be sure about wait

[GitHub] [hbase] Apache-HBase commented on pull request #3063: HBASE-25651: NORMALIZER_TARGET_REGION_SIZE needs a unit in its name

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3063: URL: https://github.com/apache/hbase/pull/3063#issuecomment-849748849 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3063: HBASE-25651: NORMALIZER_TARGET_REGION_SIZE needs a unit in its name

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3063: URL: https://github.com/apache/hbase/pull/3063#issuecomment-849746758 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3063: HBASE-25651: NORMALIZER_TARGET_REGION_SIZE needs a unit in its name

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3063: URL: https://github.com/apache/hbase/pull/3063#issuecomment-849746032 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352574#comment-17352574 ] Rushabh Shah commented on HBASE-25932: -- [~vjasani] Thank you for the feedback. Are you suggesting

[GitHub] [hbase] Apache-HBase commented on pull request #3323: HBASE-25933 Log trace raw exception, instead of cause message in Nett…

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3323: URL: https://github.com/apache/hbase/pull/3323#issuecomment-849742255 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 10m

[jira] [Comment Edited] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352564#comment-17352564 ] Viraj Jasani edited comment on HBASE-25932 at 5/27/21, 3:37 PM: Anyway

[jira] [Comment Edited] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352564#comment-17352564 ] Viraj Jasani edited comment on HBASE-25932 at 5/27/21, 3:33 PM: Anyway

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

2021-05-27 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352564#comment-17352564 ] Viraj Jasani commented on HBASE-25932: -- Anyway we can wait till WAL is closed before append and

[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3266: URL: https://github.com/apache/hbase/pull/3266#issuecomment-849730040 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25924) Seeing a spike in uncleanlyClosedWALs metric.

2021-05-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352561#comment-17352561 ] Hudson commented on HBASE-25924: Results for branch branch-1 [build #132 on

[GitHub] [hbase] Apache-HBase commented on pull request #3309: HBASE-25758 Move MetaTableAccessor out of hbase-balancer module

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3309: URL: https://github.com/apache/hbase/pull/3309#issuecomment-849712315 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3318: URL: https://github.com/apache/hbase/pull/3318#issuecomment-849708684 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] wchevreuil opened a new pull request #3323: HBASE-25933 Log trace raw exception, instead of cause message in Nett…

2021-05-27 Thread GitBox
wchevreuil opened a new pull request #3323: URL: https://github.com/apache/hbase/pull/3323 …yRpcServerRequestDecoder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[jira] [Updated] (HBASE-25933) Log trace raw exception, instead of cause message in NettyRpcServerRequestDecoder

2021-05-27 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25933: - Description: In *NettyRpcServerRequestDecoder,* override of *exceptionCaught*

[jira] [Updated] (HBASE-25933) Log trace raw exception, instead of cause message in NettyRpcServerRequestDecoder

2021-05-27 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25933: - Affects Version/s: 3.0.0-alpha-1 2.2.7

[jira] [Created] (HBASE-25933) Log trace raw exception, instead of cause message in NettyRpcServerRequestDecoder

2021-05-27 Thread Wellington Chevreuil (Jira)
Wellington Chevreuil created HBASE-25933: Summary: Log trace raw exception, instead of cause message in NettyRpcServerRequestDecoder Key: HBASE-25933 URL: https://issues.apache.org/jira/browse/HBASE-25933

[GitHub] [hbase] Apache-HBase commented on pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3318: URL: https://github.com/apache/hbase/pull/3318#issuecomment-849688976 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs

2021-05-27 Thread GitBox
Apache-HBase commented on pull request #3266: URL: https://github.com/apache/hbase/pull/3266#issuecomment-849666124 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

  1   2   >