Apache-HBase commented on pull request #3800:
URL: https://github.com/apache/hbase/pull/3800#issuecomment-998546453
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3970:
URL: https://github.com/apache/hbase/pull/3970#issuecomment-998534333
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
YutSean commented on a change in pull request #3964:
URL: https://github.com/apache/hbase/pull/3964#discussion_r772866871
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/CellBlockBuilder.java
##
@@ -294,14 +296,15 @@ private ByteBuffer
YutSean commented on a change in pull request #3964:
URL: https://github.com/apache/hbase/pull/3964#discussion_r772866871
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/CellBlockBuilder.java
##
@@ -294,14 +296,15 @@ private ByteBuffer
Apache-HBase commented on pull request #3969:
URL: https://github.com/apache/hbase/pull/3969#issuecomment-998512399
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
YutSean commented on a change in pull request #3964:
URL: https://github.com/apache/hbase/pull/3964#discussion_r772854823
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/CellBlockBuilder.java
##
@@ -294,14 +296,15 @@ private ByteBuffer
Apache9 commented on a change in pull request #3952:
URL: https://github.com/apache/hbase/pull/3952#discussion_r772851451
##
File path:
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionLocatorTracing.java
##
@@ -90,16 +102,33 @@ public void tearDown()
Apache9 commented on a change in pull request #3964:
URL: https://github.com/apache/hbase/pull/3964#discussion_r772849330
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/CellBlockBuilder.java
##
@@ -294,14 +296,15 @@ private ByteBuffer
Apache-HBase commented on pull request #3969:
URL: https://github.com/apache/hbase/pull/3969#issuecomment-998490523
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3970:
URL: https://github.com/apache/hbase/pull/3970#issuecomment-998477785
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3968:
URL: https://github.com/apache/hbase/pull/3968#issuecomment-998445010
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3968:
URL: https://github.com/apache/hbase/pull/3968#issuecomment-998442698
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3968:
URL: https://github.com/apache/hbase/pull/3968#issuecomment-998442081
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3969:
URL: https://github.com/apache/hbase/pull/3969#issuecomment-998440842
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
YutSean commented on a change in pull request #3968:
URL: https://github.com/apache/hbase/pull/3968#discussion_r772795251
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java
##
@@ -640,20 +640,17 @@ public static void incrementIv(byte[]
Apache-HBase commented on pull request #3968:
URL: https://github.com/apache/hbase/pull/3968#issuecomment-998428575
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3968:
URL: https://github.com/apache/hbase/pull/3968#issuecomment-998425927
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3968:
URL: https://github.com/apache/hbase/pull/3968#issuecomment-998425285
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-22953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang resolved HBASE-22953.
-
Fix Version/s: 2.3.0
3.0.0-alpha-1
Resolution: Fixed
>
Apache9 commented on a change in pull request #3968:
URL: https://github.com/apache/hbase/pull/3968#discussion_r772790543
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java
##
@@ -640,20 +640,17 @@ public static void incrementIv(byte[]
[
https://issues.apache.org/jira/browse/HBASE-26613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yutong Xiao updated HBASE-26613:
Description:
{code:java}
public static void incrementIv(byte[] iv, int v) {
int length =
Apache9 commented on pull request #3913:
URL: https://github.com/apache/hbase/pull/3913#issuecomment-998421074
Yes, spotless should be another issue.
And on the 'one line if', for me, as said above, the old fashion is to not
have '{}' at all, in our code base this is common. But
[
https://issues.apache.org/jira/browse/HBASE-26613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462935#comment-17462935
]
Yutong Xiao commented on HBASE-26613:
-
Yes, but for v > 1, the complexity is O(m*n), where m is
ndimiduk opened a new pull request #3969:
URL: https://github.com/apache/hbase/pull/3969
The code starting at `ZKUtil.dump(ZKWatcher)` is a small mess – it has
cyclic dependencies woven
through itself, `ZKWatcher` and `RecoverableZooKeeper`. It also initializes
a static variable in
Nick Dimiduk created HBASE-26614:
Summary: Refactor code related to "dump"ing ZK nodes
Key: HBASE-26614
URL: https://issues.apache.org/jira/browse/HBASE-26614
Project: HBase
Issue Type: Task
YutSean opened a new pull request #3968:
URL: https://github.com/apache/hbase/pull/3968
https://issues.apache.org/jira/browse/HBASE-26613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/HBASE-26613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462926#comment-17462926
]
Duo Zhang commented on HBASE-26613:
---
I think we need to reset carry to false at the beginning ofthe do
Yutong Xiao created HBASE-26613:
---
Summary: The logic of the method incrementIV in Encryption class
has problem
Key: HBASE-26613
URL: https://issues.apache.org/jira/browse/HBASE-26613
Project: HBase
Josh Elser created HBASE-26612:
--
Summary: Adjust log level when looking for .filelist/{f1,f2}
Key: HBASE-26612
URL: https://issues.apache.org/jira/browse/HBASE-26612
Project: HBase
Issue Type:
caroliney14 closed pull request #3606:
URL: https://github.com/apache/hbase/pull/3606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HBASE-26536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-26536:
-
Summary: Checkstyle: permit single-line if-then statements (was: Tweak
checkstyle LeftCurly
ndimiduk commented on a change in pull request #3951:
URL: https://github.com/apache/hbase/pull/3951#discussion_r772563706
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/trace/TableOperationSpanBuilder.java
##
@@ -82,6 +89,72 @@ public
ndimiduk commented on pull request #3913:
URL: https://github.com/apache/hbase/pull/3913#issuecomment-998145153
@Apache9 if you'd like to try out spotless, please open a separate issue for
that. I think it looks promising.
In the mean time, what's wrong with the single line scoped
Apache-HBase commented on pull request #3929:
URL: https://github.com/apache/hbase/pull/3929#issuecomment-998087570
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3929:
URL: https://github.com/apache/hbase/pull/3929#issuecomment-998035888
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3929:
URL: https://github.com/apache/hbase/pull/3929#issuecomment-997922417
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
YutSean commented on pull request #3929:
URL: https://github.com/apache/hbase/pull/3929#issuecomment-997885255
Refined the variable name in the latest commit. I think this is more
readable then.
--
This is an automated message from the Apache Git Service.
To respond to the message,
sunhelly commented on a change in pull request #3800:
URL: https://github.com/apache/hbase/pull/3800#discussion_r772230583
##
File path:
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/monitor/StreamSlowMonitor.java
##
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the
sunhelly commented on a change in pull request #3800:
URL: https://github.com/apache/hbase/pull/3800#discussion_r772227119
##
File path:
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/monitor/StreamSlowMonitor.java
##
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the
39 matches
Mail list logo
