[jira] [Updated] (HBASE-26652) Unintuitive AccesControlClient.getUserPermissions() semantics

2022-01-06 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated HBASE-26652: Description: The behaviour of the AccesControlClient.getUserPermissions() calls is unintuitive.

[jira] [Created] (HBASE-26652) Unintuitive AccesControlClient.getUserPermissions() semantics

2022-01-06 Thread Istvan Toth (Jira)
Istvan Toth created HBASE-26652: --- Summary: Unintuitive AccesControlClient.getUserPermissions() semantics Key: HBASE-26652 URL: https://issues.apache.org/jira/browse/HBASE-26652 Project: HBase

[GitHub] [hbase] Apache9 commented on pull request #4016: HBASE-26650 Create module hbase-client-test-support

2022-01-06 Thread GitBox
Apache9 commented on pull request #4016: URL: https://github.com/apache/hbase/pull/4016#issuecomment-1007188578 Why not just put them under hbase-client test code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hbase] Apache-HBase commented on pull request #4016: HBASE-26650 Create module hbase-client-test-support

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4016: URL: https://github.com/apache/hbase/pull/4016#issuecomment-1007178839 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] xicm edited a comment on pull request #3849: Hbase 26167

2022-01-06 Thread GitBox
xicm edited a comment on pull request #3849: URL: https://github.com/apache/hbase/pull/3849#issuecomment-1007142035 I have a problem, I run all the unit test with "mvn clean test" several times, The failed UTs are different each time. Then I run the failed UT with "mvn clean test

[GitHub] [hbase] xicm commented on pull request #3849: Hbase 26167

2022-01-06 Thread GitBox
xicm commented on pull request #3849: URL: https://github.com/apache/hbase/pull/3849#issuecomment-1007142035 I have a problem, I run all the unit test with "mvn clean test" several times, there are different failed cases every time. Then I run the failed UT with "mvn clean test

[jira] [Commented] (HBASE-26651) TestDrainReplicationQueuesForStandBy is flakey

2022-01-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470328#comment-17470328 ] Nick Dimiduk commented on HBASE-26651: -- I did a bisect as follows: {noformat} $ git bisect start

[jira] [Commented] (HBASE-26651) TestDrainReplicationQueuesForStandBy is flakey

2022-01-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470327#comment-17470327 ] Nick Dimiduk commented on HBASE-26651: -- {noformat} ca3ba494cbc322b0824d2d755bcf4191c3a525ed is the

[GitHub] [hbase] Apache-HBase commented on pull request #4014: Backport "HBASE-26474 Implement connection-level attributes" to branch-2

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4014: URL: https://github.com/apache/hbase/pull/4014#issuecomment-1007098783 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4014: Backport "HBASE-26474 Implement connection-level attributes" to branch-2

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4014: URL: https://github.com/apache/hbase/pull/4014#issuecomment-1007091155 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4016: HBASE-26650 Create module hbase-client-test-support

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4016: URL: https://github.com/apache/hbase/pull/4016#issuecomment-1007086677 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-26651) TestDrainReplicationQueuesForStandBy is flakey

2022-01-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470290#comment-17470290 ] Duo Zhang commented on HBASE-26651: --- This for sync replication so should not be affected by

[GitHub] [hbase] Apache9 commented on pull request #3973: HBASE-26616 Refactor code related to ZooKeeper authentication

2022-01-06 Thread GitBox
Apache9 commented on pull request #3973: URL: https://github.com/apache/hbase/pull/3973#issuecomment-1007074210 The error prone output is not very stable, so typically warnings should be fine, but if it fails the compilation then we still need to take care of it. -- This is an automated

[jira] [Updated] (HBASE-26616) Refactor code related to ZooKeeper authentication

2022-01-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26616: - Fix Version/s: 3.0.0-alpha-3 > Refactor code related to ZooKeeper authentication >

[GitHub] [hbase] ndimiduk merged pull request #3973: HBASE-26616 Refactor code related to ZooKeeper authentication

2022-01-06 Thread GitBox
ndimiduk merged pull request #3973: URL: https://github.com/apache/hbase/pull/3973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-26651) TestDrainReplicationQueuesForStandBy is flakey

2022-01-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470272#comment-17470272 ] Nick Dimiduk commented on HBASE-26651: -- Flakey rate is the same back on {{fbc8046bc3}}, so I think

[jira] [Created] (HBASE-26651) TestDrainReplicationQueuesForStandBy is flakey

2022-01-06 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-26651: Summary: TestDrainReplicationQueuesForStandBy is flakey Key: HBASE-26651 URL: https://issues.apache.org/jira/browse/HBASE-26651 Project: HBase Issue Type:

[GitHub] [hbase] ndimiduk commented on pull request #3973: HBASE-26616 Refactor code related to ZooKeeper authentication

2022-01-06 Thread GitBox
ndimiduk commented on pull request #3973: URL: https://github.com/apache/hbase/pull/3973#issuecomment-1007043643 ErrorProne parsing is still broken -- those javac failures are in files I did not touch. `TestDrainReplicationQueuesForStandBy` is flaky for me on master. It's failing

[GitHub] [hbase] Apache-HBase commented on pull request #4016: HBASE-26650 Create module hbase-client-test-support

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4016: URL: https://github.com/apache/hbase/pull/4016#issuecomment-1007034067 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4014: Backport "HBASE-26474 Implement connection-level attributes" to branch-2

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4014: URL: https://github.com/apache/hbase/pull/4014#issuecomment-1007033426 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4015: HBASE-26520 Remove use of `db.hbase.namespance` tracing attribute

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4015: URL: https://github.com/apache/hbase/pull/4015#issuecomment-1007011487 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #3934: URL: https://github.com/apache/hbase/pull/3934#issuecomment-1007010885 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4015: HBASE-26520 Remove use of `db.hbase.namespance` tracing attribute

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4015: URL: https://github.com/apache/hbase/pull/4015#issuecomment-1007008910 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Assigned] (HBASE-26648) Improve fidelity of RegionLocator spans

2022-01-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reassigned HBASE-26648: Assignee: Nick Dimiduk > Improve fidelity of RegionLocator spans >

[GitHub] [hbase] Apache-HBase commented on pull request #4014: Backport "HBASE-26474 Implement connection-level attributes" to branch-2

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4014: URL: https://github.com/apache/hbase/pull/4014#issuecomment-1007005107 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4015: HBASE-26520 Remove use of `db.hbase.namespance` tracing attribute

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4015: URL: https://github.com/apache/hbase/pull/4015#issuecomment-1007004382 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4014: Backport "HBASE-26474 Implement connection-level attributes" to branch-2

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4014: URL: https://github.com/apache/hbase/pull/4014#issuecomment-1007002710 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-26650) Create module hbase-client-test-support

2022-01-06 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26650: - Status: Patch Available (was: Open) > Create module hbase-client-test-support >

[GitHub] [hbase] ndimiduk opened a new pull request #4016: HBASE-26650 Create module hbase-client-test-support

2022-01-06 Thread GitBox
ndimiduk opened a new pull request #4016: URL: https://github.com/apache/hbase/pull/4016 Move `SpanData` matcher support classes to new module. Probably there are others, but start with these for now. This is a prerequisite for further progress with the otel effort. -- This is an

[jira] [Created] (HBASE-26650) Create module hbase-client-test-support

2022-01-06 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-26650: Summary: Create module hbase-client-test-support Key: HBASE-26650 URL: https://issues.apache.org/jira/browse/HBASE-26650 Project: HBase Issue Type: Sub-task

[GitHub] [hbase] ndimiduk opened a new pull request #4015: HBASE-26520 Remove use of `db.hbase.namespance` tracing attribute

2022-01-06 Thread GitBox
ndimiduk opened a new pull request #4015: URL: https://github.com/apache/hbase/pull/4015 The HBase-specific attribute `db.hbase.namespace` has been deprecated in favor of the generic `db.name`. See also https://github.com/open-telemetry/opentelemetry-specification/issues/1760 --

[GitHub] [hbase] Apache-HBase commented on pull request #4010: HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4010: URL: https://github.com/apache/hbase/pull/4010#issuecomment-1006970736 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4010: HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4010: URL: https://github.com/apache/hbase/pull/4010#issuecomment-1006965199 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-26649) Support meta replica LoadBalance mode for RegionLocator#getAllRegionLocations()

2022-01-06 Thread Huaxiang Sun (Jira)
Huaxiang Sun created HBASE-26649: Summary: Support meta replica LoadBalance mode for RegionLocator#getAllRegionLocations() Key: HBASE-26649 URL: https://issues.apache.org/jira/browse/HBASE-26649

[GitHub] [hbase] Apache-HBase commented on pull request #4014: Backport "HBASE-26474 Implement connection-level attributes" to branch-2

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4014: URL: https://github.com/apache/hbase/pull/4014#issuecomment-1006932188 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4005: HBASE-26643 AssignmentManager should check for empty result returned …

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4005: URL: https://github.com/apache/hbase/pull/4005#issuecomment-1006922809 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] ndimiduk commented on pull request #4014: Backport "HBASE-26474 Implement connection-level attributes" to branch-2

2022-01-06 Thread GitBox
ndimiduk commented on pull request #4014: URL: https://github.com/apache/hbase/pull/4014#issuecomment-1006902804 reviewers: please notice this change to internal behavior of caching region locations in `HRegionLocator#listRegionLocations()`. I believe that the contents of the cache are

[GitHub] [hbase] ndimiduk opened a new pull request #4014: Backport "HBASE-26474 Implement connection-level attributes" to branch-2

2022-01-06 Thread GitBox
ndimiduk opened a new pull request #4014: URL: https://github.com/apache/hbase/pull/4014 Add support for `db.system`, `db.connection_string`, `db.user`. This is a non-trivial backport of #3952 to branch-2. It's non-trivial because it implements these tracing features on the

[GitHub] [hbase] Apache-HBase commented on pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #3934: URL: https://github.com/apache/hbase/pull/3934#issuecomment-1006895892 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-26590) Hbase-client Meta lookup performance regression between hbase-1 and hbase-2

2022-01-06 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun resolved HBASE-26590. -- Fix Version/s: 2.5.0 2.4.10 Resolution: Fixed Resolved it for now,

[jira] [Updated] (HBASE-26543) HBase shell no longer properly parses several args

2022-01-06 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-26543: Status: Patch Available (was: In Progress) > HBase shell no longer properly parses several args

[GitHub] [hbase] huaxiangsun merged pull request #4013: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
huaxiangsun merged pull request #4013: URL: https://github.com/apache/hbase/pull/4013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] huaxiangsun merged pull request #4012: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
huaxiangsun merged pull request #4012: URL: https://github.com/apache/hbase/pull/4012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] huaxiangsun merged pull request #4011: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
huaxiangsun merged pull request #4011: URL: https://github.com/apache/hbase/pull/4011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #4011: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4011: URL: https://github.com/apache/hbase/pull/4011#issuecomment-1006881644 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #4005: HBASE-26643 AssignmentManager should check for empty result returned …

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4005: URL: https://github.com/apache/hbase/pull/4005#issuecomment-1006880600 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4006: HBASE-26586 The MigrateStoreFileTrackerProcedure should not rely on t…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4006: URL: https://github.com/apache/hbase/pull/4006#issuecomment-1006879152 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4013: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4013: URL: https://github.com/apache/hbase/pull/4013#issuecomment-1006878315 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4012: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4012: URL: https://github.com/apache/hbase/pull/4012#issuecomment-1006877614 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4013: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4013: URL: https://github.com/apache/hbase/pull/4013#issuecomment-1006875481 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4012: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4012: URL: https://github.com/apache/hbase/pull/4012#issuecomment-1006874687 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 9m

[GitHub] [hbase] Apache-HBase commented on pull request #4012: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4012: URL: https://github.com/apache/hbase/pull/4012#issuecomment-1006873670 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #4011: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4011: URL: https://github.com/apache/hbase/pull/4011#issuecomment-1006873058 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4013: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4013: URL: https://github.com/apache/hbase/pull/4013#issuecomment-1006872259 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #4011: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4011: URL: https://github.com/apache/hbase/pull/4011#issuecomment-1006863293 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4006: HBASE-26586 The MigrateStoreFileTrackerProcedure should not rely on t…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4006: URL: https://github.com/apache/hbase/pull/4006#issuecomment-1006848181 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] huaxiangsun opened a new pull request #4013: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
huaxiangsun opened a new pull request #4013: URL: https://github.com/apache/hbase/pull/4013 …base-1 and hbase-2 (#4008) Change scan caching back to 1 to avoid extra work at Region Server side. For most cases, the extra 4 results fetched are wasted at the client side.

[GitHub] [hbase] huaxiangsun opened a new pull request #4012: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
huaxiangsun opened a new pull request #4012: URL: https://github.com/apache/hbase/pull/4012 …base-1 and hbase-2 (#4008) Change scan caching back to 1 to avoid extra work at Region Server side. For most cases, the extra 4 results fetched are wasted at the client side.

[GitHub] [hbase] huaxiangsun opened a new pull request #4011: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
huaxiangsun opened a new pull request #4011: URL: https://github.com/apache/hbase/pull/4011 …base-1 and hbase-2 (#4008) Change scan caching back to 1 to avoid extra work at Region Server side. For most cases, the extra 4 results fetched are wasted at the client side.

[GitHub] [hbase] Apache-HBase commented on pull request #4010: HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4010: URL: https://github.com/apache/hbase/pull/4010#issuecomment-1006826590 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-26347) Support detect and exclude slow DNs in fan-out of WAL

2022-01-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470121#comment-17470121 ] Hudson commented on HBASE-26347: Results for branch branch-2 [build #436 on

[jira] [Commented] (HBASE-26585) Add SFT configuration to META table descriptor when creating META

2022-01-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470120#comment-17470120 ] Hudson commented on HBASE-26585: Results for branch branch-2 [build #436 on

[GitHub] [hbase] huaxiangsun merged pull request #4008: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
huaxiangsun merged pull request #4008: URL: https://github.com/apache/hbase/pull/4008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (HBASE-26648) Improve fidelity of RegionLocator spans

2022-01-06 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-26648: Summary: Improve fidelity of RegionLocator spans Key: HBASE-26648 URL: https://issues.apache.org/jira/browse/HBASE-26648 Project: HBase Issue Type: Sub-task

[GitHub] [hbase] Apache-HBase commented on pull request #4008: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4008: URL: https://github.com/apache/hbase/pull/4008#issuecomment-1006812135 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #3934: URL: https://github.com/apache/hbase/pull/3934#issuecomment-1006811704 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4008: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4008: URL: https://github.com/apache/hbase/pull/4008#issuecomment-1006811636 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4008: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4008: URL: https://github.com/apache/hbase/pull/4008#issuecomment-1006809324 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] huaxiangsun commented on pull request #4008: HBASE-26590 Hbase-client Meta lookup performance regression between h…

2022-01-06 Thread GitBox
huaxiangsun commented on pull request #4008: URL: https://github.com/apache/hbase/pull/4008#issuecomment-1006786825 Thanks Duo for the review. I restarted pr-merge check to get a successful run. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache-HBase commented on pull request #4010: HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4010: URL: https://github.com/apache/hbase/pull/4010#issuecomment-1006780455 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] joshelser commented on a change in pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-06 Thread GitBox
joshelser commented on a change in pull request #3934: URL: https://github.com/apache/hbase/pull/3934#discussion_r779716278 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/security/oauthbearer/internals/OAuthBearerSaslServer.java ## @@ -0,0 +1,271 @@ +/* + *

[GitHub] [hbase] joshelser commented on a change in pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-06 Thread GitBox
joshelser commented on a change in pull request #3934: URL: https://github.com/apache/hbase/pull/3934#discussion_r779716079 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/security/oauthbearer/OAuthBearerTokenCallback.java ## @@ -0,0 +1,122 @@ +/* + *

[GitHub] [hbase] joshelser commented on a change in pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-06 Thread GitBox
joshelser commented on a change in pull request #3934: URL: https://github.com/apache/hbase/pull/3934#discussion_r779715206 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/security/auth/SaslExtensionsCallback.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to the

[GitHub] [hbase] joshelser commented on a change in pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-06 Thread GitBox
joshelser commented on a change in pull request #3934: URL: https://github.com/apache/hbase/pull/3934#discussion_r779714133 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/exceptions/SaslAuthenticationException.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to the

[GitHub] [hbase] Apache-HBase commented on pull request #4005: HBASE-26643 AssignmentManager should check for empty result returned …

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4005: URL: https://github.com/apache/hbase/pull/4005#issuecomment-1006759842 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4006: HBASE-26586 The MigrateStoreFileTrackerProcedure should not rely on t…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4006: URL: https://github.com/apache/hbase/pull/4006#issuecomment-1006754765 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4009: HBASE-26640 The master local region should not be effected by the glo…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4009: URL: https://github.com/apache/hbase/pull/4009#issuecomment-1006752758 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] anmolnar commented on a change in pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-06 Thread GitBox
anmolnar commented on a change in pull request #3934: URL: https://github.com/apache/hbase/pull/3934#discussion_r779673170 ## File path: hbase-common/pom.xml ## @@ -255,6 +255,10 @@ kerb-simplekdc test + + com.nimbusds + nimbus-jose-jwt

[GitHub] [hbase] anmolnar commented on a change in pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-06 Thread GitBox
anmolnar commented on a change in pull request #3934: URL: https://github.com/apache/hbase/pull/3934#discussion_r779672461 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/security/oauthbearer/internals/OAuthBearerSaslServer.java ## @@ -0,0 +1,271 @@ +/* + *

[GitHub] [hbase] Apache9 commented on a change in pull request #4009: HBASE-26640 The master local region should not be effected by the glo…

2022-01-06 Thread GitBox
Apache9 commented on a change in pull request #4009: URL: https://github.com/apache/hbase/pull/4009#discussion_r779671593 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegionFactory.java ## @@ -83,6 +84,7 @@ public static final byte[]

[GitHub] [hbase] Apache9 commented on pull request #4006: HBASE-26586 The MigrateStoreFileTrackerProcedure should not rely on t…

2022-01-06 Thread GitBox
Apache9 commented on pull request #4006: URL: https://github.com/apache/hbase/pull/4006#issuecomment-1006717373 > Logic wise, LGTM, agree this is the safest approach to do here. I just think we should change this class name to something like "InitializeStoreFileTrackerProcedure", as its

[jira] [Updated] (HBASE-26586) We should not rely on the global config when setting SFT implementation for a table while upgrading

2022-01-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26586: -- Summary: We should not rely on the global config when setting SFT implementation for a table while

[jira] [Updated] (HBASE-26586) Should not rely on the global config when setting SFT implementation for a table while upgrading

2022-01-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26586: -- Summary: Should not rely on the global config when setting SFT implementation for a table while

[jira] [Updated] (HBASE-26643) LoadBalancer should not return empty map

2022-01-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26643: -- Summary: LoadBalancer should not return empty map (was: AssignmentManager should check for empty

[GitHub] [hbase] Apache-HBase commented on pull request #4010: HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4010: URL: https://github.com/apache/hbase/pull/4010#issuecomment-1006712670 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on pull request #4005: HBASE-26643 AssignmentManager should check for empty result returned …

2022-01-06 Thread GitBox
Apache9 commented on pull request #4005: URL: https://github.com/apache/hbase/pull/4005#issuecomment-1006710848 Ah, there is a problem. For RSGroupLoadBalancer, we have to use BOGUS_SERVER_NAME to indicate the upper layer that some regions can not be assigned, otherwise the upper layer

[GitHub] [hbase] wchevreuil commented on a change in pull request #4009: HBASE-26640 The master local region should not be effected by the glo…

2022-01-06 Thread GitBox
wchevreuil commented on a change in pull request #4009: URL: https://github.com/apache/hbase/pull/4009#discussion_r779660193 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegionFactory.java ## @@ -83,6 +84,7 @@ public static final

[GitHub] [hbase] Apache-HBase commented on pull request #4009: HBASE-26640 The master local region should not be effected by the glo…

2022-01-06 Thread GitBox
Apache-HBase commented on pull request #4009: URL: https://github.com/apache/hbase/pull/4009#issuecomment-1006699232 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] busbey commented on a change in pull request #4000: HBASE-26543 correct parsing of shell args with GetoptLong

2022-01-06 Thread GitBox
busbey commented on a change in pull request #4000: URL: https://github.com/apache/hbase/pull/4000#discussion_r779639725 ## File path: hbase-shell/src/main/ruby/jar-bootstrap.rb ## @@ -78,62 +78,59 @@ def add_to_configuration(c, arg) c end +conf_from_cli = nil + +# strip

[GitHub] [hbase] anmolnar commented on a change in pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-06 Thread GitBox
anmolnar commented on a change in pull request #3934: URL: https://github.com/apache/hbase/pull/3934#discussion_r779637060 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/security/oauthbearer/OAuthBearerTokenCallback.java ## @@ -0,0 +1,122 @@ +/* + * Licensed

[GitHub] [hbase] anmolnar commented on a change in pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-06 Thread GitBox
anmolnar commented on a change in pull request #3934: URL: https://github.com/apache/hbase/pull/3934#discussion_r779630173 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/security/auth/SaslExtensionsCallback.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to the

[GitHub] [hbase] anmolnar commented on a change in pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-06 Thread GitBox
anmolnar commented on a change in pull request #3934: URL: https://github.com/apache/hbase/pull/3934#discussion_r779629490 ## File path: hbase-common/pom.xml ## @@ -255,6 +255,10 @@ kerb-simplekdc test + + com.nimbusds + nimbus-jose-jwt

[jira] [Assigned] (HBASE-26587) Introduce a new Admin API to change SFT implementation

2022-01-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-26587: - Assignee: Duo Zhang > Introduce a new Admin API to change SFT implementation >

[jira] [Commented] (HBASE-26588) Implement a migration tool to help users migrate SFT implementation for a large set of tables

2022-01-06 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469966#comment-17469966 ] Wellington Chevreuil commented on HBASE-26588: -- Was thinking about a new hbase shell

[jira] [Commented] (HBASE-26587) Introduce a new Admin API to change SFT implementation

2022-01-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469965#comment-17469965 ] Duo Zhang commented on HBASE-26587: --- It should be any implementation. Will provide a patch soon~ >

[jira] [Commented] (HBASE-26587) Introduce a new Admin API to change SFT implementation

2022-01-06 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469964#comment-17469964 ] Wellington Chevreuil commented on HBASE-26587: -- {quote} I would like to introduce a new

[jira] [Commented] (HBASE-26611) Changing SFT implementation on disabled table is dangerous

2022-01-06 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469948#comment-17469948 ] Wellington Chevreuil commented on HBASE-26611: -- {quote} Think of you change the SFT

[GitHub] [hbase] anmolnar commented on a change in pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-06 Thread GitBox
anmolnar commented on a change in pull request #3934: URL: https://github.com/apache/hbase/pull/3934#discussion_r779586844 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/security/oauthbearer/OAuthBearerStringUtils.java ## @@ -0,0 +1,82 @@ +/* + * Licensed to

[jira] [Commented] (HBASE-26474) Implement connection-level attributes

2022-01-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469937#comment-17469937 ] Hudson commented on HBASE-26474: Results for branch master [build #488 on

[jira] [Commented] (HBASE-26585) Add SFT configuration to META table descriptor when creating META

2022-01-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469936#comment-17469936 ] Hudson commented on HBASE-26585: Results for branch master [build #488 on

  1   2   >