Apache-HBase commented on PR #4959:
URL: https://github.com/apache/hbase/pull/4959#issuecomment-1381998631
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s | Docke
Apache-HBase commented on PR #4959:
URL: https://github.com/apache/hbase/pull/4959#issuecomment-1381990458
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 28s | Docke
Apache-HBase commented on PR #4959:
URL: https://github.com/apache/hbase/pull/4959#issuecomment-1381985145
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s | Docke
ndimiduk commented on code in PR #4963:
URL: https://github.com/apache/hbase/pull/4963#discussion_r1069532219
##
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java:
##
@@ -260,18 +260,32 @@ protected void startDataNode(ServerName server) throws
IOException
ndimiduk commented on code in PR #4959:
URL: https://github.com/apache/hbase/pull/4959#discussion_r1069514903
##
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartActiveNameNodeAction.java:
##
@@ -57,39 +57,47 @@ protected Logger getLogger() {
@Override
p
rmdmattingly commented on PR #4937:
URL: https://github.com/apache/hbase/pull/4937#issuecomment-1381845691
🤨 I'm a little skeptical of the spotless check failure — running
spotless:apply yields no diff, and [the
output](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4937/1
Apache-HBase commented on PR #4937:
URL: https://github.com/apache/hbase/pull/4937#issuecomment-138180
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s | Docker
Apache9 commented on code in PR #4959:
URL: https://github.com/apache/hbase/pull/4959#discussion_r1069259752
##
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/DumpHdfsClusterStatusAction.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (
Reidd commented on code in PR #4963:
URL: https://github.com/apache/hbase/pull/4963#discussion_r1069073755
##
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java:
##
@@ -260,18 +260,32 @@ protected void startDataNode(ServerName server) throws
IOExceptio
Reidd commented on code in PR #4963:
URL: https://github.com/apache/hbase/pull/4963#discussion_r1069073389
##
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java:
##
@@ -260,18 +260,32 @@ protected void startDataNode(ServerName server) throws
IOExceptio
virajjasani commented on code in PR #4924:
URL: https://github.com/apache/hbase/pull/4924#discussion_r1069068913
##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java:
##
@@ -178,16 +179,19 @@ private void decorateConf() {
/**
Apache9 commented on PR #4955:
URL: https://github.com/apache/hbase/pull/4955#issuecomment-1381374246
we only need to support hadoop3 on 3.0+, so I think we only need to apply
the patch to branch-2.x?
--
This is an automated message from the Apache Git Service.
To respond to the message,
Apache9 commented on code in PR #4924:
URL: https://github.com/apache/hbase/pull/4924#discussion_r1068971919
##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java:
##
@@ -178,16 +179,19 @@ private void decorateConf() {
/**
* R
Apache-HBase commented on PR #4937:
URL: https://github.com/apache/hbase/pull/4937#issuecomment-1381249603
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s | Docke
Apache-HBase commented on PR #4963:
URL: https://github.com/apache/hbase/pull/4963#issuecomment-1381156298
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 8s | Docke
Apache-HBase commented on PR #4937:
URL: https://github.com/apache/hbase/pull/4937#issuecomment-1381116334
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 13s | Docke
Apache-HBase commented on PR #4933:
URL: https://github.com/apache/hbase/pull/4933#issuecomment-1381084475
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 2s | Docke
Apache-HBase commented on PR #4933:
URL: https://github.com/apache/hbase/pull/4933#issuecomment-1381083709
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s | Docke
Apache-HBase commented on PR #4933:
URL: https://github.com/apache/hbase/pull/4933#issuecomment-1381082442
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s | Docke
jarrydlee commented on code in PR #4933:
URL: https://github.com/apache/hbase/pull/4933#discussion_r1068731158
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/RestoreRequest.java:
##
@@ -68,6 +73,7 @@ public RestoreRequest build() {
}
private String backupRo
Apache-HBase commented on PR #4963:
URL: https://github.com/apache/hbase/pull/4963#issuecomment-1381001162
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s | Docke
Apache-HBase commented on PR #4963:
URL: https://github.com/apache/hbase/pull/4963#issuecomment-1380970721
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 6s | Docker
Apache-HBase commented on PR #4963:
URL: https://github.com/apache/hbase/pull/4963#issuecomment-1380960006
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 14s | Docke
virajjasani commented on code in PR #4924:
URL: https://github.com/apache/hbase/pull/4924#discussion_r1068598414
##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java:
##
@@ -178,16 +179,19 @@ private void decorateConf() {
/**
Apache-HBase commented on PR #4965:
URL: https://github.com/apache/hbase/pull/4965#issuecomment-1380764269
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 52s | Docke
Apache-HBase commented on PR #4965:
URL: https://github.com/apache/hbase/pull/4965#issuecomment-1380764007
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 36s | Docke
Apache-HBase commented on PR #4965:
URL: https://github.com/apache/hbase/pull/4965#issuecomment-1380751648
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 21s | Docke
Apache-HBase commented on PR #4959:
URL: https://github.com/apache/hbase/pull/4959#issuecomment-1380750481
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 10s | Docke
Apache-HBase commented on PR #4959:
URL: https://github.com/apache/hbase/pull/4959#issuecomment-1380745201
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 15s | Docke
Apache-HBase commented on PR #4959:
URL: https://github.com/apache/hbase/pull/4959#issuecomment-1380740107
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s | Docke
ndimiduk merged PR #4965:
URL: https://github.com/apache/hbase/pull/4965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache
ndimiduk commented on PR #4965:
URL: https://github.com/apache/hbase/pull/4965#issuecomment-1380730888
Trying backport again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ndimiduk opened a new pull request, #4965:
URL: https://github.com/apache/hbase/pull/4965
Signed-off-by: Duo Zhang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
ndimiduk merged PR #4964:
URL: https://github.com/apache/hbase/pull/4964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache
ndimiduk opened a new pull request, #4964:
URL: https://github.com/apache/hbase/pull/4964
Reverts apache/hbase#4962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
ndimiduk merged PR #4962:
URL: https://github.com/apache/hbase/pull/4962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache
ndimiduk merged PR #4961:
URL: https://github.com/apache/hbase/pull/4961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache
ndimiduk merged PR #4960:
URL: https://github.com/apache/hbase/pull/4960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache
ndimiduk merged PR #4954:
URL: https://github.com/apache/hbase/pull/4954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache
Apache-HBase commented on PR #4963:
URL: https://github.com/apache/hbase/pull/4963#issuecomment-1380711658
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s | Docker
ndimiduk opened a new pull request, #4963:
URL: https://github.com/apache/hbase/pull/4963
Depends on #4959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
Apache-HBase commented on PR #4962:
URL: https://github.com/apache/hbase/pull/4962#issuecomment-1380613164
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m 16s | Docke
Apache-HBase commented on PR #4962:
URL: https://github.com/apache/hbase/pull/4962#issuecomment-1380589716
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 52s | Docke
Apache-HBase commented on PR #4962:
URL: https://github.com/apache/hbase/pull/4962#issuecomment-1380587943
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 55s | Docke
Apache-HBase commented on PR #4962:
URL: https://github.com/apache/hbase/pull/4962#issuecomment-1380565163
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 21s | Docker
Apache-HBase commented on PR #4954:
URL: https://github.com/apache/hbase/pull/4954#issuecomment-1380564325
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 21s | Docke
Apache-HBase commented on PR #4962:
URL: https://github.com/apache/hbase/pull/4962#issuecomment-1380563522
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 59s | Docker
Apache-HBase commented on PR #4962:
URL: https://github.com/apache/hbase/pull/4962#issuecomment-1380561745
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 20s | Docker
Apache-HBase commented on PR #4961:
URL: https://github.com/apache/hbase/pull/4961#issuecomment-1380555159
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 0s | Docke
Apache-HBase commented on PR #4960:
URL: https://github.com/apache/hbase/pull/4960#issuecomment-1380553693
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 15s | Docke
Apache-HBase commented on PR #4954:
URL: https://github.com/apache/hbase/pull/4954#issuecomment-1380549479
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s | Docke
Apache-HBase commented on PR #4960:
URL: https://github.com/apache/hbase/pull/4960#issuecomment-1380547322
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 28s | Docke
Apache-HBase commented on PR #4961:
URL: https://github.com/apache/hbase/pull/4961#issuecomment-1380544795
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 14s | Docke
Apache-HBase commented on PR #4961:
URL: https://github.com/apache/hbase/pull/4961#issuecomment-1380540558
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 19s | Docke
Apache-HBase commented on PR #4954:
URL: https://github.com/apache/hbase/pull/4954#issuecomment-1380538429
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s | Docke
Apache-HBase commented on PR #4960:
URL: https://github.com/apache/hbase/pull/4960#issuecomment-1380538802
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 35s | Docke
ndimiduk commented on PR #4962:
URL: https://github.com/apache/hbase/pull/4962#issuecomment-1380514232
Hmm. `ReservoirSample` isn't available on branch-2.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ndimiduk opened a new pull request, #4962:
URL: https://github.com/apache/hbase/pull/4962
Signed-off-by: Duo Zhang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
Apache-HBase commented on PR #4954:
URL: https://github.com/apache/hbase/pull/4954#issuecomment-1380493487
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 8s | Docke
Apache-HBase commented on PR #4954:
URL: https://github.com/apache/hbase/pull/4954#issuecomment-1380489742
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s | Docke
ndimiduk opened a new pull request, #4961:
URL: https://github.com/apache/hbase/pull/4961
Signed-off-by: Duo Zhang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
ndimiduk opened a new pull request, #4960:
URL: https://github.com/apache/hbase/pull/4960
Signed-off-by: Duo Zhang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
Apache-HBase commented on PR #4954:
URL: https://github.com/apache/hbase/pull/4954#issuecomment-1380482307
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s | Docke
ndimiduk commented on code in PR #4954:
URL: https://github.com/apache/hbase/pull/4954#discussion_r1068205759
##
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/monkies/PolicyBasedChaosMonkey.java:
##
@@ -116,13 +120,31 @@ public static T selectWeightedRandomItem(List> ite
Apache-HBase commented on PR #4959:
URL: https://github.com/apache/hbase/pull/4959#issuecomment-1380378374
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 10s | Docke
petersomogyi merged PR #4958:
URL: https://github.com/apache/hbase/pull/4958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.ap
petersomogyi commented on PR #4958:
URL: https://github.com/apache/hbase/pull/4958#issuecomment-1380373823
The test failure is not related to this change and passes locally on this
commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
Apache-HBase commented on PR #4959:
URL: https://github.com/apache/hbase/pull/4959#issuecomment-1380372608
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 55s | Docke
Apache-HBase commented on PR #4959:
URL: https://github.com/apache/hbase/pull/4959#issuecomment-1380367664
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 20s | Docke
Apache-HBase commented on PR #4945:
URL: https://github.com/apache/hbase/pull/4945#issuecomment-1380347478
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 3s | Docke
Apache-HBase commented on PR #4958:
URL: https://github.com/apache/hbase/pull/4958#issuecomment-1380321998
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s | Docker
Apache-HBase commented on PR #4958:
URL: https://github.com/apache/hbase/pull/4958#issuecomment-1380319817
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 8s | Docke
Apache9 commented on code in PR #4954:
URL: https://github.com/apache/hbase/pull/4954#discussion_r1068074857
##
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/monkies/PolicyBasedChaosMonkey.java:
##
@@ -116,13 +120,31 @@ public static T selectWeightedRandomItem(List> item
Apache-HBase commented on PR #4954:
URL: https://github.com/apache/hbase/pull/4954#issuecomment-1380247475
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 22s | Docke
Apache-HBase commented on PR #4954:
URL: https://github.com/apache/hbase/pull/4954#issuecomment-1380238904
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 12s | Docke
wchevreuil commented on code in PR #4945:
URL: https://github.com/apache/hbase/pull/4945#discussion_r1068048711
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java:
##
@@ -188,6 +225,25 @@ protected boolean waitInitialized(Mas
wchevreuil commented on code in PR #4945:
URL: https://github.com/apache/hbase/pull/4945#discussion_r1068047188
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java:
##
@@ -126,6 +144,14 @@
private boolean isSplit;
+ pr
Apache-HBase commented on PR #4954:
URL: https://github.com/apache/hbase/pull/4954#issuecomment-1380235327
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 17s | Docke
wchevreuil commented on code in PR #4945:
URL: https://github.com/apache/hbase/pull/4945#discussion_r1068046637
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java:
##
@@ -126,6 +144,14 @@
private boolean isSplit;
+ pr
ndimiduk commented on code in PR #4954:
URL: https://github.com/apache/hbase/pull/4954#discussion_r1068024563
##
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/monkies/PolicyBasedChaosMonkey.java:
##
@@ -151,7 +157,9 @@ public boolean isStopped() {
@Override
public
ndimiduk commented on PR #4954:
URL: https://github.com/apache/hbase/pull/4954#issuecomment-1380191681
Good points all around, thanks @Apache9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Apache-HBase commented on PR #4958:
URL: https://github.com/apache/hbase/pull/4958#issuecomment-1380072958
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 8s | Docke
Apache-HBase commented on PR #4942:
URL: https://github.com/apache/hbase/pull/4942#issuecomment-1379978460
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s | Docker
EungsopYoo commented on PR #4942:
URL: https://github.com/apache/hbase/pull/4942#issuecomment-1379938945
How about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Apache9 commented on code in PR #4924:
URL: https://github.com/apache/hbase/pull/4924#discussion_r1067794535
##
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionServerObserver.java:
##
@@ -137,4 +140,33 @@ default void
preExecuteProcedures(ObserverContext ct
Apache9 commented on code in PR #4954:
URL: https://github.com/apache/hbase/pull/4954#discussion_r1067756498
##
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/monkies/PolicyBasedChaosMonkey.java:
##
@@ -116,13 +119,16 @@ public static T selectWeightedRandomItem(List> item
Apache-HBase commented on PR #4937:
URL: https://github.com/apache/hbase/pull/4937#issuecomment-1379381945
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 55s | Docke
apurtell commented on code in PR #4924:
URL: https://github.com/apache/hbase/pull/4924#discussion_r1067359503
##
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionServerObserver.java:
##
@@ -137,4 +140,33 @@ default void
preExecuteProcedures(ObserverContext c
Apache-HBase commented on PR #4958:
URL: https://github.com/apache/hbase/pull/4958#issuecomment-1379275411
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s | Docker
Apache-HBase commented on PR #4958:
URL: https://github.com/apache/hbase/pull/4958#issuecomment-1379261431
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s | Docke
petersomogyi commented on code in PR #4945:
URL: https://github.com/apache/hbase/pull/4945#discussion_r1067275122
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java:
##
@@ -107,6 +108,20 @@
private static final Logger LO
Apache-HBase commented on PR #4954:
URL: https://github.com/apache/hbase/pull/4954#issuecomment-1379182920
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 10s | Docker
Apache-HBase commented on PR #4954:
URL: https://github.com/apache/hbase/pull/4954#issuecomment-1379177988
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 45s | Docke
Apache-HBase commented on PR #4954:
URL: https://github.com/apache/hbase/pull/4954#issuecomment-1379164264
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s | Docke
Apache-HBase commented on PR #4937:
URL: https://github.com/apache/hbase/pull/4937#issuecomment-1379115479
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 32s | Docke
ndimiduk commented on PR #4954:
URL: https://github.com/apache/hbase/pull/4954#issuecomment-1379107373
This code handles the `ratio=1.0` case correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ndimiduk commented on PR #4954:
URL: https://github.com/apache/hbase/pull/4954#issuecomment-1379094607
We have `1.0f` as default ratio values for a couple constants in
`MonkeyConstants.java`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
ndimiduk commented on PR #4954:
URL: https://github.com/apache/hbase/pull/4954#issuecomment-1378984679
```
2023-01-11T15:39:46,370 DEBUG [ChaosMonkey-0]
monkies.PolicyBasedChaosMonkey: selectRandomItems(10, 1.0) of type class
[Lorg.apache.hadoop.hbase.ServerName;
```
--
This is an
Apache9 commented on PR #4954:
URL: https://github.com/apache/hbase/pull/4954#issuecomment-1378900636
Checked the code, the ratio is percentage of regionservers we want to
restart, normally, so in general it should be a value between 0 and 1. But
there is no sanity check in our code...
--
Apache-HBase commented on PR #4958:
URL: https://github.com/apache/hbase/pull/4958#issuecomment-1378852629
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 9s | Docke
301 - 400 of 3511 matches
Mail list logo