Re: [PR] HBASE-28443 Return too slow when scanning a table with non-existing REGION_REPLICA_ID [hbase]

2024-03-23 Thread via GitHub
guluo2016 commented on PR #5767: URL: https://github.com/apache/hbase/pull/5767#issuecomment-2016469719 > Mind explaining more on why locating is so slow when the replica id does not exist? Busying with other things, Sorry for the late reply. In a short, hbase would retry 8 tim

Re: [PR] HBASE-28443 Return too slow when scanning a table with non-existing REGION_REPLICA_ID [hbase]

2024-03-24 Thread via GitHub
Apache9 commented on PR #5767: URL: https://github.com/apache/hbase/pull/5767#issuecomment-2016817710 I think we should try to check the replica id when we hit the RegionOfflineException, like what we have done in AsyncRpcRetryingCaller. -- This is an automated message from the Apache Git

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2016939886 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 41s | Docke

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017004220 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 20s | Docke

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017011424 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 33s | Docke

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017023902 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s | Docke

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
Apache9 commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1536961183 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,19 @@ public void regionServerReport(ServerName sn, ServerMetrics sl)

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1536979403 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,19 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1536979403 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,19 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1536980319 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,19 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1536981102 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,19 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
Apache9 commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1537006507 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,19 @@ public void regionServerReport(ServerName sn, ServerMetrics sl)

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1537084622 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,19 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017319464 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s | Docke

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017617328 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docke

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017644363 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017678393 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker

Re: [PR] HBASE-28436 Use connection url to specify the connection registry inf… [hbase]

2024-03-25 Thread via GitHub
Apache9 commented on PR #5770: URL: https://github.com/apache/hbase/pull/5770#issuecomment-2017744432 Ping @ndimiduk . Could you please take a look at this? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2017903345 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docke

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-03-25 Thread via GitHub
wchevreuil commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1537538033 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -295,10 +302,23 @@ private void readStoreFile(Path storeFilePath, throws E

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
briaugenreich commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018137695 I tweaked the existing test to verify the changes here. When the fix is not implemented we get double the expected results due to the scan matching the prefix incorrectly. cc

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018205291 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 24s | Docker

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018216063 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s | Docke

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018214956 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docke

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018220994 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 15s | Docke

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2018348042 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 25s | Docke

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018411087 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docke

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018422433 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docke

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018422885 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docke

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018424121 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5772: URL: https://github.com/apache/hbase/pull/5772#issuecomment-2018608695 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docke

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2018612244 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s | Docker

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2018643204 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker

Re: [PR] HBASE-28453 FixedIntervalRateLimiter support for a shorter refill interval [hbase]

2024-03-25 Thread via GitHub
bbeaudreault merged PR #5773: URL: https://github.com/apache/hbase/pull/5773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.ap

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
bbeaudreault merged PR #5768: URL: https://github.com/apache/hbase/pull/5768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.ap

[PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-25 Thread via GitHub
bbeaudreault opened a new pull request, #5775: URL: https://github.com/apache/hbase/pull/5775 - Unifies _SeqId_ handling - Adds necessary config in MapReduceHFileSplliter so that sorting can include sequenceId - Updates HFileInputFormat to handle sequenceIds of bulkloaded files. This

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5772: URL: https://github.com/apache/hbase/pull/5772#issuecomment-2018954446 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docke

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2018963880 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docke

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5772: URL: https://github.com/apache/hbase/pull/5772#issuecomment-2018973711 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 27s | Docke

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5772: URL: https://github.com/apache/hbase/pull/5772#issuecomment-2018987203 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docke

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-201899 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 29s | Docke

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2019199580 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2019212143 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docke

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
bbeaudreault commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1538470996 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-2019242072 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s | Docke

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1538494129 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2019254850 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-2019259781 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docke

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-2019280912 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
Apache9 commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1538516753 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn, ServerMetrics sl)

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1538525120 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-2019310980 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 43s | Docke

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-2019538318 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-2019544586 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-2019797454 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1539000878 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539139640 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539147304 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020327457 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
ndimiduk commented on code in PR #5775: URL: https://github.com/apache/hbase/pull/5775#discussion_r1539165446 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java: ## @@ -423,6 +424,54 @@ public String toString() { + (isReference() ? "->"

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020352997 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5775: URL: https://github.com/apache/hbase/pull/5775#discussion_r1539170198 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java: ## @@ -423,6 +424,54 @@ public String toString() { + (isReference() ? "

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020355217 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020368143 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 41s | Docker

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5775: URL: https://github.com/apache/hbase/pull/5775#discussion_r1539191315 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -165,7 +165,7 @@ protected static byte[] combineTableNameSuffix(byt

Re: [PR] HBASE-27315 Add timeout to JavaRegexEngine [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-2020417661 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s | Docker

Re: [PR] HBASE-27315 Add timeout to JavaRegexEngine [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-2020425262 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker

Re: [PR] HBASE-27315 Add timeout to JavaRegexEngine [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-2020434957 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docker

Re: [PR] HBASE-27315 Add timeout to JavaRegexEngine [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-2020447314 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s | Docker

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-26 Thread via GitHub
wchevreuil commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2020453022 The UT flakeyness is actually a bug in the BucketCache.notifyFileCachingCompleted logic. The UT needs to be changed as well to consistently reproduce the issue, so I will address it in a

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
ndimiduk commented on code in PR #5775: URL: https://github.com/apache/hbase/pull/5775#discussion_r1539260241 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -165,7 +165,7 @@ protected static byte[] combineTableNameSuffix(byte[]

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-2020514083 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docke

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
Apache9 commented on code in PR #5775: URL: https://github.com/apache/hbase/pull/5775#discussion_r1539339492 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,262 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5775: URL: https://github.com/apache/hbase/pull/5775#discussion_r1539365245 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileInputFormat.java: ## @@ -109,6 +114,9 @@ public boolean nextKeyValue() throws IOException, I

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2020592593 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s | Docke

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
bbeaudreault merged PR #5775: URL: https://github.com/apache/hbase/pull/5775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.ap

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
rubenvw-ngdata commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539447876 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539449576 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539470479 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] HBASE-28443 Return too slow when scanning a table with non-existing REGION_REPLICA_ID [hbase]

2024-03-26 Thread via GitHub
guluo2016 commented on PR #5767: URL: https://github.com/apache/hbase/pull/5767#issuecomment-2020729857 > I think we should try to check the replica id when we hit the RegionOfflineException, like what we have done in AsyncRpcRetryingCaller. Thanks for your good suggestion, the change

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
rubenvw-ngdata commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539479695 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[PR] HBASE-28458 BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached [hbase]

2024-03-26 Thread via GitHub
wchevreuil opened a new pull request, #5777: URL: https://github.com/apache/hbase/pull/5777 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539518711 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539531767 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] HBASE-28443 Return too slow when scanning a table with non-existing REGION_REPLICA_ID [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5767: URL: https://github.com/apache/hbase/pull/5767#issuecomment-2020830781 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docke

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
rubenvw-ngdata commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539479695 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
rubenvw-ngdata commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539574336 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28458 BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5777: URL: https://github.com/apache/hbase/pull/5777#issuecomment-2020878066 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539621891 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/BackupTestUtil.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539624430 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -18,6 +18,7 @@ package org.apache.hadoop.hbase.backup;

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
rubenvw-ngdata commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539649431 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -18,6 +18,7 @@ package org.apache.hadoop.hbase.backup;

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
rubenvw-ngdata commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539650301 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/BackupTestUtil.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020970457 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docke

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020972463 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s | Docke

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020995259 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docke

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2021002223 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s | Docke

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2021066328 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2021082313 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docke

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2021093977 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docke

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2021094695 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docke

<    1   2   3   4   5   6   7   8   9   10   >