[jira] [Commented] (HBASE-5732) Remove the SecureRPCEngine and merge the security-related logic in the core engine

2012-04-17 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255767#comment-13255767 ] Devaraj Das commented on HBASE-5732: bq. over in Hadoop, there is a discussion around

[jira] [Commented] (HBASE-5732) Remove the SecureRPCEngine and merge the security-related logic in the core engine

2012-04-17 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255765#comment-13255765 ] Devaraj Das commented on HBASE-5732: bq. I'm all for removing shims and hacks wherever

[jira] [Commented] (HBASE-5732) Remove the SecureRPCEngine and merge the security-related logic in the core engine

2012-04-16 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255360#comment-13255360 ] Devaraj Das commented on HBASE-5732: Thanks, Zhihong for the detailed comments. I'll a

[jira] [Commented] (HBASE-5732) Remove the SecureRPCEngine and merge the security-related logic in the core engine

2012-04-16 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255282#comment-13255282 ] Devaraj Das commented on HBASE-5732: Thanks, Zhihong for the review. I forgot to menti

[jira] [Commented] (HBASE-4336) Convert source tree into maven modules

2012-04-10 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251226#comment-13251226 ] Devaraj Das commented on HBASE-4336: bq. I'm against an hbase-core module and hbase-se

[jira] [Commented] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

2012-04-09 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249975#comment-13249975 ] Devaraj Das commented on HBASE-5727: bq. Another option is to ask Nicolas to put the g

[jira] [Commented] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

2012-04-09 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249967#comment-13249967 ] Devaraj Das commented on HBASE-5727: But this isn't related to the patch committed, ri

[jira] [Commented] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

2012-04-07 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249292#comment-13249292 ] Devaraj Das commented on HBASE-5727: Thanks, Zhihong. Will take a look.

[jira] [Commented] (HBASE-5732) Remove the SecureRPCEngine and merge the security-related logic in the core engine

2012-04-05 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247700#comment-13247700 ] Devaraj Das commented on HBASE-5732: I will take a stab at this. > Re

[jira] [Commented] (HBASE-5451) Switch RPC call envelope/headers to PBs

2012-04-05 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247593#comment-13247593 ] Devaraj Das commented on HBASE-5451: For the record, the discussion & resolution of th

[jira] [Commented] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

2012-04-05 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247529#comment-13247529 ] Devaraj Das commented on HBASE-5727: bq. How about running 'mvn -P security -P localTe

[jira] [Commented] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

2012-04-05 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247512#comment-13247512 ] Devaraj Das commented on HBASE-5727: Yes, I agree that we should merge the secure/unse

[jira] [Commented] (HBASE-5727) secure hbase build broke because of 'HBASE-5451 Switch RPC call envelope/headers to PBs'

2012-04-05 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247329#comment-13247329 ] Devaraj Das commented on HBASE-5727: I will get to it today. Sorry that I broke the bu

[jira] [Commented] (HBASE-5451) Switch RPC call envelope/headers to PBs

2012-04-03 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245369#comment-13245369 ] Devaraj Das commented on HBASE-5451: Thank you, Stack! > Switch RPC c

[jira] [Commented] (HBASE-5451) Switch RPC call envelope/headers to PBs

2012-03-23 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236933#comment-13236933 ] Devaraj Das commented on HBASE-5451: Could someone please look at this. Thanks!

[jira] [Commented] (HBASE-5451) Switch RPC call envelope/headers to PBs

2012-03-07 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224544#comment-13224544 ] Devaraj Das commented on HBASE-5451: After talking with Jimmy offline, it seems that t

[jira] [Commented] (HBASE-5451) Switch RPC call envelope/headers to PBs

2012-03-02 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221163#comment-13221163 ] Devaraj Das commented on HBASE-5451: bq. Won't hbase be all pb natively by 0.96.0? Th

[jira] [Commented] (HBASE-5451) Switch RPC call envelope/headers to PBs

2012-03-02 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221122#comment-13221122 ] Devaraj Das commented on HBASE-5451: bq. Can we avoid the copy in the interim by havin

[jira] [Commented] (HBASE-5451) Switch RPC call envelope/headers to PBs

2012-03-01 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220242#comment-13220242 ] Devaraj Das commented on HBASE-5451: bq. For example, I wonder if we need the protobuf

[jira] [Commented] (HBASE-5451) Switch RPC call envelope/headers to PBs

2012-02-29 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219728#comment-13219728 ] Devaraj Das commented on HBASE-5451: Updated reviewboard patch has most of the review

[jira] [Commented] (HBASE-5451) Switch RPC call envelope/headers to PBs

2012-02-24 Thread Devaraj Das (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215861#comment-13215861 ] Devaraj Das commented on HBASE-5451: Thanks Stack, for the quick but detailed review..