[jira] [Commented] (HBASE-7612) [JDK8] Replace use of high-scale-lib counters with intrinsic facilities

2016-12-01 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713609#comment-15713609 ] Hiroshi Ikeda commented on HBASE-7612: -- Sorry I have been busy and not created a patch. > [JDK8]

[jira] [Commented] (HBASE-10656) high-scale-lib's Counter depends on Oracle (Sun) JRE, and also has some bug

2016-10-30 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621076#comment-15621076 ] Hiroshi Ikeda commented on HBASE-10656: --- bq. No. AtomicLong is pretty bad for metrics usage. I

[jira] [Commented] (HBASE-10656) high-scale-lib's Counter depends on Oracle (Sun) JRE, and also has some bug

2016-10-18 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587767#comment-15587767 ] Hiroshi Ikeda commented on HBASE-10656: --- - The Counter is not intended to be frequently created and

[jira] [Commented] (HBASE-16642) Use DelayQueue instead of TimeoutBlockingQueue

2016-10-13 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574053#comment-15574053 ] Hiroshi Ikeda commented on HBASE-16642: --- Also I forget to prepare the case proc is null in

[jira] [Commented] (HBASE-16642) Use DelayQueue instead of TimeoutBlockingQueue

2016-10-13 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574030#comment-15574030 ] Hiroshi Ikeda commented on HBASE-16642: --- Sorry my patch V1 contains bugs, which you have easily

[jira] [Commented] (HBASE-16642) Use DelayQueue instead of TimeoutBlockingQueue

2016-10-13 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573895#comment-15573895 ] Hiroshi Ikeda commented on HBASE-16642: --- {code} ---

[jira] [Commented] (HBASE-16642) Use DelayQueue instead of TimeoutBlockingQueue

2016-10-11 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567573#comment-15567573 ] Hiroshi Ikeda commented on HBASE-16642: --- V2 mixes some other issues and I can't say for sure except

[jira] [Commented] (HBASE-16642) Use DelayQueue instead of TimeoutBlockingQueue

2016-10-03 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15541942#comment-15541942 ] Hiroshi Ikeda commented on HBASE-16642: --- Oops, I didn't realize that a single thread execute the

[jira] [Updated] (HBASE-16642) Use DelayQueue instead of TimeoutBlockingQueue

2016-09-30 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-16642: -- Attachment: HBASE-16642.master.V1.patch > Use DelayQueue instead of TimeoutBlockingQueue >

[jira] [Updated] (HBASE-16642) Use DelayQueue instead of TimeoutBlockingQueue

2016-09-30 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-16642: -- Status: Patch Available (was: Open) > Use DelayQueue instead of TimeoutBlockingQueue >

[jira] [Commented] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-20 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508357#comment-15508357 ] Hiroshi Ikeda commented on HBASE-16648: --- That result seems natural. The atomicity of

[jira] [Commented] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-20 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506063#comment-15506063 ] Hiroshi Ikeda commented on HBASE-16648: --- I'm not sure about JMH, but I suspect that the classes are

[jira] [Commented] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-19 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505655#comment-15505655 ] Hiroshi Ikeda commented on HBASE-16648: --- My bad, I didn't realized that the default implementation

[jira] [Commented] (HBASE-7612) [JDK8] Replace use of high-scale-lib counters with intrinsic facilities

2016-09-19 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505346#comment-15505346 ] Hiroshi Ikeda commented on HBASE-7612: -- Instead of reset, using another AtomicLonger to keep the last

[jira] [Commented] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-19 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505335#comment-15505335 ] Hiroshi Ikeda commented on HBASE-16648: --- I read just halfway the patch, but behaviors of

[jira] [Created] (HBASE-16642) Use DelayQueue instead of TimeoutBlockingQueue

2016-09-16 Thread Hiroshi Ikeda (JIRA)
Hiroshi Ikeda created HBASE-16642: - Summary: Use DelayQueue instead of TimeoutBlockingQueue Key: HBASE-16642 URL: https://issues.apache.org/jira/browse/HBASE-16642 Project: HBase Issue Type:

[jira] [Commented] (HBASE-16616) Rpc handlers stuck on ThreadLocalMap.expungeStaleEntry

2016-09-13 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486513#comment-15486513 ] Hiroshi Ikeda commented on HBASE-16616: --- It might be good to change indexHolderThreadLocal to be

[jira] [Updated] (HBASE-16569) Removed unnecessary declarations of throwing InterruptedException in RpcServer

2016-09-07 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-16569: -- Attachment: HBASE-16569.master.V2.patch HBASE-16569.branch-1.V2.patch Added

[jira] [Updated] (HBASE-16569) Removed unnecessary declarations of throwing InterruptedException in RpcServer

2016-09-07 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-16569: -- Component/s: (was: Performance) > Removed unnecessary declarations of throwing

[jira] [Updated] (HBASE-16569) Removed unnecessary declarations of throwing InterruptedException in RpcServer

2016-09-07 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-16569: -- Attachment: HBASE-16569.master.patch Added a patch for master. > Removed unnecessary

[jira] [Updated] (HBASE-16569) Removed unnecessary declarations of throwing InterruptedException in RpcServer

2016-09-07 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-16569: -- Attachment: HBASE-16569.branch-1.patch Added a patch for branch-1. > Removed unnecessary

[jira] [Updated] (HBASE-16569) Removed unnecessary declarations of throwing InterruptedException in RpcServer

2016-09-07 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-16569: -- Assignee: Hiroshi Ikeda Status: Patch Available (was: Open) > Removed unnecessary

[jira] [Created] (HBASE-16569) Removed unnecessary declarations of throwing InterruptedException in RpcServer

2016-09-07 Thread Hiroshi Ikeda (JIRA)
Hiroshi Ikeda created HBASE-16569: - Summary: Removed unnecessary declarations of throwing InterruptedException in RpcServer Key: HBASE-16569 URL: https://issues.apache.org/jira/browse/HBASE-16569

[jira] [Commented] (HBASE-16498) NPE when Scan's stopRow is set NULL

2016-08-29 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447991#comment-15447991 ] Hiroshi Ikeda commented on HBASE-16498: --- It is better to add a comment about how to scan to the end

[jira] [Commented] (HBASE-16502) Reduce garbage in BufferedDataBlockEncoder

2016-08-29 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447970#comment-15447970 ] Hiroshi Ikeda commented on HBASE-16502: --- +1 > Reduce garbage in BufferedDataBlockEncoder >

[jira] [Commented] (HBASE-16502) Reduce garbage in BufferedDataBlockEncoder

2016-08-29 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447597#comment-15447597 ] Hiroshi Ikeda commented on HBASE-16502: --- Sorry for late response. The last patch seems good except

[jira] [Commented] (HBASE-16502) Reduce garbage in BufferedDataBlockEncoder

2016-08-26 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438645#comment-15438645 ] Hiroshi Ikeda commented on HBASE-16502: --- Oops, too late :( > Reduce garbage in

[jira] [Commented] (HBASE-16502) Reduce garbage in BufferedDataBlockEncoder

2016-08-26 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438643#comment-15438643 ] Hiroshi Ikeda commented on HBASE-16502: --- It seems ensureSpaceForTags is called before copying

[jira] [Commented] (HBASE-16498) NPE when Scan's stopRow is set NULL

2016-08-26 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438553#comment-15438553 ] Hiroshi Ikeda commented on HBASE-16498: --- In general the behavior is undefined when passing a null

[jira] [Commented] (HBASE-16278) Use ConcurrentHashMap instead of ConcurrentSkipListMap if possible

2016-07-25 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391480#comment-15391480 ] Hiroshi Ikeda commented on HBASE-16278: --- Creating an object itself are quite light-weight and that

[jira] [Updated] (HBASE-16278) Use ConcurrentHashMap instead of ConcurrentSkipListMap if possible

2016-07-24 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-16278: -- Attachment: ConcurrentHashByteArrayMap.java Added a trial class which might be useful. > Use

[jira] [Updated] (HBASE-14479) Apply the Leader/Followers pattern to RpcServer's Reader

2016-07-24 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-14479: -- Attachment: HBASE-14479.branch-1.V5_e.patch Add a renamed patch for Hadoop QA, with fixing

[jira] [Updated] (HBASE-14479) Apply the Leader/Followers pattern to RpcServer's Reader

2016-07-22 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-14479: -- Attachment: HBASE-14479-V4-experimental_branch-1.patch Added a correct patch. > Apply the

[jira] [Commented] (HBASE-14479) Apply the Leader/Followers pattern to RpcServer's Reader

2016-07-22 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389699#comment-15389699 ] Hiroshi Ikeda commented on HBASE-14479: --- Oops some files are lost. I'll correct... > Apply the

[jira] [Updated] (HBASE-14479) Apply the Leader/Followers pattern to RpcServer's Reader

2016-07-22 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-14479: -- Attachment: HBASE-14479-V3-experimental_branch-1.patch Added an experimental patch for

[jira] [Commented] (HBASE-16210) Add Timestamp class to the hbase-common

2016-07-19 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385172#comment-15385172 ] Hiroshi Ikeda commented on HBASE-16210: --- Use abstract methods instead of throwing

[jira] [Updated] (HBASE-16236) Typo in javadoc of InstancePending

2016-07-15 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-16236: -- Assignee: Hiroshi Ikeda Status: Patch Available (was: Open) > Typo in javadoc of

[jira] [Updated] (HBASE-16236) Typo in javadoc of InstancePending

2016-07-15 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-16236: -- Attachment: HBASE-16236.patch > Typo in javadoc of InstancePending >

[jira] [Created] (HBASE-16236) Typo in javadoc of InstancePending

2016-07-15 Thread Hiroshi Ikeda (JIRA)
Hiroshi Ikeda created HBASE-16236: - Summary: Typo in javadoc of InstancePending Key: HBASE-16236 URL: https://issues.apache.org/jira/browse/HBASE-16236 Project: HBase Issue Type: Sub-task

[jira] [Commented] (HBASE-16210) Add Timestamp class to the hbase-common and Timestamp type to HTable.

2016-07-14 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378885#comment-15378885 ] Hiroshi Ikeda commented on HBASE-16210: --- It seems better to use enum like TimeUnit. No doubt naming

[jira] [Commented] (HBASE-14479) Apply the Leader/Followers pattern to RpcServer's Reader

2016-07-14 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378767#comment-15378767 ] Hiroshi Ikeda commented on HBASE-14479: --- In order to reduce overhead of unnecessarily changing

[jira] [Commented] (HBASE-14479) Apply the Leader/Followers pattern to RpcServer's Reader

2016-07-13 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376201#comment-15376201 ] Hiroshi Ikeda commented on HBASE-14479: --- bq. The doRunLoop will doRead for each key gotten on a

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-07-07 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367154#comment-15367154 ] Hiroshi Ikeda commented on HBASE-15716: --- I realized I should have named the test class using the

[jira] [Updated] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-07-07 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-15716: -- Assignee: stack (was: Hiroshi Ikeda) > HRegion#RegionScannerImpl scannerReadPoints

[jira] [Updated] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-07-07 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-15716: -- Attachment: TestScannerReadPointDoesntGoBack.java Added another test to check some

[jira] [Assigned] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-07-07 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda reassigned HBASE-15716: - Assignee: Hiroshi Ikeda (was: stack) > HRegion#RegionScannerImpl scannerReadPoints

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-07-05 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362226#comment-15362226 ] Hiroshi Ikeda commented on HBASE-15716: --- bq. I should make getReadPoint private. It is only for use

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-07-04 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361878#comment-15361878 ] Hiroshi Ikeda commented on HBASE-15716: --- I found there is some changes on the master around this

[jira] [Updated] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-07-04 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-15716: -- Attachment: ScannerReadPoints.v2.java Added a revised class, but messy :( >

[jira] [Updated] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-07-04 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-15716: -- Assignee: stack (was: Hiroshi Ikeda) > HRegion#RegionScannerImpl scannerReadPoints

[jira] [Updated] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-07-04 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-15716: -- Assignee: Hiroshi Ikeda (was: stack) > HRegion#RegionScannerImpl scannerReadPoints

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-07-04 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361009#comment-15361009 ] Hiroshi Ikeda commented on HBASE-15716: --- bq. You have tests that prove going backwards? It is

[jira] [Commented] (HBASE-14479) Apply the Leader/Followers pattern to RpcServer's Reader

2016-07-04 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360884#comment-15360884 ] Hiroshi Ikeda commented on HBASE-14479: --- RpcServer.Responder is sort of a safety net used when the

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-07-01 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358754#comment-15358754 ] Hiroshi Ikeda commented on HBASE-15716: --- That's bad. When there is no scanner, it is possible that

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-07-01 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358632#comment-15358632 ] Hiroshi Ikeda commented on HBASE-15716: --- Sorry, I found that getSmallestReadPoint() may go backward

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-06-30 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358319#comment-15358319 ] Hiroshi Ikeda commented on HBASE-15716: --- {code} + } // Otherwise head.references is

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-06-30 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358316#comment-15358316 ] Hiroshi Ikeda commented on HBASE-15716: --- I meant, in Listener.doAccept, change {code} Reader reader

[jira] [Updated] (HBASE-16150) Remove ConcurrentIndex

2016-06-30 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-16150: -- Attachment: HBASE-16150-master.patch HBASE-16150-branch-1.patch > Remove

[jira] [Updated] (HBASE-16150) Remove ConcurrentIndex

2016-06-30 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-16150: -- Status: Patch Available (was: Open) > Remove ConcurrentIndex > -- > >

[jira] [Created] (HBASE-16150) Remove ConcurrentIndex

2016-06-30 Thread Hiroshi Ikeda (JIRA)
Hiroshi Ikeda created HBASE-16150: - Summary: Remove ConcurrentIndex Key: HBASE-16150 URL: https://issues.apache.org/jira/browse/HBASE-16150 Project: HBase Issue Type: Bug

[jira] [Updated] (HBASE-14279) Race condition in ConcurrentIndex

2016-06-30 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-14279: -- Resolution: Invalid Status: Resolved (was: Patch Available) > Race condition in

[jira] [Commented] (HBASE-14279) Race condition in ConcurrentIndex

2016-06-30 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356599#comment-15356599 ] Hiroshi Ikeda commented on HBASE-14279: --- bq. If someone want it, open another issue for it. Oops,

[jira] [Updated] (HBASE-14279) Race condition in ConcurrentIndex

2016-06-30 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-14279: -- Status: Patch Available (was: Reopened) > Race condition in ConcurrentIndex >

[jira] [Reopened] (HBASE-14279) Race condition in ConcurrentIndex

2016-06-30 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda reopened HBASE-14279: --- Assignee: Hiroshi Ikeda (was: Heng Chen) > Race condition in ConcurrentIndex >

[jira] [Updated] (HBASE-14279) Race condition in ConcurrentIndex

2016-06-30 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-14279: -- Attachment: HBASE-14279-V8-ikeda-master.patch

[jira] [Commented] (HBASE-14279) Race condition in ConcurrentIndex

2016-06-29 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356521#comment-15356521 ] Hiroshi Ikeda commented on HBASE-14279: --- I again re-checked and considered how ConcurrentIndex is

[jira] [Updated] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-06-29 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-15716: -- Assignee: stack (was: Hiroshi Ikeda) > HRegion#RegionScannerImpl scannerReadPoints

[jira] [Updated] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-06-29 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroshi Ikeda updated HBASE-15716: -- Attachment: TestScannerReadPoints.java ScannerReadPoints.java Anyway I add

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-06-29 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356363#comment-15356363 ] Hiroshi Ikeda commented on HBASE-15716: --- Now I find the menu item "Attach Files". But I feel it

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-06-28 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354603#comment-15354603 ] Hiroshi Ikeda commented on HBASE-15716: --- I find I'm an administrator by the wheel icon, but still

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-06-28 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354577#comment-15354577 ] Hiroshi Ikeda commented on HBASE-15716: --- I still don't find a menu item or something to attach

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-06-28 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352818#comment-15352818 ] Hiroshi Ikeda commented on HBASE-15716: --- I tried some and created some tiny file but I just

[jira] [Commented] (HBASE-15146) Don't block on Reader threads queueing to a scheduler queue

2016-06-24 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348059#comment-15348059 ] Hiroshi Ikeda commented on HBASE-15146: --- If all clients are well-behaved and patiently wait their

[jira] [Commented] (HBASE-15146) Don't block on Reader threads queueing to a scheduler queue

2016-06-22 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343934#comment-15343934 ] Hiroshi Ikeda commented on HBASE-15146: --- That seems based on the fact that there are some clients

[jira] [Commented] (HBASE-15146) Don't block on Reader threads queueing to a scheduler queue

2016-06-21 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343753#comment-15343753 ] Hiroshi Ikeda commented on HBASE-15146: --- Oh, I just realized I misunderstood classification

[jira] [Commented] (HBASE-15146) Don't block on Reader threads queueing to a scheduler queue

2016-06-21 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343718#comment-15343718 ] Hiroshi Ikeda commented on HBASE-15146: --- Changing the published method RWQueueRpcExecutor.dispatch

[jira] [Commented] (HBASE-16023) Fastpath for the FIFO rpcscheduler

2016-06-19 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338883#comment-15338883 ] Hiroshi Ikeda commented on HBASE-16023: --- Other worrying things: {code} protected CallRunner

[jira] [Commented] (HBASE-16063) Race condition in new FIFO fastpath from HBASE-16023

2016-06-19 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338869#comment-15338869 ] Hiroshi Ikeda commented on HBASE-16063: --- bq. I do not see how we could lock up. If the unlikely

[jira] [Commented] (HBASE-14331) a single callQueue related improvements

2016-06-15 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331253#comment-15331253 ] Hiroshi Ikeda commented on HBASE-14331: --- bq. Do you want to close this issue then in favor of

[jira] [Commented] (HBASE-16023) Fastpath for the FIFO rpcscheduler

2016-06-14 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331172#comment-15331172 ] Hiroshi Ikeda commented on HBASE-16023: --- Sorry my lack of explanation. An concrete example of the

[jira] [Commented] (HBASE-16023) Fastpath for the FIFO rpcscheduler

2016-06-14 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331123#comment-15331123 ] Hiroshi Ikeda commented on HBASE-16023: --- {code} protected CallRunner getCallRunner() throws

[jira] [Commented] (HBASE-15971) Regression: Random Read/WorkloadC slower in 1.x than 0.98

2016-06-14 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331029#comment-15331029 ] Hiroshi Ikeda commented on HBASE-15971: --- I meant LinkedTransferQueue implements BlockingQueue

[jira] [Commented] (HBASE-15971) Regression: Random Read/WorkloadC slower in 1.x than 0.98

2016-06-13 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327030#comment-15327030 ] Hiroshi Ikeda commented on HBASE-15971: --- Sorry, LinkedTransferQueue is unbound. > Regression:

[jira] [Commented] (HBASE-15971) Regression: Random Read/WorkloadC slower in 1.x than 0.98

2016-06-13 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326895#comment-15326895 ] Hiroshi Ikeda commented on HBASE-15971: --- There seems excessive contention when the reader threads

[jira] [Commented] (HBASE-15967) Metric for active ipc Readers and make default fraction of cpu count

2016-06-07 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317950#comment-15317950 ] Hiroshi Ikeda commented on HBASE-15967: --- I think it is enough to queue and pay attention to

[jira] [Commented] (HBASE-15967) Metric for active ipc Readers and make default fraction of cpu count

2016-06-06 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317689#comment-15317689 ] Hiroshi Ikeda commented on HBASE-15967: --- If we apply the leader/followers pattern, remove the

[jira] [Commented] (HBASE-15803) ZooKeeperWatcher's constructor can leak a ZooKeeper instance with throwing ZooKeeperConnectionException when canCreateBaseZNode is true

2016-06-06 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317595#comment-15317595 ] Hiroshi Ikeda commented on HBASE-15803: --- +1 Anyway the patch should make it better. >

[jira] [Commented] (HBASE-15803) ZooKeeperWatcher's constructor can leak a ZooKeeper instance with throwing ZooKeeperConnectionException when canCreateBaseZNode is true

2016-05-29 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15306176#comment-15306176 ] Hiroshi Ikeda commented on HBASE-15803: --- That should work well except it is better to restore

[jira] [Commented] (HBASE-15802) ConnectionUtils should use ThreadLocalRandom instead of Random

2016-05-22 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295815#comment-15295815 ] Hiroshi Ikeda commented on HBASE-15802: --- This is another issue but {code} +long jitter = (long)

[jira] [Commented] (HBASE-15292) Refined ZooKeeperWatcher to prevent ZooKeeper's callback while construction

2016-05-15 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284064#comment-15284064 ] Hiroshi Ikeda commented on HBASE-15292: --- NVM, that's wrong; Setting these parameters happens before

[jira] [Commented] (HBASE-15292) Refined ZooKeeperWatcher to prevent ZooKeeper's callback while construction

2016-05-09 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276150#comment-15276150 ] Hiroshi Ikeda commented on HBASE-15292: --- FYI It is already fixed by this patch but I just noticed

[jira] [Created] (HBASE-15803) ZooKeeperWatcher's constructor can leak a ZooKeeper instance with throwing ZooKeeperConnectionException when canCreateBaseZNode is true

2016-05-09 Thread Hiroshi Ikeda (JIRA)
Hiroshi Ikeda created HBASE-15803: - Summary: ZooKeeperWatcher's constructor can leak a ZooKeeper instance with throwing ZooKeeperConnectionException when canCreateBaseZNode is true Key: HBASE-15803 URL:

[jira] [Created] (HBASE-15802) ConnectionUtils should use ThreadLocalRandom instead of Random

2016-05-08 Thread Hiroshi Ikeda (JIRA)
Hiroshi Ikeda created HBASE-15802: - Summary: ConnectionUtils should use ThreadLocalRandom instead of Random Key: HBASE-15802 URL: https://issues.apache.org/jira/browse/HBASE-15802 Project: HBase

[jira] [Commented] (HBASE-15702) Improve PerClientRandomNonceGenerator

2016-05-01 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266119#comment-15266119 ] Hiroshi Ikeda commented on HBASE-15702: --- {code} - private static volatile NonceGenerator

[jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read

2016-05-01 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266056#comment-15266056 ] Hiroshi Ikeda commented on HBASE-15716: --- {code} + // If the isolation level is

[jira] [Commented] (HBASE-15702) Improve PerClientRandomNonceGenerator

2016-04-28 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261851#comment-15261851 ] Hiroshi Ikeda commented on HBASE-15702: --- {quote} the loading is exclusively done with locking the

[jira] [Commented] (HBASE-15702) Improve PerClientRandomNonceGenerator

2016-04-28 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261822#comment-15261822 ] Hiroshi Ikeda commented on HBASE-15702: --- Yes. When threads try to load the same class, the loading

[jira] [Commented] (HBASE-15702) Improve PerClientRandomNonceGenerator

2016-04-28 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261778#comment-15261778 ] Hiroshi Ikeda commented on HBASE-15702: --- I know you get what I meant, but "static" is required for

[jira] [Commented] (HBASE-15702) Improve PerClientRandomNonceGenerator

2016-04-28 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261705#comment-15261705 ] Hiroshi Ikeda commented on HBASE-15702: --- Is there any possibility that you use (load) the class

[jira] [Commented] (HBASE-15525) OutOfMemory could occur when using BoundedByteBufferPool during RPC bursts

2016-04-28 Thread Hiroshi Ikeda (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261677#comment-15261677 ] Hiroshi Ikeda commented on HBASE-15525: --- I expect you create better implementation than the one I

  1   2   3   4   >