Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5899: URL: https://github.com/apache/hbase/pull/5899#issuecomment-218325 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5899: URL: https://github.com/apache/hbase/pull/5899#issuecomment-213972 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5899: URL: https://github.com/apache/hbase/pull/5899#issuecomment-2111084483 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
gvprathyusha6 closed pull request #5898: HBASE-27938 - PE load any custom implementation of tests at runtime URL: https://github.com/apache/hbase/pull/5898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HBASE-26625 ExportSnapshot tool failed to copy data files for tables with merge region [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5897: URL: https://github.com/apache/hbase/pull/5897#issuecomment-2110988251 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-26625 ExportSnapshot tool failed to copy data files for tables with merge region [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5897: URL: https://github.com/apache/hbase/pull/5897#issuecomment-2110968811 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
virajjasani commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110922431 @gvprathyusha6 could you also create branch-2 PR? we can merge both of them together and backport as required. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-14 Thread via GitHub
virajjasani commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2110914019 > Here you just submit the async zk operation in the timer task, and then in the callback, you check reschedule the timer task and then you have a chance to check timeout, but what if

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110679307 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110679226 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110675983 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110656423 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-26625 ExportSnapshot tool failed to copy data files for tables with merge region [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5897: URL: https://github.com/apache/hbase/pull/5897#issuecomment-2110593995 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-14 Thread via GitHub
Apache9 commented on code in PR #5837: URL: https://github.com/apache/hbase/pull/5837#discussion_r1599917696 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncMetaRegionLocator.java: ## @@ -25,6 +25,7 @@ import java.util.concurrent.CompletableFuture; import

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110053326 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110045600 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110041594 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110040484 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s |

Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-14 Thread via GitHub
frostruan commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2109960909 > Thanks @frostruan. I don't have any other feedback here, I just saw that it stalled. > > If you have time to finish it, that'd be great. If not I can ask someone at my company

Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-14 Thread via GitHub
bbeaudreault commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2109932196 Thanks @frostruan. I don't have any other feedback here, I just saw that it stalled. If you have time to finish it, that'd be great. If not I can ask someone at my company to

Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-14 Thread via GitHub
frostruan commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2109777296 @bbeaudreault This PR has some conflicts with the master branch. I can fix PR if you need. And if you have new or more ideas, it's completely ok for me to close this PR and you can

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-13 Thread via GitHub
virajjasani commented on code in PR #5837: URL: https://github.com/apache/hbase/pull/5837#discussion_r1599411467 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKConnectionRegistry.java: ## @@ -70,6 +73,11 @@ class ZKConnectionRegistry implements

Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-13 Thread via GitHub
frostruan commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2109241221 We have this patch in our internal branch for a long time, and the effect is in line with expectations. So I think we can pick this up too. -- This is an automated message from the

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2108938449 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2108931751 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s |

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2108889817 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s |

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2108528810 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5876: URL: https://github.com/apache/hbase/pull/5876#issuecomment-2108325553 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5876: URL: https://github.com/apache/hbase/pull/5876#issuecomment-2108323241 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5876: URL: https://github.com/apache/hbase/pull/5876#issuecomment-2108321888 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5876: URL: https://github.com/apache/hbase/pull/5876#issuecomment-2108300478 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s |

Re: [PR] HBASE-28502 Cleanup old backup manifest logic [hbase]

2024-05-13 Thread via GitHub
joshelser commented on PR #5871: URL: https://github.com/apache/hbase/pull/5871#issuecomment-2108176794  sorry, I don't recall exactly what was being put into the incremental backups anymore. I remember holding on to all of the WAL files quickly got out of control and we talked about

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

2024-05-13 Thread via GitHub
DieterDP-ng commented on code in PR #5876: URL: https://github.com/apache/hbase/pull/5876#discussion_r1598758193 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java: ## @@ -129,20 +128,15 @@ public int deleteBackups(String[] backupIds) throws

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

2024-05-13 Thread via GitHub
DieterDP-ng commented on PR #5876: URL: https://github.com/apache/hbase/pull/5876#issuecomment-2108155158 > Test failure looks like a failure of the backup system. It's attempting to take an incremental backup, which assumes the existence of a WAL that no longer exists. The test harness

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5896: URL: https://github.com/apache/hbase/pull/5896#issuecomment-2108125557 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s |

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5895: URL: https://github.com/apache/hbase/pull/5895#issuecomment-2108095534 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s |

Re: [PR] HBASE-28539 Fix merging of incremental backups when the backup filesystem is not the same as the one underpinning HBase itself. [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5867: URL: https://github.com/apache/hbase/pull/5867#issuecomment-2108092675 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 19s |

Re: [PR] HBASE-28539 Fix merging of incremental backups when the backup filesystem is not the same as the one underpinning HBase itself. [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5867: URL: https://github.com/apache/hbase/pull/5867#issuecomment-2108090607 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28539 Fix merging of incremental backups when the backup filesystem is not the same as the one underpinning HBase itself. [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5867: URL: https://github.com/apache/hbase/pull/5867#issuecomment-2108081495 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 23s |

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5896: URL: https://github.com/apache/hbase/pull/5896#issuecomment-2108072939 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 16s |

Re: [PR] HBASE-28539 Fix merging of incremental backups when the backup filesystem is not the same as the one underpinning HBase itself. [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5867: URL: https://github.com/apache/hbase/pull/5867#issuecomment-2108057539 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5894: URL: https://github.com/apache/hbase/pull/5894#issuecomment-2108035193 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5894: URL: https://github.com/apache/hbase/pull/5894#issuecomment-2108035051 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-13 Thread via GitHub
Apache9 commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2108018917 Have you faced this problem in your production? @bbeaudreault We can pick this up I think. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5895: URL: https://github.com/apache/hbase/pull/5895#issuecomment-2108006254 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 25s |

Re: [PR] HBASE-28539 Fix merging of incremental backups when the backup filesystem is not the same as the one underpinning HBase itself. [hbase]

2024-05-13 Thread via GitHub
bcolyn-ngdata commented on code in PR #5867: URL: https://github.com/apache/hbase/pull/5867#discussion_r1598654473 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupMerge.java: ## @@ -124,4 +128,44 @@ public void TestIncBackupMergeRestore() throws Exception

Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-13 Thread via GitHub
bbeaudreault commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2107770254 Can we pick this back up? This is actually a big issue. If you clear compaction queues, you're almost guaranteed to enter a case where new compactions for those regions cannot

Re: [PR] HBASE-28502 Cleanup old backup manifest logic [hbase]

2024-05-13 Thread via GitHub
DieterDP-ng commented on code in PR #5871: URL: https://github.com/apache/hbase/pull/5871#discussion_r1598573660 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/HBackupFileSystem.java: ## @@ -102,24 +95,6 @@ public static Path getTableBackupPath(TableName

Re: [PR] HBASE-28502 Cleanup old backup manifest logic [hbase]

2024-05-13 Thread via GitHub
DieterDP-ng commented on PR #5871: URL: https://github.com/apache/hbase/pull/5871#issuecomment-2107727003 > Looks good to me. It would be good to solicit comments from whomever made the change that deprecated the old manifest logic in the first place. @DieterDP-ng do you know whom that

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-13 Thread via GitHub
Apache9 commented on code in PR #5893: URL: https://github.com/apache/hbase/pull/5893#discussion_r1598529826 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java: ## @@ -686,12 +686,6 @@ public void abortCacheFlush(byte[] encodedRegionName)

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-13 Thread via GitHub
2005hithlj commented on PR #5893: URL: https://github.com/apache/hbase/pull/5893#issuecomment-2107650319 The failed UT TestMasterRegionWALCleaner is not related to the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5895: URL: https://github.com/apache/hbase/pull/5895#issuecomment-2107452083 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5896: URL: https://github.com/apache/hbase/pull/5896#issuecomment-2107435722 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s |

Re: [PR] HBASE-28592 Backport HBASE-26525 Use unique thread name for group WALs [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5894: URL: https://github.com/apache/hbase/pull/5894#issuecomment-2107405484 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s |

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5893: URL: https://github.com/apache/hbase/pull/5893#issuecomment-2107079527 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5893: URL: https://github.com/apache/hbase/pull/5893#issuecomment-2107008756 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 29s |

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-13 Thread via GitHub
Apache-HBase commented on PR #5893: URL: https://github.com/apache/hbase/pull/5893#issuecomment-2106990146 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28547 Support specifying connection configuration through queri… [hbase]

2024-05-13 Thread via GitHub
ndimiduk commented on PR #5853: URL: https://github.com/apache/hbase/pull/5853#issuecomment-2106862711 +1 from my. Still, I would like to hear @anmolnar 's arguments against. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-12 Thread via GitHub
Apache-HBase commented on PR #5893: URL: https://github.com/apache/hbase/pull/5893#issuecomment-2106662183 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

[PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-12 Thread via GitHub
2005hithlj opened a new pull request, #5893: URL: https://github.com/apache/hbase/pull/5893 https://issues.apache.org/jira/browse/HBASE-28588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HBASE-28586 Backport HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method [hbase]

2024-05-12 Thread via GitHub
Apache9 merged PR #5888: URL: https://github.com/apache/hbase/pull/5888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28547 Support specifying connection configuration through queri… [hbase]

2024-05-12 Thread via GitHub
Apache-HBase commented on PR #5853: URL: https://github.com/apache/hbase/pull/5853#issuecomment-2106286365 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 33s |

Re: [PR] HBASE-28547 Support specifying connection configuration through queri… [hbase]

2024-05-12 Thread via GitHub
Apache-HBase commented on PR #5853: URL: https://github.com/apache/hbase/pull/5853#issuecomment-2106285291 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 35s |

Re: [PR] HBASE-28547 Support specifying connection configuration through queri… [hbase]

2024-05-12 Thread via GitHub
Apache-HBase commented on PR #5853: URL: https://github.com/apache/hbase/pull/5853#issuecomment-2106278040 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s |

Re: [PR] HBASE-28547 Support specifying connection configuration through queri… [hbase]

2024-05-12 Thread via GitHub
Apache-HBase commented on PR #5853: URL: https://github.com/apache/hbase/pull/5853#issuecomment-2106276454 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-28586 Backport HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method [hbase]

2024-05-12 Thread via GitHub
Apache-HBase commented on PR #5888: URL: https://github.com/apache/hbase/pull/5888#issuecomment-2106263406 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

Re: [PR] HBASE-28586 Backport HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method [hbase]

2024-05-12 Thread via GitHub
Apache-HBase commented on PR #5888: URL: https://github.com/apache/hbase/pull/5888#issuecomment-2106263182 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 41s |

Re: [PR] HBASE-28586 Backport HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method [hbase]

2024-05-12 Thread via GitHub
Apache-HBase commented on PR #5888: URL: https://github.com/apache/hbase/pull/5888#issuecomment-2106262504 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 35s |

Re: [PR] HBASE-28547 Support specifying connection registry configuration thro… [hbase]

2024-05-12 Thread via GitHub
Apache9 commented on PR #5850: URL: https://github.com/apache/hbase/pull/5850#issuecomment-2106260770 Close in favor of #5853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HBASE-28547 Support specifying connection registry configuration thro… [hbase]

2024-05-12 Thread via GitHub
Apache9 commented on code in PR #5850: URL: https://github.com/apache/hbase/pull/5850#discussion_r1597646001 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKConnectionRegistryURIFactory.java: ## @@ -30,9 +34,34 @@ * Connection registry creator implementation

Re: [PR] HBASE-28547 Support specifying connection registry configuration thro… [hbase]

2024-05-12 Thread via GitHub
Apache9 closed pull request #5850: HBASE-28547 Support specifying connection registry configuration thro… URL: https://github.com/apache/hbase/pull/5850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HBASE-28581 Remove deprecated methods in TableDescriotorBuilder [hbase]

2024-05-12 Thread via GitHub
Apache9 merged PR #5892: URL: https://github.com/apache/hbase/pull/5892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-12 Thread via GitHub
Apache9 merged PR #5891: URL: https://github.com/apache/hbase/pull/5891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-12 Thread via GitHub
Apache9 commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2106253685 Please fix the spotless errors? @q977734161 Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HBASE-28586 Backport HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method [hbase]

2024-05-12 Thread via GitHub
Apache9 merged PR #5887: URL: https://github.com/apache/hbase/pull/5887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28586 Backport HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method [hbase]

2024-05-12 Thread via GitHub
Apache9 merged PR #5890: URL: https://github.com/apache/hbase/pull/5890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28586 Backport HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method [hbase]

2024-05-12 Thread via GitHub
Apache9 merged PR #5886: URL: https://github.com/apache/hbase/pull/5886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-11 Thread via GitHub
2005hithlj commented on PR #5891: URL: https://github.com/apache/hbase/pull/5891#issuecomment-2105649073 This time, it was a different UT TestNamespaceReplication that failed, and it is not related to the changes. -- This is an automated message from the Apache Git Service. To

Re: [PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5891: URL: https://github.com/apache/hbase/pull/5891#issuecomment-2105574213 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5891: URL: https://github.com/apache/hbase/pull/5891#issuecomment-2105572985 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5891: URL: https://github.com/apache/hbase/pull/5891#issuecomment-2105572433 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28581 Remove deprecated methods in TableDescriotorBuilder [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5892: URL: https://github.com/apache/hbase/pull/5892#issuecomment-2105463844 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28581 Remove deprecated methods in TableDescriotorBuilder [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5892: URL: https://github.com/apache/hbase/pull/5892#issuecomment-2105463027 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28581 Remove deprecated methods in TableDescriotorBuilder [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5892: URL: https://github.com/apache/hbase/pull/5892#issuecomment-2105460816 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

Re: [PR] HBASE-28581 Remove deprecated methods in TableDescriotorBuilder [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5892: URL: https://github.com/apache/hbase/pull/5892#issuecomment-2105460406 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

Re: [PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5891: URL: https://github.com/apache/hbase/pull/5891#issuecomment-2105443232 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-10 Thread via GitHub
2005hithlj commented on PR #5891: URL: https://github.com/apache/hbase/pull/5891#issuecomment-2105433912 The failed UTs TestBlockingIPC/TestPrefetchWithBucketCache is not related to the changes, let's see if it will still fail in the new commit. -- This is an automated message from the

Re: [PR] HBASE-28581 Remove deprecated methods in TableDescriotorBuilder [hbase]

2024-05-10 Thread via GitHub
2005hithlj commented on PR #5892: URL: https://github.com/apache/hbase/pull/5892#issuecomment-2105430990 I will fix the spotless check errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-10 Thread via GitHub
2005hithlj commented on PR #5891: URL: https://github.com/apache/hbase/pull/5891#issuecomment-2105431081 I will fix the spotless check errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HBASE-28579 Hide HFileScanner related methods in StoreFileReader [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5889: URL: https://github.com/apache/hbase/pull/5889#issuecomment-2105262236 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2105198103 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2105194222 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2105192953 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2105187283 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s |

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2105154925 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28579 Hide HFileScanner related methods in StoreFileReader [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5889: URL: https://github.com/apache/hbase/pull/5889#issuecomment-2105147484 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s |

Re: [PR] HBASE-28579 Hide HFileScanner related methods in StoreFileReader [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5889: URL: https://github.com/apache/hbase/pull/5889#issuecomment-2105106888 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5891: URL: https://github.com/apache/hbase/pull/5891#issuecomment-2105106222 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5891: URL: https://github.com/apache/hbase/pull/5891#issuecomment-2105098107 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2105065234 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

  1   2   3   4   5   6   7   8   9   10   >