[jira] [Commented] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262394#comment-13262394 ] Hudson commented on HBASE-5652: --- Integrated in HBase-TRUNK-security #185 (See

[jira] [Commented] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-23 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259439#comment-13259439 ] Jonathan Hsieh commented on HBASE-5652: --- I side with Greg here. I'd rather we only

[jira] [Commented] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259946#comment-13259946 ] Hadoop QA commented on HBASE-5652: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-23 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259957#comment-13259957 ] stack commented on HBASE-5652: -- I ran TestSplitLogManager ten times on trunk and it passed

[jira] [Commented] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-22 Thread Uma Maheswara Rao G (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259177#comment-13259177 ] Uma Maheswara Rao G commented on HBASE-5652: @Gregory, Also please update the

[jira] [Commented] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-22 Thread Gregory Chanan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259272#comment-13259272 ] Gregory Chanan commented on HBASE-5652: --- @Ted: will update spacing @Uma: will

[jira] [Commented] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-22 Thread Zhihong Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259277#comment-13259277 ] Zhihong Yu commented on HBASE-5652: --- I think we can release this.cacheFlushLock before

[jira] [Commented] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-21 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258786#comment-13258786 ] ramkrishna.s.vasudevan commented on HBASE-5652: --- @Greg I think the lock

[jira] [Commented] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-21 Thread Uma Maheswara Rao G (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258791#comment-13258791 ] Uma Maheswara Rao G commented on HBASE-5652: Agreed with Ram, variable

[jira] [Commented] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-21 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258794#comment-13258794 ] ramkrishna.s.vasudevan commented on HBASE-5652: --- Yes Uma you are right. Jon

[jira] [Commented] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258698#comment-13258698 ] Hadoop QA commented on HBASE-5652: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5652) [findbugs] Fix lock release on all paths

2012-04-20 Thread Zhihong Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258763#comment-13258763 ] Zhihong Yu commented on HBASE-5652: --- {code} +if(status != null)