[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[
https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13716044#comment-13716044
]
stack commented on HBASE-5995:
--
TestLogRolling.testLogRollOnPipelineRestart failed on hadoop1 here:
https://builds.apache.org/job/hbase-0.95/352/consoleText It went zombie.
In the double thread dump on the end:
{code}
pool-1-thread-1 prio=10 tid=0x73f9dc00 nid=0x3a34 in Object.wait()
[0x7517d000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
- waiting on 0xcf624ad0 (a java.util.concurrent.atomic.AtomicLong)
at
org.apache.hadoop.hbase.client.AsyncProcess.waitForNextTaskDone(AsyncProcess.java:634)
- locked 0xcf624ad0 (a java.util.concurrent.atomic.AtomicLong)
at
org.apache.hadoop.hbase.client.AsyncProcess.waitForMaximumCurrentTasks(AsyncProcess.java:659)
at
org.apache.hadoop.hbase.client.AsyncProcess.waitUntilDone(AsyncProcess.java:670)
at
org.apache.hadoop.hbase.client.HTable.backgroundFlushCommits(HTable.java:813)
at org.apache.hadoop.hbase.client.HTable.flushCommits(HTable.java:1170)
at org.apache.hadoop.hbase.client.HTable.put(HTable.java:753)
at
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.doPut(TestLogRolling.java:640)
at
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.writeData(TestLogRolling.java:248)
at
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.testLogRollOnPipelineRestart(TestLogRolling.java:515)
{code}
... we are stuck here.
The math looks like it could go wonky. But looking in the output for the test,
it seems that when this test ran we got this:
2013-07-23 01:23:29,560 INFO [pool-1-thread-1] hbase.HBaseTestingUtility(922):
Minicluster is down
2013-07-23 01:23:29,574 INFO [pool-1-thread-1] hbase.ResourceChecker(171):
after: regionserver.wal.TestLogRolling#testLogRollOnPipelineRestart Thread=39
(was 31) - Thread LEAK? -, OpenFileDescriptor=312 (was 272) -
OpenFileDescriptor LEAK? -, MaxFileDescriptor=4 (was 4),
SystemLoadAverage=351 (was 368), ProcessCount=144 (was 142) - ProcessCount
LEAK? -, AvailableMemoryMB=906 (was 1995), ConnectionCount=0 (was 0)
So we were up against the fd limit.
Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
Key: HBASE-5995
URL: https://issues.apache.org/jira/browse/HBASE-5995
Project: HBase
Issue Type: Sub-task
Components: test
Reporter: stack
Assignee: Enis Soztutar
Priority: Blocker
Fix For: 0.98.0, 0.95.1
Attachments: hbase-5995_v1.patch, hbase-5995_v2.patch,
hbase-5995_v3.patch
HBASE-5984 disabled this flakey test (See the issue for more). This issue is
about getting it enabled again. Made a blocker on 0.96.0 so it gets
attention.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13716053#comment-13716053 ] stack commented on HBASE-5995: -- bq. So we were up against the fd limit. When I say the above, I am wrong. I am misreading the output of the ResourceChecker. We are not up against the limit. This test went zombie on us. Let me open new issue. Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Sub-task Components: test Reporter: stack Assignee: Enis Soztutar Priority: Blocker Fix For: 0.98.0, 0.95.1 Attachments: hbase-5995_v1.patch, hbase-5995_v2.patch, hbase-5995_v3.patch HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13659267#comment-13659267 ] Hudson commented on HBASE-5995: --- Integrated in hbase-0.95-on-hadoop2 #101 (See [https://builds.apache.org/job/hbase-0.95-on-hadoop2/101/]) HBASE-5995 Fix and reenable TestLogRolling.testLogRollOnPipelineRestart (Revision 1483006) Result = FAILURE enis : Files : * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Sub-task Components: test Reporter: stack Assignee: Enis Soztutar Priority: Blocker Fix For: 0.98.0, 0.95.1 Attachments: hbase-5995_v1.patch, hbase-5995_v2.patch, hbase-5995_v3.patch HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658661#comment-13658661 ] Enis Soztutar commented on HBASE-5995: -- Failing test is possibly due to HBASE-8535. Will commit this now. Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Sub-task Components: test Reporter: stack Assignee: Enis Soztutar Priority: Blocker Fix For: 0.98.0, 0.95.1 Attachments: hbase-5995_v1.patch, hbase-5995_v2.patch, hbase-5995_v3.patch HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658963#comment-13658963 ] Hudson commented on HBASE-5995: --- Integrated in hbase-0.95 #196 (See [https://builds.apache.org/job/hbase-0.95/196/]) HBASE-5995 Fix and reenable TestLogRolling.testLogRollOnPipelineRestart (Revision 1483006) Result = FAILURE enis : Files : * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Sub-task Components: test Reporter: stack Assignee: Enis Soztutar Priority: Blocker Fix For: 0.98.0, 0.95.1 Attachments: hbase-5995_v1.patch, hbase-5995_v2.patch, hbase-5995_v3.patch HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13659153#comment-13659153 ] Hudson commented on HBASE-5995: --- Integrated in HBase-TRUNK #4122 (See [https://builds.apache.org/job/HBase-TRUNK/4122/]) HBASE-5995 Fix and reenable TestLogRolling.testLogRollOnPipelineRestart (Revision 1483004) Result = FAILURE enis : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Sub-task Components: test Reporter: stack Assignee: Enis Soztutar Priority: Blocker Fix For: 0.98.0, 0.95.1 Attachments: hbase-5995_v1.patch, hbase-5995_v2.patch, hbase-5995_v3.patch HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13659233#comment-13659233 ] Hudson commented on HBASE-5995: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #532 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/532/]) HBASE-5995 Fix and reenable TestLogRolling.testLogRollOnPipelineRestart (Revision 1483004) Result = FAILURE enis : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Sub-task Components: test Reporter: stack Assignee: Enis Soztutar Priority: Blocker Fix For: 0.98.0, 0.95.1 Attachments: hbase-5995_v1.patch, hbase-5995_v2.patch, hbase-5995_v3.patch HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[
https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13657632#comment-13657632
]
stack commented on HBASE-5995:
--
If we do this:
{code}
- sync();
+ try {
+sync();
+ } catch (IOException ioe) {
+if (ioe.getMessage().contains(DFSOutputStream is closed)) {
+ //do not throw this here, sync() failed we will just close the
writer
+}
+ }
{code}
... we will skip this:
{code}
LOG.error(Failed close of HLog writer, e);
int errors = closeErrorCount.incrementAndGet();
if (errors = closeErrorsTolerated !hasDeferredEntries()) {
LOG.warn(Riding over HLog close failure! error count=+errors);
} else {
if (hasDeferredEntries()) {
LOG.error(Aborting due to unflushed edits in HLog);
}
// Failed close of log file. Means we're losing edits. For now,
// shut ourselves down to minimize loss. Alternative is to try and
// keep going. See HBASE-930.
FailedLogCloseException flce =
new FailedLogCloseException(# + currentfilenum);
flce.initCause(e);
throw flce;
}
{code}
... in particular, the abort of the server because we failed sync out some
deferred edits.
Should the close into a finally?
Else looks good
Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
Key: HBASE-5995
URL: https://issues.apache.org/jira/browse/HBASE-5995
Project: HBase
Issue Type: Sub-task
Components: test
Reporter: stack
Assignee: Enis Soztutar
Priority: Blocker
Fix For: 0.98.0, 0.95.1
Attachments: hbase-5995_v1.patch, hbase-5995_v2.patch
HBASE-5984 disabled this flakey test (See the issue for more). This issue is
about getting it enabled again. Made a blocker on 0.96.0 so it gets
attention.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13657860#comment-13657860 ] Enis Soztutar commented on HBASE-5995: -- bq. we will skip this:.. in particular, the abort of the server because we failed sync out some deferred edits. good catch. Although we are only catching the IOE in sync(), not in close(), we might need the below lines for aborting RS. I removed exception catching there altogether. I had put it there because the logs were getting filled with hundreds of DFSOutputStream is closed exceptions, but with the sleep statement added in LogScyner exception, I think this is not the case anymore. Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Sub-task Components: test Reporter: stack Assignee: Enis Soztutar Priority: Blocker Fix For: 0.98.0, 0.95.1 Attachments: hbase-5995_v1.patch, hbase-5995_v2.patch, hbase-5995_v3.patch HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13657897#comment-13657897 ] stack commented on HBASE-5995: -- +1 if test passes. Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Sub-task Components: test Reporter: stack Assignee: Enis Soztutar Priority: Blocker Fix For: 0.98.0, 0.95.1 Attachments: hbase-5995_v1.patch, hbase-5995_v2.patch, hbase-5995_v3.patch HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[
https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13657899#comment-13657899
]
Hadoop QA commented on HBASE-5995:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12583273/hbase-5995_v3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.client.TestHCM.testDeleteForZKConnLeak(TestHCM.java:855)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5696//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5696//console
This message is automatically generated.
Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
Key: HBASE-5995
URL: https://issues.apache.org/jira/browse/HBASE-5995
Project: HBase
Issue Type: Sub-task
Components: test
Reporter: stack
Assignee: Enis Soztutar
Priority: Blocker
Fix For: 0.98.0, 0.95.1
Attachments: hbase-5995_v1.patch, hbase-5995_v2.patch,
hbase-5995_v3.patch
HBASE-5984 disabled this flakey test (See the issue for more). This issue is
about getting it enabled again. Made a blocker on 0.96.0 so it gets
attention.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[
https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13656575#comment-13656575
]
Sergey Shelukhin commented on HBASE-5995:
-
{code}
-closeBarrier.endOp();
+if (!closed) {
+ closeBarrier.endOp();
+}
{code}
The start code is:
{code}
boolean isClosed = closed;
if (isClosed || !closeBarrier.beginOp()) {
LOG.debug(HLog + (isClosed ? closed : closing) + . Skipping
rolling of writer);
return regionsToFlush;
}
{code}
End should not be called only if isClosed || !closeBarrier.beginOp() is
false. isClosed needs to be checked lest closed changed, and whether we could
start the op.
In fact maybe it's better to move that if before try? (and keep
logRollRunning in)
{code}
+ try {
+sync();
+ } catch (IOException ioe) {
+if (ioe.getMessage().contains(DFSOutputStream is closed)) {
+ //do not throw this here, sync() failed we will just close the
writer
+}
+ }
{code}
This if is pointless... should it throw in other cases? Also comment could be
made more descriptive :)
Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
Key: HBASE-5995
URL: https://issues.apache.org/jira/browse/HBASE-5995
Project: HBase
Issue Type: Sub-task
Components: test
Reporter: stack
Assignee: Enis Soztutar
Priority: Blocker
Fix For: 0.98.0, 0.95.1
Attachments: hbase-5995_v1.patch, hbase-5995_v2.patch
HBASE-5984 disabled this flakey test (See the issue for more). This issue is
about getting it enabled again. Made a blocker on 0.96.0 so it gets
attention.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13656639#comment-13656639 ] Enis Soztutar commented on HBASE-5995: -- Thanks Sergey for taking a look. bq. End should not be called only if isClosed || !closeBarrier.beginOp() is false. isClosed needs to be checked lest closed changed Right. Closed is not changed once it is set to true, but it might change between false - true. bq. In fact maybe it's better to move that if before try? (and keep logRollRunning in) Then we have to replicate the log and return statements. This looked cleaner. bq. This if is pointless... should it throw in other cases? yes, it should definitely throw the exception in else. Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Sub-task Components: test Reporter: stack Assignee: Enis Soztutar Priority: Blocker Fix For: 0.98.0, 0.95.1 Attachments: hbase-5995_v1.patch, hbase-5995_v2.patch HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[
https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655090#comment-13655090
]
Hadoop QA commented on HBASE-5995:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12582735/hbase-5995_v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5633//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5633//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5633//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5633//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5633//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5633//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5633//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5633//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5633//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5633//console
This message is automatically generated.
Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
Key: HBASE-5995
URL: https://issues.apache.org/jira/browse/HBASE-5995
Project: HBase
Issue Type: Sub-task
Components: test
Reporter: stack
Assignee: Enis Soztutar
Priority: Blocker
Fix For: 0.98.0, 0.95.1
Attachments: hbase-5995_v1.patch, hbase-5995_v2.patch
HBASE-5984 disabled this flakey test (See the issue for more). This issue is
about getting it enabled again. Made a blocker on 0.96.0 so it gets
attention.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[
https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13650594#comment-13650594
]
Hadoop QA commented on HBASE-5995:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12582007/hbase-5995_v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5572//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5572//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5572//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5572//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5572//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5572//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5572//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5572//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5572//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5572//console
This message is automatically generated.
Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
Key: HBASE-5995
URL: https://issues.apache.org/jira/browse/HBASE-5995
Project: HBase
Issue Type: Sub-task
Components: test
Reporter: stack
Assignee: Enis Soztutar
Priority: Blocker
Fix For: 0.98.0, 0.95.1
Attachments: hbase-5995_v1.patch
HBASE-5984 disabled this flakey test (See the issue for more). This issue is
about getting it enabled again. Made a blocker on 0.96.0 so it gets
attention.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[
https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13650300#comment-13650300
]
Ted Yu commented on HBASE-5995:
---
Under hadoop 1.0, testLogRollOnPipelineRestart took more than two minutes on
MacBook:
{code}
Running org.apache.hadoop.hbase.regionserver.wal.TestLogRolling
2013-05-06 17:25:33.239 java[26563:1203] Unable to load realm info from
SCDynamicStore
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 159.722 sec
{code}
Can this test be separated into its own ?
Good job.
Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
Key: HBASE-5995
URL: https://issues.apache.org/jira/browse/HBASE-5995
Project: HBase
Issue Type: Sub-task
Components: test
Reporter: stack
Assignee: Enis Soztutar
Priority: Blocker
Fix For: 0.98.0, 0.95.1
Attachments: hbase-5995_v1.patch
HBASE-5984 disabled this flakey test (See the issue for more). This issue is
about getting it enabled again. Made a blocker on 0.96.0 so it gets
attention.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13650487#comment-13650487 ] stack commented on HBASE-5995: -- OK. Makes sense. Test always passes even though our recoverLease is currently kinda broke w/ its 4 second wait (my guess is the dn's in the test have much long socket timeouts than this? We don't seem to change the default looking at head of the test). -1 on moving to its own test. Why? (Or why would having test standalone make it run faster?) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Sub-task Components: test Reporter: stack Assignee: Enis Soztutar Priority: Blocker Fix For: 0.98.0, 0.95.1 Attachments: hbase-5995_v1.patch HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13646390#comment-13646390 ] Enis Soztutar commented on HBASE-5995: -- This still fails with 2.0.4-alpha. It seems that all the replicas are in state RWR, and we cannot get the length of the block while the replicas are waiting to be recovered. Will inspect more and share the results. Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.95.2 Reporter: stack Assignee: Enis Soztutar Priority: Blocker Fix For: 0.95.1 HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13633514#comment-13633514 ] Enis Soztutar commented on HBASE-5995: -- Assigning this to myself to understand what is going on. Will update with results. Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.95.2 Reporter: stack Assignee: Enis Soztutar Priority: Blocker Fix For: 0.95.1 HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629421#comment-13629421 ] Sergey Shelukhin commented on HBASE-5995: - This appears to be stuck. Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.95.2 Reporter: stack Assignee: Todd Lipcon Priority: Blocker Fix For: 0.95.1 HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629426#comment-13629426 ] stack commented on HBASE-5995: -- [~sershe] A bunch has changed since what w/ fs op retries and the like. I have not tried the test lately. I would do that first. There is probably something to hdfs-2288 too... Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.95.2 Reporter: stack Assignee: Todd Lipcon Priority: Blocker Fix For: 0.95.1 HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13499236#comment-13499236 ] stack commented on HBASE-5995: -- I tried the test w/ hadoop 2.0.2-alpha and it fails same way. Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.96.0 Reporter: stack Assignee: Todd Lipcon Priority: Blocker Fix For: 0.96.0 HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13499250#comment-13499250 ] Todd Lipcon commented on HBASE-5995: I'm remembering now that this was due to HDFS-2288, which got closed as invalid. But, I still think HDFS-2288 is valid, so I will do my best to revive it and convince other HDFS developers of that :) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.96.0 Reporter: stack Assignee: Todd Lipcon Priority: Blocker Fix For: 0.96.0 HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[
https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13470752#comment-13470752
]
Ted Yu commented on HBASE-5995:
---
When I ran the test against hadoop 2.0, it failed with:
{code}
testLogRollOnPipelineRestart(org.apache.hadoop.hbase.regionserver.wal.TestLogRolling)
Time elapsed: 0.243 sec ERROR!
java.io.IOException: Cannot obtain block length for
LocatedBlock{BP-1150895311-10.249.196.101-1349476630606:blk_7782056094701760427_1026;
getBlockSize()=1472; corrupt=false; offset=0; locs=[127.0.0.1:44729,
127.0.0.1:38785]}
at
org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:232)
at
org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:177)
at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:119)
at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:112)
at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:966)
at
org.apache.hadoop.hdfs.DistributedFileSystem.open(DistributedFileSystem.java:212)
at
org.apache.hadoop.hdfs.DistributedFileSystem.open(DistributedFileSystem.java:75)
at org.apache.hadoop.io.SequenceFile$Reader.openFile(SequenceFile.java:1768)
at
org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader$WALReader.openFile(SequenceFileLogReader.java:63)
at org.apache.hadoop.io.SequenceFile$Reader.init(SequenceFile.java:1688)
at org.apache.hadoop.io.SequenceFile$Reader.init(SequenceFile.java:1709)
at
org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader$WALReader.init(SequenceFileLogReader.java:56)
at
org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.init(SequenceFileLogReader.java:176)
at
org.apache.hadoop.hbase.regionserver.wal.HLogFactory.createReader(HLogFactory.java:82)
at
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.testLogRollOnPipelineRestart(TestLogRolling.java:501)
{code}
Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
Key: HBASE-5995
URL: https://issues.apache.org/jira/browse/HBASE-5995
Project: HBase
Issue Type: Task
Components: test
Affects Versions: 0.96.0
Reporter: stack
Priority: Blocker
Fix For: 0.96.0
HBASE-5984 disabled this flakey test (See the issue for more). This issue is
about getting it enabled again. Made a blocker on 0.96.0 so it gets
attention.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13470872#comment-13470872 ] Andrew Purtell commented on HBASE-5995: --- This fails consistently against Hadoop 2. Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.96.0 Reporter: stack Priority: Blocker Fix For: 0.96.0 HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
[ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13274759#comment-13274759 ] Andrew Purtell commented on HBASE-5995: --- +1 for blocker status, thanks Stack. HBase should be able to survive a rolling DN restart and we need to test for that. Fix and reenable TestLogRolling.testLogRollOnPipelineRestart Key: HBASE-5995 URL: https://issues.apache.org/jira/browse/HBASE-5995 Project: HBase Issue Type: Task Components: test Affects Versions: 0.96.0 Reporter: stack Priority: Blocker Fix For: 0.96.0 HBASE-5984 disabled this flakey test (See the issue for more). This issue is about getting it enabled again. Made a blocker on 0.96.0 so it gets attention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
