[jira] [Commented] (HBASE-10395) endTime won't be set in VerifyReplication if startTime is not set

2014-01-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878418#comment-13878418
 ] 

Hadoop QA commented on HBASE-10395:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12624298/HBASE-10395-0.94-v1.patch
  against trunk revision .
  ATTACHMENT ID: 12624298

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8493//console

This message is automatically generated.

 endTime won't be set in VerifyReplication if startTime is not set
 -

 Key: HBASE-10395
 URL: https://issues.apache.org/jira/browse/HBASE-10395
 Project: HBase
  Issue Type: Improvement
  Components: mapreduce, Replication
Affects Versions: 0.94.16
Reporter: cuijianwei
Assignee: cuijianwei
Priority: Minor
 Attachments: HBASE-10395-0.94-v1.patch


 In VerifyReplication, we may set startTime and endTime to restrict the data 
 to verfiy. However, the endTime won't be set in the program if we only pass 
 endTime without startTime in command line argument. The reason is the 
 following code:
 {code}
 if (startTime != 0) {
   scan.setTimeRange(startTime,
   endTime == 0 ? HConstants.LATEST_TIMESTAMP : endTime);
 }
 {code}
 The code will ignore endTime setting when not passing startTime in command 
 line argument. Another place needs to improvement is the help message as 
 follows:
 {code}
 System.err.println( stoprow  end of the row);
 {code}
 However, the program actually use endrow to parse the arguments:
 {code}
 final String endTimeArgKey = --endtime=;
 if (cmd.startsWith(endTimeArgKey)) {
   endTime = Long.parseLong(cmd.substring(endTimeArgKey.length()));
   continue;
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10395) endTime won't be set in VerifyReplication if startTime is not set

2014-01-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878527#comment-13878527
 ] 

Hadoop QA commented on HBASE-10395:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12624315/HBASE-10395-trunk-v3.patch
  against trunk revision .
  ATTACHMENT ID: 12624315

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

{color:green}+1 hadoop1.1{color}.  The patch compiles against the hadoop 
1.1 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 findbugs{color}.  The patch appears to introduce 2 new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

{color:red}-1 site{color}.  The patch appears to cause mvn site goal to 
fail.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

 {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s):   
at 
org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface.testHBase3583(TestRegionObserverInterface.java:244)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8494//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8494//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8494//console

This message is automatically generated.

 endTime won't be set in VerifyReplication if startTime is not set
 -

 Key: HBASE-10395
 URL: https://issues.apache.org/jira/browse/HBASE-10395
 Project: HBase
  Issue Type: Improvement
  Components: mapreduce, Replication
Affects Versions: 0.94.16
Reporter: cuijianwei
Assignee: cuijianwei
Priority: Minor
 Attachments: HBASE-10395-0.94-v1.patch, HBASE-10395-0.94-v2.patch, 
 HBASE-10395-0.94-v3.patch, HBASE-10395-trunk-v1.patch, 
 HBASE-10395-trunk-v2.patch, HBASE-10395-trunk-v3.patch


 In VerifyReplication, we may set startTime and endTime to restrict the data 
 to verfiy. However, the endTime won't be set in the program if we only pass 
 endTime without startTime in command line argument. The reason is the 
 following code:
 {code}
 if (startTime != 0) {
   scan.setTimeRange(startTime,
   endTime == 0 ? HConstants.LATEST_TIMESTAMP : endTime);
 }
 {code}
 The code will ignore endTime setting when not passing startTime in command 
 line argument. Another place needs to improvement is the help message as 
 follows:
 {code}
 System.err.println( stoprow  end of the row);
 {code}
 However, the program actually use endrow to parse the arguments:
 {code}
 final String endTimeArgKey = --endtime=;
 if (cmd.startsWith(endTimeArgKey)) {
   

[jira] [Commented] (HBASE-10395) endTime won't be set in VerifyReplication if startTime is not set

2014-01-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878525#comment-13878525
 ] 

Hadoop QA commented on HBASE-10395:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12624315/HBASE-10395-trunk-v3.patch
  against trunk revision .
  ATTACHMENT ID: 12624315

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

{color:green}+1 hadoop1.1{color}.  The patch compiles against the hadoop 
1.1 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 findbugs{color}.  The patch appears to introduce 2 new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

{color:red}-1 site{color}.  The patch appears to cause mvn site goal to 
fail.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8495//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8495//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8495//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8495//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8495//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8495//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8495//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8495//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8495//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8495//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8495//console

This message is automatically generated.

 endTime won't be set in VerifyReplication if startTime is not set
 -

 Key: HBASE-10395
 URL: https://issues.apache.org/jira/browse/HBASE-10395
 Project: HBase
  Issue Type: Improvement
  Components: mapreduce, Replication
Affects Versions: 0.94.16
Reporter: cuijianwei
Assignee: cuijianwei
Priority: Minor
 Attachments: HBASE-10395-0.94-v1.patch, HBASE-10395-0.94-v2.patch, 
 HBASE-10395-0.94-v3.patch, HBASE-10395-trunk-v1.patch, 
 HBASE-10395-trunk-v2.patch, HBASE-10395-trunk-v3.patch


 In VerifyReplication, we may set startTime and endTime to restrict the data 
 to verfiy. However, the endTime won't be set in the program if we only pass 
 endTime without startTime in command line argument. The reason is the 
 following code:
 {code}
 if (startTime != 0) {
   scan.setTimeRange(startTime,
   endTime == 0 ? HConstants.LATEST_TIMESTAMP : endTime);
 }
 {code}
 The code will ignore endTime setting when not passing startTime in command 
 line argument. Another place needs to improvement is the help message as 
 follows:
 {code}
 System.err.println( stoprow  end of the row);
 {code}
 However, the program actually use endrow to parse the arguments:
 {code}
 final String endTimeArgKey = --endtime=;
 if (cmd.startsWith(endTimeArgKey)) {
   endTime = Long.parseLong(cmd.substring(endTimeArgKey.length()));
   continue;
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10395) endTime won't be set in VerifyReplication if startTime is not set

2014-01-22 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878862#comment-13878862
 ] 

Ted Yu commented on HBASE-10395:


+1

[~apurtell]:
Do you want this in 0.98 ?

 endTime won't be set in VerifyReplication if startTime is not set
 -

 Key: HBASE-10395
 URL: https://issues.apache.org/jira/browse/HBASE-10395
 Project: HBase
  Issue Type: Improvement
  Components: mapreduce, Replication
Affects Versions: 0.94.16
Reporter: cuijianwei
Assignee: cuijianwei
Priority: Minor
 Attachments: HBASE-10395-0.94-v1.patch, HBASE-10395-0.94-v2.patch, 
 HBASE-10395-0.94-v3.patch, HBASE-10395-trunk-v1.patch, 
 HBASE-10395-trunk-v2.patch, HBASE-10395-trunk-v3.patch


 In VerifyReplication, we may set startTime and endTime to restrict the data 
 to verfiy. However, the endTime won't be set in the program if we only pass 
 endTime without startTime in command line argument. The reason is the 
 following code:
 {code}
 if (startTime != 0) {
   scan.setTimeRange(startTime,
   endTime == 0 ? HConstants.LATEST_TIMESTAMP : endTime);
 }
 {code}
 The code will ignore endTime setting when not passing startTime in command 
 line argument. Another place needs to improvement is the help message as 
 follows:
 {code}
 System.err.println( stoprow  end of the row);
 {code}
 However, the program actually use endrow to parse the arguments:
 {code}
 final String endTimeArgKey = --endtime=;
 if (cmd.startsWith(endTimeArgKey)) {
   endTime = Long.parseLong(cmd.substring(endTimeArgKey.length()));
   continue;
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10395) endTime won't be set in VerifyReplication if startTime is not set

2014-01-22 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878864#comment-13878864
 ] 

Andrew Purtell commented on HBASE-10395:


+1

 endTime won't be set in VerifyReplication if startTime is not set
 -

 Key: HBASE-10395
 URL: https://issues.apache.org/jira/browse/HBASE-10395
 Project: HBase
  Issue Type: Improvement
  Components: mapreduce, Replication
Affects Versions: 0.94.16
Reporter: cuijianwei
Assignee: cuijianwei
Priority: Minor
 Attachments: HBASE-10395-0.94-v1.patch, HBASE-10395-0.94-v2.patch, 
 HBASE-10395-0.94-v3.patch, HBASE-10395-trunk-v1.patch, 
 HBASE-10395-trunk-v2.patch, HBASE-10395-trunk-v3.patch


 In VerifyReplication, we may set startTime and endTime to restrict the data 
 to verfiy. However, the endTime won't be set in the program if we only pass 
 endTime without startTime in command line argument. The reason is the 
 following code:
 {code}
 if (startTime != 0) {
   scan.setTimeRange(startTime,
   endTime == 0 ? HConstants.LATEST_TIMESTAMP : endTime);
 }
 {code}
 The code will ignore endTime setting when not passing startTime in command 
 line argument. Another place needs to improvement is the help message as 
 follows:
 {code}
 System.err.println( stoprow  end of the row);
 {code}
 However, the program actually use endrow to parse the arguments:
 {code}
 final String endTimeArgKey = --endtime=;
 if (cmd.startsWith(endTimeArgKey)) {
   endTime = Long.parseLong(cmd.substring(endTimeArgKey.length()));
   continue;
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10395) endTime won't be set in VerifyReplication if startTime is not set

2014-01-22 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879100#comment-13879100
 ] 

Hudson commented on HBASE-10395:


SUCCESS: Integrated in HBase-0.98 #103 (See 
[https://builds.apache.org/job/HBase-0.98/103/])
HBASE-10395 endTime won't be set in VerifyReplication if startTime is not set 
(Jianwei Cui) (Tedyu: rev 1560433)
* 
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java


 endTime won't be set in VerifyReplication if startTime is not set
 -

 Key: HBASE-10395
 URL: https://issues.apache.org/jira/browse/HBASE-10395
 Project: HBase
  Issue Type: Improvement
  Components: mapreduce, Replication
Affects Versions: 0.94.16
Reporter: cuijianwei
Assignee: cuijianwei
Priority: Minor
 Fix For: 0.98.0, 0.99.0

 Attachments: HBASE-10395-0.94-v1.patch, HBASE-10395-0.94-v2.patch, 
 HBASE-10395-0.94-v3.patch, HBASE-10395-trunk-v1.patch, 
 HBASE-10395-trunk-v2.patch, HBASE-10395-trunk-v3.patch


 In VerifyReplication, we may set startTime and endTime to restrict the data 
 to verfiy. However, the endTime won't be set in the program if we only pass 
 endTime without startTime in command line argument. The reason is the 
 following code:
 {code}
 if (startTime != 0) {
   scan.setTimeRange(startTime,
   endTime == 0 ? HConstants.LATEST_TIMESTAMP : endTime);
 }
 {code}
 The code will ignore endTime setting when not passing startTime in command 
 line argument. Another place needs to improvement is the help message as 
 follows:
 {code}
 System.err.println( stoprow  end of the row);
 {code}
 However, the program actually use endrow to parse the arguments:
 {code}
 final String endTimeArgKey = --endtime=;
 if (cmd.startsWith(endTimeArgKey)) {
   endTime = Long.parseLong(cmd.substring(endTimeArgKey.length()));
   continue;
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10395) endTime won't be set in VerifyReplication if startTime is not set

2014-01-22 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879147#comment-13879147
 ] 

Hudson commented on HBASE-10395:


SUCCESS: Integrated in HBase-TRUNK #4849 (See 
[https://builds.apache.org/job/HBase-TRUNK/4849/])
HBASE-10395 endTime won't be set in VerifyReplication if startTime is not set 
(Jianwei Cui) (Tedyu: rev 1560434)
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java


 endTime won't be set in VerifyReplication if startTime is not set
 -

 Key: HBASE-10395
 URL: https://issues.apache.org/jira/browse/HBASE-10395
 Project: HBase
  Issue Type: Improvement
  Components: mapreduce, Replication
Affects Versions: 0.94.16
Reporter: cuijianwei
Assignee: cuijianwei
Priority: Minor
 Fix For: 0.98.0, 0.99.0

 Attachments: HBASE-10395-0.94-v1.patch, HBASE-10395-0.94-v2.patch, 
 HBASE-10395-0.94-v3.patch, HBASE-10395-trunk-v1.patch, 
 HBASE-10395-trunk-v2.patch, HBASE-10395-trunk-v3.patch


 In VerifyReplication, we may set startTime and endTime to restrict the data 
 to verfiy. However, the endTime won't be set in the program if we only pass 
 endTime without startTime in command line argument. The reason is the 
 following code:
 {code}
 if (startTime != 0) {
   scan.setTimeRange(startTime,
   endTime == 0 ? HConstants.LATEST_TIMESTAMP : endTime);
 }
 {code}
 The code will ignore endTime setting when not passing startTime in command 
 line argument. Another place needs to improvement is the help message as 
 follows:
 {code}
 System.err.println( stoprow  end of the row);
 {code}
 However, the program actually use endrow to parse the arguments:
 {code}
 final String endTimeArgKey = --endtime=;
 if (cmd.startsWith(endTimeArgKey)) {
   endTime = Long.parseLong(cmd.substring(endTimeArgKey.length()));
   continue;
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10395) endTime won't be set in VerifyReplication if startTime is not set

2014-01-22 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879194#comment-13879194
 ] 

Hudson commented on HBASE-10395:


FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #97 (See 
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/97/])
HBASE-10395 endTime won't be set in VerifyReplication if startTime is not set 
(Jianwei Cui) (Tedyu: rev 1560433)
* 
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java


 endTime won't be set in VerifyReplication if startTime is not set
 -

 Key: HBASE-10395
 URL: https://issues.apache.org/jira/browse/HBASE-10395
 Project: HBase
  Issue Type: Improvement
  Components: mapreduce, Replication
Affects Versions: 0.94.16
Reporter: cuijianwei
Assignee: cuijianwei
Priority: Minor
 Fix For: 0.98.0, 0.99.0

 Attachments: HBASE-10395-0.94-v1.patch, HBASE-10395-0.94-v2.patch, 
 HBASE-10395-0.94-v3.patch, HBASE-10395-trunk-v1.patch, 
 HBASE-10395-trunk-v2.patch, HBASE-10395-trunk-v3.patch


 In VerifyReplication, we may set startTime and endTime to restrict the data 
 to verfiy. However, the endTime won't be set in the program if we only pass 
 endTime without startTime in command line argument. The reason is the 
 following code:
 {code}
 if (startTime != 0) {
   scan.setTimeRange(startTime,
   endTime == 0 ? HConstants.LATEST_TIMESTAMP : endTime);
 }
 {code}
 The code will ignore endTime setting when not passing startTime in command 
 line argument. Another place needs to improvement is the help message as 
 follows:
 {code}
 System.err.println( stoprow  end of the row);
 {code}
 However, the program actually use endrow to parse the arguments:
 {code}
 final String endTimeArgKey = --endtime=;
 if (cmd.startsWith(endTimeArgKey)) {
   endTime = Long.parseLong(cmd.substring(endTimeArgKey.length()));
   continue;
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)