[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110224#comment-15110224
]
deepankar commented on HBASE-15101:
---
It is on on branch-1 only. ( But I have ported other patches also
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110198#comment-15110198
]
ramkrishna.s.vasudevan commented on HBASE-15101:
[~dvdreddy]
I have a question - the
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108406#comment-15108406
]
Hudson commented on HBASE-15101:
FAILURE: Integrated in HBase-Trunk_matrix #645 (See
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108295#comment-15108295
]
Hadoop QA commented on HBASE-15101:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106464#comment-15106464
]
ramkrishna.s.vasudevan commented on HBASE-15101:
Can you try coming up with a test case
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106413#comment-15106413
]
deepankar commented on HBASE-15101:
---
I thought before HBASE-13082, when a compaction starts and before
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108007#comment-15108007
]
ramkrishna.s.vasudevan commented on HBASE-15101:
Will commit this patch to trunk and wait
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108017#comment-15108017
]
deepankar commented on HBASE-15101:
---
Attached patch with close calls also.
> Leaked References to
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108061#comment-15108061
]
ramkrishna.s.vasudevan commented on HBASE-15101:
bq. I think we need some cleanup in
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108063#comment-15108063
]
ramkrishna.s.vasudevan commented on HBASE-15101:
bq.Adding those extra close(false) might
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108080#comment-15108080
]
ramkrishna.s.vasudevan commented on HBASE-15101:
Will discuss and further check with
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108013#comment-15108013
]
deepankar commented on HBASE-15101:
---
Should I add the close calls before return statement as I
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108038#comment-15108038
]
ramkrishna.s.vasudevan commented on HBASE-15101:
bq.. I added it to all places where we
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108036#comment-15108036
]
deepankar commented on HBASE-15101:
---
Adding the close did not help before, but I thought it should
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108082#comment-15108082
]
Anoop Sam John commented on HBASE-15101:
+1
Ya that addition of close(false) will not impact any
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108029#comment-15108029
]
ramkrishna.s.vasudevan commented on HBASE-15101:
Then you will need to add it in 2 more
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108030#comment-15108030
]
ramkrishna.s.vasudevan commented on HBASE-15101:
Once you update the patch then I can
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108073#comment-15108073
]
ramkrishna.s.vasudevan commented on HBASE-15101:
Further clean up of the delayed closed
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108051#comment-15108051
]
Anoop Sam John commented on HBASE-15101:
Adding those extra close(false) might not be really
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106396#comment-15106396
]
ramkrishna.s.vasudevan commented on HBASE-15101:
Patch looks good to me. ya I think the
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101816#comment-15101816
]
Ted Yu commented on HBASE-15101:
{code}
379* Returns a pair of lists of scanners where the first
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102559#comment-15102559
]
deepankar commented on HBASE-15101:
---
Ah sorry, fixed it
> Leaked References to StoreFile.Reader after
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102569#comment-15102569
]
deepankar commented on HBASE-15101:
---
In StoreScanner, can the close(false) not being called lead to
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102926#comment-15102926
]
Hadoop QA commented on HBASE-15101:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102936#comment-15102936
]
Ted Yu commented on HBASE-15101:
bq. not being preceded with close
I think close() should be added for
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101476#comment-15101476
]
Hadoop QA commented on HBASE-15101:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098058#comment-15098058
]
ramkrishna.s.vasudevan commented on HBASE-15101:
Pls give me a couple of days to check
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098566#comment-15098566
]
deepankar commented on HBASE-15101:
---
I havent backported HBASE-15027, will backport it now. With just
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098560#comment-15098560
]
deepankar commented on HBASE-15101:
---
Done.
> Leaked References to StoreFile.Reader after HBASE-13082
>
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098603#comment-15098603
]
deepankar commented on HBASE-15101:
---
Should we also finalize the files when a region is closed (may be
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098213#comment-15098213
]
Anoop Sam John commented on HBASE-15101:
Analysis seems reasonable. Any other places we missed
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098982#comment-15098982
]
Hadoop QA commented on HBASE-15101:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097147#comment-15097147
]
deepankar commented on HBASE-15101:
---
I can add a basic unit test to check whether dummy scanners are
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097133#comment-15097133
]
Ted Yu commented on HBASE-15101:
Is it possible to add a test for this bug ?
> Leaked References to
[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097438#comment-15097438
]
Hadoop QA commented on HBASE-15101:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
35 matches
Mail list logo
