[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171602#comment-17171602
]
Rushabh Shah commented on HBASE-15222:
--
[~eclark] Could you please share the benchmarking tool you
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749760#comment-15749760
]
stack commented on HBASE-15222:
---
[~ghelmling] You fellows running this in prod?
> Use less contended
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749737#comment-15749737
]
stack commented on HBASE-15222:
---
Not sure about risk/downside. It is a big patch. Maybe too risky then
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749628#comment-15749628
]
Sean Busbey commented on HBASE-15222:
-
this would be a backport for HBASE-15222, HBASE-12133, and
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749588#comment-15749588
]
stack commented on HBASE-15222:
---
[~busbey] ok to backport to 1.2?
> Use less contended classes for metrics
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351923#comment-15351923
]
Mikhail Antonov commented on HBASE-15222:
-
AFAIK these were no plans to backport this one. Are
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168198#comment-15168198
]
Hudson commented on HBASE-15222:
FAILURE: Integrated in HBase-Trunk_matrix #738 (See
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168102#comment-15168102
]
Hudson commented on HBASE-15222:
SUCCESS: Integrated in HBase-1.3-IT #518 (See
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168084#comment-15168084
]
Sean Busbey commented on HBASE-15222:
-
{quote}
Sean Busbey Any changes to a module are not being
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168048#comment-15168048
]
Elliott Clark commented on HBASE-15222:
---
[~busbey] Any changes to a module are not being picked up
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167936#comment-15167936
]
Ted Yu commented on HBASE-15222:
The following test still fails:
{code}
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167887#comment-15167887
]
Sean Busbey commented on HBASE-15222:
-
{quote}
Sean Busbey The metrics rpc tests passing on the
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167880#comment-15167880
]
Hudson commented on HBASE-15222:
FAILURE: Integrated in HBase-1.3 #572 (See
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167613#comment-15167613
]
Mikhail Antonov commented on HBASE-15222:
-
Suspected HBASE-15306 may also suffer from it since I
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167608#comment-15167608
]
Elliott Clark commented on HBASE-15222:
---
[~busbey] The metrics rpc tests passing on the pre-runs
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167449#comment-15167449
]
Elliott Clark commented on HBASE-15222:
---
The second one will succeed. Counts are always kept.
>
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166870#comment-15166870
]
wangdawei commented on HBASE-15222:
---
你是中国人吗?不好意思，英语不好，想请教关于hbase的两个问题：
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166829#comment-15166829
]
Duo Zhang commented on HBASE-15222:
---
For {{TestRpcMetrics}}, first we need to add null check for two
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166747#comment-15166747
]
Duo Zhang commented on HBASE-15222:
---
Seems this causes several tests fail?
See
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166693#comment-15166693
]
Hudson commented on HBASE-15222:
FAILURE: Integrated in HBase-Trunk_matrix #736 (See
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166675#comment-15166675
]
Hudson commented on HBASE-15222:
SUCCESS: Integrated in HBase-1.3-IT #515 (See
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166573#comment-15166573
]
Hudson commented on HBASE-15222:
FAILURE: Integrated in HBase-1.3 #569 (See
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163862#comment-15163862
]
Mikhail Antonov commented on HBASE-15222:
-
[~eclark] Last version on reviews board looks good to
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163343#comment-15163343
]
Elliott Clark commented on HBASE-15222:
---
bq. I'll start a Yetus release vote on Friday and on
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159823#comment-15159823
]
Sean Busbey commented on HBASE-15222:
-
Alternatively, we could waste a bunch of energy on getting a
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159819#comment-15159819
]
Sean Busbey commented on HBASE-15222:
-
The problem is the burden that puts on the Yetus community. As
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159798#comment-15159798
]
Elliott Clark commented on HBASE-15222:
---
I see no problem with using a non-release build script.
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159790#comment-15159790
]
Hadoop QA commented on HBASE-15222:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159549#comment-15159549
]
Sean Busbey commented on HBASE-15222:
-
No. we should not be relying on non-release versions of ASF
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159528#comment-15159528
]
Mikhail Antonov commented on HBASE-15222:
-
Can we make this option default to on for HBase
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159511#comment-15159511
]
Sean Busbey commented on HBASE-15222:
-
The build error for module ordering is YETUS-280. you can
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158274#comment-15158274
]
Hadoop QA commented on HBASE-15222:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158008#comment-15158008
]
Hadoop QA commented on HBASE-15222:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157996#comment-15157996
]
Elliott Clark commented on HBASE-15222:
---
Even on a more beefy server with 32 cores the trend seems
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157987#comment-15157987
]
Elliott Clark commented on HBASE-15222:
---
Yeah, fastLong is continually much faster than Yammer and
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157561#comment-15157561
]
Hadoop QA commented on HBASE-15222:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157540#comment-15157540
]
Hadoop QA commented on HBASE-15222:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157383#comment-15157383
]
stack commented on HBASE-15222:
---
That testMutableTimeHistogram looks good?
> Use less contended classes
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155182#comment-15155182
]
Elliott Clark commented on HBASE-15222:
---
I think I have a solution that's just as fast as possible,
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155181#comment-15155181
]
Elliott Clark commented on HBASE-15222:
---
Almost every histogram in HBase uses them.
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155076#comment-15155076
]
stack commented on HBASE-15222:
---
Where are they used? MutableRangeHistogram?
> Use less contended classes
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154903#comment-15154903
]
Elliott Clark commented on HBASE-15222:
---
So the MutableRangeHistogram is really slow. It gets us
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154728#comment-15154728
]
Elliott Clark commented on HBASE-15222:
---
New quick run benchmarks for histograms:
{code}
Benchmark
[
https://issues.apache.org/jira/browse/HBASE-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154668#comment-15154668
]
Elliott Clark commented on HBASE-15222:
---
I pushed a new benchmark for Counter/AtomicLong/LongAdder.
44 matches
Mail list logo
