[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222452#comment-15222452
]
Ted Yu commented on HBASE-15411:
Rerun all the backup tests:
{code}
Running
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222413#comment-15222413
]
Ted Yu commented on HBASE-15411:
Thanks for the review, Matteo, Enis and Stephen.
I pushed the modified
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220786#comment-15220786
]
Enis Soztutar commented on HBASE-15411:
---
Sounds good.
> Rewrite backup with Procedure V2
>
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220234#comment-15220234
]
Stephen Yuan Jiang commented on HBASE-15411:
Today, we directly access the {{mpmHost}} from
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220119#comment-15220119
]
Ted Yu commented on HBASE-15411:
Alternatively, we can expose the following method of
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220106#comment-15220106
]
Ted Yu commented on HBASE-15411:
Currently the following member of Master is not exposed:
{code}
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219215#comment-15219215
]
Ted Yu commented on HBASE-15411:
One of the review comments was to drop call to Admin#execProcedure().
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218782#comment-15218782
]
Ted Yu commented on HBASE-15411:
All comments addressed except for more robust failure handling which
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218777#comment-15218777
]
Enis Soztutar commented on HBASE-15411:
---
I'll take a look. Did you address all the review comments
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218716#comment-15218716
]
Ted Yu commented on HBASE-15411:
Planning to check into HBASE-7921 branch tomorrow morning if there is no
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216742#comment-15216742
]
Ted Yu commented on HBASE-15411:
[~mbertozzi] [~enis]:
Any more review comment ?
Thanks
> Rewrite
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214960#comment-15214960
]
Ted Yu commented on HBASE-15411:
TestFullBackup based on patch v27:
{code}
Running
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15213624#comment-15213624
]
Ted Yu commented on HBASE-15411:
[~enis] [~mbertozzi]:
This is how I plan to move the waiting logic to
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212530#comment-15212530
]
Ted Yu commented on HBASE-15411:
Here are the existing Util classes in hbase-client:
{code}
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212026#comment-15212026
]
Ted Yu commented on HBASE-15411:
w.r.t. switching to
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210957#comment-15210957
]
Ted Yu commented on HBASE-15411:
The two enum's in BackupHandler are moved to BackupContext.
> Rewrite
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210520#comment-15210520
]
Ted Yu commented on HBASE-15411:
The following 3 files were removed in patch v24:
{code}
1566 grm
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209640#comment-15209640
]
Ted Yu commented on HBASE-15411:
One comment is for not going through Connection when doing snapshot.
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209603#comment-15209603
]
Ted Yu commented on HBASE-15411:
git is quite smart: when BackupHandler is removed from git, it shows
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209276#comment-15209276
]
Enis Soztutar commented on HBASE-15411:
---
bq. Had some issue uploading to review board: error:
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208767#comment-15208767
]
Hadoop QA commented on HBASE-15411:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205755#comment-15205755
]
Ted Yu commented on HBASE-15411:
Created https://reviews.apache.org/r/45149/
Let's continue review
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205744#comment-15205744
]
Ted Yu commented on HBASE-15411:
bq. This connection and Admin is leaked
In the next patch,
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205738#comment-15205738
]
Ted Yu commented on HBASE-15411:
bq. Lets gather these arguments in a client-public class like
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205671#comment-15205671
]
Enis Soztutar commented on HBASE-15411:
---
To create an RB for reviewing this, I have committed the
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205587#comment-15205587
]
Enis Soztutar commented on HBASE-15411:
---
To those of us following the backup work, this patch comes
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204800#comment-15204800
]
Hadoop QA commented on HBASE-15411:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200137#comment-15200137
]
Vladimir Rodionov commented on HBASE-15411:
---
Moved to Phase 1.
> Rewrite backup with Procedure
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198611#comment-15198611
]
Hadoop QA commented on HBASE-15411:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200166#comment-15200166
]
Hadoop QA commented on HBASE-15411:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200017#comment-15200017
]
Ted Yu commented on HBASE-15411:
I tried extracting common code between FullTableBackupProcedure and
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202452#comment-15202452
]
Hadoop QA commented on HBASE-15411:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191364#comment-15191364
]
Ted Yu commented on HBASE-15411:
In test run of TestFullBackup#testFullBackupSingle, even though snapshot
[
https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188629#comment-15188629
]
Enis Soztutar commented on HBASE-15411:
---
bq. Still encounters the following when running
34 matches
Mail list logo
