[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069717#comment-16069717
]
binlijin commented on HBASE-15756:
--
@stack All have done, i will close this.
> Pluggable RpcServer
>
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069526#comment-16069526
]
stack commented on HBASE-15756:
---
What remains to be done here [~aoxiang]? Thank you. The netty server is
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743889#comment-15743889
]
binlijin commented on HBASE-15756:
--
I add metrics to record how many responses handled by Handlers and
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743880#comment-15743880
]
binlijin commented on HBASE-15756:
--
The current RpcServer is complicated, it support plain
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743861#comment-15743861
]
binlijin commented on HBASE-15756:
--
And i also test the Netty4RpcServer perf on master version, the
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743826#comment-15743826
]
binlijin commented on HBASE-15756:
--
We run NettyRpcServer on production for two months in Alibaba
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725857#comment-15725857
]
stack commented on HBASE-15756:
---
Oops. Repeating myself. From top of this issue: "I'd suggest you not waste
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725854#comment-15725854
]
stack commented on HBASE-15756:
---
Lets NOT make it pluggable. Lets just switch to netty. Can you say how
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724630#comment-15724630
]
binlijin commented on HBASE-15756:
--
Thanks, man!
> Pluggable RpcServer
> ---
>
>
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724616#comment-15724616
]
ramkrishna.s.vasudevan commented on HBASE-15756:
Yes. It can be done with offheap
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724589#comment-15724589
]
binlijin commented on HBASE-15756:
--
We have use NettyRpcServer on production for two months in Alibaba
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411630#comment-15411630
]
ramkrishna.s.vasudevan commented on HBASE-15756:
[~aoxiang]
I think I got that it is for
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411621#comment-15411621
]
binlijin commented on HBASE-15756:
--
@ramkrishna.s.vasudevan, We current test the Netty4RpcServer on
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411614#comment-15411614
]
ramkrishna.s.vasudevan commented on HBASE-15756:
Seeing the code here - the
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410412#comment-15410412
]
stack commented on HBASE-15756:
---
Testing today, the results are less conclusive. I can do about 380k/sec w/
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410355#comment-15410355
]
binlijin commented on HBASE-15756:
--
So the Netty's NioWork doing more work, and the number may be should
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410352#comment-15410352
]
binlijin commented on HBASE-15756:
--
[~stack] i am not use the Netty4RpcServer much, so may be i
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410348#comment-15410348
]
binlijin commented on HBASE-15756:
--
{quote}
"But our current rpcserver, the reader only read request
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409578#comment-15409578
]
stack commented on HBASE-15756:
---
[~aoxiang] Have you seen an issue around server shutdown? I am seeing
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409574#comment-15409574
]
stack commented on HBASE-15756:
---
[~anoop.hbase] It is the two patches [~aoxiang] says above and then I've
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409401#comment-15409401
]
binlijin commented on HBASE-15756:
--
Netty4RpcServer_forperf.patch with PooledByteBufAllocator2.patch,
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409365#comment-15409365
]
Anoop Sam John commented on HBASE-15756:
Sorry I missed all the conversation here. So which is
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408913#comment-15408913
]
binlijin commented on HBASE-15756:
--
Yeah, if i find other things can impact the performance, i will tell
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408909#comment-15408909
]
binlijin commented on HBASE-15756:
--
Yeah, Netty's NioWork read request from client but also write
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408881#comment-15408881
]
stack commented on HBASE-15756:
---
Hmm... I upped the worker thread count from 6 to 12 and the netty rpc
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408816#comment-15408816
]
stack commented on HBASE-15756:
---
Yeah, unpatched 400k and the patched does 300k. I played with worker
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408706#comment-15408706
]
binlijin commented on HBASE-15756:
--
The unpatched version can reach 400k ops/sec? This is huge.
Or your
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407682#comment-15407682
]
binlijin commented on HBASE-15756:
--
Sorry sir for my mistake. PooledByteBufAllocator2.patch should be
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407240#comment-15407240
]
stack commented on HBASE-15756:
---
Thank you for fast turnaround [~aoxiang]. I'm pretty sure I got your patch
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406987#comment-15406987
]
binlijin commented on HBASE-15756:
--
[~stack] What about patch with the PooledByteBufAllocator.patch?
>
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401512#comment-15401512
]
stack commented on HBASE-15756:
---
Thanks [~aoxiang] Will try it in morning boss.
> Pluggable RpcServer
>
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401477#comment-15401477
]
binlijin commented on HBASE-15756:
--
[~stack] Upload Netty4RpcServer_forperf.patch which base on Netty4.
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400929#comment-15400929
]
stack commented on HBASE-15756:
---
I have defaults which is ten columns with value of 128 bytes?
> Pluggable
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400868#comment-15400868
]
binlijin commented on HBASE-15756:
--
Yes.
> Pluggable RpcServer
> ---
>
>
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400867#comment-15400867
]
binlijin commented on HBASE-15756:
--
Looks like i am guessing wrong.
But a region server have only 105k
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400860#comment-15400860
]
binlijin commented on HBASE-15756:
--
I think handlers will have more lock contention when trying to write
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400715#comment-15400715
]
stack commented on HBASE-15756:
---
We'll have to dig. We need to have Netty make use of [~anoop.hbase]'s nice
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400713#comment-15400713
]
stack commented on HBASE-15756:
---
Yes. It is the same as we have except in regard to response being possible
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400712#comment-15400712
]
stack commented on HBASE-15756:
---
Change it to what? I have 24 * 8 * 32 clients running against a single
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400416#comment-15400416
]
binlijin commented on HBASE-15756:
--
you can change the hbase.client.ipc.pool.size to see how the result
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400410#comment-15400410
]
binlijin commented on HBASE-15756:
--
The more client connections, the result will be more different.
>
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400400#comment-15400400
]
binlijin commented on HBASE-15756:
--
The result is much different with my's result, i am curious how you
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400398#comment-15400398
]
binlijin commented on HBASE-15756:
--
Netty's NioWork read request from channel to OffHeap, current we
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400386#comment-15400386
]
binlijin commented on HBASE-15756:
--
First let me try to explain Netty's Thread Model first:
Netty's
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276139#comment-15276139
]
ramkrishna.s.vasudevan commented on HBASE-15756:
Seeing the patch the operations seems to
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275981#comment-15275981
]
Anoop Sam John commented on HBASE-15756:
Sorry for being late here.
I had a go at the new
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273832#comment-15273832
]
binlijin commented on HBASE-15756:
--
@Jurriaan Mous, thanks for you advice, we will change it to Netty4.
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273831#comment-15273831
]
Jurriaan Mous commented on HBASE-15756:
---
I would highly prefer a Netty 4 implementation like the
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273743#comment-15273743
]
binlijin commented on HBASE-15756:
--
I will test it with netty4 this days.
> Pluggable RpcServer
>
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273739#comment-15273739
]
binlijin commented on HBASE-15756:
--
@stack, upload the patch for branch-1, and this patch is a draft for
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273671#comment-15273671
]
Yu Li commented on HBASE-15756:
---
Ok, got it. [~aoxiang] please upload our draft patch for branch-1 so stack
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273615#comment-15273615
]
stack commented on HBASE-15756:
---
Yes. Need to make sure we are good w/ [~ram_krish] and [~anoop.hbase]
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273540#comment-15273540
]
Yu Li commented on HBASE-15756:
---
bq. If you have some questions on the Netty Client which I built earlier I
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273536#comment-15273536
]
Yu Li commented on HBASE-15756:
---
Thanks for chim in [~ghelmling]
bq. What it typically meant was that
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273504#comment-15273504
]
Yu Li commented on HBASE-15756:
---
bq. I was suggesting not bothering w/ pluggable aspect because when
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272823#comment-15272823
]
Gary Helmling commented on HBASE-15756:
---
We had a pluggable RpcServer back when security was first
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272589#comment-15272589
]
stack commented on HBASE-15756:
---
Pluggable for branch-1 could be a good way to go. I was suggesting not
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272196#comment-15272196
]
Jurriaan Mous commented on HBASE-15756:
---
If you have some questions on the Netty Client which I
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272141#comment-15272141
]
Yu Li commented on HBASE-15756:
---
[~aoxiang] is my workmate so allow me to give some supplement here (it
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271889#comment-15271889
]
ramkrishna.s.vasudevan commented on HBASE-15756:
Even the NettyRpcServer will do the read
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271750#comment-15271750
]
binlijin commented on HBASE-15756:
--
Use Netty, we can keep the scheduling Queues, we still have
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271732#comment-15271732
]
binlijin commented on HBASE-15756:
--
So if we can make the RpcServer pluggable, and if we do not want to
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271731#comment-15271731
]
binlijin commented on HBASE-15756:
--
[~andrew.purt...@gmail.com], i have a question with the thrift
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271727#comment-15271727
]
binlijin commented on HBASE-15756:
--
I also test the situation: Readers read ByteBuffer data, and handoff
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271327#comment-15271327
]
stack commented on HBASE-15756:
---
The argument for Netty could be the built-in features it has that we don't
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271325#comment-15271325
]
stack commented on HBASE-15756:
---
I forgot to say, yeah, justify why we should do netty instead of what we
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270753#comment-15270753
]
Andrew Purtell commented on HBASE-15756:
bq. I'd suggest you not waste your time making it
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270241#comment-15270241
]
binlijin commented on HBASE-15756:
--
I only test the read performance.
> Pluggable RpcServer
>
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270209#comment-15270209
]
binlijin commented on HBASE-15756:
--
@stack，i test with some quick implements, and test it with ycsb:
1
[
https://issues.apache.org/jira/browse/HBASE-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270186#comment-15270186
]
stack commented on HBASE-15756:
---
I'd suggest you not waste your time making it pluggable [~aoxiang]. Just
70 matches
Mail list logo
