[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898321#comment-15898321
]
Enis Soztutar commented on HBASE-17680:
---
Remove this:
{code}
- hbase::Configuration conf;
+
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898233#comment-15898233
]
Enis Soztutar commented on HBASE-17680:
---
Thanks Ted for the changes.
- Please remove ALL commented
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898154#comment-15898154
]
Ted Yu commented on HBASE-17680:
"buck test --all" passed for patch v31.
> Run mini cluster through JNI
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895347#comment-15895347
]
Enis Soztutar commented on HBASE-17680:
---
Can you please remove all commented out code. There are
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893716#comment-15893716
]
Ted Yu commented on HBASE-17680:
Ran valgrind again.
libjvm.so still showed up but there was no
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893389#comment-15893389
]
Ted Yu commented on HBASE-17680:
bq. This behavior coming from the existing code
How about addressing
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893355#comment-15893355
]
Ted Yu commented on HBASE-17680:
w.r.t. lint warnings, there are a lot of existing ones.
e.g.
{code}
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893228#comment-15893228
]
Enis Soztutar commented on HBASE-17680:
---
I've checked the v23 patch. You did not address these
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889492#comment-15889492
]
Ted Yu commented on HBASE-17680:
Noticed the following from valgrind output:
{code}
==21686== Invalid
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888972#comment-15888972
]
Ted Yu commented on HBASE-17680:
After installing valgrind, I got (using above valgrind command):
{code}
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888961#comment-15888961
]
Enis Soztutar commented on HBASE-17680:
---
I was able to run the tests successfully.
I checked the
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1515#comment-1515
]
Enis Soztutar commented on HBASE-17680:
---
Nevermind, I think it is due to the {{mvn install}}
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1514#comment-1514
]
Enis Soztutar commented on HBASE-17680:
---
It is failing like this:
{code}
STANDARD ERR
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888783#comment-15888783
]
Ted Yu commented on HBASE-17680:
{code}
PASS<100ms 2 Passed 0 Skipped 0 Failed
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888736#comment-15888736
]
Enis Soztutar commented on HBASE-17680:
---
Are you gonna address the remaining review comments?
The
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886687#comment-15886687
]
Enis Soztutar commented on HBASE-17680:
---
I am also getting a lot of these warnings:
{code}
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886491#comment-15886491
]
Enis Soztutar commented on HBASE-17680:
---
Thanks Ted for the updated patch.
- No commented out code
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886091#comment-15886091
]
Ted Yu commented on HBASE-17680:
Performed "make" under hbase-native-client directory.
The build passed.
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883100#comment-15883100
]
Ted Yu commented on HBASE-17680:
w.r.t. Makefile, on docker the library we link with is under
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883050#comment-15883050
]
Ted Yu commented on HBASE-17680:
Performed "mvn install -DskipTests" on docker (running on Mac):
{code}
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882164#comment-15882164
]
Devaraj Das commented on HBASE-17680:
-
I think for now it's fine to make the whole thing work via
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881865#comment-15881865
]
Ted Yu commented on HBASE-17680:
w.r.t. compiler_flags, on Mac, there is no $JAVA_HOME/include/linux
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881683#comment-15881683
]
Enis Soztutar commented on HBASE-17680:
---
bq. Not sure of why we should create NativeTestingUtility
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881670#comment-15881670
]
Enis Soztutar commented on HBASE-17680:
---
Couple of more comments:
- At least some of the methods
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881652#comment-15881652
]
Ted Yu commented on HBASE-17680:
Not sure of why we should create NativeTestingUtility - it would be
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881646#comment-15881646
]
Enis Soztutar commented on HBASE-17680:
---
Thanks for working on this [~devaraj] and [~ted_yu].
This
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879524#comment-15879524
]
Ted Yu commented on HBASE-17680:
The two tests where shell command is replaced:
{code}
RESULTS FOR
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879481#comment-15879481
]
stack commented on HBASE-17680:
---
We already write a cache of classpath at ./target/cached_classpath.txt
>
[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879430#comment-15879430
]
Ted Yu commented on HBASE-17680:
docker hardcodes CLASSPATH as
29 matches
Mail list logo
