[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090279#comment-16090279 ] Hudson commented on HBASE-18268: FAILURE: Integrated in Jenkins build HBASE-14070.HLC #69 (See

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083304#comment-16083304 ] Hudson commented on HBASE-18268: SUCCESS: Integrated in Jenkins build HBase-1.3-JDK7 #196 (See

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-11 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083279#comment-16083279 ] Chia-Ping Tsai commented on HBASE-18268: TestReplicator pass on my machine..Will keep an eye on

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083244#comment-16083244 ] Hudson commented on HBASE-18268: FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #210 (See

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083182#comment-16083182 ] Hudson commented on HBASE-18268: FAILURE: Integrated in Jenkins build HBase-2.0 #156 (See

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083221#comment-16083221 ] Hudson commented on HBASE-18268: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3358 (See

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083160#comment-16083160 ] Hudson commented on HBASE-18268: FAILURE: Integrated in Jenkins build HBase-1.4 #806 (See

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083095#comment-16083095 ] Hudson commented on HBASE-18268: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK7 #162 (See

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083070#comment-16083070 ] Hudson commented on HBASE-18268: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #158 (See

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082845#comment-16082845 ] Hudson commented on HBASE-18268: SUCCESS: Integrated in Jenkins build HBase-1.2-IT #895 (See

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082818#comment-16082818 ] Hudson commented on HBASE-18268: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #135 (See

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-11 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081774#comment-16081774 ] Chia-Ping Tsai commented on HBASE-18268: [~zghaobac] Thanks for the reviews. Will commit it

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-10 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081693#comment-16081693 ] Guanghao Zhang commented on HBASE-18268: +1. > Eliminate the findbugs warnings for hbase-client

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-04 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073293#comment-16073293 ] Chia-Ping Tsai commented on HBASE-18268: Ping for reviews. [~busbey] > Eliminate the findbugs

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073281#comment-16073281 ] Hadoop QA commented on HBASE-18268: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073206#comment-16073206 ] Hadoop QA commented on HBASE-18268: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-03 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073148#comment-16073148 ] Chia-Ping Tsai commented on HBASE-18268: We don't commit the HBASE-18293 to branch-1.3. Will fix

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073111#comment-16073111 ] Hadoop QA commented on HBASE-18268: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072236#comment-16072236 ] Hadoop QA commented on HBASE-18268: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-07-03 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072176#comment-16072176 ] Chia-Ping Tsai commented on HBASE-18268: Oh...The default jdk for branch-1.2+ may be different

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-30 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070975#comment-16070975 ] Chia-Ping Tsai commented on HBASE-18268: After HBASE-18293, there is no findbugs warnings in

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-28 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067749#comment-16067749 ] Chia-Ping Tsai commented on HBASE-18268: see HBASE-18293 > Eliminate the findbugs warnings for

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-28 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067017#comment-16067017 ] Sean Busbey commented on HBASE-18268: - we support both jdk-7 and jdk-8 on branch-1.2+. We generally

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-27 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065816#comment-16065816 ] Chia-Ping Tsai commented on HBASE-18268: bq. Can we only add the spotbugs dependency when jdk8 is

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-27 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065070#comment-16065070 ] Sean Busbey commented on HBASE-18268: - oh poop. Can we only add the spotbugs dependency when jdk8 is

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-26 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064298#comment-16064298 ] Chia-Ping Tsai commented on HBASE-18268: {noformat} [INFO] Fork Value is true [java]

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064231#comment-16064231 ] Hadoop QA commented on HBASE-18268: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-26 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064190#comment-16064190 ] Guanghao Zhang commented on HBASE-18268: Got it. +1 for v1 patch. Thanks. > Eliminate the

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-26 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064187#comment-16064187 ] Mike Drob commented on HBASE-18268: --- bq. We should have another jira to discuss it. The fix may be

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064185#comment-16064185 ] Hadoop QA commented on HBASE-18268: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-26 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064182#comment-16064182 ] Chia-Ping Tsai commented on HBASE-18268: bq. Why the previous findbug result still show these

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-26 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064175#comment-16064175 ] Guanghao Zhang commented on HBASE-18268: Why the previous findbug result still show these

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-26 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064171#comment-16064171 ] Chia-Ping Tsai commented on HBASE-18268: bq. it breaks the Map API contract in so many ways,

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-26 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064168#comment-16064168 ] Mike Drob commented on HBASE-18268: --- Yes, also {{PoolMap::entrySet}}. Reading this class again, it

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-26 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064159#comment-16064159 ] Chia-Ping Tsai commented on HBASE-18268: bq. Not sure if it's in scope here or not, but some of

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-26 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064148#comment-16064148 ] Mike Drob commented on HBASE-18268: --- Not sure if it's in scope here or not, but some of the other

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-26 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063143#comment-16063143 ] Sean Busbey commented on HBASE-18268: - {code} diff --git

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063128#comment-16063128 ] Hadoop QA commented on HBASE-18268: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-26 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063114#comment-16063114 ] Chia-Ping Tsai commented on HBASE-18268: Indeed, that is a bad bug. I guess the method is never

[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

2017-06-26 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063097#comment-16063097 ] Sean Busbey commented on HBASE-18268: - {code} diff --git