[jira] [Commented] (HBASE-19333) Consider exposing ExportSnapshot#getSnapshotFiles through POJO class
[
https://issues.apache.org/jira/browse/HBASE-19333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267738#comment-16267738
]
Jerry He commented on HBASE-19333:
--
I agree here that it is probably better to have a clean-up tool. We can ask if
the person who asked/responded can contribute the tool.
> Consider exposing ExportSnapshot#getSnapshotFiles through POJO class
>
>
> Key: HBASE-19333
> URL: https://issues.apache.org/jira/browse/HBASE-19333
> Project: HBase
> Issue Type: Improvement
>Reporter: Ted Yu
>
> In the thread,
> http://search-hadoop.com/m/HBase/YGbbUxY9FyU74X?subj=Re+Deleting+and+cleaning+old+snapshots+exported+to+S3
> , Timothy mentioned that he used reflection to get to
> ExportSnapshot#getSnapshotFiles().
> {code}
> private static List> getSnapshotFiles(final
> Configuration conf,
> final FileSystem fs, final Path snapshotDir) throws IOException {
> {code}
> SnapshotFileInfo is protobuf.
> We should consider exposing the API by replacing the protobuf class with POJO
> class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19333) Consider exposing ExportSnapshot#getSnapshotFiles through POJO class
[
https://issues.apache.org/jira/browse/HBASE-19333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263593#comment-16263593
]
Ted Yu commented on HBASE-19333:
bq. Make sure it does not come off as 'instruction' or a 'command'.
I read description again and don't which part constitutes a command.
> Consider exposing ExportSnapshot#getSnapshotFiles through POJO class
>
>
> Key: HBASE-19333
> URL: https://issues.apache.org/jira/browse/HBASE-19333
> Project: HBase
> Issue Type: Improvement
>Reporter: Ted Yu
>
> In the thread,
> http://search-hadoop.com/m/HBase/YGbbUxY9FyU74X?subj=Re+Deleting+and+cleaning+old+snapshots+exported+to+S3
> , Timothy mentioned that he used reflection to get to
> ExportSnapshot#getSnapshotFiles().
> {code}
> private static List> getSnapshotFiles(final
> Configuration conf,
> final FileSystem fs, final Path snapshotDir) throws IOException {
> {code}
> SnapshotFileInfo is protobuf.
> We should consider exposing the API by replacing the protobuf class with POJO
> class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19333) Consider exposing ExportSnapshot#getSnapshotFiles through POJO class
[
https://issues.apache.org/jira/browse/HBASE-19333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263562#comment-16263562
]
stack commented on HBASE-19333:
---
bq. HBASE-15762 Consider hbase-client to be shaded by default in 2.0
Yeah, bad idea there too.
bq. I looked for Tim's handle on JIRA. The first one was from
fellowshipvillage. The second one has different spelling in last name.
You do it on the mailing list out in public so those addressed (or those
watching) understand that a key attributes of our community, ones we'd like to
talk-up, are encouraged participation and inclusion, and that there is no need
for a mediator filing or fixing issues in our project. Be careful too how you
make your suggestion. Make sure it does not come off as 'instruction' or a
'command'.
bq. I just felt using reflection is not something that would be accepted in the
open source version.
If a proper tool, would not need to expose files.
> Consider exposing ExportSnapshot#getSnapshotFiles through POJO class
>
>
> Key: HBASE-19333
> URL: https://issues.apache.org/jira/browse/HBASE-19333
> Project: HBase
> Issue Type: Improvement
>Reporter: Ted Yu
>
> In the thread,
> http://search-hadoop.com/m/HBase/YGbbUxY9FyU74X?subj=Re+Deleting+and+cleaning+old+snapshots+exported+to+S3
> , Timothy mentioned that he used reflection to get to
> ExportSnapshot#getSnapshotFiles().
> {code}
> private static List> getSnapshotFiles(final
> Configuration conf,
> final FileSystem fs, final Path snapshotDir) throws IOException {
> {code}
> SnapshotFileInfo is protobuf.
> We should consider exposing the API by replacing the protobuf class with POJO
> class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19333) Consider exposing ExportSnapshot#getSnapshotFiles through POJO class
[
https://issues.apache.org/jira/browse/HBASE-19333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263549#comment-16263549
]
Ted Yu commented on HBASE-19333:
bq. Why file on behalf of others?
I looked for Tim's handle on JIRA. The first one was from fellowshipvillage.
The second one has different spelling in last name.
bq. Why not encourage them to file their own issues?
I have no problem changing reporter to Tim. Will request the person to log JIRA
in the future. I will also remind people who don't follow this practice.
bq. the problem is a cleaning tool
True. Open sourcing the tool is another matter. I just felt using reflection is
not something that would be accepted in the open source version.
> Consider exposing ExportSnapshot#getSnapshotFiles through POJO class
>
>
> Key: HBASE-19333
> URL: https://issues.apache.org/jira/browse/HBASE-19333
> Project: HBase
> Issue Type: Improvement
>Reporter: Ted Yu
>
> In the thread,
> http://search-hadoop.com/m/HBase/YGbbUxY9FyU74X?subj=Re+Deleting+and+cleaning+old+snapshots+exported+to+S3
> , Timothy mentioned that he used reflection to get to
> ExportSnapshot#getSnapshotFiles().
> {code}
> private static List> getSnapshotFiles(final
> Configuration conf,
> final FileSystem fs, final Path snapshotDir) throws IOException {
> {code}
> SnapshotFileInfo is protobuf.
> We should consider exposing the API by replacing the protobuf class with POJO
> class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19333) Consider exposing ExportSnapshot#getSnapshotFiles through POJO class
[
https://issues.apache.org/jira/browse/HBASE-19333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263543#comment-16263543
]
Ted Yu commented on HBASE-19333:
bq. And whats with the 'Consider'? Why file issue an issue for a
'Consideration'?
I am confused. There have been precedents. e.g.
HBASE-15762 Consider hbase-client to be shaded by default in 2.0
> Consider exposing ExportSnapshot#getSnapshotFiles through POJO class
>
>
> Key: HBASE-19333
> URL: https://issues.apache.org/jira/browse/HBASE-19333
> Project: HBase
> Issue Type: Improvement
>Reporter: Ted Yu
>
> In the thread,
> http://search-hadoop.com/m/HBase/YGbbUxY9FyU74X?subj=Re+Deleting+and+cleaning+old+snapshots+exported+to+S3
> , Timothy mentioned that he used reflection to get to
> ExportSnapshot#getSnapshotFiles().
> {code}
> private static List> getSnapshotFiles(final
> Configuration conf,
> final FileSystem fs, final Path snapshotDir) throws IOException {
> {code}
> SnapshotFileInfo is protobuf.
> We should consider exposing the API by replacing the protobuf class with POJO
> class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19333) Consider exposing ExportSnapshot#getSnapshotFiles through POJO class
[
https://issues.apache.org/jira/browse/HBASE-19333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263488#comment-16263488
]
stack commented on HBASE-19333:
---
Why file on behalf of others? Why not encourage them to file their own issues?
Besides, the problem is a cleaning tool... Not " exposing
ExportSnapshot#getSnapshotFiles through POJO class". And whats with the
'Consider'? Why file issue an issue for a 'Consideration'? Filing issues should
be more than 'Considerations'.
in fact, let me close this as ill-specified.
> Consider exposing ExportSnapshot#getSnapshotFiles through POJO class
>
>
> Key: HBASE-19333
> URL: https://issues.apache.org/jira/browse/HBASE-19333
> Project: HBase
> Issue Type: Improvement
>Reporter: Ted Yu
>
> In the thread,
> http://search-hadoop.com/m/HBase/YGbbUxY9FyU74X?subj=Re+Deleting+and+cleaning+old+snapshots+exported+to+S3
> , Timothy mentioned that he used reflection to get to
> ExportSnapshot#getSnapshotFiles().
> {code}
> private static List> getSnapshotFiles(final
> Configuration conf,
> final FileSystem fs, final Path snapshotDir) throws IOException {
> {code}
> SnapshotFileInfo is protobuf.
> We should consider exposing the API by replacing the protobuf class with POJO
> class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
