[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207031#comment-13207031
]
stack commented on HBASE-5388:
--
I agree w/ Zhihong, that '+if (!(this.internalMap
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207036#comment-13207036
]
Zhihong Yu commented on HBASE-5388:
---
The javadoc involving 'greatest' comes from javadoc
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207051#comment-13207051
]
stack commented on HBASE-5388:
--
bq. The javadoc involving 'greatest' comes from javadoc for
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207101#comment-13207101
]
Hadoop QA commented on HBASE-5388:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207106#comment-13207106
]
Zhihong Yu commented on HBASE-5388:
---
@Lars:
What do you think ?
Tuning
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207226#comment-13207226
]
Zhihong Yu commented on HBASE-5388:
---
The new method, lowerValueByKey(), isn't in
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207257#comment-13207257
]
ronghai.ma commented on HBASE-5388:
---
rename it lower()
Tuning
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207258#comment-13207258
]
Zhihong Yu commented on HBASE-5388:
---
lower() isn't in NavigableMap or TreeMap.
And the
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207264#comment-13207264
]
ronghai.ma commented on HBASE-5388:
---
As the class is called SoftValueSortedMap, how
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207309#comment-13207309
]
Lars Hofhansl commented on HBASE-5388:
--
I had a look. Having SoftValueSortedMap
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207310#comment-13207310
]
Zhihong Yu commented on HBASE-5388:
---
@Lars:
Can you clarify which patch you favor: v2 or
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207325#comment-13207325
]
ronghai.ma commented on HBASE-5388:
---
@Lars,Zhihong Yu
What about a new Class for the
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207355#comment-13207355
]
ronghai.ma commented on HBASE-5388:
---
{code}
if (value.get() == null) {
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207360#comment-13207360
]
Lars Hofhansl commented on HBASE-5388:
--
@rongmai: How's that? This has nothing to do
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207363#comment-13207363
]
Lars Hofhansl commented on HBASE-5388:
--
@Ted: patch crossing :)
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207364#comment-13207364
]
Zhihong Yu commented on HBASE-5388:
---
@Lars:
What do you think of patch v6 ?
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207365#comment-13207365
]
Lars Hofhansl commented on HBASE-5388:
--
+1 on v6
Although I still think that
{code}
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207367#comment-13207367
]
ronghai.ma commented on HBASE-5388:
---
yes, splited region will be deleted in
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207373#comment-13207373
]
ronghai.ma commented on HBASE-5388:
---
Without remove operation,
are synchronized and
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207375#comment-13207375
]
Zhihong Yu commented on HBASE-5388:
---
I prefer keeping the remove() call.
Isn't it nice
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207382#comment-13207382
]
Lars Hofhansl commented on HBASE-5388:
--
@ronghai: Null is returned either way,
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207401#comment-13207401
]
Hadoop QA commented on HBASE-5388:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207409#comment-13207409
]
Zhihong Yu commented on HBASE-5388:
---
TestSplitLogManager passed locally on MacBook with
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207412#comment-13207412
]
ronghai.ma commented on HBASE-5388:
---
@Lars
If we change(put,remove) internalMap, we use
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207413#comment-13207413
]
Zhihong Yu commented on HBASE-5388:
---
@Ronghai:
Do you think patch v6 is good to go ?
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207417#comment-13207417
]
ronghai.ma commented on HBASE-5388:
---
Excellent for this patch.
Make another thread for
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206508#comment-13206508
]
Lars Hofhansl commented on HBASE-5388:
--
Wow, nice find. Should consider back porting
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206543#comment-13206543
]
Zhihong Yu commented on HBASE-5388:
---
@Ronghai:
I haven't seen your patch yet.
According
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206556#comment-13206556
]
ronghai.ma commented on HBASE-5388:
---
I will upload the patch latter, many meetings,take
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206559#comment-13206559
]
Zhihong Yu commented on HBASE-5388:
---
I see.
Should this new method, getLower(), be
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206561#comment-13206561
]
Zhihong Yu commented on HBASE-5388:
---
Please also publish performance numbers before and
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206563#comment-13206563
]
Lars Hofhansl commented on HBASE-5388:
--
NavigableMap has lowerKey and lowerEntry, we
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206572#comment-13206572
]
ronghai.ma commented on HBASE-5388:
---
rename the method SoftValueSortedMap#getLower to
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206573#comment-13206573
]
Lars Hofhansl commented on HBASE-5388:
--
Usually a diff is better: you can use svn
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206579#comment-13206579
]
ronghai.ma commented on HBASE-5388:
---
CPU:IA32
JVM OPTIONS:-server
cached regions:6
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206581#comment-13206581
]
ronghai.ma commented on HBASE-5388:
---
@Lars hofhansl
thank you.
Tuning
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206641#comment-13206641
]
Hadoop QA commented on HBASE-5388:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206653#comment-13206653
]
Zhihong Yu commented on HBASE-5388:
---
@Ronghai:
Since this is an improvement, we should
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1320#comment-1320
]
Hadoop QA commented on HBASE-5388:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206674#comment-13206674
]
Lars Hofhansl commented on HBASE-5388:
--
Not too fond of this part:
{code}
-
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206686#comment-13206686
]
Zhihong Yu commented on HBASE-5388:
---
It wouldn't be an overkill if you have strong
[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206691#comment-13206691
]
ronghai.ma commented on HBASE-5388:
---
@Lars Hofhansl
I prefer to make code short, and let
42 matches
Mail list logo
