[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396401#comment-16396401
]
Vihang Karajgaonkar commented on HIVE-17580:
patch merged to standalone-metastore branch.
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394361#comment-16394361
]
Vihang Karajgaonkar commented on HIVE-17580:
Fixed TestAvroObjectInspectorGenerator. Rest of
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394170#comment-16394170
]
Hive QA commented on HIVE-17580:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393906#comment-16393906
]
Vihang Karajgaonkar commented on HIVE-17580:
Thanks for the review [~alangates] Attached the
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392082#comment-16392082
]
Alan Gates commented on HIVE-17580:
---
+1 for the latest PR. Thank Vihang, this was a lot of work.
>
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392022#comment-16392022
]
Vihang Karajgaonkar commented on HIVE-17580:
I update the PR to include the above proposed
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388946#comment-16388946
]
Vihang Karajgaonkar commented on HIVE-17580:
Thanks [~owen.omalley] for explaining. In that
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388658#comment-16388658
]
Owen O'Malley commented on HIVE-17580:
--
{quote}I don't see a particular logically grouping of classes
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388655#comment-16388655
]
Owen O'Malley commented on HIVE-17580:
--
{quote}The other option suggested of moving ObjectInspector
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387354#comment-16387354
]
Vihang Karajgaonkar commented on HIVE-17580:
Combining the enums is not going to help solve
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386564#comment-16386564
]
Owen O'Malley commented on HIVE-17580:
--
The problem with putting ObjectInspector into storage-api is
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382432#comment-16382432
]
Vihang Karajgaonkar commented on HIVE-17580:
[~owen.omalley] [~alangates] any thoughts on my
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381165#comment-16381165
]
Vihang Karajgaonkar commented on HIVE-17580:
on a side note, took a look at the test failures
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381124#comment-16381124
]
Vihang Karajgaonkar commented on HIVE-17580:
Thanks [~owen.omalley] for taking a look.
bq.
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381021#comment-16381021
]
Hive QA commented on HIVE-17580:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380792#comment-16380792
]
Owen O'Malley commented on HIVE-17580:
--
I'm not happy about ObjectInspector moving into storage-api.
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380769#comment-16380769
]
Hive QA commented on HIVE-17580:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380695#comment-16380695
]
Vihang Karajgaonkar commented on HIVE-17580:
resubmitted patch to trigger precommit. 092 is
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379860#comment-16379860
]
Vihang Karajgaonkar commented on HIVE-17580:
latest patch restores {{Category}} enum back into
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376509#comment-16376509
]
Vihang Karajgaonkar commented on HIVE-17580:
I tried to run TestTablesCreateDropAlterTruncate
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376197#comment-16376197
]
Hive QA commented on HIVE-17580:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376164#comment-16376164
]
Vihang Karajgaonkar commented on HIVE-17580:
added {{mavenTestArgs = -Dtest.groups=""}} to
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375930#comment-16375930
]
Hive QA commented on HIVE-17580:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375907#comment-16375907
]
Vihang Karajgaonkar commented on HIVE-17580:
Most of these failures are because
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375663#comment-16375663
]
Hive QA commented on HIVE-17580:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375360#comment-16375360
]
Vihang Karajgaonkar commented on HIVE-17580:
Posting the pre-commit result here. 294 tests
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374823#comment-16374823
]
Vihang Karajgaonkar commented on HIVE-17580:
pre-commit didn't trigger for some reason.
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373700#comment-16373700
]
Vihang Karajgaonkar commented on HIVE-17580:
Hi [~alangates] the latest patch attached here
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373685#comment-16373685
]
ASF GitHub Bot commented on HIVE-17580:
---
GitHub user vihangk1 opened a pull request:
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335179#comment-16335179
]
Vihang Karajgaonkar commented on HIVE-17580:
Added the fix for the failing tests. Updated the
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334582#comment-16334582
]
Vihang Karajgaonkar commented on HIVE-17580:
Test failures look related. I will take a look.
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334052#comment-16334052
]
Hive QA commented on HIVE-17580:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333955#comment-16333955
]
ASF GitHub Bot commented on HIVE-17580:
---
GitHub user vihangk1 opened a pull request:
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323292#comment-16323292
]
Vihang Karajgaonkar commented on HIVE-17580:
The reason why most of the tests are failing is
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318918#comment-16318918
]
Vihang Karajgaonkar commented on HIVE-17580:
[~alangates] I think its failing because its not
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318831#comment-16318831
]
Alan Gates commented on HIVE-17580:
---
I suspect HiveQA is getting tripped up by 'standalone-metastore'
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318824#comment-16318824
]
Vihang Karajgaonkar commented on HIVE-17580:
HiveQA does not seem to like patches on
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314314#comment-16314314
]
Vihang Karajgaonkar commented on HIVE-17580:
[~alangates] [~owen.omalley] and [~sershe] Can
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314309#comment-16314309
]
ASF GitHub Bot commented on HIVE-17580:
---
GitHub user vihangk1 opened a pull request:
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275877#comment-16275877
]
Vihang Karajgaonkar commented on HIVE-17580:
[~sershe], [~alangates], [~owen.omalley],
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270239#comment-16270239
]
Vihang Karajgaonkar commented on HIVE-17580:
After moving Deserializer, Serializer,
[
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179431#comment-16179431
]
Alan Gates commented on HIVE-17580:
---
I'm +1 on using the SARGs for this, but I think we will have to
42 matches
Mail list logo
