[jira] [Commented] (HIVE-18883) Add findbugs to yetus pre-commit checks

[ https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438207#comment-16438207 ] Peter Vary commented on HIVE-18883: --- [~stakiar]: Something should be amiss here. The {{patchprocess}} 

[jira] [Commented] (HIVE-18883) Add findbugs to yetus pre-commit checks

[ https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437784#comment-16437784 ] Sahil Takiar commented on HIVE-18883: - Ok think I found the issue. This patch isn't working on ptest

[jira] [Commented] (HIVE-18883) Add findbugs to yetus pre-commit checks

[ https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435618#comment-16435618 ] Sahil Takiar commented on HIVE-18883: - Looks like this needs to be deployed manually, on

[jira] [Commented] (HIVE-18883) Add findbugs to yetus pre-commit checks

[ https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423798#comment-16423798 ] Peter Vary commented on HIVE-18883: --- [~stakiar]: The patch contains an extra file

[jira] [Commented] (HIVE-18883) Add findbugs to yetus pre-commit checks

[ https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423243#comment-16423243 ] Sahil Takiar commented on HIVE-18883: - [~pvary] any comments on this? > Add findbugs to yetus

[jira] [Commented] (HIVE-18883) Add findbugs to yetus pre-commit checks

[ https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408670#comment-16408670 ] Sahil Takiar commented on HIVE-18883: - [~szita] any ideas on how I can test this beyond running it

[jira] [Commented] (HIVE-18883) Add findbugs to yetus pre-commit checks

[ https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393427#comment-16393427 ] Sahil Takiar commented on HIVE-18883: - [~pvary] is there a good way to test this on Hive QA? I think

[jira] [Commented] (HIVE-18883) Add findbugs to yetus pre-commit checks

[ https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392509#comment-16392509 ] Hive QA commented on HIVE-18883: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18883) Add findbugs to yetus pre-commit checks

[ https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392478#comment-16392478 ] Hive QA commented on HIVE-18883: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-18883) Add findbugs to yetus pre-commit checks

[ https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391980#comment-16391980 ] Sahil Takiar commented on HIVE-18883: - Hive QA hasn't run yet, but attaching updated patch: *

[jira] [Commented] (HIVE-18883) Add findbugs to yetus pre-commit checks

[ https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391009#comment-16391009 ] Peter Vary commented on HIVE-18883: --- [~stakiar]: Thanks for the patch. One minor comment: * I would

[jira] [Commented] (HIVE-18883) Add findbugs to yetus pre-commit checks

[ https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390680#comment-16390680 ] Sahil Takiar commented on HIVE-18883: - Thanks for the tip [~pvary]! Helped a lot. What do you think of

[jira] [Commented] (HIVE-18883) Add findbugs to yetus pre-commit checks

[ https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389113#comment-16389113 ] Peter Vary commented on HIVE-18883: --- Findbugs binary has to be installed on the ptest server and

[jira] [Commented] (HIVE-18883) Add findbugs to yetus pre-commit checks

[ https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388657#comment-16388657 ] Sahil Takiar commented on HIVE-18883: - [~szita], [~pvary] any tips on how to do this? > Add findbugs