Re: [PR] feat: add row-based immutable data structure [iceberg-cpp]

2025-09-28 Thread via GitHub
wgtmac commented on code in PR #181: URL: https://github.com/apache/iceberg-cpp/pull/181#discussion_r2386873146 ## src/iceberg/row/struct_like.h: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. S

Re: [I] ManifestFileBean is missing keyMetadata; SparkActions can't decrypt Avro [iceberg]

2025-09-28 Thread via GitHub
hemanthboyina commented on issue #14164: URL: https://github.com/apache/iceberg/issues/14164#issuecomment-3345095065 hi @devyn would you be able to attach stack trace of the issue ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [I] feat: Expose Iceberg table statistics in DataFusion interface(s) [iceberg-rust]

2025-09-28 Thread via GitHub
github-actions[bot] closed issue #869: feat: Expose Iceberg table statistics in DataFusion interface(s) URL: https://github.com/apache/iceberg-rust/issues/869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Fix commit idempotence of DynamicIcebergSink [iceberg]

2025-09-28 Thread via GitHub
aiborodin commented on PR #14092: URL: https://github.com/apache/iceberg/pull/14092#issuecomment-3344861698 > IMHO the solution you implemented goes beyond the scope of fixing the issue. I'm open to refactoring the aggregator / committer code, but I think we should add a set of minimal chan

Re: [PR] feat: add UUID representation [iceberg-cpp]

2025-09-28 Thread via GitHub
zhjwpku commented on code in PR #242: URL: https://github.com/apache/iceberg-cpp/pull/242#discussion_r2386013358 ## src/iceberg/util/uuid.cc: ## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] infra: use spark base image for docker [iceberg-python]

2025-09-28 Thread via GitHub
kevinjqliu commented on code in PR #2540: URL: https://github.com/apache/iceberg-python/pull/2540#discussion_r2386232833 ## dev/provision.py: ## @@ -23,35 +22,27 @@ from pyiceberg.schema import Schema from pyiceberg.types import FixedType, NestedField, UUIDType -# The config

Re: [I] Remove Python 3.9 support? [iceberg-python]

2025-09-28 Thread via GitHub
Fokko commented on issue #2534: URL: https://github.com/apache/iceberg-python/issues/2534#issuecomment-3343926295 Sent out an email: https://lists.apache.org/thread/z3dhxx2wc0dhvgq9js5ktbqf4ggsn4z8 -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Flink: flink delta write support dvs [iceberg]

2025-09-28 Thread via GitHub
shangxinli commented on code in PR #14197: URL: https://github.com/apache/iceberg/pull/14197#discussion_r2386030651 ## flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java: ## @@ -110,7 +113,7 @@ public void write(RowData row) throws IOException

Re: [PR] Flink: Preserve row lineage in RewriteDataFiles [iceberg]

2025-09-28 Thread via GitHub
Guosmilesmile commented on PR #14149: URL: https://github.com/apache/iceberg/pull/14149#issuecomment-3343046018 Mark ci fail https://github.com/apache/iceberg/actions/runs/18073439985/job/51426507107?pr=14149 ``` TestFlinkTableSink > testIcebergSinkDifferentDAG() > catalogName=te

Re: [I] Tracking issues of Iceberg Rust 0.7 Release [iceberg-rust]

2025-09-28 Thread via GitHub
kevinjqliu commented on issue #1631: URL: https://github.com/apache/iceberg-rust/issues/1631#issuecomment-3343738306 #1713 is merged, pushed a new tag https://github.com/apache/iceberg-rust/releases/tag/v0.7.0-rc.2 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] feat: add UUID representation [iceberg-cpp]

2025-09-28 Thread via GitHub
zhjwpku commented on code in PR #242: URL: https://github.com/apache/iceberg-cpp/pull/242#discussion_r2386012784 ## src/iceberg/util/uuid.h: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] Data: Add UUID conversion support for InternalRecordWrapper [iceberg]

2025-09-28 Thread via GitHub
shangxinli commented on code in PR #14208: URL: https://github.com/apache/iceberg/pull/14208#discussion_r2385942645 ## data/src/test/java/org/apache/iceberg/data/TestInternalRecordWrapper.java: ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[PR] Data: Add UUID conversion support for InternalRecordWrapper [iceberg]

2025-09-28 Thread via GitHub
xxubai opened a new pull request, #14208: URL: https://github.com/apache/iceberg/pull/14208 In data files, the UUID type is written as a fixed-length 16-byte binary. Therefore, to correctly convert the UUID type when implementing a custom PartitionedFanoutWriter, it is necessary to a

Re: [PR] Encryption integration and test [iceberg]

2025-09-28 Thread via GitHub
ggershinsky commented on PR #13066: URL: https://github.com/apache/iceberg/pull/13066#issuecomment-3343256438 cc @huaxingao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Encryption integration and test [iceberg]

2025-09-28 Thread via GitHub
ggershinsky commented on code in PR #13066: URL: https://github.com/apache/iceberg/pull/13066#discussion_r2385737985 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -97,17 +119,55 @@ protected String tableName() { @Override public

Re: [PR] Flink: backport PR #14063 to add uid-suffix write option to prevent operator UID hash collisions [iceberg]

2025-09-28 Thread via GitHub
pvary merged PR #14193: URL: https://github.com/apache/iceberg/pull/14193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Encryption integration and test [iceberg]

2025-09-28 Thread via GitHub
ggershinsky commented on code in PR #13066: URL: https://github.com/apache/iceberg/pull/13066#discussion_r2385696223 ## spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/sql/TestTableEncryption.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (

[I] Potential Log4j class conflict if using Iceberg AWS bundle jar [iceberg]

2025-09-28 Thread via GitHub
FANNG1 opened a new issue, #14207: URL: https://github.com/apache/iceberg/issues/14207 ### Apache Iceberg version 1.10.0 (latest release) ### Query engine None ### Please describe the bug 🐞 The log4j is packaged in Iceberg AWS bundle jar, this may cause clas

[PR] chore(deps): Bump tempfile from 3.22.0 to 3.23.0 [iceberg-rust]

2025-09-28 Thread via GitHub
dependabot[bot] opened a new pull request, #1717: URL: https://github.com/apache/iceberg-rust/pull/1717 Bumps [tempfile](https://github.com/Stebalien/tempfile) from 3.22.0 to 3.23.0. Changelog Sourced from https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md";>tempfile's

[PR] chore(deps): Bump crate-ci/typos from 1.36.2 to 1.36.3 [iceberg-rust]

2025-09-28 Thread via GitHub
dependabot[bot] opened a new pull request, #1715: URL: https://github.com/apache/iceberg-rust/pull/1715 Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.36.2 to 1.36.3. Release notes Sourced from https://github.com/crate-ci/typos/releases";>crate-ci/typos's release

Re: [PR] Flink: Preserve row lineage in RewriteDataFiles [iceberg]

2025-09-28 Thread via GitHub
Guosmilesmile closed pull request #14149: Flink: Preserve row lineage in RewriteDataFiles URL: https://github.com/apache/iceberg/pull/14149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[I] Add the ability to write sql expression with pyiceberg [iceberg-python]

2025-09-28 Thread via GitHub
ForeverAngry opened a new issue, #2542: URL: https://github.com/apache/iceberg-python/issues/2542 ### Feature Request / Improvement The [DSL](https://github.com/apache/iceberg-python/blob/main/mkdocs/docs/expression-dsl.md) provided by the project today adds an additional overhead fo

Re: [PR] Flink: Preserve row lineage in RewriteDataFiles [iceberg]

2025-09-28 Thread via GitHub
Guosmilesmile commented on code in PR #14149: URL: https://github.com/apache/iceberg/pull/14149#discussion_r2385477314 ## flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/OperatorTestBase.java: ## @@ -122,7 +124,6 @@ void after() throws IOException {

Re: [PR] feat: add UUID representation [iceberg-cpp]

2025-09-28 Thread via GitHub
mapleFU commented on code in PR #242: URL: https://github.com/apache/iceberg-cpp/pull/242#discussion_r2385377572 ## src/iceberg/util/uuid.cc: ## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] Flink: Preserve row lineage in RewriteDataFiles [iceberg]

2025-09-28 Thread via GitHub
pvary commented on code in PR #14149: URL: https://github.com/apache/iceberg/pull/14149#discussion_r2385379059 ## flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/OperatorTestBase.java: ## @@ -122,7 +124,6 @@ void after() throws IOException { }

Re: [PR] Flink: flink delta write support dvs [iceberg]

2025-09-28 Thread via GitHub
pvary commented on code in PR #14197: URL: https://github.com/apache/iceberg/pull/14197#discussion_r2385230944 ## core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java: ## @@ -115,20 +115,32 @@ public WriteResult complete() throws IOException { protected abstract class

Re: [PR] chore: update changelog and dependencies for 0.7.0 release [iceberg-rust]

2025-09-28 Thread via GitHub
liurenjie1024 merged PR #1713: URL: https://github.com/apache/iceberg-rust/pull/1713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] FLINK: clear globalStatisticsState and only keep the state of subtask 0 to avoid duplication [iceberg]

2025-09-28 Thread via GitHub
hydrogenlee commented on PR #14080: URL: https://github.com/apache/iceberg/pull/14080#issuecomment-3342759027 > Another question: any idea how to test this? It would be good to add a test, so we could prevent the issue recurring I originally added the check(see below) in `initializeSt

Re: [PR] feat: add UUID representation [iceberg-cpp]

2025-09-28 Thread via GitHub
wgtmac commented on code in PR #242: URL: https://github.com/apache/iceberg-cpp/pull/242#discussion_r2385258189 ## src/iceberg/util/uuid.h: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] Flink: flink delta write support dvs [iceberg]

2025-09-28 Thread via GitHub
pvary commented on code in PR #14197: URL: https://github.com/apache/iceberg/pull/14197#discussion_r2385251092 ## flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkManifestUtil.java: ## @@ -101,7 +104,8 @@ public static DeltaManifests writeCompletedFiles(

Re: [PR] Flink: Dynamic Sink: Use max write parallelism if none is supplied [iceberg]

2025-09-28 Thread via GitHub
pvary commented on code in PR #14191: URL: https://github.com/apache/iceberg/pull/14191#discussion_r2385215493 ## flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecord.java: ## @@ -39,6 +39,18 @@ public class DynamicRecord { private boolean upsert

Re: [PR] FLINK: clear globalStatisticsState and only keep the state of subtask 0 to avoid duplication [iceberg]

2025-09-28 Thread via GitHub
pvary commented on PR #14080: URL: https://github.com/apache/iceberg/pull/14080#issuecomment-3342606365 @hydrogenlee: We can put a clear state here: https://github.com/apache/iceberg/blob/582d63b52f9e583bc5cb0eb933eb03b32d10aa32/flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink

[PR] build(deps): bump the gomod_updates group with 7 updates [iceberg-go]

2025-09-28 Thread via GitHub
dependabot[bot] opened a new pull request, #582: URL: https://github.com/apache/iceberg-go/pull/582 Bumps the gomod_updates group with 7 updates: | Package | From | To | | --- | --- | --- | | [cloud.google.com/go/storage](https://github.com/googleapis/google-cloud-go) | `1.56.2

[I] How to load a catalog with a specified name. [iceberg-python]

2025-09-28 Thread via GitHub
lihuan92 opened a new issue, #2541: URL: https://github.com/apache/iceberg-python/issues/2541 ### Question I use the following code to load the catalog 'bi_31', but it always ends up loading the 'hive' catalog. Does it only support loading the default catalog? `catalog_config =