[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2020-05-26 Thread GitBox
rdblue commented on a change in pull request #199: URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r430545525 ## File path: orc/src/main/java/org/apache/iceberg/orc/avro/GenericDataOrcWriter.java ## @@ -0,0 +1,526 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2020-05-22 Thread GitBox
rdblue commented on a change in pull request #199: URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r429484194 ## File path: parquet/src/test/java/org/apache/iceberg/parquet/TestParquetMetrics.java ## @@ -57,10 +78,133 @@ public File writeRecords(Schema

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2020-05-22 Thread GitBox
rdblue commented on a change in pull request #199: URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r429456478 ## File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java ## @@ -65,10 +65,28 @@ public String name() { public

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2020-05-22 Thread GitBox
rdblue commented on a change in pull request #199: URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r429456115 ## File path: orc/src/test/java/org/apache/iceberg/orc/TestOrcMetrics.java ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2020-05-22 Thread GitBox
rdblue commented on a change in pull request #199: URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r429455898 ## File path: parquet/src/test/java/org/apache/iceberg/parquet/TestParquetMetrics.java ## @@ -57,10 +78,133 @@ public File writeRecords(Schema

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2020-05-22 Thread GitBox
rdblue commented on a change in pull request #199: URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r429454818 ## File path: orc/src/test/java/org/apache/iceberg/orc/TestOrcMetrics.java ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2020-05-22 Thread GitBox
rdblue commented on a change in pull request #199: URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r429454482 ## File path: orc/src/test/java/org/apache/iceberg/orc/TestOrcMetrics.java ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2020-05-22 Thread GitBox
rdblue commented on a change in pull request #199: URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r429453526 ## File path: orc/src/main/java/org/apache/iceberg/orc/avro/GenericDataOrcWriter.java ## @@ -0,0 +1,526 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2020-05-22 Thread GitBox
rdblue commented on a change in pull request #199: URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r429453135 ## File path: orc/src/main/java/org/apache/iceberg/orc/OrcMetrics.java ## @@ -19,51 +19,211 @@ package org.apache.iceberg.orc; +import

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2020-05-22 Thread GitBox
rdblue commented on a change in pull request #199: URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r429452774 ## File path: orc/src/main/java/org/apache/iceberg/orc/OrcMetrics.java ## @@ -19,51 +19,211 @@ package org.apache.iceberg.orc; +import

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2020-05-22 Thread GitBox
rdblue commented on a change in pull request #199: URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r429451053 ## File path: orc/src/main/java/org/apache/iceberg/orc/OrcMetrics.java ## @@ -19,51 +19,211 @@ package org.apache.iceberg.orc; +import

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2020-05-22 Thread GitBox
rdblue commented on a change in pull request #199: URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r429450738 ## File path: orc/src/main/java/org/apache/iceberg/orc/OrcMetrics.java ## @@ -19,51 +19,211 @@ package org.apache.iceberg.orc; +import

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2020-05-22 Thread GitBox
rdblue commented on a change in pull request #199: URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r429443956 ## File path: orc/src/main/java/org/apache/iceberg/orc/OrcMetrics.java ## @@ -19,51 +19,211 @@ package org.apache.iceberg.orc; +import

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2020-05-22 Thread GitBox
rdblue commented on a change in pull request #199: URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r429443627 ## File path: orc/src/main/java/org/apache/iceberg/orc/OrcMetrics.java ## @@ -19,51 +19,211 @@ package org.apache.iceberg.orc; +import

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2020-05-22 Thread GitBox
rdblue commented on a change in pull request #199: URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r429441352 ## File path: orc/src/main/java/org/apache/iceberg/orc/OrcMetrics.java ## @@ -19,51 +19,211 @@ package org.apache.iceberg.orc; +import

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2020-05-22 Thread GitBox
rdblue commented on a change in pull request #199: URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r429439746 ## File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java ## @@ -65,10 +65,28 @@ public String name() { public

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2020-05-21 Thread GitBox
rdblue commented on a change in pull request #199: URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r428902997 ## File path: gradle/wrapper/gradle-wrapper.properties ## @@ -1,24 +1,6 @@ -# -# Licensed to the Apache Software Foundation (ASF) under one -# or

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2019-06-11 Thread GitBox
rdblue commented on a change in pull request #199: ORC metrics URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r292555999 ## File path: orc/src/main/java/org/apache/iceberg/orc/OrcMetrics.java ## @@ -19,16 +19,32 @@ package org.apache.iceberg.orc;

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics

2019-06-11 Thread GitBox
rdblue commented on a change in pull request #199: ORC metrics URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r292555668 ## File path: orc/src/main/java/org/apache/iceberg/orc/OrcMetrics.java ## @@ -19,16 +19,32 @@ package org.apache.iceberg.orc;

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics and listPartition support

2019-06-07 Thread GitBox
rdblue commented on a change in pull request #199: ORC metrics and listPartition support URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r291774632 ## File path: orc/src/test/java/org/apache/iceberg/orc/OrcMetricsTest.java ## @@ -0,0 +1,135 @@ +/* + *

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics and listPartition support

2019-06-07 Thread GitBox
rdblue commented on a change in pull request #199: ORC metrics and listPartition support URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r291774523 ## File path: orc/src/test/java/org/apache/iceberg/orc/OrcMetricsTest.java ## @@ -0,0 +1,135 @@ +/* + *

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics and listPartition support

2019-06-07 Thread GitBox
rdblue commented on a change in pull request #199: ORC metrics and listPartition support URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r291774284 ## File path: orc/src/main/java/org/apache/iceberg/orc/TypeConversion.java ## @@ -159,21 +154,21 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics and listPartition support

2019-06-07 Thread GitBox
rdblue commented on a change in pull request #199: ORC metrics and listPartition support URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r291773996 ## File path: orc/src/main/java/org/apache/iceberg/orc/OrcMetrics.java ## @@ -0,0 +1,142 @@ +/* + *

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics and listPartition support

2019-06-07 Thread GitBox
rdblue commented on a change in pull request #199: ORC metrics and listPartition support URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r291773906 ## File path: orc/src/main/java/org/apache/iceberg/orc/OrcMetrics.java ## @@ -0,0 +1,142 @@ +/* + *

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics and listPartition support

2019-06-07 Thread GitBox
rdblue commented on a change in pull request #199: ORC metrics and listPartition support URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r291773630 ## File path: orc/src/main/java/org/apache/iceberg/orc/OrcMetrics.java ## @@ -0,0 +1,142 @@ +/* + *

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #199: ORC metrics and listPartition support

2019-06-07 Thread GitBox
rdblue commented on a change in pull request #199: ORC metrics and listPartition support URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r291773469 ## File path: orc/src/main/java/org/apache/iceberg/orc/OrcMetrics.java ## @@ -0,0 +1,154 @@ +/* + *