[GitHub] mccheah commented on issue #85: Encryption APIs for Iceberg.

2019-01-22 Thread GitBox
mccheah commented on issue #85: Encryption APIs for Iceberg. URL: https://github.com/apache/incubator-iceberg/pull/85#issuecomment-456648809 @rdblue @yifeih @vinooganesh Another attempt at encryption APIs! Will build a proof of concept around this soon.

[GitHub] mccheah commented on issue #80: Introduce metadata for encrypting table data files

2019-01-22 Thread GitBox
mccheah commented on issue #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#issuecomment-456648211 Superceded by https://github.com/apache/incubator-iceberg/pull/85

[GitHub] mccheah opened a new pull request #85: Encryption APIs for Iceberg.

2019-01-22 Thread GitBox
mccheah opened a new pull request #85: Encryption APIs for Iceberg. URL: https://github.com/apache/incubator-iceberg/pull/85 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] rdblue commented on a change in pull request #82: Make expression binding support a case sensitivity flag

2019-01-22 Thread GitBox
rdblue commented on a change in pull request #82: Make expression binding support a case sensitivity flag URL: https://github.com/apache/incubator-iceberg/pull/82#discussion_r250014071 ## File path: api/src/main/java/com/netflix/iceberg/expressions/Evaluator.java ## @@

[GitHub] xabriel commented on issue #82: Make expression binding support a case sensitivity flag

2019-01-22 Thread GitBox
xabriel commented on issue #82: Make expression binding support a case sensitivity flag URL: https://github.com/apache/incubator-iceberg/pull/82#issuecomment-456595316 > What do you think about adding versions of these methods that don't have the flag and default to case sensitive?

[GitHub] rdblue commented on a change in pull request #80: Introduce metadata for encrypting table data files

2019-01-22 Thread GitBox
rdblue commented on a change in pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#discussion_r249969490 ## File path: api/src/main/java/com/netflix/iceberg/encryption/PhysicalEncryptionKey.java ##

[GitHub] rdblue commented on a change in pull request #80: Introduce metadata for encrypting table data files

2019-01-22 Thread GitBox
rdblue commented on a change in pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#discussion_r249968153 ## File path: api/src/main/java/com/netflix/iceberg/encryption/EncryptionKeyMetadata.java ##

[GitHub] mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files

2019-01-22 Thread GitBox
mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#discussion_r249967948 ## File path: api/src/main/java/com/netflix/iceberg/encryption/PhysicalEncryptionKey.java

[GitHub] mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files

2019-01-22 Thread GitBox
mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#discussion_r249967727 ## File path: api/src/main/java/com/netflix/iceberg/encryption/PhysicalEncryptionKey.java

[GitHub] mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files

2019-01-22 Thread GitBox
mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#discussion_r249966256 ## File path: api/src/main/java/com/netflix/iceberg/encryption/PhysicalEncryptionKey.java

[GitHub] mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files

2019-01-22 Thread GitBox
mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#discussion_r249965552 ## File path: api/src/main/java/com/netflix/iceberg/encryption/EncryptionKeyMetadata.java

[GitHub] rdblue commented on a change in pull request #80: Introduce metadata for encrypting table data files

2019-01-22 Thread GitBox
rdblue commented on a change in pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#discussion_r249963970 ## File path: api/src/main/java/com/netflix/iceberg/encryption/PhysicalEncryptionKey.java ##

[GitHub] rdblue commented on issue #82: Make expression binding support a case sensitivity flag

2019-01-22 Thread GitBox
rdblue commented on issue #82: Make expression binding support a case sensitivity flag URL: https://github.com/apache/incubator-iceberg/pull/82#issuecomment-456511762 Thanks for the update, @xabriel! Adding a `caseSensitive` flag requires quite a few updates elsewhere, and method

[GitHub] rdblue commented on issue #69: Use "org.apache.iceberg" package name

2019-01-22 Thread GitBox
rdblue commented on issue #69: Use "org.apache.iceberg" package name URL: https://github.com/apache/incubator-iceberg/pull/69#issuecomment-456504057 Yeah, I haven't looked at this much because I think we will want to plan when we switch over. It will break other pull requests. It's also a