[GitHub] [incubator-iceberg] waterlx commented on issue #279: Transforming timestamp to date should produce date

2019-08-16 Thread GitBox
waterlx commented on issue #279: Transforming timestamp to date should produce date URL: https://github.com/apache/incubator-iceberg/issues/279#issuecomment-522198656 Thanks for the clarification, Ryan! I am drafting the patch.

[GitHub] [incubator-iceberg] rdsr commented on issue #315: [WIP] Incremental processing prototype

2019-08-16 Thread GitBox
rdsr commented on issue #315: [WIP] Incremental processing prototype URL: https://github.com/apache/incubator-iceberg/pull/315#issuecomment-522166976 @rdblue, any comments on this updated rb? This is an automated message from

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

2019-08-16 Thread GitBox
rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314875570 ## File path: api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java ## @@ -125,13 +154,38 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

2019-08-16 Thread GitBox
rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314873793 ## File path: api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java ## @@ -125,13 +180,65 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

2019-08-16 Thread GitBox
rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314869628 ## File path: api/src/main/java/org/apache/iceberg/util/CharSequenceWrapper.java ## @@ -49,21 +50,22 @@ public

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

2019-08-16 Thread GitBox
rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314868900 ## File path: api/src/main/java/org/apache/iceberg/expressions/LiteralSet.java ## @@ -0,0 +1,140 @@ +/* + *

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

2019-08-16 Thread GitBox
rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314867459 ## File path: api/src/main/java/org/apache/iceberg/expressions/Binder.java ## @@ -140,6 +140,11 @@ public

[GitHub] [incubator-iceberg] xabriel commented on a change in pull request #389: Add test cases

2019-08-16 Thread GitBox
xabriel commented on a change in pull request #389: Add test cases URL: https://github.com/apache/incubator-iceberg/pull/389#discussion_r314844945 ## File path: core/src/test/java/org/apache/iceberg/TestScanSummary.java ## @@ -32,7 +33,47 @@ import static

[GitHub] [incubator-iceberg] rdblue commented on issue #279: Transforming timestamp to date should produce date

2019-08-16 Thread GitBox
rdblue commented on issue #279: Transforming timestamp to date should produce date URL: https://github.com/apache/incubator-iceberg/issues/279#issuecomment-522102358 Yes, I think both should return `DateType` This is an

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

2019-08-16 Thread GitBox
rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314831880 ## File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java ## @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

2019-08-16 Thread GitBox
rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314831740 ## File path: api/src/main/java/org/apache/iceberg/expressions/Expressions.java ## @@ -109,16 +111,46 @@ public

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

2019-08-16 Thread GitBox
rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314831603 ## File path: api/src/main/java/org/apache/iceberg/expressions/Expressions.java ## @@ -109,16 +111,46 @@ public

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

2019-08-16 Thread GitBox
rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314830695 ## File path: api/src/main/java/org/apache/iceberg/expressions/Literals.java ## @@ -109,6 +110,26 @@ public T

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

2019-08-16 Thread GitBox
rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314830563 ## File path: api/src/main/java/org/apache/iceberg/expressions/LiteralSet.java ## @@ -0,0 +1,212 @@ +/* + *

[GitHub] [incubator-iceberg] manishmalhotrawork commented on issue #279: Transforming timestamp to date should produce date

2019-08-16 Thread GitBox
manishmalhotrawork commented on issue #279: Transforming timestamp to date should produce date URL: https://github.com/apache/incubator-iceberg/issues/279#issuecomment-522055383 @rdblue > This change would primarily just update getResultType and return DateType.get() when the

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table

2019-08-16 Thread GitBox
aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r314773879 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5

[GitHub] [incubator-iceberg] chenjunjiedada commented on a change in pull request #374: Migrate spark table to iceberg table

2019-08-16 Thread GitBox
chenjunjiedada commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r314771349 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table

2019-08-16 Thread GitBox
aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r314769035 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table

2019-08-16 Thread GitBox
aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r314769035 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table

2019-08-16 Thread GitBox
aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r314766368 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table

2019-08-16 Thread GitBox
aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r314764345 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5

[GitHub] [incubator-iceberg] aokolnychyi commented on issue #366: Concurrent appends to the same table using HiveCatalog lead to deadlock in the Metastore

2019-08-16 Thread GitBox
aokolnychyi commented on issue #366: Concurrent appends to the same table using HiveCatalog lead to deadlock in the Metastore URL: https://github.com/apache/incubator-iceberg/issues/366#issuecomment-522039325 Below is the part in `HiveTableOperations` I was talking about: ```

[GitHub] [incubator-iceberg] aokolnychyi commented on issue #366: Concurrent appends to the same table using HiveCatalog lead to deadlock in the Metastore

2019-08-16 Thread GitBox
aokolnychyi commented on issue #366: Concurrent appends to the same table using HiveCatalog lead to deadlock in the Metastore URL: https://github.com/apache/incubator-iceberg/issues/366#issuecomment-522038874 HMS has an internal mechanism for recovering in such cases, which might be slow

[GitHub] [incubator-iceberg] arina-ielchiieva edited a comment on issue #309: Add mechanism to expire table metadata

2019-08-16 Thread GitBox
arina-ielchiieva edited a comment on issue #309: Add mechanism to expire table metadata URL: https://github.com/apache/incubator-iceberg/pull/309#issuecomment-522009933 From Ryan's comment suggested approach is not suitable but currently I don't have time for the re-design so feel free to

[GitHub] [incubator-iceberg] arina-ielchiieva commented on issue #309: Add mechanism to expire table metadata

2019-08-16 Thread GitBox
arina-ielchiieva commented on issue #309: Add mechanism to expire table metadata URL: https://github.com/apache/incubator-iceberg/pull/309#issuecomment-522009933 From Ryan's comment suggested approach is not suitable but currently I don't have time for the re-design so feel to close this

[GitHub] [incubator-iceberg] aokolnychyi closed issue #132: Add a test for ParquetMetrics with multiple row groups

2019-08-16 Thread GitBox
aokolnychyi closed issue #132: Add a test for ParquetMetrics with multiple row groups URL: https://github.com/apache/incubator-iceberg/issues/132 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-iceberg] aokolnychyi commented on issue #132: Add a test for ParquetMetrics with multiple row groups

2019-08-16 Thread GitBox
aokolnychyi commented on issue #132: Add a test for ParquetMetrics with multiple row groups URL: https://github.com/apache/incubator-iceberg/issues/132#issuecomment-522008754 Closing this one as it was resolved by #365

[GitHub] [incubator-iceberg] aokolnychyi commented on issue #309: Add mechanism to expire table metadata

2019-08-16 Thread GitBox
aokolnychyi commented on issue #309: Add mechanism to expire table metadata URL: https://github.com/apache/incubator-iceberg/pull/309#issuecomment-522008526 @arina-ielchiieva @rdblue @rdsr any ideas on the questions above?

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #362: Support create and replace transactions in Catalog

2019-08-16 Thread GitBox
aokolnychyi commented on a change in pull request #362: Support create and replace transactions in Catalog URL: https://github.com/apache/incubator-iceberg/pull/362#discussion_r314714596 ## File path: hive/src/test/java/org/apache/iceberg/hive/HiveCreateReplaceTableTest.java

[GitHub] [incubator-iceberg] jerryshao opened a new pull request #395: Remove Hadoop Configuration dependency in BaseMetastoreTableOperations

2019-08-16 Thread GitBox
jerryshao opened a new pull request #395: Remove Hadoop Configuration dependency in BaseMetastoreTableOperations URL: https://github.com/apache/incubator-iceberg/pull/395 This is for issue #353 , to remove the Configuration dependency in `BaseMetastoreOperations`. No new UT added,

[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #374: Migrate spark table to iceberg table

2019-08-16 Thread GitBox
jerryshao commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r314627097 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5 +301,88

[GitHub] [incubator-iceberg] jerryshao commented on issue #370: Iceberg failed to work with embedded metastore, which is by default in Spark

2019-08-16 Thread GitBox
jerryshao commented on issue #370: Iceberg failed to work with embedded metastore, which is by default in Spark URL: https://github.com/apache/incubator-iceberg/issues/370#issuecomment-521917078 After spending a bit time on this issue, seems this problem is more complicated than I

[GitHub] [incubator-iceberg] waterlx edited a comment on issue #394: Wrong URL of "Iceberg API" on Spark user docs

2019-08-16 Thread GitBox
waterlx edited a comment on issue #394: Wrong URL of "Iceberg API" on Spark user docs URL: https://github.com/apache/incubator-iceberg/issues/394#issuecomment-521903689 @rdblue I am not sure if the website is not deployed after #333 is merged. Would you please have a check at your

[GitHub] [incubator-iceberg] waterlx commented on issue #394: Wrong URL of "Iceberg API" on Spark user docs

2019-08-16 Thread GitBox
waterlx commented on issue #394: Wrong URL of "Iceberg API" on Spark user docs URL: https://github.com/apache/incubator-iceberg/issues/394#issuecomment-521903689 @rdblue I am not sure if the website is not deployed after [issue 333](https://github.com/apache/incubator-iceberg/pull/333) is

[GitHub] [incubator-iceberg] jun-he commented on a change in pull request #357: Add in and not in predicates

2019-08-16 Thread GitBox
jun-he commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314591877 ## File path: api/src/main/java/org/apache/iceberg/expressions/Literals.java ## @@ -109,6 +110,26 @@ public T