[jira] [Commented] (IGNITE-13151) Checkpointer code refactoring: extracting classes from GridCacheDatabaseSharedManager
[ https://issues.apache.org/jira/browse/IGNITE-13151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177799#comment-17177799 ] Sergey Chugunov commented on IGNITE-13151: -- [~akalashnikov], I merged your patch to master branch in commit *8d6a636b795a860974a7e86d3e2f54e9295616b6*. Thank you for contribution! > Checkpointer code refactoring: extracting classes from > GridCacheDatabaseSharedManager > - > > Key: IGNITE-13151 > URL: https://issues.apache.org/jira/browse/IGNITE-13151 > Project: Ignite > Issue Type: Sub-task > Components: persistence >Reporter: Sergey Chugunov >Assignee: Anton Kalashnikov >Priority: Major > Labels: IEP-47 > Time Spent: 20m > Remaining Estimate: 0h > > Checkpointer is at the center of Ignite persistence subsystem and more people > from the community understand it the better means it is more stable and more > efficient. > However for now checkpointer code sits inside of > GridCacheDatabaseSharedManager class and is entangled with this higher-level > and more general component. > To take a step forward to more modular checkpointer we need to do two things: > # Move checkpointer code outside database manager to a separate class. > (That's what this ticket is about.) > # Create a well-defined API of checkpointer that will allow us to create new > implementations of checkpointer in the future. An example of this is new > checkpointer implementation needed for defragmentation feature purposes. > (Should be done in a separate ticket) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-13151) Checkpointer code refactoring: extracting classes from GridCacheDatabaseSharedManager
[ https://issues.apache.org/jira/browse/IGNITE-13151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177015#comment-17177015 ] Anton Kalashnikov commented on IGNITE-13151: [~agura] Thanks for your comment, but there are no new classes, in fact, all of these classes were extracted mostly from GridCacheDatabaseSharedManager with minimum changes. So I agree that javadocs are not perfect and I improved it a little but the further improvement I suggest to do in my next task because these classes will be changed. It is the same about naming - I left old names for easier the review but in the further, it is a high probability that I will find a more suitable name for them. [~sergey-chugunov] can you recheck these changes(there are not a lot of changes since the last time) and merge it to master. > Checkpointer code refactoring: extracting classes from > GridCacheDatabaseSharedManager > - > > Key: IGNITE-13151 > URL: https://issues.apache.org/jira/browse/IGNITE-13151 > Project: Ignite > Issue Type: Sub-task > Components: persistence >Reporter: Sergey Chugunov >Assignee: Anton Kalashnikov >Priority: Major > Labels: IEP-47 > Time Spent: 10m > Remaining Estimate: 0h > > Checkpointer is at the center of Ignite persistence subsystem and more people > from the community understand it the better means it is more stable and more > efficient. > However for now checkpointer code sits inside of > GridCacheDatabaseSharedManager class and is entangled with this higher-level > and more general component. > To take a step forward to more modular checkpointer we need to do two things: > # Move checkpointer code outside database manager to a separate class. > (That's what this ticket is about.) > # Create a well-defined API of checkpointer that will allow us to create new > implementations of checkpointer in the future. An example of this is new > checkpointer implementation needed for defragmentation feature purposes. > (Should be done in a separate ticket) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-13151) Checkpointer code refactoring: extracting classes from GridCacheDatabaseSharedManager
[
https://issues.apache.org/jira/browse/IGNITE-13151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175008#comment-17175008
]
Andrey N. Gura commented on IGNITE-13151:
-
[~akalashnikov] LGTM. But a couple of comments:
- newly created classes should be documented better and more carefully;
- it's surprising to me that {{DbCheckpointContextImpl}} has {{Db}} prefix
while other new classes don't have such prefix.
> Checkpointer code refactoring: extracting classes from
> GridCacheDatabaseSharedManager
> -
>
> Key: IGNITE-13151
> URL: https://issues.apache.org/jira/browse/IGNITE-13151
> Project: Ignite
> Issue Type: Sub-task
> Components: persistence
>Reporter: Sergey Chugunov
>Assignee: Anton Kalashnikov
>Priority: Major
> Labels: IEP-47
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Checkpointer is at the center of Ignite persistence subsystem and more people
> from the community understand it the better means it is more stable and more
> efficient.
> However for now checkpointer code sits inside of
> GridCacheDatabaseSharedManager class and is entangled with this higher-level
> and more general component.
> To take a step forward to more modular checkpointer we need to do two things:
> # Move checkpointer code outside database manager to a separate class.
> (That's what this ticket is about.)
> # Create a well-defined API of checkpointer that will allow us to create new
> implementations of checkpointer in the future. An example of this is new
> checkpointer implementation needed for defragmentation feature purposes.
> (Should be done in a separate ticket)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-13151) Checkpointer code refactoring: extracting classes from GridCacheDatabaseSharedManager
[
https://issues.apache.org/jira/browse/IGNITE-13151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171501#comment-17171501
]
Ignite TC Bot commented on IGNITE-13151:
{panel:title=Branch: [pull/7937/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/7937/head] Base: [master] : New Tests
(8)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Service Grid{color} [[tests
4|https://ci.ignite.apache.org/viewLog.html?buildId=5513138]]
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple
[val1=DiscoveryEvent [evtNode=c387b6c0-2344-4563-a4af-9030842e27f0, topVer=0,
msgTemplate=null, span=null, nodeId8=f4e17bc3, msg=, type=NODE_JOINED,
tstamp=1596543975607], val2=AffinityTopologyVersion
[topVer=6798418167270086684, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple
[val1=DiscoveryEvent [evtNode=c387b6c0-2344-4563-a4af-9030842e27f0, topVer=0,
msgTemplate=null, span=null, nodeId8=f4e17bc3, msg=, type=NODE_JOINED,
tstamp=1596543975607], val2=AffinityTopologyVersion
[topVer=6798418167270086684, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest
[id=2d02a79b371-4b4a0775-8c84-49e3-b311-f94885bd9300, reqs=SingletonList
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent
[evtNode=05481f9e-4a91-4d98-9404-60581f2b986e, topVer=0, msgTemplate=null,
span=null, nodeId8=05481f9e, msg=null, type=DISCOVERY_CUSTOM_EVT,
tstamp=1596543975607]], val2=AffinityTopologyVersion
[topVer=627954088910431382, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest
[id=2d02a79b371-4b4a0775-8c84-49e3-b311-f94885bd9300, reqs=SingletonList
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent
[evtNode=05481f9e-4a91-4d98-9404-60581f2b986e, topVer=0, msgTemplate=null,
span=null, nodeId8=05481f9e, msg=null, type=DISCOVERY_CUSTOM_EVT,
tstamp=1596543975607]], val2=AffinityTopologyVersion
[topVer=627954088910431382, minorTopVer=0]]] - PASSED{color}
{color:#8b}Service Grid (legacy mode){color} [[tests
4|https://ci.ignite.apache.org/viewLog.html?buildId=5513139]]
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest
[id=503ae69b371-4fa3582c-3c64-40bf-b9b0-12cd82f52e34, reqs=SingletonList
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent
[evtNode=1cd104e1-1c45-4897-95bc-1f0c70507add, topVer=0, msgTemplate=null,
span=null, nodeId8=1cd104e1, msg=null, type=DISCOVERY_CUSTOM_EVT,
tstamp=1596543902465]], val2=AffinityTopologyVersion
[topVer=-8441994602695658790, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple
[val1=DiscoveryEvent [evtNode=cb2f303c-2f19-4fb9-adbe-6117c22cae9a, topVer=0,
msgTemplate=null, span=null, nodeId8=84ed60f7, msg=, type=NODE_JOINED,
tstamp=1596543902465], val2=AffinityTopologyVersion
[topVer=8447837232382488239, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple
[val1=DiscoveryEvent [evtNode=cb2f303c-2f19-4fb9-adbe-6117c22cae9a, topVer=0,
msgTemplate=null, span=null, nodeId8=84ed60f7, msg=, type=NODE_JOINED,
tstamp=1596543902465], val2=AffinityTopologyVersion
[topVer=8447837232382488239, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest
[id=503ae69b371-4fa3582c-3c64-40bf-b9b0-12cd82f52e34, reqs=SingletonList
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent
[evtNode=1cd104e1-1c45-4897-95bc-1f0c70507add, topVer=0, msgTemplate=null,
span=null, nodeId8=1cd104e1, msg=null, type=DISCOVERY_CUSTOM_EVT,
tstamp=1596543902465]], val2=AffinityTopologyVersion
[topVer=-8441994602695658790, minorTopVer=0]]] - PASSED{color}
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5513161buildTypeId=IgniteTests24Java8_RunAll]
> Checkpointer code refactoring: extracting classes from
> GridCacheDatabaseSharedManager
> -
>
> Key:
[jira] [Commented] (IGNITE-13151) Checkpointer code refactoring: extracting classes from GridCacheDatabaseSharedManager
[ https://issues.apache.org/jira/browse/IGNITE-13151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147600#comment-17147600 ] Sergey Chugunov commented on IGNITE-13151: -- [~akalashnikov], As far as I understand, this patch just moves checkpointer code and related interfaces outside of GridCacheDatabaseSharedManager class, no structural refactoring was made. >From that perspective change looks good to me. How do you estimate risks of merging it to master before upcoming 2.9 release? > Checkpointer code refactoring: extracting classes from > GridCacheDatabaseSharedManager > - > > Key: IGNITE-13151 > URL: https://issues.apache.org/jira/browse/IGNITE-13151 > Project: Ignite > Issue Type: Sub-task > Components: persistence >Reporter: Sergey Chugunov >Assignee: Anton Kalashnikov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Checkpointer is at the center of Ignite persistence subsystem and more people > from the community understand it the better means it is more stable and more > efficient. > However for now checkpointer code sits inside of > GridCacheDatabaseSharedManager class and is entangled with this higher-level > and more general component. > To take a step forward to more modular checkpointer we need to do two things: > # Move checkpointer code outside database manager to a separate class. > (That's what this ticket is about.) > # Create a well-defined API of checkpointer that will allow us to create new > implementations of checkpointer in the future. An example of this is new > checkpointer implementation needed for defragmentation feature purposes. > (Should be done in a separate ticket) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-13151) Checkpointer code refactoring: extracting classes from GridCacheDatabaseSharedManager
[
https://issues.apache.org/jira/browse/IGNITE-13151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141870#comment-17141870
]
Ignite TC Bot commented on IGNITE-13151:
{panel:title=Branch: [pull/7937/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5400343buildTypeId=IgniteTests24Java8_RunAll]
> Checkpointer code refactoring: extracting classes from
> GridCacheDatabaseSharedManager
> -
>
> Key: IGNITE-13151
> URL: https://issues.apache.org/jira/browse/IGNITE-13151
> Project: Ignite
> Issue Type: Sub-task
> Components: persistence
>Reporter: Sergey Chugunov
>Assignee: Anton Kalashnikov
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Checkpointer is at the center of Ignite persistence subsystem and more people
> from the community understand it the better means it is more stable and more
> efficient.
> However for now checkpointer code sits inside of
> GridCacheDatabaseSharedManager class and is entangled with this higher-level
> and more general component.
> To take a step forward to more modular checkpointer we need to do two things:
> # Move checkpointer code outside database manager to a separate class.
> (That's what this ticket is about.)
> # Create a well-defined API of checkpointer that will allow us to create new
> implementations of checkpointer in the future. An example of this is new
> checkpointer implementation needed for defragmentation feature purposes.
> (Should be done in a separate ticket)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
