[GitHub] hit-lacus opened a new pull request #368: KYLIN-3187 Forbid calls to JDK APIs that use the default locale
hit-lacus opened a new pull request #368: KYLIN-3187 Forbid calls to JDK APIs that use the default locale URL: https://github.com/apache/kylin/pull/368 Fix encode bugs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hit-lacus commented on issue #368: KYLIN-3187 Forbid calls to JDK APIs that use the default locale
hit-lacus commented on issue #368: KYLIN-3187 Forbid calls to JDK APIs that use the default locale URL: https://github.com/apache/kylin/pull/368#issuecomment-443176896 ```sql select uid, act_type, count(*) as cnt from useraction as ua where act_type > '播放' group by uid, act_type order by uid, act_type; ``` This sql query result is correct compare Kylin with Hive. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] woyumen4597 commented on issue #366: KYLIN-3707 add configuration for setting isolation-level for sqoop
woyumen4597 commented on issue #366: KYLIN-3707 add configuration for setting isolation-level for sqoop URL: https://github.com/apache/kylin/pull/366#issuecomment-442820920 CI has passed.  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi commented on a change in pull request #348: added release notes, modified kylin and coprocessor upgrade guides
shaofengshi commented on a change in pull request #348: added release notes, modified kylin and coprocessor upgrade guides URL: https://github.com/apache/kylin/pull/348#discussion_r238899445 ## File path: website/_docs/index.cn.md ## @@ -9,21 +9,31 @@ permalink: /cn/docs/index.html > Extreme OLAP Engine for Big Data -Apache Kylin™是一个开源的分布式分析引擎，提供Hadoop之上的SQL查询接口及多维分析（OLAP）能力以支持超大规模数据，最初由eBay Inc.开发并贡献至开源社区。 +Apache Kylin™ 是一个开源 OLAP（On-Line Analytics Processing）分析引擎，针对数据库与亿万级记录提供亚秒级查询响应能力。2014 年由 eBay Inc.开发并贡献至开源社区。2015 年毕业于 Apache 顶级项目并迅速被全球数千家公司与组织应用于数据分析业务，同时也在 2015 与 2016 年赢得 InfoWorld Bossie Awards 年度最佳大数据开源工具。 Review comment: "Online" is a word, not "On-Line", please check the terms: https://en.wikipedia.org/wiki/Online_analytical_processing This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi commented on a change in pull request #348: added release notes, modified kylin and coprocessor upgrade guides
shaofengshi commented on a change in pull request #348: added release notes, modified kylin and coprocessor upgrade guides URL: https://github.com/apache/kylin/pull/348#discussion_r238899442 ## File path: website/_docs/index.cn.md ## @@ -9,21 +9,31 @@ permalink: /cn/docs/index.html > Extreme OLAP Engine for Big Data -Apache Kylin™是一个开源的分布式分析引擎，提供Hadoop之上的SQL查询接口及多维分析（OLAP）能力以支持超大规模数据，最初由eBay Inc.开发并贡献至开源社区。 +Apache Kylin™ 是一个开源 OLAP（On-Line Analytics Processing）分析引擎，针对数据库与亿万级记录提供亚秒级查询响应能力。2014 年由 eBay Inc.开发并贡献至开源社区。2015 年毕业于 Apache 顶级项目并迅速被全球数千家公司与组织应用于数据分析业务，同时也在 2015 与 2016 年赢得 InfoWorld Bossie Awards 年度最佳大数据开源工具。 Review comment: "Online" is a word, not "On-Line", please check the terms: https://en.wikipedia.org/wiki/Online_analytical_processing This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi commented on a change in pull request #348: added release notes, modified kylin and coprocessor upgrade guides
shaofengshi commented on a change in pull request #348: added release notes, modified kylin and coprocessor upgrade guides URL: https://github.com/apache/kylin/pull/348#discussion_r238899806 ## File path: website/download/index.cn.md ## @@ -21,7 +21,7 @@ title: 下载 v2.5.0 - 这是2.4版本后的一个主要发布版本，包含了96 个以及各种改进。关于具体内容请查看[v2.5.0 正式发布](/blog/2018/09/20/release-v2.5.0/). -- [发布说明](/docs/release_notes.html) and [升级指南](/docs/howto/howto_upgrade.html) +- [发布声明](/cn/docs/releases/kylin_release_notes.html) and [Kylin 升级](/cn/docs/howto/howto_upgrade.html) Review comment: We don't need to provide multiple language for release notes... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi commented on a change in pull request #348: added release notes, modified kylin and coprocessor upgrade guides
shaofengshi commented on a change in pull request #348: added release notes, modified kylin and coprocessor upgrade guides URL: https://github.com/apache/kylin/pull/348#discussion_r238900055 ## File path: website/download/index.md ## @@ -20,7 +20,7 @@ You can verify the download by following these [procedures](https://www.apache.o v2.5.0 - This is a major release after 2.4, with 96 bug fixes and enhancement. Check the [v2.5.0 release announcement](/blog/2018/09/20/release-v2.5.0/) and the release notes. -- [Release notes](/docs/release_notes.html) and [upgrade guide](/docs/howto/howto_upgrade.html) +- [Kylin Release Notes](/docs/releases/kylin_release_notes.html) and [Upgrade Kylin From Old Versions](/docs/howto/howto_upgrade.html) Review comment: I think the "upgrade guide" in lower case is more friendly than "Upgrade Kylin From Old Versions" in hump... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi commented on a change in pull request #348: added release notes, modified kylin and coprocessor upgrade guides
shaofengshi commented on a change in pull request #348: added release notes, modified kylin and coprocessor upgrade guides URL: https://github.com/apache/kylin/pull/348#discussion_r238900904 ## File path: website/_docs/howto/howto_upgrade.md ## @@ -1,112 +1,146 @@ --- layout: docs -title: Upgrade From Old Versions +title: Upgrade Kylin From Old Versions categories: howto permalink: /docs/howto/howto_upgrade.html since: v1.5.1 --- -Running as a Hadoop client, Apache Kylin's metadata and Cube data are persistended in Hadoop (HBase and HDFS), so the upgrade is relatively easy and user does not need worry about data loss. The upgrade can be performed in the following steps: +Running as a Hadoop client, Apache Kylin's metadata and Cube data are persistent in Hadoop (HBase and HDFS), so the upgrade is relatively easy and user does not need worry about data loss. The upgrade can be performed in the following steps: Review comment: "persistent" is incorrect in this context, it is adjective, while here we need "be persisted" which is a passive voice; (a typo in the previous version). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi commented on a change in pull request #348: added release notes, modified kylin and coprocessor upgrade guides
shaofengshi commented on a change in pull request #348: added release notes, modified kylin and coprocessor upgrade guides URL: https://github.com/apache/kylin/pull/348#discussion_r238900295 ## File path: website/_data/docs.yml ## @@ -78,6 +77,10 @@ - howto/howto_use_cli - howto/howto_ldap_and_sso - howto/howto_use_beeline - - howto/howto_update_coprocessor + - howto/howto_upgrade_coprocessor Review comment: This change will change the URL endpoint. We hope the URL can be kept as there are many external references. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi commented on a change in pull request #348: added release notes, modified kylin and coprocessor upgrade guides
shaofengshi commented on a change in pull request #348: added release notes, modified kylin and coprocessor upgrade guides URL: https://github.com/apache/kylin/pull/348#discussion_r238900533 ## File path: website/_docs/howto/howto_upgrade.md ## @@ -1,112 +1,146 @@ --- layout: docs -title: Upgrade From Old Versions +title: Upgrade Kylin From Old Versions Review comment: Of course it is "Kylin", this looks redundant ... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #371: KYLIN-3695, fix lose decimal scale value in column type decimal(a, b)
asfgit commented on issue #371: KYLIN-3695, fix lose decimal scale value in column type decimal(a, b) URL: https://github.com/apache/kylin/pull/371#issuecomment-444363598 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Emiya0306 opened a new pull request #371: KYLIN-3695, fix lose decimal scale value in column type decimal(a, b)
Emiya0306 opened a new pull request #371: KYLIN-3695, fix lose decimal scale value in column type decimal(a, b) URL: https://github.com/apache/kylin/pull/371 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] luguosheng1314 closed pull request #371: KYLIN-3695, fix lose decimal scale value in column type decimal(a, b)
luguosheng1314 closed pull request #371: KYLIN-3695, fix lose decimal scale
value in column type decimal(a, b)
URL: https://github.com/apache/kylin/pull/371
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/webapp/app/js/controllers/cubeMeasures.js
b/webapp/app/js/controllers/cubeMeasures.js
index 7beb528d6b..f1821dda87 100644
--- a/webapp/app/js/controllers/cubeMeasures.js
+++ b/webapp/app/js/controllers/cubeMeasures.js
@@ -465,10 +465,10 @@ KylinApp.controller('CubeMeasuresCtrl', function ($scope,
$modal,MetaModel,cubes
return 'bigint';
} else {
if(colType.indexOf('decimal') != -1) {
-var returnRegex = new
RegExp('(\\w+)(?:\\((\\w+?)(?:\\,(\\w+?))?\\))?')
-var returnValue = returnRegex.exec(colType)
-var precision = 19
-var scale = returnValue[3]
+var returnRegex = new
RegExp('(\\w+)(?:\\((\\w+?)(?:\\,(\\w+?))?\\))?');
+var returnValue = returnRegex.exec(colType);
+var precision = 19;
+var scale = returnValue[3] || 0;
return 'decimal(' + precision + ',' + scale + ')';
}else{
return colType;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #371: KYLIN-3695, fix lose decimal scale value in column type decimal(a, b)
codecov-io commented on issue #371: KYLIN-3695, fix lose decimal scale value in column type decimal(a, b) URL: https://github.com/apache/kylin/pull/371#issuecomment-444367864 # [Codecov](https://codecov.io/gh/apache/kylin/pull/371?src=pr=h1) Report > Merging [#371](https://codecov.io/gh/apache/kylin/pull/371?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/be5df4a8bb6939c0c62c6135c4312fe3ad56775d?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/371?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #371 +/- ## - Coverage 23.64% 23.63% -0.02% + Complexity 4838 4837 -1 Files 1131 1131 Lines 6819368193 Branches 9684 9684 - Hits 1612416116 -8 - Misses5050350509 +6 - Partials 1566 1568 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/371?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/371/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/371/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/371/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (-0.92%)` | `7% <0%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/371?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/371?src=pr=footer). Last update [be5df4a...a073222](https://codecov.io/gh/apache/kylin/pull/371?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #372: KYLIN-1111 Ignore unsupported hive column types when sync hive table
codecov-io commented on issue #372: KYLIN- Ignore unsupported hive column types when sync hive table URL: https://github.com/apache/kylin/pull/372#issuecomment-444610689 # [Codecov](https://codecov.io/gh/apache/kylin/pull/372?src=pr=h1) Report > Merging [#372](https://codecov.io/gh/apache/kylin/pull/372?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7f672b074a068d20779d33889f1cb63b0da172a7?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `26.66%`. [](https://codecov.io/gh/apache/kylin/pull/372?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #372 +/- ## - Coverage 23.64% 23.63% -0.01% - Complexity 4838 4840 +2 Files 1131 1131 Lines 6819368199 +6 Branches 9684 9686 +2 - Hits 1612416120 -4 - Misses5050350510 +7 - Partials 1566 1569 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/372?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...apache/kylin/source/hive/HiveMetadataExplorer.java](https://codecov.io/gh/apache/kylin/pull/372/diff?src=pr=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVNZXRhZGF0YUV4cGxvcmVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...a/org/apache/kylin/metadata/datatype/DataType.java](https://codecov.io/gh/apache/kylin/pull/372/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvZGF0YXR5cGUvRGF0YVR5cGUuamF2YQ==) | `70.28% <80%> (+0.28%)` | `44 <3> (+3)` | :arrow_up: | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/372/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/372/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/372/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (-0.92%)` | `7% <0%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/372?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/372?src=pr=footer). Last update [7f672b0...5971b6f](https://codecov.io/gh/apache/kylin/pull/372?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #372: KYLIN-1111 Ignore unsupported hive column types when sync hive table
asfgit commented on issue #372: KYLIN- Ignore unsupported hive column types when sync hive table URL: https://github.com/apache/kylin/pull/372#issuecomment-444600629 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] whuwb opened a new pull request #372: KYLIN-1111 Ignore unsupported hive column types when sync hive table
whuwb opened a new pull request #372: KYLIN- Ignore unsupported hive column types when sync hive table URL: https://github.com/apache/kylin/pull/372 Issue : https://issues.apache.org/jira/browse/KYLIN- Solution : Filter in HiveMetadataExplorer#extractColumnFromMeta How to verify: 1. add new UT 2. Verified with IT: [INFO] Apache Kylin - Integration Test SUCCESS [ 02:30 h] [INFO] Apache Kylin - Tomcat Extension SUCCESS [ 2.303 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 02:47 h [INFO] Finished at: 2018-12-05T18:29:37Z [INFO] 3. Manual add a Hive table with map, and try to load into Kylin This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GinaZhai opened a new pull request #359: KYLIN-3628 The wrong result when a query with one lookup table
GinaZhai opened a new pull request #359: KYLIN-3628 The wrong result when a query with one lookup table URL: https://github.com/apache/kylin/pull/359 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #359: KYLIN-3628 The wrong result when a query with one lookup table
asfgit commented on issue #359: KYLIN-3628 The wrong result when a query with one lookup table URL: https://github.com/apache/kylin/pull/359#issuecomment-441250502 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] whuwb opened a new pull request #358: KYLIN-3559 Use Splitter for splitting String
whuwb opened a new pull request #358: KYLIN-3559 Use Splitter for splitting String URL: https://github.com/apache/kylin/pull/358 Issue : https://issues.apache.org/jira/browse/KYLIN-3559 Solution : 1. Leverage Splitter in Guava to create split/splitByComma and refactor splitAndTrim method in StringUtil 2. Replace the string.split with StringUtil.split This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #358: KYLIN-3559 Use Splitter for splitting String
asfgit commented on issue #358: KYLIN-3559 Use Splitter for splitting String URL: https://github.com/apache/kylin/pull/358#issuecomment-441171380 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #358: KYLIN-3559 Use Splitter for splitting String
coveralls commented on issue #358: KYLIN-3559 Use Splitter for splitting String URL: https://github.com/apache/kylin/pull/358#issuecomment-441174625 ## Pull Request Test Coverage Report for [Build 3878](https://coveralls.io/builds/20255839) * **9** of **42** **(21.43%)** changed or added relevant lines in **21** files are covered. * **7** unchanged lines in **3** files lost coverage. * Overall coverage increased (+**0.002%**) to **25.918%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-cube/src/main/java/org/apache/kylin/cube/cli/CubeSignatureRefresher.java](https://coveralls.io/builds/20255839/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FCubeSignatureRefresher.java#L65) | 0 | 1 | 0.0% | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java](https://coveralls.io/builds/20255839/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDistributedScheduler.java#L154) | 0 | 1 | 0.0% | [engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java](https://coveralls.io/builds/20255839/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FAbstractHadoopJob.java#L327) | 0 | 1 | 0.0% | [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeDictionaryReducer.java](https://coveralls.io/builds/20255839/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FMergeDictionaryReducer.java#L39) | 0 | 1 | 0.0% | [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkMergingDictionary.java](https://coveralls.io/builds/20255839/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkMergingDictionary.java#L155) | 0 | 1 | 0.0% | [query/src/main/java/org/apache/kylin/query/relnode/OLAPTableScan.java](https://coveralls.io/builds/20255839/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPTableScan.java#L246) | 0 | 1 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/init/InitialTaskManager.java](https://coveralls.io/builds/20255839/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Finit%2FInitialTaskManager.java#L53) | 0 | 1 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/service/AdminService.java](https://coveralls.io/builds/20255839/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FAdminService.java#L110) | 0 | 1 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/20255839/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L319) | 0 | 1 | 0.0% | [source-hive/src/main/java/org/apache/kylin/source/hive/cardinality/HiveColumnCardinalityUpdateJob.java](https://coveralls.io/builds/20255839/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2Fcardinality%2FHiveColumnCardinalityUpdateJob.java#L164) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeDictionaryMapper.java](https://coveralls.io/builds/20255839/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FMergeDictionaryMapper.java#L126) | 1 | 0.0% | | [server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/20255839/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72) | 1 | 47.62% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/20255839/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% | | Totals | [](https://coveralls.io/builds/20255839) | | :-- | --: | | Change from base [Build 3871](https://coveralls.io/builds/20236865): | 0.002% | | Covered Lines: | 17651 | | Relevant Lines: | 68102 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #358: KYLIN-3559 Use Splitter for splitting String
codecov-io commented on issue #358: KYLIN-3559 Use Splitter for splitting String URL: https://github.com/apache/kylin/pull/358#issuecomment-441174344 # [Codecov](https://codecov.io/gh/apache/kylin/pull/358?src=pr=h1) Report > Merging [#358](https://codecov.io/gh/apache/kylin/pull/358?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/98cb504470c85718abd1616e78d36851c21f2fd0?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `21.42%`. [](https://codecov.io/gh/apache/kylin/pull/358?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #358 +/- ## - Coverage 23.61% 23.61% -0.01% - Complexity 4826 4827 +1 Files 1133 1133 Lines 6810468102 -2 Branches 9659 9657 -2 - Hits 1608516080 -5 Misses5045550455 - Partials 1564 1567 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/358?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/358/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...che/kylin/engine/spark/SparkMergingDictionary.java](https://codecov.io/gh/apache/kylin/pull/358/diff?src=pr=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtNZXJnaW5nRGljdGlvbmFyeS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ve/cardinality/HiveColumnCardinalityUpdateJob.java](https://codecov.io/gh/apache/kylin/pull/358/diff?src=pr=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL2NhcmRpbmFsaXR5L0hpdmVDb2x1bW5DYXJkaW5hbGl0eVVwZGF0ZUpvYi5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/358/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.13% <0%> (ø)` | `2 <0> (ø)` | :arrow_down: | | [...apache/kylin/query/relnode/OLAPAuthentication.java](https://codecov.io/gh/apache/kylin/pull/358/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvT0xBUEF1dGhlbnRpY2F0aW9uLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...a/org/apache/kylin/tool/CubeMigrationCheckCLI.java](https://codecov.io/gh/apache/kylin/pull/358/diff?src=pr=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9DdWJlTWlncmF0aW9uQ2hlY2tDTEkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ylin/job/impl/threadpool/DistributedScheduler.java](https://codecov.io/gh/apache/kylin/pull/358/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGlzdHJpYnV0ZWRTY2hlZHVsZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../apache/kylin/cube/cli/CubeSignatureRefresher.java](https://codecov.io/gh/apache/kylin/pull/358/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NsaS9DdWJlU2lnbmF0dXJlUmVmcmVzaGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../kylin/engine/mr/steps/MergeDictionaryReducer.java](https://codecov.io/gh/apache/kylin/pull/358/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvTWVyZ2VEaWN0aW9uYXJ5UmVkdWNlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../org/apache/kylin/query/relnode/OLAPTableScan.java](https://codecov.io/gh/apache/kylin/pull/358/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvT0xBUFRhYmxlU2Nhbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | ... and [14 more](https://codecov.io/gh/apache/kylin/pull/358/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/358?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/358?src=pr=footer). Last update [98cb504...a418100](https://codecov.io/gh/apache/kylin/pull/358?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[GitHub] Aaaaaaron commented on a change in pull request #352: KYLIN-3669, add log to indicate the case when using "GTStreamAggregateScanner".
Aaron commented on a change in pull request #352: KYLIN-3669, add log to indicate the case when using "GTStreamAggregateScanner". URL: https://github.com/apache/kylin/pull/352#discussion_r235229952 ## File path: core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SegmentCubeTupleIterator.java ## @@ -92,6 +92,7 @@ public SegmentCubeTupleIterator(CubeSegmentScanner scanner, Cuboid cuboid, Sethttp://apache-kylin.74782.x6.nabble.com/Re-doubt-about-measure-of-processedRowCount-tc12250.html#none This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Aaaaaaron commented on a change in pull request #352: KYLIN-3669, add log to indicate the case when using "GTStreamAggregateScanner".
Aaron commented on a change in pull request #352: KYLIN-3669, add log to indicate the case when using "GTStreamAggregateScanner". URL: https://github.com/apache/kylin/pull/352#discussion_r235229952 ## File path: core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SegmentCubeTupleIterator.java ## @@ -92,6 +92,7 @@ public SegmentCubeTupleIterator(CubeSegmentScanner scanner, Cuboid cuboid, Sethttp://apache-kylin.74782.x6.nabble.com/Re-doubt-about-measure-of-processedRowCount-tc12250.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi commented on a change in pull request #352: KYLIN-3669, add log to indicate the case when using "GTStreamAggregateScanner".
shaofengshi commented on a change in pull request #352: KYLIN-3669, add log to indicate the case when using "GTStreamAggregateScanner". URL: https://github.com/apache/kylin/pull/352#discussion_r235217694 ## File path: core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SegmentCubeTupleIterator.java ## @@ -92,6 +92,7 @@ public SegmentCubeTupleIterator(CubeSegmentScanner scanner, Cuboid cuboid, Set
[GitHub] codecov-io commented on issue #347: KYLIN-3666 HDFS metadata url not be recognized
codecov-io commented on issue #347: KYLIN-3666 HDFS metadata url not be recognized URL: https://github.com/apache/kylin/pull/347#issuecomment-440520921 # [Codecov](https://codecov.io/gh/apache/kylin/pull/347?src=pr=h1) Report > Merging [#347](https://codecov.io/gh/apache/kylin/pull/347?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7105e5ef1403a571922efe1661cc3d62680d560a?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/347?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#347 +/- ## === - Coverage 23.61% 23.6% -0.01% + Complexity 48264825 -1 === Files 11331133 Lines 68102 68103 +1 Branches 96599659 === - Hits 16079 16078 -1 - Misses50458 50459 +1 - Partials 15651566 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/347?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/347/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.13% <0%> (-0.04%)` | `2 <0> (ø)` | | | [...he/kylin/engine/mr/steps/UpdateDictionaryStep.java](https://codecov.io/gh/apache/kylin/pull/347/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvVXBkYXRlRGljdGlvbmFyeVN0ZXAuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/347/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/347/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `70.94% <0%> (-1.36%)` | `8% <0%> (ø)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/347/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/347?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/347?src=pr=footer). Last update [7105e5e...46bb2bb](https://codecov.io/gh/apache/kylin/pull/347?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls edited a comment on issue #347: KYLIN-3666 HDFS metadata url not be recognized
coveralls edited a comment on issue #347: KYLIN-3666 HDFS metadata url not be recognized URL: https://github.com/apache/kylin/pull/347#issuecomment-439015589 ## Pull Request Test Coverage Report for [Build 3870](https://coveralls.io/builds/20216347) * **0** of **4** **(0.0%)** changed or added relevant lines in **2** files are covered. * **3** unchanged lines in **3** files lost coverage. * Overall coverage decreased (**-0.0004%**) to **25.914%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/UpdateDictionaryStep.java](https://coveralls.io/builds/20216347/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FUpdateDictionaryStep.java#L71) | 0 | 1 | 0.0% | [engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java](https://coveralls.io/builds/20216347/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FAbstractHadoopJob.java#L493) | 0 | 3 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java](https://coveralls.io/builds/20216347/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FAbstractHadoopJob.java#L528) | 1 | 15.38% | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/20216347/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/20216347/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L319) | 1 | 81.08% | | Totals | [](https://coveralls.io/builds/20216347) | | :-- | --: | | Change from base [Build 3869](https://coveralls.io/builds/20215506): | -0.0004% | | Covered Lines: | 17648 | | Relevant Lines: | 68103 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi closed pull request #352: KYLIN-3669, add log to indicate the case when using "GTStreamAggregateScanner".
shaofengshi closed pull request #352: KYLIN-3669, add log to indicate the case when using "GTStreamAggregateScanner". URL: https://github.com/apache/kylin/pull/352 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SegmentCubeTupleIterator.java b/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SegmentCubeTupleIterator.java index 629c02563b..028d105a17 100644 --- a/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SegmentCubeTupleIterator.java +++ b/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SegmentCubeTupleIterator.java @@ -92,6 +92,7 @@ public SegmentCubeTupleIterator(CubeSegmentScanner scanner, Cuboid cuboid, Set
[GitHub] shaofengshi commented on a change in pull request #352: KYLIN-3669, add log to indicate the case when using "GTStreamAggregateScanner".
shaofengshi commented on a change in pull request #352: KYLIN-3669, add log to indicate the case when using "GTStreamAggregateScanner". URL: https://github.com/apache/kylin/pull/352#discussion_r235249257 ## File path: core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SegmentCubeTupleIterator.java ## @@ -92,6 +92,7 @@ public SegmentCubeTupleIterator(CubeSegmentScanner scanner, Cuboid cuboid, Set
[GitHub] shaofengshi closed pull request #354: KYLIN-3697 minor, only kylin.sh start check-env
shaofengshi closed pull request #354: KYLIN-3697 minor, only kylin.sh start
check-env
URL: https://github.com/apache/kylin/pull/354
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build/bin/kylin.sh b/build/bin/kylin.sh
index b65cb958a5..b04707815c 100755
--- a/build/bin/kylin.sh
+++ b/build/bin/kylin.sh
@@ -27,7 +27,6 @@ if [ "$verbose" = true ]; then
shift
fi
-source ${dir}/check-env.sh
mkdir -p ${KYLIN_HOME}/logs
mkdir -p ${KYLIN_HOME}/ext
@@ -66,7 +65,9 @@ then
quit "Kylin is running, stop it first"
fi
fi
-
+
+source ${dir}/check-env.sh
+
tomcat_root=${dir}/../tomcat
export tomcat_root
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] shaofengshi closed pull request #350: Fix issue : KYLIN-3631
shaofengshi closed pull request #350: Fix issue : KYLIN-3631
URL: https://github.com/apache/kylin/pull/350
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-cube/src/test/java/org/apache/kylin/cube/cuboid/CuboidSchedulerTest.java
b/core-cube/src/test/java/org/apache/kylin/cube/cuboid/CuboidSchedulerTest.java
index 87bf9c3c35..c40e766a67 100644
---
a/core-cube/src/test/java/org/apache/kylin/cube/cuboid/CuboidSchedulerTest.java
+++
b/core-cube/src/test/java/org/apache/kylin/cube/cuboid/CuboidSchedulerTest.java
@@ -118,8 +118,9 @@ private void testSpanningAndGetParent(CuboidScheduler
scheduler, CubeDesc cube,
}
long[] spanningsArray = Longs.toArray(totalSpanning);
-Arrays.sort(spanningsArray);
-Arrays.sort(expectChildren);
+
+Arrays.parallelSort(spanningsArray);
+Arrays.parallelSort(expectChildren);
assertArrayEquals(expectChildren, spanningsArray);
}
diff --git
a/core-metadata/src/main/java/org/apache/kylin/metadata/model/Segments.java
b/core-metadata/src/main/java/org/apache/kylin/metadata/model/Segments.java
index bb68299133..6c4c9a3142 100644
--- a/core-metadata/src/main/java/org/apache/kylin/metadata/model/Segments.java
+++ b/core-metadata/src/main/java/org/apache/kylin/metadata/model/Segments.java
@@ -220,7 +220,7 @@ public SegmentRange autoMergeCubeSegments(boolean
needAutoMerge, String cubeName
// exclude those already under merging segments
readySegs.removeAll(mergingSegs);
-Arrays.sort(timeRanges);
+Arrays.parallelSort(timeRanges);
for (int i = timeRanges.length - 1; i >= 0; i--) {
long toMergeRange = timeRanges[i];
diff --git
a/core-metadata/src/main/java/org/apache/kylin/metadata/model/TableDesc.java
b/core-metadata/src/main/java/org/apache/kylin/metadata/model/TableDesc.java
index 63a78f89e6..6bbc70c96c 100644
--- a/core-metadata/src/main/java/org/apache/kylin/metadata/model/TableDesc.java
+++ b/core-metadata/src/main/java/org/apache/kylin/metadata/model/TableDesc.java
@@ -308,7 +308,7 @@ public void init(KylinConfig config, String project) {
setDatabase(getDatabase().toUpperCase(Locale.ROOT));
if (columns != null) {
-Arrays.sort(columns, new Comparator() {
+Arrays.parallelSort(columns, new Comparator() {
@Override
public int compare(ColumnDesc col1, ColumnDesc col2) {
Integer id1 = Integer.parseInt(col1.getId());
diff --git
a/core-metadata/src/test/java/org/apache/kylin/measure/topn/DoubleDeltaSerializerTest.java
b/core-metadata/src/test/java/org/apache/kylin/measure/topn/DoubleDeltaSerializerTest.java
index e979791df5..30b2e56711 100644
---
a/core-metadata/src/test/java/org/apache/kylin/measure/topn/DoubleDeltaSerializerTest.java
+++
b/core-metadata/src/test/java/org/apache/kylin/measure/topn/DoubleDeltaSerializerTest.java
@@ -67,7 +67,8 @@ public void testRandom() {
for (int i = 0; i < n; i++) {
nums[i] = rand.nextDouble() * 100;
}
-Arrays.sort(nums);
+
+Arrays.parallelSort(nums);
buf.clear();
dds.serialize(nums, buf);
@@ -86,7 +87,8 @@ public void testRandom2() {
for (int i = 0; i < n; i++) {
nums[i] = rand.nextInt();
}
-Arrays.sort(nums);
+
+Arrays.parallelSort(nums);
buf.clear();
dds.serialize(nums, buf);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls edited a comment on issue #350: Fix issue : KYLIN-3631
coveralls edited a comment on issue #350: Fix issue : KYLIN-3631 URL: https://github.com/apache/kylin/pull/350#issuecomment-439873914 ## Pull Request Test Coverage Report for [Build 3860](https://coveralls.io/builds/20193220) * **1** of **2** **(50.0%)** changed or added relevant lines in **2** files are covered. * **7** unchanged lines in **3** files lost coverage. * Overall coverage decreased (**-0.003%**) to **25.913%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-metadata/src/main/java/org/apache/kylin/metadata/model/Segments.java](https://coveralls.io/builds/20193220/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FSegments.java#L223) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/20193220/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/20193220/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/20193220/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 4 | 78.12% | | Totals | [](https://coveralls.io/builds/20193220) | | :-- | --: | | Change from base [Build 3853](https://coveralls.io/builds/20137109): | -0.003% | | Covered Lines: | 17645 | | Relevant Lines: | 68093 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #351: KYLIN-3290 Leverage getDecalredConstructor().newInstance() instead of newInstance()
codecov-io commented on issue #351: KYLIN-3290 Leverage getDecalredConstructor().newInstance() instead of newInstance() URL: https://github.com/apache/kylin/pull/351#issuecomment-440175653 # [Codecov](https://codecov.io/gh/apache/kylin/pull/351?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@dca3ee7`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `50%`. [](https://codecov.io/gh/apache/kylin/pull/351?src=pr=tree) ```diff @@Coverage Diff@@ ## master #351 +/- ## = Coverage ? 23.61% Complexity? 4826 = Files ? 1133 Lines ?68102 Branches ? 9659 = Hits ?16080 Misses?50457 Partials ? 1565 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/351?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...va/org/apache/kylin/dict/DictionarySerializer.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L0RpY3Rpb25hcnlTZXJpYWxpemVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...n/java/org/apache/kylin/dict/NumberDictionary.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlckRpY3Rpb25hcnkuamF2YQ==) | `22.22% <0%> (ø)` | `2 <0> (?)` | | | [...g/apache/kylin/query/relnode/OLAPAggregateRel.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvT0xBUEFnZ3JlZ2F0ZVJlbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../apache/kylin/dict/global/GlobalDictHDFSStore.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2dsb2JhbC9HbG9iYWxEaWN0SERGU1N0b3JlLmphdmE=) | `70.44% <100%> (ø)` | `18 <0> (?)` | | | [...n/java/org/apache/kylin/common/util/ClassUtil.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0NsYXNzVXRpbC5qYXZh) | `51.66% <100%> (ø)` | `9 <1> (?)` | | | [...va/org/apache/kylin/dict/TrieDictionaryForest.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L1RyaWVEaWN0aW9uYXJ5Rm9yZXN0LmphdmE=) | `87.32% <100%> (ø)` | `62 <0> (?)` | | | [...ain/java/org/apache/kylin/dict/TrieDictionary.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L1RyaWVEaWN0aW9uYXJ5LmphdmE=) | `73.02% <100%> (ø)` | `57 <1> (?)` | | | [.../java/org/apache/kylin/dict/NumberDictionary2.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlckRpY3Rpb25hcnkyLmphdmE=) | `71.42% <100%> (ø)` | `2 <0> (?)` | | | [...rg/apache/kylin/dict/DictionaryInfoSerializer.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L0RpY3Rpb25hcnlJbmZvU2VyaWFsaXplci5qYXZh) | `56.66% <20%> (ø)` | `5 <0> (?)` | | | [...n/java/org/apache/kylin/query/QueryConnection.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L1F1ZXJ5Q29ubmVjdGlvbi5qYXZh) | `83.33% <50%> (ø)` | `3 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/351?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/351?src=pr=footer). Last update [dca3ee7...fe29b71](https://codecov.io/gh/apache/kylin/pull/351?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With
[GitHub] shaofengshi closed pull request #351: KYLIN-3290 Leverage getDecalredConstructor().newInstance() instead of newInstance()
shaofengshi closed pull request #351: KYLIN-3290 Leverage
getDecalredConstructor().newInstance() instead of newInstance()
URL: https://github.com/apache/kylin/pull/351
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-common/src/main/java/org/apache/kylin/common/util/ClassUtil.java
b/core-common/src/main/java/org/apache/kylin/common/util/ClassUtil.java
index cd78fe0e01..5019b21053 100644
--- a/core-common/src/main/java/org/apache/kylin/common/util/ClassUtil.java
+++ b/core-common/src/main/java/org/apache/kylin/common/util/ClassUtil.java
@@ -85,7 +85,7 @@ private static String forRenamedClass(String name) {
public static Object newInstance(String clz) {
try {
-return forName(clz, Object.class).newInstance();
+return forName(clz,
Object.class).getDeclaredConstructor().newInstance();
} catch (Exception e) {
throw new RuntimeException(e);
}
diff --git
a/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryInfoSerializer.java
b/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryInfoSerializer.java
index ee88ea7cb3..96d34a1439 100644
---
a/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryInfoSerializer.java
+++
b/core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryInfoSerializer.java
@@ -21,6 +21,7 @@
import java.io.DataInputStream;
import java.io.DataOutputStream;
import java.io.IOException;
+import java.lang.reflect.InvocationTargetException;
import org.apache.kylin.common.persistence.Serializer;
import org.apache.kylin.common.util.ClassUtil;
@@ -63,14 +64,19 @@ public DictionaryInfo deserialize(DataInputStream in)
throws IOException {
if (infoOnly == false) {
Dictionary dict;
try {
-dict = (Dictionary)
ClassUtil.forName(obj.getDictionaryClass(), Dictionary.class).newInstance();
+dict = (Dictionary)
ClassUtil.forName(obj.getDictionaryClass(),
Dictionary.class).getDeclaredConstructor().newInstance();
} catch (InstantiationException e) {
throw new RuntimeException(e);
} catch (IllegalAccessException e) {
throw new RuntimeException(e);
} catch (ClassNotFoundException e) {
throw new RuntimeException(e);
+} catch (NoSuchMethodException e) {
+throw new RuntimeException(e);
+} catch (InvocationTargetException e) {
+throw new RuntimeException(e);
}
+
dict.readFields(in);
obj.setDictionaryObject(dict);
}
diff --git
a/core-dictionary/src/main/java/org/apache/kylin/dict/DictionarySerializer.java
b/core-dictionary/src/main/java/org/apache/kylin/dict/DictionarySerializer.java
index 72dc9953c3..23f2b88608 100644
---
a/core-dictionary/src/main/java/org/apache/kylin/dict/DictionarySerializer.java
+++
b/core-dictionary/src/main/java/org/apache/kylin/dict/DictionarySerializer.java
@@ -41,7 +41,7 @@ private DictionarySerializer() {
try {
final DataInputStream dataInputStream = new
DataInputStream(inputStream);
final String type = dataInputStream.readUTF();
-final Dictionary dictionary = ClassUtil.forName(type,
Dictionary.class).newInstance();
+final Dictionary dictionary = ClassUtil.forName(type,
Dictionary.class).getDeclaredConstructor().newInstance();
dictionary.readFields(dataInputStream);
return dictionary;
} catch (Exception e) {
diff --git
a/core-dictionary/src/main/java/org/apache/kylin/dict/NumberDictionary.java
b/core-dictionary/src/main/java/org/apache/kylin/dict/NumberDictionary.java
index 1377e8ef13..8e5979289d 100644
--- a/core-dictionary/src/main/java/org/apache/kylin/dict/NumberDictionary.java
+++ b/core-dictionary/src/main/java/org/apache/kylin/dict/NumberDictionary.java
@@ -49,7 +49,7 @@ protected boolean isNullObjectForm(T value) {
@Override
protected void setConverterByName(String converterName) throws Exception {
converterName = "org.apache.kylin.dict.Number2BytesConverter";
-this.bytesConvert = ClassUtil.forName(converterName,
BytesConverter.class).newInstance();
+this.bytesConvert = ClassUtil.forName(converterName,
BytesConverter.class).getDeclaredConstructor().newInstance();
((Number2BytesConverter)this.bytesConvert).setMaxDigitsBeforeDecimalPoint(Number2BytesConverter.MAX_DIGITS_BEFORE_DECIMAL_POINT_LEGACY);
}
diff --git
a/core-dictionary/src/main/java/org/apache/kylin/dict/NumberDictionary2.java
b/core-dictionary/src/main/java/org/apache/kylin/dict/NumberDictionary2.java
index 0efe9362ca..24700ca48d 100644
---
[GitHub] whuwb opened a new pull request #351: KYLIN-3290 Leverage getDecalredConstructor().newInstance() instead of newInstance()
whuwb opened a new pull request #351: KYLIN-3290 Leverage getDecalredConstructor().newInstance() instead of newInstance() URL: https://github.com/apache/kylin/pull/351 Issue : https://issues.apache.org/jira/browse/KYLIN-3290 How to fix : Leverage getDecalredConstructor().newInstance() instead of newInstance() This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #351: KYLIN-3290 Leverage getDecalredConstructor().newInstance() instead of newInstance()
asfgit commented on issue #351: KYLIN-3290 Leverage getDecalredConstructor().newInstance() instead of newInstance() URL: https://github.com/apache/kylin/pull/351#issuecomment-440170481 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi closed pull request #347: KYLIN-3666 HDFS metadata url not be recognized
shaofengshi closed pull request #347: KYLIN-3666 HDFS metadata url not be
recognized
URL: https://github.com/apache/kylin/pull/347
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java
b/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java
index 6a9158d609..0624f94dc7 100644
---
a/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java
+++
b/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java
@@ -490,7 +490,14 @@ public static KylinConfig loadKylinPropsAndMetadata()
throws IOException {
public static KylinConfig
loadKylinConfigFromHdfs(SerializableConfiguration conf, String uri) {
HadoopUtil.setCurrentConfiguration(conf.get());
-return loadKylinConfigFromHdfs(uri);
+KylinConfig config = loadKylinConfigFromHdfs(uri);
+
+// This is a bad example where the thread local KylinConfig cannot be
auto-closed due to
+// limitation of MR API. It works because MR task runs its own
process. Do not copy.
+@SuppressWarnings("unused")
+SetAndUnsetThreadLocalConfig shouldAutoClose =
KylinConfig.setAndUnsetThreadLocalConfig(config);
+
+return config;
}
public static KylinConfig loadKylinConfigFromHdfs(String uri) {
@@ -517,11 +524,7 @@ public static KylinConfig loadKylinConfigFromHdfs(String
uri) {
} catch (IOException e) {
throw new RuntimeException(e);
}
-
-// This is a bad example where the thread local KylinConfig cannot be
auto-closed due to
-// limitation of MR API. It works because MR task runs its own
process. Do not copy.
-@SuppressWarnings("unused")
-SetAndUnsetThreadLocalConfig shouldAutoClose =
KylinConfig.setAndUnsetThreadLocalConfig(config);
+
kylinConfigCache.put(uri, config);
return config;
}
diff --git
a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/UpdateDictionaryStep.java
b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/UpdateDictionaryStep.java
index bcdb29f52c..28c567a7d0 100644
---
a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/UpdateDictionaryStep.java
+++
b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/UpdateDictionaryStep.java
@@ -43,6 +43,7 @@
import org.apache.kylin.cube.CubeUpdate;
import org.apache.kylin.dict.DictionaryInfo;
import org.apache.kylin.dict.DictionaryManager;
+import org.apache.kylin.engine.mr.common.AbstractHadoopJob;
import org.apache.kylin.engine.mr.common.BatchConstants;
import org.apache.kylin.job.exception.ExecuteException;
import org.apache.kylin.job.execution.AbstractExecutable;
@@ -67,7 +68,7 @@ protected ExecuteResult doWork(ExecutableContext context)
throws ExecuteExceptio
final String metadataUrl =
this.getParams().get(BatchConstants.ARG_META_URL);
final KylinConfig kylinConfHbase = cube.getConfig();
-final KylinConfig kylinConfHdfs =
KylinConfig.createInstanceFromUri(metadataUrl);
+final KylinConfig kylinConfHdfs =
AbstractHadoopJob.loadKylinConfigFromHdfs(metadataUrl);
Collections.sort(mergingSegments);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] asfgit commented on issue #355: detailed configurations could be override in the Cube-level
asfgit commented on issue #355: detailed configurations could be override in the Cube-level URL: https://github.com/apache/kylin/pull/355#issuecomment-440662329 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DingqianZhou opened a new pull request #355: detailed configurations could be override in the Cube-level
DingqianZhou opened a new pull request #355: detailed configurations could be override in the Cube-level URL: https://github.com/apache/kylin/pull/355 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #360: [KYLIN-3665]-Partition time column may never be added fixed.
coveralls commented on issue #360: [KYLIN-3665]-Partition time column may never be added fixed. URL: https://github.com/apache/kylin/pull/360#issuecomment-441565049 ## Pull Request Test Coverage Report for [Build 3883](https://coveralls.io/builds/20286362) * **10** of **14** **(71.43%)** changed or added relevant lines in **1** file are covered. * **1** unchanged line in **1** file lost coverage. * Overall coverage increased (+**0.002%**) to **25.918%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-metadata/src/main/java/org/apache/kylin/metadata/model/PartitionDesc.java](https://coveralls.io/builds/20286362/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FPartitionDesc.java#L203) | 10 | 14 | 71.43% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/20286362/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553) | 1 | 78.12% | | Totals | [](https://coveralls.io/builds/20286362) | | :-- | --: | | Change from base [Build 3871](https://coveralls.io/builds/20236865): | 0.002% | | Covered Lines: | 17652 | | Relevant Lines: | 68107 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi closed pull request #357: KYLIN-3694 Bug fix and revert guava version
shaofengshi closed pull request #357: KYLIN-3694 Bug fix and revert guava
version
URL: https://github.com/apache/kylin/pull/357
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/assembly/pom.xml b/assembly/pom.xml
index 6dfe165cbe..1e546cb313 100644
--- a/assembly/pom.xml
+++ b/assembly/pom.xml
@@ -34,11 +34,6 @@
-
-com.google.guava
-guava
-compile
-
org.apache.kylin
kylin-source-hive
@@ -228,10 +223,6 @@
org.apache.commons.jocl
${shadeBase}.org.apache.commons.jocl
-
-com.google.guava
-
${shadeBase}.com.google.guava
-
diff --git
a/core-cube/src/main/java/org/apache/kylin/cube/util/CubingUtils.java
b/core-cube/src/main/java/org/apache/kylin/cube/util/CubingUtils.java
index 8f4a1f6919..f78e92b530 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/util/CubingUtils.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/util/CubingUtils.java
@@ -87,7 +87,7 @@
Hasher hc = hf.newHasher();
final String cell =
row.get(flatDesc.getRowKeyColumnIndexes()[i]);
if (cell != null) {
-row_hashcodes[i] =
hc.putUnencodedChars(cell).hash().asBytes();
+row_hashcodes[i] = hc.putString(cell).hash().asBytes();
} else {
row_hashcodes[i] = hc.putInt(0).hash().asBytes();
}
diff --git
a/core-cube/src/test/java/org/apache/kylin/cube/cuboid/algorithm/CuboidStatsUtilTest.java
b/core-cube/src/test/java/org/apache/kylin/cube/cuboid/algorithm/CuboidStatsUtilTest.java
index b9fb9841e1..c3642cb22d 100644
---
a/core-cube/src/test/java/org/apache/kylin/cube/cuboid/algorithm/CuboidStatsUtilTest.java
+++
b/core-cube/src/test/java/org/apache/kylin/cube/cuboid/algorithm/CuboidStatsUtilTest.java
@@ -147,7 +147,7 @@ public void createDirectChildrenCacheTest() {
@Test
public void createDirectChildrenCacheStressTest() {
-Stopwatch sw = Stopwatch.createStarted();
+Stopwatch sw = new Stopwatch();
Set cuboidSet = generateMassCuboidSet();
System.out.println("Time elapsed for creating sorted cuboid list: " +
sw.elapsed(TimeUnit.MILLISECONDS));
sw.reset();
diff --git
a/core-cube/src/test/java/org/apache/kylin/gridtable/AggregationCacheMemSizeTest.java
b/core-cube/src/test/java/org/apache/kylin/gridtable/AggregationCacheMemSizeTest.java
index 81fe71f9f6..0e15687d7f 100644
---
a/core-cube/src/test/java/org/apache/kylin/gridtable/AggregationCacheMemSizeTest.java
+++
b/core-cube/src/test/java/org/apache/kylin/gridtable/AggregationCacheMemSizeTest.java
@@ -167,7 +167,8 @@ public void testEstimateBitmapMemSize() {
}
}
-@Test
+// Ignore because of OOM
+// @Test
public void testEstimateMemSize() throws InterruptedException {
int scale = Integer.parseInt(System.getProperty("scale", "1"));
scale = Math.max(1, Math.min(10, scale));
diff --git
a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CalculateStatsFromBaseCuboidMapper.java
b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CalculateStatsFromBaseCuboidMapper.java
index 0814281d87..1b32944228 100644
---
a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CalculateStatsFromBaseCuboidMapper.java
+++
b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CalculateStatsFromBaseCuboidMapper.java
@@ -146,7 +146,7 @@ public void putRowKeyToHLLOld(String[] row) {
Hasher hc = hf.newHasher();
String colValue = row[i];
if (colValue != null) {
-rowHashCodes[i] =
hc.putUnencodedChars(colValue).hash().asBytes();
+rowHashCodes[i] = hc.putString(colValue).hash().asBytes();
} else {
rowHashCodes[i] = hc.putInt(0).hash().asBytes();
}
@@ -170,7 +170,7 @@ private void putRowKeyToHLLNew(String[] row) {
String colValue = row[i];
if (colValue == null)
colValue = "0";
-byte[] bytes = hc.putUnencodedChars(colValue).hash().asBytes();
+byte[] bytes = hc.putString(colValue).hash().asBytes();
rowHashCodesLong[i] = (Bytes.toLong(bytes) + i);//add column
ordinal to the hash value to distinguish between (a,b) and (b,a)
}
diff --git
[GitHub] FrancisLiang opened a new pull request #360: [KYLIN-3665]-Partition time column may never be added fixed.
FrancisLiang opened a new pull request #360: [KYLIN-3665]-Partition time column may never be added fixed. URL: https://github.com/apache/kylin/pull/360 Fixed [KYLIN-3665]: Partition time column may never be added. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #360: [KYLIN-3665]-Partition time column may never be added fixed.
asfgit commented on issue #360: [KYLIN-3665]-Partition time column may never be added fixed. URL: https://github.com/apache/kylin/pull/360#issuecomment-441558684 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi closed pull request #358: KYLIN-3559 Use Splitter for splitting String
shaofengshi closed pull request #358: KYLIN-3559 Use Splitter for splitting
String
URL: https://github.com/apache/kylin/pull/358
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-common/src/main/java/org/apache/kylin/common/util/StringUtil.java
b/core-common/src/main/java/org/apache/kylin/common/util/StringUtil.java
index 84c1da5919..4fc37c9154 100644
--- a/core-common/src/main/java/org/apache/kylin/common/util/StringUtil.java
+++ b/core-common/src/main/java/org/apache/kylin/common/util/StringUtil.java
@@ -22,6 +22,9 @@
import java.util.Collection;
import java.util.Locale;
+
+import com.google.common.base.Splitter;
+import com.google.common.collect.Iterables;
import org.apache.commons.lang.StringUtils;
/**
@@ -159,14 +162,17 @@ public static void appendWithSeparator(StringBuilder src,
String append) {
}
public static String[] splitAndTrim(String str, String splitBy) {
-String[] split = str.split(splitBy);
-ArrayList r = new ArrayList<>(split.length);
-for (String s : split) {
-s = s.trim();
-if (!s.isEmpty())
-r.add(s);
-}
-return r.toArray(new String[r.size()]);
+Splitter splitterWithTrim =
Splitter.on(splitBy).trimResults().omitEmptyStrings();
+
+return Iterables.toArray(splitterWithTrim.split(str), String.class);
+}
+
+public static String[] split(String str, String splitBy) {
+return Iterables.toArray(Splitter.on(splitBy).split(str),
String.class);
+}
+
+public static String[] splitByComma(String str) {
+return split(str, ",");
}
// calculating length in UTF-8 of Java String without actually encoding it
diff --git
a/core-common/src/test/java/org/apache/kylin/common/util/StringUtilTest.java
b/core-common/src/test/java/org/apache/kylin/common/util/StringUtilTest.java
new file mode 100644
index 00..88ed9d84a8
--- /dev/null
+++ b/core-common/src/test/java/org/apache/kylin/common/util/StringUtilTest.java
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kylin.common.util;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class StringUtilTest {
+@Test
+public void splitTest() {
+String normalText = "Try to make the code better";
+String[] expected = new String[] { "Try", "to", "make", "the", "code",
"better" };
+Assert.assertArrayEquals(expected, StringUtil.split(normalText, " "));
+
+// case in http://errorprone.info/bugpattern/StringSplitter
+expected = new String[] { "" };
+Assert.assertArrayEquals(expected, StringUtil.split("", ":"));
+
+expected = new String[] { "", "" };
+Assert.assertArrayEquals(expected, StringUtil.split(":", ":"));
+
+expected = new String[] { "1", "2" };
+Assert.assertArrayEquals(expected, StringUtil.split("1<|>2", "<|>"));
+}
+
+@Test
+public void splitAndTrimTest() {
+String[] expected = new String[] { "foo", "bar" };
+Assert.assertArrayEquals(expected, StringUtil.splitAndTrim(" foo...
bar. ", "."));
+}
+
+@Test
+public void splitByCommaTest() {
+String[] expected = new String[] { "Hello", "Kylin" };
+Assert.assertArrayEquals(expected,
StringUtil.splitByComma("Hello,Kylin"));
+}
+}
diff --git
a/core-cube/src/main/java/org/apache/kylin/cube/cli/CubeSignatureRefresher.java
b/core-cube/src/main/java/org/apache/kylin/cube/cli/CubeSignatureRefresher.java
index 2eaebb1a9a..b149f11dec 100644
---
a/core-cube/src/main/java/org/apache/kylin/cube/cli/CubeSignatureRefresher.java
+++
b/core-cube/src/main/java/org/apache/kylin/cube/cli/CubeSignatureRefresher.java
@@ -24,6 +24,7 @@
import org.apache.commons.lang.ArrayUtils;
import org.apache.kylin.common.KylinConfig;
import org.apache.kylin.common.persistence.ResourceStore;
+import org.apache.kylin.common.util.StringUtil;
import org.apache.kylin.cube.CubeDescManager;
[GitHub] shaofengshi closed pull request #344: #KYLIN-3684, HIVE_LIB is not set or not resolved correctly
shaofengshi closed pull request #344: #KYLIN-3684, HIVE_LIB is not set or not
resolved correctly
URL: https://github.com/apache/kylin/pull/344
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build/bin/find-hive-dependency.sh
b/build/bin/find-hive-dependency.sh
index a8793ebb3c..558c9b583c 100755
--- a/build/bin/find-hive-dependency.sh
+++ b/build/bin/find-hive-dependency.sh
@@ -37,6 +37,17 @@ else
hive_env=`hive ${hive_conf_properties} -e set 2>&1 | grep 'env:CLASSPATH'`
fi
+if [ -z $hive_env ]
+then
+hive_permission=`hive ${hive_conf_properties} -e set 2>&1 | grep 'No valid
credentials provided'`
+if [ -n "$hive_permission" ]
+then
+quit "No valid credentials provided for Hive CLI, please check
permission of hive. (e.g. check if Kerberos is expired or not)"
+else
+quit "Something wrong with Hive CLI or Beeline, please execute Hive
CLI or Beeline CLI in terminal to find the root cause."
+fi
+fi
+
hive_classpath=`echo $hive_env | grep 'env:CLASSPATH' | awk -F '=' '{print
$2}'`
arr=(`echo $hive_classpath | cut -d ":" -f 1- | sed 's/:/ /g'`)
hive_conf_path=
@@ -73,6 +84,11 @@ then
quit "Couldn't find hive configuration directory. Please set HIVE_CONF to
the path which contains hive-site.xml."
fi
+if [ -z "$hive_exec_path" ]
+then
+quit "Couldn't find hive executable jar. Please check if hive executable
jar exists in HIVE_LIB folder."
+fi
+
# in some versions of hive hcatalog is not in hive's classpath, find it
separately
if [ -z "$HCAT_HOME" ]
then
@@ -89,7 +105,7 @@ then
elif [ -n is_aws ] && [ -d "/usr/lib/hive-hcatalog" ]; then
# special handling for Amazon EMR
hcatalog_home=/usr/lib/hive-hcatalog
-else
+else
quit "Couldn't locate hcatalog installation, please make sure it is
installed and set HCAT_HOME to the path."
fi
else
@@ -106,7 +122,27 @@ fi
function checkFileExist()
{
-files=(`echo $1 | cut -d ":" -f 1- | sed 's/:/ /g'`)
+msg_hint=""
+if [ "$1" == "hive_lib" ]
+then
+msg_hint=", please check jar files in current HIVE_LIB or export
HIVE_LIB='YOUR_LOCAL_HIVE_LIB'"
+elif [ "$1" == "hcatalog" ]
+then
+msg_hint=", please check jar files in current HCAT_HOME or export
HCAT_HOME='YOUR_LOCAL_HCAT_HOME'"
+fi
+
+if [ -z "$2" ]
+then
+if [ "$1" == "hive_lib" ]
+then
+quit "Current HIVE_LIB is not valid, please export
HIVE_LIB='YOUR_LOCAL_HIVE_LIB'"
+elif [ "$1" == "hcatalog" ]
+then
+quit "Current HCAT_HOME is not valid, please export
HCAT_HOME='YOUR_LOCAL_HCAT_HOME'"
+fi
+fi
+
+files=(`echo $2 | cut -d ":" -f 1- | sed 's/:/ /g'`)
misFiles=0
outputMissFiles=
for file in ${files}
@@ -119,7 +155,7 @@ function checkFileExist()
done
if [ 0 != ${misFiles} ]; then
times=`expr ${allFiles} / ${misFiles}`
-[[ ${times} -gt 10 ]] || quit "A couple of hive jars can't be found:
${outputMisFiles}, please export HIVE_LIB='YOUR_LOCAL_HIVE_LIB'"
+[[ ${times} -gt 10 ]] || quit "A couple of hive jars can't be found:
${outputMisFiles}${msg_hint}"
fi
}
@@ -146,15 +182,20 @@ function validateDirectory()
if [ -z "$HIVE_LIB" ]
then
verbose "HIVE_LIB is not set, try to retrieve hive lib from hive_exec_path"
-hive_lib_dir="$(dirname $hive_exec_path)"
+if [[ $hive_exec_path =~ ^\/.*hive.*\/lib\/hive-exec[a-z0-9A-Z\.-]*.jar ]]
+then
+hive_lib_dir="$(dirname $hive_exec_path)"
+else
+quit "HIVE_LIB not found, please check hive installation or export
HIVE_LIB='YOUR_LOCAL_HIVE_LIB'."
+fi
else
hive_lib_dir="$HIVE_LIB"
fi
hive_lib=`find -L ${hive_lib_dir} -name '*.jar' ! -name '*druid*' ! -name
'*slf4j*' ! -name '*avatica*' ! -name '*calcite*' ! -name
'*jackson-datatype-joda*' ! -name '*derby*' -printf '%p:' | sed 's/:$//'`
validateDirectory ${hive_conf_path}
-checkFileExist ${hive_lib}
-checkFileExist ${hcatalog}
+checkFileExist hive_lib ${hive_lib}
+checkFileExist hcatalog ${hcatalog}
hive_dependency=${hive_conf_path}:${hive_lib}:${hcatalog}
verbose "hive dependency is $hive_dependency"
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] shaofengshi commented on issue #349: KYLIN-3694 Kylin On Druid Storage
shaofengshi commented on issue #349: KYLIN-3694 Kylin On Druid Storage URL: https://github.com/apache/kylin/pull/349#issuecomment-441596761 This is not needed now, let's use the "kylin_on_druid" branch to stage the changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vaful opened a new pull request #361: KYLIN-3704 upgrade calcite version to 1.16.0-kylin-r2 version
vaful opened a new pull request #361: KYLIN-3704 upgrade calcite version to 1.16.0-kylin-r2 version URL: https://github.com/apache/kylin/pull/361 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #361: KYLIN-3704 upgrade calcite version to 1.16.0-kylin-r2 version
asfgit commented on issue #361: KYLIN-3704 upgrade calcite version to 1.16.0-kylin-r2 version URL: https://github.com/apache/kylin/pull/361#issuecomment-441600947 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi closed pull request #363: KYLIN-3597 fix static code issues
shaofengshi closed pull request #363: KYLIN-3597 fix static code issues
URL: https://github.com/apache/kylin/pull/363
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core-common/src/main/java/org/apache/kylin/common/util/Bytes.java
b/core-common/src/main/java/org/apache/kylin/common/util/Bytes.java
index 33fc31a987..a2679219f3 100644
--- a/core-common/src/main/java/org/apache/kylin/common/util/Bytes.java
+++ b/core-common/src/main/java/org/apache/kylin/common/util/Bytes.java
@@ -41,7 +41,6 @@
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
-
import sun.misc.Unsafe;
/**
@@ -116,6 +115,7 @@
// JHat says BU is 56 bytes.
// SizeOf which uses java.lang.instrument says 24 bytes. (3 longs?)
public static final int ESTIMATED_HEAP_TAX = 16;
+public static final String LENGTH_MUST_BE_GREATER_THAN_0 = "length must be
greater than 0";
/**
* Returns length of the byte array, returning 0 if the array is null.
@@ -491,7 +491,7 @@ public static int putLong(byte[] bytes, int offset, long
val) {
* @return incremented offset
*/
public static int putLongUnsafe(byte[] bytes, int offset, long val) {
-if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.littleEndian)
{
+if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.LITTLEENDIAN)
{
val = Long.reverseBytes(val);
}
org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.theUnsafe.putLong(bytes,
@@ -652,7 +652,7 @@ public static int toInt(byte[] bytes, int offset, final int
length) {
* @return the int value
*/
public static int toIntUnsafe(byte[] bytes, int offset) {
-if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.littleEndian)
{
+if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.LITTLEENDIAN)
{
return Integer.reverseBytes(
org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.theUnsafe
.getInt(bytes, (long) offset
@@ -672,7 +672,7 @@ public static int toIntUnsafe(byte[] bytes, int offset) {
* @return the short value
*/
public static short toShortUnsafe(byte[] bytes, int offset) {
-if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.littleEndian)
{
+if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.LITTLEENDIAN)
{
return Short.reverseBytes(
org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.theUnsafe
.getShort(bytes, (long) offset
@@ -692,7 +692,7 @@ public static short toShortUnsafe(byte[] bytes, int offset)
{
* @return the long value
*/
public static long toLongUnsafe(byte[] bytes, int offset) {
-if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.littleEndian)
{
+if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.LITTLEENDIAN)
{
return Long.reverseBytes(
org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.theUnsafe
.getLong(bytes, (long) offset
@@ -763,7 +763,7 @@ public static int putInt(byte[] bytes, int offset, int val)
{
* @return incremented offset
*/
public static int putIntUnsafe(byte[] bytes, int offset, int val) {
-if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.littleEndian)
{
+if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.LITTLEENDIAN)
{
val = Integer.reverseBytes(val);
}
org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.theUnsafe.putInt(bytes,
@@ -880,7 +880,7 @@ public static int putShort(byte[] bytes, int offset, short
val) {
* @return incremented offset
*/
public static int putShortUnsafe(byte[] bytes, int offset, short val) {
-if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.littleEndian)
{
+if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.LITTLEENDIAN)
{
val = Short.reverseBytes(val);
}
org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.theUnsafe.putShort(bytes,
@@ -1097,7 +1097,7 @@ public Object run() {
}
}
-static final
[GitHub] shaofengshi closed pull request #364: KYLIN-3559 Use Splitter for splitting String
shaofengshi closed pull request #364: KYLIN-3559 Use Splitter for splitting
String
URL: https://github.com/apache/kylin/pull/364
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-common/src/main/java/org/apache/kylin/common/util/StringUtil.java
b/core-common/src/main/java/org/apache/kylin/common/util/StringUtil.java
index 84c1da5919..4fc37c9154 100644
--- a/core-common/src/main/java/org/apache/kylin/common/util/StringUtil.java
+++ b/core-common/src/main/java/org/apache/kylin/common/util/StringUtil.java
@@ -22,6 +22,9 @@
import java.util.Collection;
import java.util.Locale;
+
+import com.google.common.base.Splitter;
+import com.google.common.collect.Iterables;
import org.apache.commons.lang.StringUtils;
/**
@@ -159,14 +162,17 @@ public static void appendWithSeparator(StringBuilder src,
String append) {
}
public static String[] splitAndTrim(String str, String splitBy) {
-String[] split = str.split(splitBy);
-ArrayList r = new ArrayList<>(split.length);
-for (String s : split) {
-s = s.trim();
-if (!s.isEmpty())
-r.add(s);
-}
-return r.toArray(new String[r.size()]);
+Splitter splitterWithTrim =
Splitter.on(splitBy).trimResults().omitEmptyStrings();
+
+return Iterables.toArray(splitterWithTrim.split(str), String.class);
+}
+
+public static String[] split(String str, String splitBy) {
+return Iterables.toArray(Splitter.on(splitBy).split(str),
String.class);
+}
+
+public static String[] splitByComma(String str) {
+return split(str, ",");
}
// calculating length in UTF-8 of Java String without actually encoding it
diff --git
a/core-common/src/test/java/org/apache/kylin/common/util/StringUtilTest.java
b/core-common/src/test/java/org/apache/kylin/common/util/StringUtilTest.java
new file mode 100644
index 00..88ed9d84a8
--- /dev/null
+++ b/core-common/src/test/java/org/apache/kylin/common/util/StringUtilTest.java
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kylin.common.util;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class StringUtilTest {
+@Test
+public void splitTest() {
+String normalText = "Try to make the code better";
+String[] expected = new String[] { "Try", "to", "make", "the", "code",
"better" };
+Assert.assertArrayEquals(expected, StringUtil.split(normalText, " "));
+
+// case in http://errorprone.info/bugpattern/StringSplitter
+expected = new String[] { "" };
+Assert.assertArrayEquals(expected, StringUtil.split("", ":"));
+
+expected = new String[] { "", "" };
+Assert.assertArrayEquals(expected, StringUtil.split(":", ":"));
+
+expected = new String[] { "1", "2" };
+Assert.assertArrayEquals(expected, StringUtil.split("1<|>2", "<|>"));
+}
+
+@Test
+public void splitAndTrimTest() {
+String[] expected = new String[] { "foo", "bar" };
+Assert.assertArrayEquals(expected, StringUtil.splitAndTrim(" foo...
bar. ", "."));
+}
+
+@Test
+public void splitByCommaTest() {
+String[] expected = new String[] { "Hello", "Kylin" };
+Assert.assertArrayEquals(expected,
StringUtil.splitByComma("Hello,Kylin"));
+}
+}
diff --git
a/core-cube/src/main/java/org/apache/kylin/cube/cli/CubeSignatureRefresher.java
b/core-cube/src/main/java/org/apache/kylin/cube/cli/CubeSignatureRefresher.java
index 2eaebb1a9a..b149f11dec 100644
---
a/core-cube/src/main/java/org/apache/kylin/cube/cli/CubeSignatureRefresher.java
+++
b/core-cube/src/main/java/org/apache/kylin/cube/cli/CubeSignatureRefresher.java
@@ -24,6 +24,7 @@
import org.apache.commons.lang.ArrayUtils;
import org.apache.kylin.common.KylinConfig;
import org.apache.kylin.common.persistence.ResourceStore;
+import org.apache.kylin.common.util.StringUtil;
import org.apache.kylin.cube.CubeDescManager;
[GitHub] coveralls commented on issue #362: KYLIN-3700 Quote sql identities when creating flat table
coveralls commented on issue #362: KYLIN-3700 Quote sql identities when creating flat table URL: https://github.com/apache/kylin/pull/362#issuecomment-442330731 ## Pull Request Test Coverage Report for [Build 3896](https://coveralls.io/builds/20329464) * **72** of **244** **(29.51%)** changed or added relevant lines in **15** files are covered. * **6** unchanged lines in **3** files lost coverage. * Overall coverage decreased (**-0.006%**) to **25.941%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-metadata/src/main/java/org/apache/kylin/metadata/model/TableRef.java](https://coveralls.io/builds/20329464/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FTableRef.java#L72) | 0 | 1 | 0.0% | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/JdbcConnector.java](https://coveralls.io/builds/20329464/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2FJdbcConnector.java#L89) | 2 | 3 | 66.67% | [source-hive/src/main/java/org/apache/kylin/source/hive/GarbageCollectionStep.java](https://coveralls.io/builds/20329464/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FGarbageCollectionStep.java#L67) | 0 | 1 | 0.0% | [source-hive/src/main/java/org/apache/kylin/source/hive/HiveInputBase.java](https://coveralls.io/builds/20329464/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FHiveInputBase.java#L121) | 4 | 5 | 80.0% | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/SqlConverter.java](https://coveralls.io/builds/20329464/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2Fconv%2FSqlConverter.java#L75) | 7 | 9 | 77.78% | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/DefaultConfiguer.java](https://coveralls.io/builds/20329464/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2Fconv%2FDefaultConfiguer.java#L132) | 6 | 9 | 66.67% | [core-metadata/src/main/java/org/apache/kylin/metadata/model/TableDesc.java](https://coveralls.io/builds/20329464/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FTableDesc.java#L223) | 0 | 6 | 0.0% | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/ConvSqlWriter.java](https://coveralls.io/builds/20329464/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2Fconv%2FConvSqlWriter.java#L156) | 5 | 12 | 41.67% | [source-jdbc/src/main/java/org/apache/kylin/source/jdbc/JdbcHiveMRInput.java](https://coveralls.io/builds/20329464/source?filename=source-jdbc%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fjdbc%2FJdbcHiveMRInput.java#L160) | 3 | 11 | 27.27% | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/adaptor/AbstractJdbcAdaptor.java](https://coveralls.io/builds/20329464/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fadaptor%2FAbstractJdbcAdaptor.java#L300) | 4 | 18 | 22.22% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/20329464/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553) | 1 | 78.12% | | [core-job/src/main/java/org/apache/kylin/job/JoinedFlatTable.java](https://coveralls.io/builds/20329464/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2FJoinedFlatTable.java#L235) | 2 | 0.0% | | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/adaptor/DefaultAdaptor.java](https://coveralls.io/builds/20329464/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fadaptor%2FDefaultAdaptor.java#L145) | 3 | 35.51% | | Totals | [](https://coveralls.io/builds/20329464) | | :-- | --: | | Change from base [Build 3894](https://coveralls.io/builds/20327415): | -0.006% | | Covered Lines: | 17690 | | Relevant Lines: | 68193 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #362: KYLIN-3700 Quote sql identities when creating flat table
codecov-io edited a comment on issue #362: KYLIN-3700 Quote sql identities when creating flat table URL: https://github.com/apache/kylin/pull/362#issuecomment-441728994 # [Codecov](https://codecov.io/gh/apache/kylin/pull/362?src=pr=h1) Report > Merging [#362](https://codecov.io/gh/apache/kylin/pull/362?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/97ee98bfbd93510b578db93998f2ab488199ef40?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `27.86%`. [](https://codecov.io/gh/apache/kylin/pull/362?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #362 +/- ## - Coverage 23.63% 23.63% -0.01% - Complexity 4828 4838 +10 Files 1130 1131 +1 Lines 6802368193 +170 Branches 9657 9684 +27 + Hits 1607916119 +40 - Misses5037750507 +130 Partials 1567 1567 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/362?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...k/datasource/framework/SourceConnectorFactory.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2ZyYW1ld29yay9Tb3VyY2VDb25uZWN0b3JGYWN0b3J5LmphdmE=) | `57.89% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: | | [...java/org/apache/kylin/metadata/model/TableRef.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvVGFibGVSZWYuamF2YQ==) | `51.16% <0%> (-1.22%)` | `11 <0> (ø)` | | | [...ain/java/org/apache/kylin/job/JoinedFlatTable.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9Kb2luZWRGbGF0VGFibGUuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ava/org/apache/kylin/metadata/model/TableDesc.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvVGFibGVEZXNjLmphdmE=) | `46.01% <0%> (-1.76%)` | `27 <0> (ø)` | | | [...pache/kylin/source/hive/GarbageCollectionStep.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0dhcmJhZ2VDb2xsZWN0aW9uU3RlcC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...a/org/apache/kylin/common/util/HiveCmdBuilder.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hpdmVDbWRCdWlsZGVyLmphdmE=) | `83.33% <100%> (ø)` | `12 <0> (ø)` | :arrow_down: | | [.../kylin/source/jdbc/extensible/JdbcHiveMRInput.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL2V4dGVuc2libGUvSmRiY0hpdmVNUklucHV0LmphdmE=) | `89.79% <100%> (+0.9%)` | `3 <0> (ø)` | :arrow_down: | | [...e/kylin/sdk/datasource/adaptor/DefaultAdaptor.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2FkYXB0b3IvRGVmYXVsdEFkYXB0b3IuamF2YQ==) | `32.71% <19.35%> (-3.38%)` | `12 <1> (ø)` | | | [.../apache/kylin/job/util/FlatTableSqlQuoteUtils.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi91dGlsL0ZsYXRUYWJsZVNxbFF1b3RlVXRpbHMuamF2YQ==) | `21% <21%> (ø)` | `8 <8> (?)` | | | [...in/sdk/datasource/adaptor/AbstractJdbcAdaptor.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2FkYXB0b3IvQWJzdHJhY3RKZGJjQWRhcHRvci5qYXZh) | `51.04% <22.22%> (-3.18%)` | `14 <2> (+1)` | | | ... and [10 more](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/362?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/362?src=pr=footer). Last update [97ee98b...708163d](https://codecov.io/gh/apache/kylin/pull/362?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[GitHub] coveralls edited a comment on issue #362: KYLIN-3700 Quote sql identities when creating flat table
coveralls edited a comment on issue #362: KYLIN-3700 Quote sql identities when creating flat table URL: https://github.com/apache/kylin/pull/362#issuecomment-442330731 ## Pull Request Test Coverage Report for [Build 3897](https://coveralls.io/builds/20329685) * **72** of **244** **(29.51%)** changed or added relevant lines in **15** files are covered. * **6** unchanged lines in **3** files lost coverage. * Overall coverage decreased (**-0.006%**) to **25.941%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-metadata/src/main/java/org/apache/kylin/metadata/model/TableRef.java](https://coveralls.io/builds/20329685/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FTableRef.java#L72) | 0 | 1 | 0.0% | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/JdbcConnector.java](https://coveralls.io/builds/20329685/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2FJdbcConnector.java#L89) | 2 | 3 | 66.67% | [source-hive/src/main/java/org/apache/kylin/source/hive/GarbageCollectionStep.java](https://coveralls.io/builds/20329685/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FGarbageCollectionStep.java#L67) | 0 | 1 | 0.0% | [source-hive/src/main/java/org/apache/kylin/source/hive/HiveInputBase.java](https://coveralls.io/builds/20329685/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FHiveInputBase.java#L121) | 4 | 5 | 80.0% | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/SqlConverter.java](https://coveralls.io/builds/20329685/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2Fconv%2FSqlConverter.java#L75) | 7 | 9 | 77.78% | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/DefaultConfiguer.java](https://coveralls.io/builds/20329685/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2Fconv%2FDefaultConfiguer.java#L132) | 6 | 9 | 66.67% | [core-metadata/src/main/java/org/apache/kylin/metadata/model/TableDesc.java](https://coveralls.io/builds/20329685/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FTableDesc.java#L223) | 0 | 6 | 0.0% | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/ConvSqlWriter.java](https://coveralls.io/builds/20329685/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2Fconv%2FConvSqlWriter.java#L156) | 5 | 12 | 41.67% | [source-jdbc/src/main/java/org/apache/kylin/source/jdbc/JdbcHiveMRInput.java](https://coveralls.io/builds/20329685/source?filename=source-jdbc%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fjdbc%2FJdbcHiveMRInput.java#L160) | 3 | 11 | 27.27% | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/adaptor/AbstractJdbcAdaptor.java](https://coveralls.io/builds/20329685/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fadaptor%2FAbstractJdbcAdaptor.java#L300) | 4 | 18 | 22.22% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/20329685/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [core-job/src/main/java/org/apache/kylin/job/JoinedFlatTable.java](https://coveralls.io/builds/20329685/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2FJoinedFlatTable.java#L235) | 2 | 0.0% | | [datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/adaptor/DefaultAdaptor.java](https://coveralls.io/builds/20329685/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fadaptor%2FDefaultAdaptor.java#L145) | 3 | 35.51% | | Totals | [](https://coveralls.io/builds/20329685) | | :-- | --: | | Change from base [Build 3894](https://coveralls.io/builds/20327415): | -0.006% | | Covered Lines: | 17690 | | Relevant Lines: | 68193 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #362: KYLIN-3700 Quote sql identities when creating flat table
codecov-io edited a comment on issue #362: KYLIN-3700 Quote sql identities when creating flat table URL: https://github.com/apache/kylin/pull/362#issuecomment-441728994 # [Codecov](https://codecov.io/gh/apache/kylin/pull/362?src=pr=h1) Report > Merging [#362](https://codecov.io/gh/apache/kylin/pull/362?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/97ee98bfbd93510b578db93998f2ab488199ef40?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `27.86%`. [](https://codecov.io/gh/apache/kylin/pull/362?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #362 +/- ## - Coverage 23.63% 23.63% -0.01% - Complexity 4828 4837 +9 Files 1130 1131 +1 Lines 6802368193 +170 Branches 9657 9684 +27 + Hits 1607916119 +40 - Misses5037750507 +130 Partials 1567 1567 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/362?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...k/datasource/framework/SourceConnectorFactory.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2ZyYW1ld29yay9Tb3VyY2VDb25uZWN0b3JGYWN0b3J5LmphdmE=) | `57.89% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: | | [...java/org/apache/kylin/metadata/model/TableRef.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvVGFibGVSZWYuamF2YQ==) | `51.16% <0%> (-1.22%)` | `11 <0> (ø)` | | | [...ain/java/org/apache/kylin/job/JoinedFlatTable.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9Kb2luZWRGbGF0VGFibGUuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ava/org/apache/kylin/metadata/model/TableDesc.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvVGFibGVEZXNjLmphdmE=) | `46.01% <0%> (-1.76%)` | `27 <0> (ø)` | | | [...pache/kylin/source/hive/GarbageCollectionStep.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0dhcmJhZ2VDb2xsZWN0aW9uU3RlcC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...a/org/apache/kylin/common/util/HiveCmdBuilder.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hpdmVDbWRCdWlsZGVyLmphdmE=) | `83.33% <100%> (ø)` | `12 <0> (ø)` | :arrow_down: | | [.../kylin/source/jdbc/extensible/JdbcHiveMRInput.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL2V4dGVuc2libGUvSmRiY0hpdmVNUklucHV0LmphdmE=) | `89.79% <100%> (+0.9%)` | `3 <0> (ø)` | :arrow_down: | | [...e/kylin/sdk/datasource/adaptor/DefaultAdaptor.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2FkYXB0b3IvRGVmYXVsdEFkYXB0b3IuamF2YQ==) | `32.71% <19.35%> (-3.38%)` | `12 <1> (ø)` | | | [.../apache/kylin/job/util/FlatTableSqlQuoteUtils.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi91dGlsL0ZsYXRUYWJsZVNxbFF1b3RlVXRpbHMuamF2YQ==) | `21% <21%> (ø)` | `8 <8> (?)` | | | [...in/sdk/datasource/adaptor/AbstractJdbcAdaptor.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2FkYXB0b3IvQWJzdHJhY3RKZGJjQWRhcHRvci5qYXZh) | `51.04% <22.22%> (-3.18%)` | `14 <2> (+1)` | | | ... and [10 more](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/362?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/362?src=pr=footer). Last update [97ee98b...f981778](https://codecov.io/gh/apache/kylin/pull/362?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[GitHub] Aaaaaaron commented on a change in pull request #365: KYLIN-2578, clean deprecated config("kylin.job.lock") usage in the code.
Aaron commented on a change in pull request #365: KYLIN-2578, clean
deprecated config("kylin.job.lock") usage in the code.
URL: https://github.com/apache/kylin/pull/365#discussion_r236961076
##
File path:
kylin-it/src/test/java/org/apache/kylin/job/BaseTestDistributedScheduler.java
##
@@ -69,7 +69,6 @@
@BeforeClass
public static void setup() throws Exception {
staticCreateTestMetadata();
-System.setProperty("kylin.job.lock",
"org.apache.kylin.storage.hbase.util.ZookeeperDistributedJobLock");
Review comment:
In fact, class "ZookeeperDistributedJobLock" already has been renamed to
"ZookeeperDistributedLock"
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] asfgit commented on issue #365: KYLIN-2578, clean deprecated config("kylin.job.lock") usage in the code.
asfgit commented on issue #365: KYLIN-2578, clean deprecated
config("kylin.job.lock") usage in the code.
URL: https://github.com/apache/kylin/pull/365#issuecomment-442342755
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Aaaaaaron opened a new pull request #365: KYLIN-2578, clean deprecated config("kylin.job.lock") usage in the code.
Aaron opened a new pull request #365: KYLIN-2578, clean deprecated
config("kylin.job.lock") usage in the code.
URL: https://github.com/apache/kylin/pull/365
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] shaofengshi closed pull request #362: KYLIN-3700 Quote sql identities when creating flat table
shaofengshi closed pull request #362: KYLIN-3700 Quote sql identities when
creating flat table
URL: https://github.com/apache/kylin/pull/362
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-common/src/main/java/org/apache/kylin/common/util/HiveCmdBuilder.java
b/core-common/src/main/java/org/apache/kylin/common/util/HiveCmdBuilder.java
index 707b3f33c9..8a99906e3e 100644
--- a/core-common/src/main/java/org/apache/kylin/common/util/HiveCmdBuilder.java
+++ b/core-common/src/main/java/org/apache/kylin/common/util/HiveCmdBuilder.java
@@ -68,7 +68,8 @@ public String build() {
case CLI:
buf.append("hive -e \"");
for (String statement : statements) {
-buf.append(statement).append("\n");
+//in bash need escape " and ` by using \
+buf.append(statement.replaceAll("`", "`")).append("\n");
}
buf.append("\"");
buf.append(parseProps());
@@ -79,7 +80,7 @@ public String build() {
try {
tmpHqlPath = "/tmp/" + UUID.randomUUID().toString() + ".hql";
for (String statement : statements) {
-hql.append(statement);
+hql.append(statement.replaceAll("`", "`"));
hql.append("\n");
}
String createFileCmd = String.format(Locale.ROOT,
CREATE_HQL_TMP_FILE_TEMPLATE, tmpHqlPath, hql);
diff --git
a/core-common/src/test/java/org/apache/kylin/common/util/HiveCmdBuilderTest.java
b/core-common/src/test/java/org/apache/kylin/common/util/HiveCmdBuilderTest.java
index ecc8961e33..8c852c1197 100644
---
a/core-common/src/test/java/org/apache/kylin/common/util/HiveCmdBuilderTest.java
+++
b/core-common/src/test/java/org/apache/kylin/common/util/HiveCmdBuilderTest.java
@@ -61,12 +61,12 @@ public void testHiveCLI() {
hivePropsOverwrite.put("hive.execution.engine", "tez");
HiveCmdBuilder hiveCmdBuilder = new HiveCmdBuilder();
hiveCmdBuilder.addStatement("USE default;");
-hiveCmdBuilder.addStatement("DROP TABLE test;");
+hiveCmdBuilder.addStatement("DROP TABLE `test`;");
hiveCmdBuilder.addStatement("SHOW\n TABLES;");
hiveCmdBuilder.setHiveConfProps(hiveProps);
hiveCmdBuilder.overwriteHiveProps(hivePropsOverwrite);
assertEquals(
-"hive -e \"USE default;\nDROP TABLE test;\nSHOW\n TABLES;\n\"
--hiveconf hive.execution.engine=tez",
+"hive -e \"USE default;\nDROP TABLE \\`test\\`;\nSHOW\n
TABLES;\n\" --hiveconf hive.execution.engine=tez",
hiveCmdBuilder.build());
}
@@ -80,7 +80,7 @@ public void testBeeline() throws IOException {
HiveCmdBuilder hiveCmdBuilder = new HiveCmdBuilder();
hiveCmdBuilder.addStatement("USE default;");
-hiveCmdBuilder.addStatement("DROP TABLE test;");
+hiveCmdBuilder.addStatement("DROP TABLE `test`;");
hiveCmdBuilder.addStatement("SHOW TABLES;");
String cmd = hiveCmdBuilder.build();
@@ -91,7 +91,7 @@ public void testBeeline() throws IOException {
Pair execute =
cliCommandExecutor.execute(createFileCmd);
String hqlStatement = FileUtils.readFileToString(new File(hqlFile),
Charset.defaultCharset());
assertEquals(
-"USE default;" + lineSeparator + "DROP TABLE test;" +
lineSeparator + "SHOW TABLES;" + lineSeparator,
+"USE default;" + lineSeparator + "DROP TABLE `test`;" +
lineSeparator + "SHOW TABLES;" + lineSeparator,
hqlStatement);
assertBeelineCmd(cmd);
FileUtils.forceDelete(new File(hqlFile));
@@ -105,7 +105,7 @@ public void testSparkSqlForTableOps() throws IOException {
HiveCmdBuilder hiveCmdBuilder = new HiveCmdBuilder();
hiveCmdBuilder.addStatement("USE default;");
-hiveCmdBuilder.addStatement("DROP TABLE test;");
+hiveCmdBuilder.addStatement("DROP TABLE `test`;");
hiveCmdBuilder.addStatement("SHOW TABLES;");
String cmd = hiveCmdBuilder.build();
assertBeelineCmd(cmd);
diff --git a/core-job/src/main/java/org/apache/kylin/job/JoinedFlatTable.java
b/core-job/src/main/java/org/apache/kylin/job/JoinedFlatTable.java
index ff48244687..d7e3b72e28 100644
--- a/core-job/src/main/java/org/apache/kylin/job/JoinedFlatTable.java
+++ b/core-job/src/main/java/org/apache/kylin/job/JoinedFlatTable.java
@@ -41,6 +41,9 @@
import org.apache.kylin.metadata.model.TableRef;
import org.apache.kylin.metadata.model.TblColRef;
+import static org.apache.kylin.job.util.FlatTableSqlQuoteUtils.quote;
+import static
org.apache.kylin.job.util.FlatTableSqlQuoteUtils.quoteIdentifierInSqlExpr;
+
[GitHub] asfgit commented on issue #356: KYLIN-3665 Partition time column may never be used
asfgit commented on issue #356: KYLIN-3665 Partition time column may never be used URL: https://github.com/apache/kylin/pull/356#issuecomment-441061435 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Wayne1c opened a new pull request #356: KYLIN-3665 Partition time column may never be used
Wayne1c opened a new pull request #356: KYLIN-3665 Partition time column may never be used URL: https://github.com/apache/kylin/pull/356 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #356: KYLIN-3665 Partition time column may never be used
coveralls commented on issue #356: KYLIN-3665 Partition time column may never be used URL: https://github.com/apache/kylin/pull/356#issuecomment-441068851 ## Pull Request Test Coverage Report for [Build 3872](https://coveralls.io/builds/20247518) * **37** of **38** **(97.37%)** changed or added relevant lines in **1** file are covered. * **8** unchanged lines in **3** files lost coverage. * Overall coverage increased (+**0.004%**) to **25.92%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-metadata/src/main/java/org/apache/kylin/metadata/model/PartitionDesc.java](https://coveralls.io/builds/20247518/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FPartitionDesc.java#L100) | 37 | 38 | 97.37% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/20247518/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72) | 1 | 47.62% | | [core-metadata/src/main/java/org/apache/kylin/metadata/model/PartitionDesc.java](https://coveralls.io/builds/20247518/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FPartitionDesc.java#L84) | 2 | 79.17% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/20247518/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% | | Totals | [](https://coveralls.io/builds/20247518) | | :-- | --: | | Change from base [Build 3871](https://coveralls.io/builds/20236865): | 0.004% | | Covered Lines: | 17650 | | Relevant Lines: | 68093 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #357: KYLIN-3694 Bug fix and revert guava version
codecov-io edited a comment on issue #357: KYLIN-3694 Bug fix and revert guava version URL: https://github.com/apache/kylin/pull/357#issuecomment-441145690 # [Codecov](https://codecov.io/gh/apache/kylin/pull/357?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`kylin-on-druid@31cacb5`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/357?src=pr=tree) ```diff @@Coverage Diff@@ ## kylin-on-druid #357 +/- ## = Coverage ? 20.43% Complexity? = Files ? 1151 Lines ?73009 Branches ?10553 = Hits ?14917 Misses?56690 Partials ? 1402 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/357?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...n/java/org/apache/kylin/cube/util/CubingUtils.java](https://codecov.io/gh/apache/kylin/pull/357/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL3V0aWwvQ3ViaW5nVXRpbHMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...lin/storage/druid/read/cursor/HttpDruidClient.java](https://codecov.io/gh/apache/kylin/pull/357/diff?src=pr=tree#diff-c3RvcmFnZS1kcnVpZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9kcnVpZC9yZWFkL2N1cnNvci9IdHRwRHJ1aWRDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...va/org/apache/kylin/storage/druid/DruidSchema.java](https://codecov.io/gh/apache/kylin/pull/357/diff?src=pr=tree#diff-c3RvcmFnZS1kcnVpZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9kcnVpZC9EcnVpZFNjaGVtYS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...lin/rest/security/KylinAuthenticationProvider.java](https://codecov.io/gh/apache/kylin/pull/357/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VjdXJpdHkvS3lsaW5BdXRoZW50aWNhdGlvblByb3ZpZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...e/mr/steps/CalculateStatsFromBaseCuboidMapper.java](https://codecov.io/gh/apache/kylin/pull/357/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQ2FsY3VsYXRlU3RhdHNGcm9tQmFzZUN1Ym9pZE1hcHBlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...lin/engine/mr/steps/FactDistinctColumnsMapper.java](https://codecov.io/gh/apache/kylin/pull/357/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvRmFjdERpc3RpbmN0Q29sdW1uc01hcHBlci5qYXZh) | `5.33% <0%> (ø)` | `0 <0> (?)` | | | [...g/apache/kylin/engine/spark/SparkFactDistinct.java](https://codecov.io/gh/apache/kylin/pull/357/diff?src=pr=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtGYWN0RGlzdGluY3QuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/357?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/357?src=pr=footer). Last update [31cacb5...ca1de0a](https://codecov.io/gh/apache/kylin/pull/357?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #356: KYLIN-3665 Partition time column may never be used
codecov-io commented on issue #356: KYLIN-3665 Partition time column may never be used URL: https://github.com/apache/kylin/pull/356#issuecomment-441150667 # [Codecov](https://codecov.io/gh/apache/kylin/pull/356?src=pr=h1) Report > Merging [#356](https://codecov.io/gh/apache/kylin/pull/356?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/98cb504470c85718abd1616e78d36851c21f2fd0?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `92.1%`. [](https://codecov.io/gh/apache/kylin/pull/356?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #356 +/- ## - Coverage 23.61% 23.61% -0.01% - Complexity 4826 4830 +4 Files 1133 1133 Lines 6810468093 -11 Branches 9659 9661 +2 - Hits 1608516080 -5 + Misses5045550448 -7 - Partials 1564 1565 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/356?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/kylin/metadata/model/PartitionDesc.java](https://codecov.io/gh/apache/kylin/pull/356/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvUGFydGl0aW9uRGVzYy5qYXZh) | `75% <92.1%> (+8.54%)` | `23 <3> (+5)` | :arrow_up: | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/356/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0%> (-4.77%)` | `5% <0%> (-1%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/356/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-1.83%)` | `7% <0%> (ø)` | | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/356/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `70.94% <0%> (-1.36%)` | `8% <0%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/356?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/356?src=pr=footer). Last update [98cb504...1a6d598](https://codecov.io/gh/apache/kylin/pull/356?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #357: KYLIN-3694 Bug fix and revert guava version
asfgit commented on issue #357: KYLIN-3694 Bug fix and revert guava version URL: https://github.com/apache/kylin/pull/357#issuecomment-441142155 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hit-lacus opened a new pull request #357: KYLIN-3694 Bug fix and revert guava version
hit-lacus opened a new pull request #357: KYLIN-3694 Bug fix and revert guava version URL: https://github.com/apache/kylin/pull/357 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #357: KYLIN-3694 Bug fix and revert guava version
codecov-io commented on issue #357: KYLIN-3694 Bug fix and revert guava version URL: https://github.com/apache/kylin/pull/357#issuecomment-441145690 # [Codecov](https://codecov.io/gh/apache/kylin/pull/357?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`kylin-on-druid@31cacb5`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/357?src=pr=tree) ```diff @@Coverage Diff@@ ## kylin-on-druid #357 +/- ## = Coverage ? 20.43% Complexity? 4443 = Files ? 1151 Lines ?73009 Branches ?10553 = Hits ?14919 Misses?56689 Partials ? 1401 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/357?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...n/java/org/apache/kylin/cube/util/CubingUtils.java](https://codecov.io/gh/apache/kylin/pull/357/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL3V0aWwvQ3ViaW5nVXRpbHMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...lin/storage/druid/read/cursor/HttpDruidClient.java](https://codecov.io/gh/apache/kylin/pull/357/diff?src=pr=tree#diff-c3RvcmFnZS1kcnVpZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9kcnVpZC9yZWFkL2N1cnNvci9IdHRwRHJ1aWRDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...lin/rest/security/KylinAuthenticationProvider.java](https://codecov.io/gh/apache/kylin/pull/357/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VjdXJpdHkvS3lsaW5BdXRoZW50aWNhdGlvblByb3ZpZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...e/mr/steps/CalculateStatsFromBaseCuboidMapper.java](https://codecov.io/gh/apache/kylin/pull/357/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQ2FsY3VsYXRlU3RhdHNGcm9tQmFzZUN1Ym9pZE1hcHBlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...lin/engine/mr/steps/FactDistinctColumnsMapper.java](https://codecov.io/gh/apache/kylin/pull/357/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvRmFjdERpc3RpbmN0Q29sdW1uc01hcHBlci5qYXZh) | `5.33% <0%> (ø)` | `0 <0> (?)` | | | [...g/apache/kylin/engine/spark/SparkFactDistinct.java](https://codecov.io/gh/apache/kylin/pull/357/diff?src=pr=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtGYWN0RGlzdGluY3QuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/357?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/357?src=pr=footer). Last update [31cacb5...ca1de0a](https://codecov.io/gh/apache/kylin/pull/357?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #353: KYLIN-3697 Check port availability when starts kylin instance
asfgit commented on issue #353: KYLIN-3697 Check port availability when starts kylin instance URL: https://github.com/apache/kylin/pull/353#issuecomment-440273296 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DingqianZhou opened a new pull request #353: KYLIN-3697 Check port availability when starts kylin instance
DingqianZhou opened a new pull request #353: KYLIN-3697 Check port availability when starts kylin instance URL: https://github.com/apache/kylin/pull/353 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi closed pull request #353: KYLIN-3697 Check port availability when starts kylin instance
shaofengshi closed pull request #353: KYLIN-3697 Check port availability when
starts kylin instance
URL: https://github.com/apache/kylin/pull/353
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build/bin/check-env.sh b/build/bin/check-env.sh
index cd745d4526..5b14e0af7d 100755
--- a/build/bin/check-env.sh
+++ b/build/bin/check-env.sh
@@ -80,4 +80,7 @@ then
then
quit "Failed to create $SPARK_HISTORYLOG_DIR. Please make sure the
user has right to access $SPARK_HISTORYLOG_DIR"
fi
-fi
\ No newline at end of file
+fi
+
+${KYLIN_HOME}/bin/check-port-availability.sh || exit 1;
+
diff --git a/build/bin/check-port-availability.sh
b/build/bin/check-port-availability.sh
new file mode 100644
index 00..023fdef3b9
--- /dev/null
+++ b/build/bin/check-port-availability.sh
@@ -0,0 +1,30 @@
+#!/bin/bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+source $(cd -P -- "$(dirname -- "$0")" && pwd -P)/header.sh
+
+
+# get port from configuraton
+kylin_port=`grep "
[GitHub] Aaaaaaron opened a new pull request #352: KYLIN-3669, add log to indicate the case when using "GTStreamAggregateScanner".
Aaron opened a new pull request #352: KYLIN-3669, add log to indicate the case when using "GTStreamAggregateScanner". URL: https://github.com/apache/kylin/pull/352 …Scanner. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #353: KYLIN-3697 Check port availability when starts kylin instance
codecov-io commented on issue #353: KYLIN-3697 Check port availability when starts kylin instance URL: https://github.com/apache/kylin/pull/353#issuecomment-440281351 # [Codecov](https://codecov.io/gh/apache/kylin/pull/353?src=pr=h1) Report > Merging [#353](https://codecov.io/gh/apache/kylin/pull/353?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/4e0340737fc39364c23c6b7d6d5f604a8e2eca7f?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/353?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #353 +/- ## + Coverage 23.6% 23.61% +<.01% - Complexity 4824 4825 +1 Files 1133 1133 Lines 6810268102 Branches 9659 9659 + Hits 1607716080 +3 + Misses5045850457 -1 + Partials 1567 1565 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/353?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/353/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `64.28% <0%> (ø)` | `179% <0%> (ø)` | :arrow_down: | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/353/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (+0.6%)` | `7% <0%> (ø)` | :arrow_down: | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/353/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `82.53% <0%> (+0.79%)` | `18% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/353?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/353?src=pr=footer). Last update [4e03407...28d1427](https://codecov.io/gh/apache/kylin/pull/353?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #352: KYLIN-3669, add log to indicate the case when using "GTStreamAggregateScanner".
asfgit commented on issue #352: KYLIN-3669, add log to indicate the case when using "GTStreamAggregateScanner". URL: https://github.com/apache/kylin/pull/352#issuecomment-440223647 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #349: KYLIN-3694 Kylin On Druid Storage
asfgit commented on issue #349: KYLIN-3694 Kylin On Druid Storage URL: https://github.com/apache/kylin/pull/349#issuecomment-439816566 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hit-lacus opened a new pull request #349: KYLIN-3694 Kylin On Druid Storage
hit-lacus opened a new pull request #349: KYLIN-3694 Kylin On Druid Storage URL: https://github.com/apache/kylin/pull/349 **Meituan** Kylin team has implemented a new storage engine for Kylin: Druid Storage Engine This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #349: KYLIN-3694 Kylin On Druid Storage
coveralls commented on issue #349: KYLIN-3694 Kylin On Druid Storage URL: https://github.com/apache/kylin/pull/349#issuecomment-439823023 ## Pull Request Test Coverage Report for [Build 3857](https://coveralls.io/builds/20175448) * **3** of **2886** **(0.1%)** changed or added relevant lines in **86** files are covered. * **17** unchanged lines in **8** files lost coverage. * Overall coverage decreased (**-1.1%**) to **24.816%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/RoaringBitmapCounter.java](https://coveralls.io/builds/20175448/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FRoaringBitmapCounter.java#L64) | 0 | 1 | 0.0% | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/RoaringBitmapCounterFactory.java](https://coveralls.io/builds/20175448/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FRoaringBitmapCounterFactory.java#L56) | 1 | 2 | 50.0% | [core-metadata/src/main/java/org/apache/kylin/metadata/filter/CaseTupleFilter.java](https://coveralls.io/builds/20175448/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FCaseTupleFilter.java#L154) | 0 | 1 | 0.0% | [core-metadata/src/main/java/org/apache/kylin/metadata/filter/ColumnTupleFilter.java](https://coveralls.io/builds/20175448/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FColumnTupleFilter.java#L161) | 0 | 1 | 0.0% | [core-metadata/src/main/java/org/apache/kylin/metadata/filter/ConstantTupleFilter.java](https://coveralls.io/builds/20175448/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FConstantTupleFilter.java#L128) | 0 | 1 | 0.0% | [core-metadata/src/main/java/org/apache/kylin/metadata/filter/DynamicTupleFilter.java](https://coveralls.io/builds/20175448/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FDynamicTupleFilter.java#L83) | 0 | 1 | 0.0% | [core-metadata/src/main/java/org/apache/kylin/metadata/filter/ExtractTupleFilter.java](https://coveralls.io/builds/20175448/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FExtractTupleFilter.java#L127) | 0 | 1 | 0.0% | [core-metadata/src/main/java/org/apache/kylin/metadata/filter/FunctionTupleFilter.java](https://coveralls.io/builds/20175448/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FFunctionTupleFilter.java#L31) | 0 | 1 | 0.0% | [core-metadata/src/main/java/org/apache/kylin/metadata/filter/LogicalTupleFilter.java](https://coveralls.io/builds/20175448/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FLogicalTupleFilter.java#L201) | 0 | 1 | 0.0% | [core-metadata/src/main/java/org/apache/kylin/metadata/filter/UnsupportedTupleFilter.java](https://coveralls.io/builds/20175448/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FUnsupportedTupleFilter.java#L62) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [query/src/main/java/org/apache/kylin/query/relnode/OLAPProjectRel.java](https://coveralls.io/builds/20175448/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPProjectRel.java#L204) | 1 | 0.0% | | [core-storage/src/main/java/org/apache/kylin/storage/StorageContext.java](https://coveralls.io/builds/20175448/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2FStorageContext.java#L77) | 1 | 0.0% | | [server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java](https://coveralls.io/builds/20175448/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FCubeService.java#L222) | 1 | 0.0% | | [core-metadata/src/main/java/org/apache/kylin/measure/MeasureCodec.java](https://coveralls.io/builds/20175448/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2FMeasureCodec.java#L94) | 1 | 0.0% | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/20175448/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/20175448/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L319) | 1 | 81.08% | |
[GitHub] whuwb opened a new pull request #350: Fix issue : KYLIN-3631
whuwb opened a new pull request #350: Fix issue : KYLIN-3631 URL: https://github.com/apache/kylin/pull/350 Issue : https://issues.apache.org/jira/browse/KYLIN-3631 How to fix : 1. Find all the Arrays.sort and replace with Arrays.parallelSort and add comments. 2. Run UT & integration tests to validate the fix. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #350: Fix issue : KYLIN-3631
asfgit commented on issue #350: Fix issue : KYLIN-3631 URL: https://github.com/apache/kylin/pull/350#issuecomment-439868082 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #350: Fix issue : KYLIN-3631
coveralls commented on issue #350: Fix issue : KYLIN-3631 URL: https://github.com/apache/kylin/pull/350#issuecomment-439873914 ## Pull Request Test Coverage Report for [Build 3858](https://coveralls.io/builds/20178446) * **1** of **2** **(50.0%)** changed or added relevant lines in **2** files are covered. * **4** unchanged lines in **2** files lost coverage. * Overall coverage increased (+**0.001%**) to **25.917%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-metadata/src/main/java/org/apache/kylin/metadata/model/Segments.java](https://coveralls.io/builds/20178446/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FSegments.java#L227) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/20178446/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L319) | 1 | 81.08% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/20178446/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | Totals | [](https://coveralls.io/builds/20178446) | | :-- | --: | | Change from base [Build 3853](https://coveralls.io/builds/20137109): | 0.001% | | Covered Lines: | 17648 | | Relevant Lines: | 68093 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #350: Fix issue : KYLIN-3631
codecov-io commented on issue #350: Fix issue : KYLIN-3631 URL: https://github.com/apache/kylin/pull/350#issuecomment-439874742 # [Codecov](https://codecov.io/gh/apache/kylin/pull/350?src=pr=h1) Report > Merging [#350](https://codecov.io/gh/apache/kylin/pull/350?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/634498649f20ce61fcabe0b46fe515bb6ca96af0?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `50%`. [](https://codecov.io/gh/apache/kylin/pull/350?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #350 +/- ## - Coverage 23.62% 23.61% -0.01% + Complexity 4823 4822 -1 Files 1133 1133 Lines 6809368093 Branches 9657 9657 - Hits 1608716081 -6 - Misses5044550449 +4 - Partials 1561 1563 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/350?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...java/org/apache/kylin/metadata/model/Segments.java](https://codecov.io/gh/apache/kylin/pull/350/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvU2VnbWVudHMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ava/org/apache/kylin/metadata/model/TableDesc.java](https://codecov.io/gh/apache/kylin/pull/350/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvVGFibGVEZXNjLmphdmE=) | `47.77% <100%> (ø)` | `27 <0> (ø)` | :arrow_down: | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/350/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `70.94% <0%> (-1.36%)` | `8% <0%> (ø)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/350/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (-0.92%)` | `7% <0%> (ø)` | | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/350/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/350?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/350?src=pr=footer). Last update [6344986...c47dd9f](https://codecov.io/gh/apache/kylin/pull/350?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi commented on a change in pull request #350: Fix issue : KYLIN-3631
shaofengshi commented on a change in pull request #350: Fix issue : KYLIN-3631 URL: https://github.com/apache/kylin/pull/350#discussion_r234635124 ## File path: core-cube/src/test/java/org/apache/kylin/cube/cuboid/CuboidSchedulerTest.java ## @@ -118,8 +118,13 @@ private void testSpanningAndGetParent(CuboidScheduler scheduler, CubeDesc cube, } long[] spanningsArray = Longs.toArray(totalSpanning); -Arrays.sort(spanningsArray); -Arrays.sort(expectChildren); + +/* +According to issue : https://issues.apache.org/jira/browse/KYLIN-3631 Review comment: This comment is not needed. Can you remove it in all the places? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] whuwb commented on a change in pull request #350: Fix issue : KYLIN-3631
whuwb commented on a change in pull request #350: Fix issue : KYLIN-3631 URL: https://github.com/apache/kylin/pull/350#discussion_r234681139 ## File path: core-cube/src/test/java/org/apache/kylin/cube/cuboid/CuboidSchedulerTest.java ## @@ -118,8 +118,13 @@ private void testSpanningAndGetParent(CuboidScheduler scheduler, CubeDesc cube, } long[] spanningsArray = Longs.toArray(totalSpanning); -Arrays.sort(spanningsArray); -Arrays.sort(expectChildren); + +/* +According to issue : https://issues.apache.org/jira/browse/KYLIN-3631 Review comment: Sure This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #354: KYLIN-3697 minor, only kylin.sh start check-env
codecov-io commented on issue #354: KYLIN-3697 minor, only kylin.sh start check-env URL: https://github.com/apache/kylin/pull/354#issuecomment-440300354 # [Codecov](https://codecov.io/gh/apache/kylin/pull/354?src=pr=h1) Report > Merging [#354](https://codecov.io/gh/apache/kylin/pull/354?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/5aea3d40646ed578f5a35fde290ebab560790785?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/354?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #354 +/- ## + Coverage 23.6% 23.61% +<.01% - Complexity 4824 4826 +2 Files 1133 1133 Lines 6810268102 Branches 9659 9659 + Hits 1607716082 +5 + Misses5045850456 -2 + Partials 1567 1564 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/354?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/354/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `64.28% <0%> (ø)` | `179% <0%> (ø)` | :arrow_down: | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/354/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (+0.6%)` | `7% <0%> (ø)` | :arrow_down: | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/354/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `82.53% <0%> (+0.79%)` | `18% <0%> (+1%)` | :arrow_up: | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/354/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `78.37% <0%> (+5.4%)` | `7% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/354?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/354?src=pr=footer). Last update [5aea3d4...c463662](https://codecov.io/gh/apache/kylin/pull/354?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #354: minor, only kylin.sh start check-env
asfgit commented on issue #354: minor, only kylin.sh start check-env URL: https://github.com/apache/kylin/pull/354#issuecomment-440292695 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DingqianZhou opened a new pull request #354: minor, only kylin.sh start check-env
DingqianZhou opened a new pull request #354: minor, only kylin.sh start check-env URL: https://github.com/apache/kylin/pull/354 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Wayne1c closed pull request #356: KYLIN-3665 Partition time column may never be used
Wayne1c closed pull request #356: KYLIN-3665 Partition time column may never be
used
URL: https://github.com/apache/kylin/pull/356
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-metadata/src/main/java/org/apache/kylin/metadata/model/PartitionDesc.java
b/core-metadata/src/main/java/org/apache/kylin/metadata/model/PartitionDesc.java
index dcb37ecdad..47802d9831 100644
---
a/core-metadata/src/main/java/org/apache/kylin/metadata/model/PartitionDesc.java
+++
b/core-metadata/src/main/java/org/apache/kylin/metadata/model/PartitionDesc.java
@@ -95,6 +95,14 @@ public boolean partitionColumnIsTimeMillis() {
return type.isBigInt() &&
!DateFormat.isDatePattern(partitionDateFormat);
}
+public boolean partitionTimeColumnIsInt() {
+if (partitionTimeColumnRef == null)
+return false;
+
+DataType type = partitionTimeColumnRef.getType();
+return (type.isInt() || type.isBigInt());
+}
+
public boolean isPartitioned() {
return partitionDateColumnRef != null;
}
@@ -194,103 +202,99 @@ public String buildDateRangeCondition(PartitionDesc
partDesc, ISegment seg, Segm
long startInclusive = (Long) segRange.start.v;
long endExclusive = (Long) segRange.end.v;
+if (endExclusive <= startInclusive) {
+return "1=0";
+}
+
TblColRef partitionDateColumn =
partDesc.getPartitionDateColumnRef();
TblColRef partitionTimeColumn =
partDesc.getPartitionTimeColumnRef();
StringBuilder builder = new StringBuilder();
-if (partDesc.partitionColumnIsYmdInt()) {
-buildSingleColumnRangeCondAsYmdInt(builder,
partitionDateColumn, startInclusive, endExclusive,
-partDesc.getPartitionDateFormat());
-} else if (partDesc.partitionColumnIsTimeMillis()) {
-buildSingleColumnRangeCondAsTimeMillis(builder,
partitionDateColumn, startInclusive, endExclusive);
-} else if (partitionDateColumn != null && partitionTimeColumn ==
null) {
-buildSingleColumnRangeCondition(builder, partitionDateColumn,
startInclusive, endExclusive,
-partDesc.getPartitionDateFormat());
-} else if (partitionDateColumn == null && partitionTimeColumn !=
null) {
-buildSingleColumnRangeCondition(builder, partitionTimeColumn,
startInclusive, endExclusive,
-partDesc.getPartitionTimeFormat());
-} else if (partitionDateColumn != null && partitionTimeColumn !=
null) {
-buildMultipleColumnRangeCondition(builder,
partitionDateColumn, partitionTimeColumn, startInclusive,
-endExclusive, partDesc.getPartitionDateFormat(),
partDesc.getPartitionTimeFormat());
+if (partitionDateColumn != null && partitionTimeColumn != null) {
+buildMultipleColumnRangeCondition(builder,
partitionDateColumn, partitionTimeColumn, startInclusive, endExclusive,
partDesc);
+} else if (partitionDateColumn != null) {
+buildSingleColumnRangeCondition(builder, partitionDateColumn,
startInclusive, endExclusive, partDesc, true);
+} else if (partitionTimeColumn != null) {
+buildSingleColumnRangeCondition(builder, partitionTimeColumn,
startInclusive, endExclusive, partDesc, false);
}
return builder.toString();
}
-private static void
buildSingleColumnRangeCondAsTimeMillis(StringBuilder builder, TblColRef
partitionColumn,
-long startInclusive, long endExclusive) {
-String partitionColumnName = partitionColumn.getIdentity();
-builder.append(partitionColumnName + " >= " + startInclusive);
-builder.append(" AND ");
-builder.append(partitionColumnName + " < " + endExclusive);
-}
-
-private static void buildSingleColumnRangeCondAsYmdInt(StringBuilder
builder, TblColRef partitionColumn,
-long startInclusive, long endExclusive, String
partitionColumnDateFormat) {
-String partitionColumnName = partitionColumn.getIdentity();
-builder.append(partitionColumnName + " >= "
-+ DateFormat.formatToDateStr(startInclusive,
partitionColumnDateFormat));
-builder.append(" AND ");
-builder.append(
-partitionColumnName + " < " +
DateFormat.formatToDateStr(endExclusive, partitionColumnDateFormat));
-}
-
private static void buildSingleColumnRangeCondition(StringBuilder
builder, TblColRef partitionColumn,
-long startInclusive, long
[GitHub] hit-lacus commented on issue #362: KYLIN-3700 Quote sql identities when creating flat table
hit-lacus commented on issue #362: KYLIN-3700 Quote sql identities when creating flat table URL: https://github.com/apache/kylin/pull/362#issuecomment-441872165 Local CI pass. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi commented on issue #355: detailed configurations could be override in the Cube-level
shaofengshi commented on issue #355: detailed configurations could be override in the Cube-level URL: https://github.com/apache/kylin/pull/355#issuecomment-441965061 Merged with patch, thank you Dingqian! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi closed pull request #355: detailed configurations could be override in the Cube-level
shaofengshi closed pull request #355: detailed configurations could be override
in the Cube-level
URL: https://github.com/apache/kylin/pull/355
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/website/_docs/install/configuration.cn.md
b/website/_docs/install/configuration.cn.md
index 4f298dc951..c833da4807 100644
--- a/website/_docs/install/configuration.cn.md
+++ b/website/_docs/install/configuration.cn.md
@@ -28,7 +28,7 @@ permalink: /cn/docs/install/configuration.html
- [Hive 客户端 & SparkSQL](#hive-client-and-sparksql)
- [配置 JDBC 数据源](#jdbc-datasource)
- [数据类型精度](#precision-config)
-- [Cube 设置](#cube-config)
+- [Cube 设计](#cube-config)
- [Cube 大小估计](#cube-estimate)
- [Cube 构建算法](#cube-algorithm)
- [自动合并](#auto-merge)
@@ -98,6 +98,20 @@ Kylin 会自动从环境中读取 Hadoop 配置（`core-site.xml`），Hive 配
在设计 Cube （**Cube Designer**）的 **Configuration Overwrites** 步骤可以添加配置项，进行 Cube
级别的配置重写，如下图所示：
+以下参数可以在 Cube 级别重写：
+
+- `kylin.cube.size-estimate*`
+- `kylin.cube.algorithm*`
+- `kylin.cube.aggrgroup*`
+- `kylin.metadata.dimension-encoding-max-length`
+- `kylin.cube.max-building-segments`
+- `kylin.cube.is-automerge-enabled`
+- `kylin.job.allow-empty-segment`
+- `kylin.job.sampling-percentage`
+- `kylin.source.hive.redistribute-flat-table`
+- `kylin.engine.spark*`
+- `kylin.query.skip-empty-segments`
+
### MapReduce 任务配置重写 {#mr-config-override}
@@ -194,7 +208,6 @@ export KYLIN_JVM_SETTINGS="-Xms1024M -Xmx4096M -Xss1024K
-XX`MaxPermSize=512M -v
### 元数据相关 {#metadata}
- `kylin.metadata.url`：指定元数据库路径，默认值为 kylin_metadata@hbase
-- `kylin.metadata.dimension-encoding-max-length`：指定维度作为 Rowkeys 时使用 fix_length
编码时的最大长度，默认值为 256
- `kylin.metadata.sync-retries`：指定元数据同步重试次数，默认值为 3
- `kylin.metadata.sync-error-handler`：默认值为 `DefaultSyncErrorHandler`
- `kylin.metadata.check-copy-on-write`：清除元数据缓存，默认值为 `FALSE`
@@ -265,7 +278,7 @@ export KYLIN_JVM_SETTINGS="-Xms1024M -Xmx4096M -Xss1024K
-XX`MaxPermSize=512M -v
-### Cube 设置 {#cube-config}
+### Cube 设计 {#cube-config}
- `kylin.cube.ignore-signature-inconsistency`：Cube desc 中的 signature 信息能保证
Cube 不被更改为损坏状态，默认值为 FALSE
- `kylin.cube.aggrgroup.max-combination`：指定一个 Cube 的聚合组 Cuboid 上限，默认值为 32768
@@ -273,6 +286,8 @@ export KYLIN_JVM_SETTINGS="-Xms1024M -Xmx4096M -Xss1024K
-XX`MaxPermSize=512M -v
- `kylin.cube.rowkey.max-size`：指定可以设置为 Rowkeys 的最大列数，默认值为 63
- `kylin.cube.allow-appear-in-multiple-projects`：是否允许一个 Cube 出现在多个项目中
- `kylin.cube.gtscanrequest-serialization-level`：默认值为 1
+- `kylin.metadata.dimension-encoding-max-length`：指定维度作为 Rowkeys 时使用 fix_length
编码时的最大长度，默认值为 256
+
diff --git a/website/_docs/install/configuration.md
b/website/_docs/install/configuration.md
index c8217405c8..cad8b967f9 100644
--- a/website/_docs/install/configuration.md
+++ b/website/_docs/install/configuration.md
@@ -88,16 +88,30 @@ Some configuration files in `$KYLIN_HOME/conf/` can be
overridden in the Web UI.
### Project-level Configuration Overriding {#project-config-override}
-Click *Manage Project* in the web UI interface, select a project, click *Edit*
-> *Project Config* -> *+ Property* to add configuration properties which could
override property values in configuration files, as the figure below shown:
+Click *Manage Project* in the web UI interface, select a project, click *Edit*
-> *Project Config* -> *+ Property* to add configuration properties which could
override property values in configuration files, as the figure below shown,
### Cube-level Configuration Overriding{#cube-config-override}
-In the *Configuration overrides* step of *Cube Designer*, user could rewrite
property values to override those in project level and configuration files, as
the figure below shown:
+In the *Configuration overrides* step of *Cube Designer*, user could rewrite
property values to override those in project level and configuration files, as
the figure below shown,
+The following configurations can be override in the Cube-level,
+
+- `kylin.cube.size-estimate*`
+- `kylin.cube.algorithm*`
+- `kylin.cube.aggrgroup*`
+- `kylin.metadata.dimension-encoding-max-length`
+- `kylin.cube.max-building-segments`
+- `kylin.cube.is-automerge-enabled`
+- `kylin.job.allow-empty-segment`
+- `kylin.job.sampling-percentage`
+- `kylin.source.hive.redistribute-flat-table`
+- `kylin.engine.spark*`
+- `kylin.query.skip-empty-segments`
+
### MapReduce Configuration Overriding {#mr-config-override}
This is an automated message from the Apache Git Service.
To respond to
[GitHub] shaofengshi closed pull request #361: KYLIN-3704 upgrade calcite version to 1.16.0-kylin-r2 version
shaofengshi closed pull request #361: KYLIN-3704 upgrade calcite version to
1.16.0-kylin-r2 version
URL: https://github.com/apache/kylin/pull/361
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/pom.xml b/pom.xml
index 680144f3f2..7474817626 100644
--- a/pom.xml
+++ b/pom.xml
@@ -72,7 +72,7 @@
-1.16.0-kylin-r2-SNAPSHOT
+1.16.0-kylin-r2
1.10.0
diff --git
a/query/src/main/java/org/apache/kylin/query/relnode/OLAPTableScan.java
b/query/src/main/java/org/apache/kylin/query/relnode/OLAPTableScan.java
index ac6241fa28..8b7c3a31bd 100644
--- a/query/src/main/java/org/apache/kylin/query/relnode/OLAPTableScan.java
+++ b/query/src/main/java/org/apache/kylin/query/relnode/OLAPTableScan.java
@@ -73,7 +73,6 @@
import org.apache.kylin.metadata.model.TableRef;
import org.apache.kylin.metadata.model.TblColRef;
import org.apache.kylin.query.enumerator.DictionaryEnumerator;
-import org.apache.kylin.query.optrule.AggregateMultipleExpandRule;
import org.apache.kylin.query.optrule.AggregateProjectReduceRule;
import org.apache.kylin.query.optrule.OLAPAggregateRule;
import org.apache.kylin.query.optrule.OLAPFilterRule;
@@ -163,13 +162,11 @@ public void register(RelOptPlanner planner) {
planner.addRule(OLAPUnionRule.INSTANCE);
planner.addRule(OLAPWindowRule.INSTANCE);
planner.addRule(OLAPValuesRule.INSTANCE);
-
-// Support translate the grouping aggregate into union of simple
aggregates
-planner.addRule(AggregateMultipleExpandRule.INSTANCE);
+
planner.addRule(AggregateProjectReduceRule.INSTANCE);
// CalcitePrepareImpl.CONSTANT_REDUCTION_RULES
-if(kylinConfig.isReduceExpressionsRulesEnabled()) {
+if (kylinConfig.isReduceExpressionsRulesEnabled()) {
planner.addRule(ReduceExpressionsRule.PROJECT_INSTANCE);
planner.addRule(ReduceExpressionsRule.FILTER_INSTANCE);
planner.addRule(ReduceExpressionsRule.CALC_INSTANCE);
@@ -181,7 +178,7 @@ public void register(RelOptPlanner planner) {
//planner.addRule(ValuesReduceRule.PROJECT_INSTANCE);
removeRules(planner, kylinConfig.getCalciteRemoveRule());
-if(!kylinConfig.isEnumerableRulesEnabled()) {
+if (!kylinConfig.isEnumerableRulesEnabled()) {
for (RelOptRule rule : CalcitePrepareImpl.ENUMERABLE_RULES) {
planner.removeRule(rule);
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] FrancisLiang commented on issue #360: KYLIN-3665 Partition time column may never be added
FrancisLiang commented on issue #360: KYLIN-3665 Partition time column may never be added URL: https://github.com/apache/kylin/pull/360#issuecomment-441988794 > Hi Francis, the change looks good. While the commit message didn't comply with Apache's style. Could you please update the commit message to "KYLIN-3665 Partition time column may never be added" (start with JIRA ID, no [] needed). Thank you! Just did it. Thanks for the information! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi opened a new pull request #363: KYLIN-3597 fix static code issues
shaofengshi opened a new pull request #363: KYLIN-3597 fix static code issues URL: https://github.com/apache/kylin/pull/363 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #363: KYLIN-3597 fix static code issues
asfgit commented on issue #363: KYLIN-3597 fix static code issues URL: https://github.com/apache/kylin/pull/363#issuecomment-442011938 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi commented on issue #360: [KYLIN-3665]-Partition time column may never be added fixed.
shaofengshi commented on issue #360: [KYLIN-3665]-Partition time column may never be added fixed. URL: https://github.com/apache/kylin/pull/360#issuecomment-441987516 Hi Francis, the change looks good. While the commit message didn't comply with Apache's style. Could you please update the commit message to "KYLIN-3665 Partition time column may never be added" (start with JIRA ID, no [] needed). Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi closed pull request #360: KYLIN-3665 Partition time column may never be added
shaofengshi closed pull request #360: KYLIN-3665 Partition time column may
never be added
URL: https://github.com/apache/kylin/pull/360
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-metadata/src/main/java/org/apache/kylin/metadata/model/PartitionDesc.java
b/core-metadata/src/main/java/org/apache/kylin/metadata/model/PartitionDesc.java
index dcb37ecdad..56ededb995 100644
---
a/core-metadata/src/main/java/org/apache/kylin/metadata/model/PartitionDesc.java
+++
b/core-metadata/src/main/java/org/apache/kylin/metadata/model/PartitionDesc.java
@@ -200,8 +200,12 @@ public String buildDateRangeCondition(PartitionDesc
partDesc, ISegment seg, Segm
StringBuilder builder = new StringBuilder();
if (partDesc.partitionColumnIsYmdInt()) {
-buildSingleColumnRangeCondAsYmdInt(builder,
partitionDateColumn, startInclusive, endExclusive,
-partDesc.getPartitionDateFormat());
+if (partitionTimeColumn == null) {
+buildSingleColumnRangeCondAsYmdInt(builder,
partitionDateColumn, startInclusive, endExclusive,
partDesc.getPartitionDateFormat());
+} else {
+buildMultipleColumnRangeCondition(builder,
partitionDateColumn, partitionTimeColumn, startInclusive,
+endExclusive, partDesc.getPartitionDateFormat(),
partDesc.getPartitionTimeFormat(), true);
+}
} else if (partDesc.partitionColumnIsTimeMillis()) {
buildSingleColumnRangeCondAsTimeMillis(builder,
partitionDateColumn, startInclusive, endExclusive);
} else if (partitionDateColumn != null && partitionTimeColumn ==
null) {
@@ -212,14 +216,14 @@ public String buildDateRangeCondition(PartitionDesc
partDesc, ISegment seg, Segm
partDesc.getPartitionTimeFormat());
} else if (partitionDateColumn != null && partitionTimeColumn !=
null) {
buildMultipleColumnRangeCondition(builder,
partitionDateColumn, partitionTimeColumn, startInclusive,
-endExclusive, partDesc.getPartitionDateFormat(),
partDesc.getPartitionTimeFormat());
+endExclusive, partDesc.getPartitionDateFormat(),
partDesc.getPartitionTimeFormat(), false);
}
return builder.toString();
}
private static void
buildSingleColumnRangeCondAsTimeMillis(StringBuilder builder, TblColRef
partitionColumn,
-long startInclusive, long endExclusive) {
+ long
startInclusive, long endExclusive) {
String partitionColumnName = partitionColumn.getIdentity();
builder.append(partitionColumnName + " >= " + startInclusive);
builder.append(" AND ");
@@ -227,7 +231,7 @@ private static void
buildSingleColumnRangeCondAsTimeMillis(StringBuilder builder
}
private static void buildSingleColumnRangeCondAsYmdInt(StringBuilder
builder, TblColRef partitionColumn,
-long startInclusive, long endExclusive, String
partitionColumnDateFormat) {
+ long
startInclusive, long endExclusive, String partitionColumnDateFormat) {
String partitionColumnName = partitionColumn.getIdentity();
builder.append(partitionColumnName + " >= "
+ DateFormat.formatToDateStr(startInclusive,
partitionColumnDateFormat));
@@ -237,7 +241,7 @@ private static void
buildSingleColumnRangeCondAsYmdInt(StringBuilder builder, Tb
}
private static void buildSingleColumnRangeCondition(StringBuilder
builder, TblColRef partitionColumn,
-long startInclusive, long endExclusive, String
partitionColumnDateFormat) {
+long
startInclusive, long endExclusive, String partitionColumnDateFormat) {
String partitionColumnName = partitionColumn.getIdentity();
if (endExclusive <= startInclusive) {
@@ -261,36 +265,37 @@ private static void
buildSingleColumnRangeCondition(StringBuilder builder, TblCo
}
private static void buildMultipleColumnRangeCondition(StringBuilder
builder, TblColRef partitionDateColumn,
-TblColRef partitionTimeColumn, long startInclusive, long
endExclusive, String partitionColumnDateFormat,
-String partitionColumnTimeFormat) {
+ TblColRef
partitionTimeColumn, long startInclusive, long endExclusive, String
partitionColumnDateFormat,
+
[GitHub] asfgit commented on issue #364: KYLIN-3559 Use Splitter for splitting String
asfgit commented on issue #364: KYLIN-3559 Use Splitter for splitting String URL: https://github.com/apache/kylin/pull/364#issuecomment-442076913 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] whuwb opened a new pull request #364: KYLIN-3559 Use Splitter for splitting String
whuwb opened a new pull request #364: KYLIN-3559 Use Splitter for splitting String URL: https://github.com/apache/kylin/pull/364 Issue: https://issues.apache.org/jira/browse/KYLIN-3559 Solution: Use Splitter for splitting String IT: [INFO] Reactor Summary for Apache Kylin 2.6.0-SNAPSHOT: [INFO] [INFO] Apache Kylin ... SUCCESS [ 6.852 s] [INFO] Apache Kylin - Core Common . SUCCESS [ 16.358 s] [INFO] Apache Kylin - Core Metadata ... SUCCESS [ 55.479 s] [INFO] Apache Kylin - Core Dictionary . SUCCESS [05:24 min] [INFO] Apache Kylin - Core Cube ... SUCCESS [01:35 min] [INFO] Apache Kylin - Core Metrics SUCCESS [ 2.747 s] [INFO] Apache Kylin - Core Job SUCCESS [ 45.493 s] [INFO] Apache Kylin - Core Storage SUCCESS [ 9.592 s] [INFO] Apache Kylin - MapReduce Engine SUCCESS [ 24.407 s] [INFO] Apache Kylin - Spark Engine SUCCESS [ 8.147 s] [INFO] Apache Kylin - Hive Source . SUCCESS [ 6.442 s] [INFO] Apache Kylin - DataSource SDK .. SUCCESS [ 11.310 s] [INFO] Apache Kylin - Jdbc Source . SUCCESS [ 24.863 s] [INFO] Apache Kylin - Kafka Source SUCCESS [ 6.304 s] [INFO] Apache Kylin - Cache ... SUCCESS [ 9.572 s] [INFO] Apache Kylin - HBase Storage ... SUCCESS [ 19.651 s] [INFO] Apache Kylin - Query ... SUCCESS [ 19.320 s] [INFO] Apache Kylin - Metrics Reporter Hive ... SUCCESS [ 2.167 s] [INFO] Apache Kylin - Metrics Reporter Kafka .. SUCCESS [ 1.122 s] [INFO] Apache Kylin - REST Server Base SUCCESS [ 27.527 s] [INFO] Apache Kylin - REST Server . SUCCESS [01:32 min] [INFO] Apache Kylin - JDBC Driver . SUCCESS [ 12.682 s] [INFO] Apache Kylin - Assembly SUCCESS [ 20.715 s] [INFO] Apache Kylin - Tool SUCCESS [ 14.791 s] [INFO] Apache Kylin - Tool Assembly ... SUCCESS [ 5.632 s] [INFO] Apache Kylin - Integration Test SUCCESS [ 02:38 h] [INFO] Apache Kylin - Tomcat Extension SUCCESS [ 1.715 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 02:52 h [INFO] Finished at: 2018-11-17T22:57:50Z [INFO] This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #363: KYLIN-3597 fix static code issues
codecov-io commented on issue #363: KYLIN-3597 fix static code issues URL: https://github.com/apache/kylin/pull/363#issuecomment-442078521 # [Codecov](https://codecov.io/gh/apache/kylin/pull/363?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@2d8e0fc`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `40.59%`. [](https://codecov.io/gh/apache/kylin/pull/363?src=pr=tree) ```diff @@Coverage Diff@@ ## master #363 +/- ## = Coverage ? 23.62% Complexity? 4824 = Files ? 1130 Lines ?68022 Branches ? 9657 = Hits ?16072 Misses?50383 Partials ? 1567 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/363?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...e/kylin/sdk/datasource/adaptor/DefaultAdaptor.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2FkYXB0b3IvRGVmYXVsdEFkYXB0b3IuamF2YQ==) | `36.08% <ø> (ø)` | `12 <0> (?)` | | | [...in/rest/broadcaster/BroadcasterReceiveServlet.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvYnJvYWRjYXN0ZXIvQnJvYWRjYXN0ZXJSZWNlaXZlU2VydmxldC5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | | | [.../org/apache/kylin/engine/mr/ByteArrayWritable.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvQnl0ZUFycmF5V3JpdGFibGUuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...e/kylin/source/kafka/util/KafkaSampleProducer.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-c291cmNlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zb3VyY2Uva2Fma2EvdXRpbC9LYWZrYVNhbXBsZVByb2R1Y2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../main/java/org/apache/kylin/common/util/Bytes.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0J5dGVzLmphdmE=) | `1.01% <0%> (ø)` | `3 <0> (?)` | | | [...re/bitmap/BitmapIntersectDistinctCountAggFunc.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwSW50ZXJzZWN0RGlzdGluY3RDb3VudEFnZ0Z1bmMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...apache/kylin/job/execution/AbstractExecutable.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQWJzdHJhY3RFeGVjdXRhYmxlLmphdmE=) | `51.4% <23.07%> (ø)` | `48 <3> (?)` | | | [...be/model/validation/rule/AggregationGroupRule.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9BZ2dyZWdhdGlvbkdyb3VwUnVsZS5qYXZh) | `54.63% <27.27%> (ø)` | `20 <17> (?)` | | | [...in/sdk/datasource/adaptor/AbstractJdbcAdaptor.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2FkYXB0b3IvQWJzdHJhY3RKZGJjQWRhcHRvci5qYXZh) | `54.21% <33.33%> (ø)` | `13 <0> (?)` | | | [...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=) | `52.04% <75%> (ø)` | `21 <1> (?)` | | | ... and [1 more](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/363?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/363?src=pr=footer). Last update [2d8e0fc...516e16c](https://codecov.io/gh/apache/kylin/pull/363?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the
[GitHub] woyumen4597 commented on issue #366: KYLIN-3707 add configuration for setting isolation-level for sqoop
woyumen4597 commented on issue #366: KYLIN-3707 add configuration for setting isolation-level for sqoop URL: https://github.com/apache/kylin/pull/366#issuecomment-442461461 @shaofengshi Good suggestion,but I think each datasource has its own configuration,including adaptor and xml file,This sqoop configuration is like other config such as sql.case-sensitive is special for one datasource.So in my opinion there is no need to add extra common configuration.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls edited a comment on issue #350: Fix issue : KYLIN-3631
coveralls edited a comment on issue #350: Fix issue : KYLIN-3631 URL: https://github.com/apache/kylin/pull/350#issuecomment-439873914 ## Pull Request Test Coverage Report for [Build 3859](https://coveralls.io/builds/20183226) * **1** of **2** **(50.0%)** changed or added relevant lines in **2** files are covered. * **3** unchanged lines in **2** files lost coverage. * Overall coverage decreased (**-0.004%**) to **25.912%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-metadata/src/main/java/org/apache/kylin/metadata/model/Segments.java](https://coveralls.io/builds/20183226/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FSegments.java#L223) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/20183226/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/20183226/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | Totals | [](https://coveralls.io/builds/20183226) | | :-- | --: | | Change from base [Build 3853](https://coveralls.io/builds/20137109): | -0.004% | | Covered Lines: | 17644 | | Relevant Lines: | 68093 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
