noblepaul commented on a change in pull request #1432:
URL: https://github.com/apache/lucene-solr/pull/1432#discussion_r443962681
##
File path: solr/core/src/test/org/apache/solr/handler/TestContainerPlugin.java
##
@@ -0,0 +1,250 @@
+/*
+ * Licensed to the Apache Software
dsmiley commented on a change in pull request #1432:
URL: https://github.com/apache/lucene-solr/pull/1432#discussion_r443257246
##
File path: solr/core/src/test/org/apache/solr/handler/TestContainerPlugin.java
##
@@ -0,0 +1,250 @@
+/*
+ * Licensed to the Apache Software
noblepaul commented on a change in pull request #1432:
URL: https://github.com/apache/lucene-solr/pull/1432#discussion_r443954744
##
File path: solr/solrj/src/java/org/apache/solr/common/util/PathTrie.java
##
@@ -82,6 +80,22 @@ public boolean add(String s) {
return parts;
noblepaul commented on a change in pull request #1432:
URL: https://github.com/apache/lucene-solr/pull/1432#discussion_r443953444
##
File path: solr/core/src/java/org/apache/solr/pkg/PackageListeners.java
##
@@ -69,7 +69,7 @@ synchronized void packagesUpdated(List
pkgs) {
[
https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142615#comment-17142615
]
Tomoko Uchida commented on LUCENE-9286:
---
[~sokolov] thanks so much for the pointers and detailed
DEVILCODER-SB99 opened a new pull request #1604:
URL: https://github.com/apache/lucene-solr/pull/1604
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please provide a short description of the
DEVILCODER-SB99 opened a new pull request #1603:
URL: https://github.com/apache/lucene-solr/pull/1603
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please provide a short description of the
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-14586:
--
Summary: replace the second function parameter in Map#computeIfAbsent with
static vars (was: replace
[
https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142526#comment-17142526
]
Chris M. Hostetter commented on SOLR-13132:
---
michael: I'm really sorry, i've been swamped with
noblepaul commented on a change in pull request #1592:
URL: https://github.com/apache/lucene-solr/pull/1592#discussion_r443887161
##
File path:
solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimClusterStateProvider.java
##
@@ -351,10 +340,10 @@ public void
[
https://issues.apache.org/jira/browse/SOLR-14554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Eduardo Fernandez Lobbe resolved SOLR-14554.
--
Fix Version/s: 8.6
master (9.0)
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142500#comment-17142500
]
Noble Paul commented on SOLR-14576:
---
This was reported by a client and unfortunately I do not have the
[
https://issues.apache.org/jira/browse/SOLR-14554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142498#comment-17142498
]
ASF subversion and git services commented on SOLR-14554:
Commit
noblepaul commented on a change in pull request #1592:
URL: https://github.com/apache/lucene-solr/pull/1592#discussion_r443887161
##
File path:
solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimClusterStateProvider.java
##
@@ -351,10 +340,10 @@ public void
[
https://issues.apache.org/jira/browse/SOLR-14554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142488#comment-17142488
]
ASF subversion and git services commented on SOLR-14554:
Commit
tflobbe merged pull request #1566:
URL: https://github.com/apache/lucene-solr/pull/1566
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
tflobbe merged pull request #1596:
URL: https://github.com/apache/lucene-solr/pull/1596
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
tflobbe opened a new pull request #1602:
URL: https://github.com/apache/lucene-solr/pull/1602
LUCENE-8962 added the ability to merge segments synchronously on commit.
This isn't done by default and the default MergePolicy won't do it, but custom
merge policies can take advantage of this.
[
https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142446#comment-17142446
]
Ilan Ginzburg commented on SOLR-14546:
--
I will merge this tomorrow (after re running precommit and
murblanc commented on pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561#issuecomment-647793592
I guess I didn't take the shortest route to rebase this PR, but at least the
diff is easy to see now.
I plan to merge this tomorrow, in case somebody wants to have a
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142433#comment-17142433
]
ASF subversion and git services commented on LUCENE-8962:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142431#comment-17142431
]
ASF subversion and git services commented on LUCENE-8962:
-
Commit
David Smiley created LUCENE-9415:
Summary: Rename MergePolicy.size to sizeInBytes
Key: LUCENE-9415
URL: https://issues.apache.org/jira/browse/LUCENE-9415
Project: Lucene - Core
Issue Type:
dsmiley commented on a change in pull request #1222:
URL: https://github.com/apache/lucene-solr/pull/1222#discussion_r443837114
##
File path:
lucene/core/src/java/org/apache/lucene/index/EagerCheapMergePolicy.java
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software
dsmiley commented on a change in pull request #1222:
URL: https://github.com/apache/lucene-solr/pull/1222#discussion_r443837114
##
File path:
lucene/core/src/java/org/apache/lucene/index/EagerCheapMergePolicy.java
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software
dsmiley commented on pull request #1222:
URL: https://github.com/apache/lucene-solr/pull/1222#issuecomment-647776562
The `setCheapLimitConcurrentMergeSegments` limit was simply a precautionary
addition given that I knew these cheap merges would up the write amplification
and so I wanted
[
https://issues.apache.org/jira/browse/SOLR-14581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142416#comment-17142416
]
David Smiley commented on SOLR-14581:
-
Commits themselves take time too so we can't really say much
[
https://issues.apache.org/jira/browse/LUCENE-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142414#comment-17142414
]
David Smiley commented on LUCENE-9414:
--
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142410#comment-17142410
]
Michael Sokolov commented on LUCENE-8962:
-
OK I'll revert from master and branch_8x then
> Can
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless reopened LUCENE-8962:
Reopening to get to the bottom of {{updateDocument}}'s atomicity.
I am also curious
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142395#comment-17142395
]
Michael McCandless commented on LUCENE-8962:
{quote}[~mikemccand] WDYT I think we should
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142389#comment-17142389
]
Simon Willnauer commented on LUCENE-8962:
-
This would also explain the failure I am looking into
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142388#comment-17142388
]
Simon Willnauer commented on LUCENE-8962:
-
[~msoko...@gmail.com] I think I have bad news for
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142384#comment-17142384
]
Megan Carey commented on SOLR-14586:
Admittedly, I was not aware that Java lambda functions were a
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142380#comment-17142380
]
David Smiley commented on LUCENE-8962:
--
bq. If we decide to do this in the future we can keep the
megancarey commented on a change in pull request #1592:
URL: https://github.com/apache/lucene-solr/pull/1592#discussion_r443788954
##
File path:
solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimClusterStateProvider.java
##
@@ -351,10 +340,10 @@ public void
megancarey commented on a change in pull request #1592:
URL: https://github.com/apache/lucene-solr/pull/1592#discussion_r443788954
##
File path:
solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimClusterStateProvider.java
##
@@ -351,10 +340,10 @@ public void
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142370#comment-17142370
]
Andrzej Bialecki commented on SOLR-14586:
-
It was relatively recently (a couple months ago) using
mikemccand commented on a change in pull request #1601:
URL: https://github.com/apache/lucene-solr/pull/1601#discussion_r443772827
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -4341,27 +4342,33 @@ private synchronized void
murblanc commented on pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561#issuecomment-647690709
Something went wrong here it seems when I tried to add just one commit for
CHANGES.txt
Need to sort this out, possibly cancelling this PR and starting fresh if I
don't
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142309#comment-17142309
]
Mike Drob commented on SOLR-14586:
--
Oh, interesting. Would love to see the perf numbers on this!
bq.
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142303#comment-17142303
]
Simon Willnauer commented on LUCENE-8962:
-
I opened a PR
s1monw commented on a change in pull request #1590:
URL: https://github.com/apache/lucene-solr/pull/1590#discussion_r443728610
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -4286,25 +4287,30 @@ private synchronized void
s1monw commented on pull request #1601:
URL: https://github.com/apache/lucene-solr/pull/1601#issuecomment-647679593
@mikemccand can you take a look
This is an automated message from the Apache Git Service.
To respond to the
s1monw commented on a change in pull request #1601:
URL: https://github.com/apache/lucene-solr/pull/1601#discussion_r443727356
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -4341,27 +4342,33 @@ private synchronized void
s1monw opened a new pull request #1601:
URL: https://github.com/apache/lucene-solr/pull/1601
IW might drop segments that are merged into a fully deleted segment on the
floor
and deletes the newly created files right away. We should not include these
segments
in a commit since we
s1monw commented on a change in pull request #1601:
URL: https://github.com/apache/lucene-solr/pull/1601#discussion_r443727012
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -3234,15 +3234,23 @@ private long prepareCommitInternal() throws
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilan Ginzburg resolved SOLR-12823.
--
Resolution: Fixed
> remove clusterstate.json in Lucene/Solr 9.0
>
Ilan Ginzburg created SOLR-14587:
Summary: Need a test for SolrCloud Zookeeper chroot
Key: SOLR-14587
URL: https://issues.apache.org/jira/browse/SOLR-14587
Project: Solr
Issue Type: Test
[
https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilan Ginzburg reassigned SOLR-14546:
Assignee: Ilan Ginzburg
> OverseerTaskProcessor can process messages out of order
>
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142264#comment-17142264
]
Andrzej Bialecki commented on SOLR-14586:
-
There's some back story behind this ... some time ago
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142249#comment-17142249
]
Mike Drob commented on SOLR-14586:
--
HashMap::new doesn't work here because computeIfAbsent expects us to
murblanc commented on pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561#issuecomment-647633475
@madrob do you want to have another look or shall I merge it? (now that I
can :)
This is an automated
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilan Ginzburg reassigned SOLR-12823:
Assignee: Ilan Ginzburg (was: Mike Drob)
> remove clusterstate.json in Lucene/Solr 9.0
>
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142226#comment-17142226
]
ASF subversion and git services commented on SOLR-12823:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142227#comment-17142227
]
ASF subversion and git services commented on SOLR-12823:
Commit
murblanc merged pull request #1575:
URL: https://github.com/apache/lucene-solr/pull/1575
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142221#comment-17142221
]
Michael Sokolov commented on LUCENE-9286:
-
[~tomoko] thanks! I think you could start by
[
https://issues.apache.org/jira/browse/LUCENE-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved LUCENE-7631.
---
Assignee: Erick Erickson
Resolution: Duplicate
Handled by Erick elsewhere.
> Enforce javac
[
https://issues.apache.org/jira/browse/LUCENE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved LUCENE-6232.
---
Resolution: Duplicate
This was cleaned up by the recent work on removing warnings.
> Replace
[
https://issues.apache.org/jira/browse/SOLR-8885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142206#comment-17142206
]
Mike Drob commented on SOLR-8885:
-
[~marcussorealheis] - this probably interests you.
> Update JS lib
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142197#comment-17142197
]
Simon Willnauer commented on LUCENE-8962:
-
I attached a log file with a failure and index writer
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Willnauer updated LUCENE-8962:
Attachment: failure_log.txt
> Can we merge small segments during refresh, for faster
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142196#comment-17142196
]
Mike Drob commented on SOLR-14576:
--
Do you have GC logs or a heap dump analysis highlighting it? I'd be
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142190#comment-17142190
]
Erick Erickson commented on LUCENE-8962:
Sounds like it may _not_ be related to SOLR-13268 then,
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142184#comment-17142184
]
Simon Willnauer commented on LUCENE-8962:
-
I can reproduce this every 10 iterations. Funny
[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142173#comment-17142173
]
Erick Erickson commented on LUCENE-9411:
Hmmm, maybe we're OK if we restrict it to Gradle. I'd
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142147#comment-17142147
]
Andrzej Bialecki edited comment on SOLR-14586 at 6/22/20, 3:05 PM:
---
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142147#comment-17142147
]
Andrzej Bialecki commented on SOLR-14586:
-
[~mdrob] this lambda was probably inlined - can you
[
https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142136#comment-17142136
]
Tomoko Uchida commented on LUCENE-9286:
---
My words might not be clear enough...
+1 for using
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142118#comment-17142118
]
Mike Drob commented on SOLR-14586:
--
bq. Now imagine that method getting called millions of times and
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142110#comment-17142110
]
Erick Erickson edited comment on LUCENE-8962 at 6/22/20, 2:44 PM:
--
dsmiley opened a new pull request #1600:
URL: https://github.com/apache/lucene-solr/pull/1600
Convert String and File paths to Path API.
CoreContainer seems to me the proper place for the node to expose key
directories at a node level. It's already doing this. It looked a bit
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142112#comment-17142112
]
Mike Drob commented on SOLR-14586:
--
Why not simply {{HashMap::new}}
> replace the second function
[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142108#comment-17142108
]
Gus Heck commented on LUCENE-9411:
--
There seem to be a number of Apache projects that have found (or
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142110#comment-17142110
]
Erick Erickson commented on LUCENE-8962:
[~mikemccand] Ever since I changed Solr to use asnyc
noblepaul commented on pull request #1568:
URL: https://github.com/apache/lucene-solr/pull/1568#issuecomment-647542614
Any benchmark numbers?
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142059#comment-17142059
]
Michael McCandless commented on LUCENE-9286:
+1 to simply download/extract docs from
[
https://issues.apache.org/jira/browse/LUCENE-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142058#comment-17142058
]
Michael McCandless commented on LUCENE-9414:
{quote}[~mikemccand]: I forked this off to its
mikemccand commented on a change in pull request #1576:
URL: https://github.com/apache/lucene-solr/pull/1576#discussion_r443573360
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -2144,39 +2145,43 @@ private synchronized boolean
noblepaul opened a new pull request #1599:
URL: https://github.com/apache/lucene-solr/pull/1599
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-14586:
--
Description:
people misunderstand lambdas
let's look at a very innocuous looking piece of code
Noble Paul created SOLR-14586:
-
Summary: replace the second function parameter in computeIfAbsent
with static vars
Key: SOLR-14586
URL: https://issues.apache.org/jira/browse/SOLR-14586
Project: Solr
mikemccand commented on a change in pull request #1222:
URL: https://github.com/apache/lucene-solr/pull/1222#discussion_r443554965
##
File path:
lucene/core/src/java/org/apache/lucene/index/EagerCheapMergePolicy.java
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache
mikemccand commented on a change in pull request #1222:
URL: https://github.com/apache/lucene-solr/pull/1222#discussion_r443549705
##
File path:
lucene/core/src/java/org/apache/lucene/index/EagerCheapMergePolicy.java
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache
mikemccand commented on a change in pull request #1222:
URL: https://github.com/apache/lucene-solr/pull/1222#discussion_r443550217
##
File path:
lucene/core/src/java/org/apache/lucene/index/EagerCheapMergePolicy.java
##
@@ -0,0 +1,202 @@
+/*
Review comment:
I think
mikemccand commented on a change in pull request #1222:
URL: https://github.com/apache/lucene-solr/pull/1222#discussion_r443549705
##
File path:
lucene/core/src/java/org/apache/lucene/index/EagerCheapMergePolicy.java
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache
jpountz commented on pull request #1593:
URL: https://github.com/apache/lucene-solr/pull/1593#issuecomment-647511693
I like the CorruptIndexException because it tells me that the problem is
that the file got altered after being written, while I would otherwise wonder
if there is a bug in
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142026#comment-17142026
]
Michael McCandless commented on LUCENE-8962:
{quote}It seems like this caused this test
[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142022#comment-17142022
]
Michael Sokolov commented on LUCENE-9411:
-
Does the presence of a SpotBugs annotation on a
mikemccand commented on a change in pull request #1590:
URL: https://github.com/apache/lucene-solr/pull/1590#discussion_r443538263
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -4286,25 +4287,30 @@ private synchronized void
msokolov commented on a change in pull request #1592:
URL: https://github.com/apache/lucene-solr/pull/1592#discussion_r443535745
##
File path:
solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimClusterStateProvider.java
##
@@ -351,10 +340,10 @@ public void
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142010#comment-17142010
]
Michael Sokolov commented on LUCENE-8962:
-
Re: the TestIndexWriter failure. I tried running this
[
https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142003#comment-17142003
]
Erick Erickson commented on SOLR-14579:
---
I'm still working on it. 9x should compile cleanly, 8x
mikemccand commented on pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-647487636
Thanks @s1monw @msfroh @msokolov! What an awesome feature and great OSS
collaboration bringing it to Lucene!
janhoy commented on pull request #1597:
URL: https://github.com/apache/lucene-solr/pull/1597#issuecomment-647483591
There is also a reference in jetty-ssl.xml, which is the defaults to
`./etc/solr-ssl.keystore.jks`. Don't know if it is useful with a default here
at all?
[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141504#comment-17141504
]
Erick Erickson edited comment on LUCENE-9411 at 6/22/20, 12:07 PM:
---
[
https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141972#comment-17141972
]
Noble Paul commented on SOLR-14579:
---
Didn't you suppress all the warnings [~erickerickson]?
> Remove
[
https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141964#comment-17141964
]
Erick Erickson commented on SOLR-14579:
---
Get used to me asking this ;). But will it compile without
[
https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141911#comment-17141911
]
Ilan Ginzburg commented on SOLR-14579:
--
I second [~ab] here. When we write non obvious code, we
1 - 100 of 114 matches
Mail list logo
