[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-24 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445321786 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java ## @@ -44,25 +48,20 @@ public boolean

[GitHub] [lucene-solr] dsmiley merged pull request #1600: SOLR Move "userfiles" stuff from SolrPaths to CoreContainer.

2020-06-24 Thread GitBox
dsmiley merged pull request #1600: URL: https://github.com/apache/lucene-solr/pull/1600 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144622#comment-17144622 ] BARIS KAZAR commented on LUCENE-9221: - [^lucene_logo8_full.pdf] > Lucene Logo Contest >

[jira] [Updated] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BARIS KAZAR updated LUCENE-9221: Attachment: lucene_logo8_full.pdf > Lucene Logo Contest > --- > >

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144621#comment-17144621 ] BARIS KAZAR commented on LUCENE-9221: - [^lucene_logo7_full.pdf] > Lucene Logo Contest >

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144620#comment-17144620 ] BARIS KAZAR commented on LUCENE-9221: - [^lucene_logo6_full.pdf] > Lucene Logo Contest >

[jira] [Updated] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BARIS KAZAR updated LUCENE-9221: Attachment: lucene_logo6_full.pdf > Lucene Logo Contest > --- > >

[jira] [Updated] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BARIS KAZAR updated LUCENE-9221: Attachment: lucene_logo7_full.pdf > Lucene Logo Contest > --- > >

[jira] [Updated] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BARIS KAZAR updated LUCENE-9221: Attachment: lucene_logo5_full.pdf > Lucene Logo Contest > --- > >

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144618#comment-17144618 ] BARIS KAZAR commented on LUCENE-9221: - [^lucene_logo5_full.pdf] > Lucene Logo Contest >

[jira] [Commented] (SOLR-14404) CoreContainer level custom requesthandlers

2020-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144617#comment-17144617 ] ASF subversion and git services commented on SOLR-14404: Commit

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144614#comment-17144614 ] BARIS KAZAR commented on LUCENE-9221: - [^lucene_logo3_full.pdf] > Lucene Logo Contest >

[jira] [Updated] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BARIS KAZAR updated LUCENE-9221: Attachment: lucene_logo3_full.pdf > Lucene Logo Contest > --- > >

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144616#comment-17144616 ] BARIS KAZAR commented on LUCENE-9221: - [^lucene_logo4_full.pdf] > Lucene Logo Contest >

[jira] [Updated] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BARIS KAZAR updated LUCENE-9221: Attachment: lucene_logo4_full.pdf > Lucene Logo Contest > --- > >

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144612#comment-17144612 ] BARIS KAZAR commented on LUCENE-9221: - [^lucene_logo1_full.pdf] > Lucene Logo Contest >

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144613#comment-17144613 ] BARIS KAZAR commented on LUCENE-9221: - [^lucene_logo2_full.pdf] > Lucene Logo Contest >

[jira] [Updated] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BARIS KAZAR updated LUCENE-9221: Attachment: lucene_logo2_full.pdf > Lucene Logo Contest > --- > >

[jira] [Updated] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BARIS KAZAR updated LUCENE-9221: Attachment: lucene_logo1_full.pdf > Lucene Logo Contest > --- > >

[jira] [Commented] (SOLR-14404) CoreContainer level custom requesthandlers

2020-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144606#comment-17144606 ] ASF subversion and git services commented on SOLR-14404: Commit

[jira] [Commented] (SOLR-14404) CoreContainer level custom requesthandlers

2020-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144605#comment-17144605 ] ASF subversion and git services commented on SOLR-14404: Commit

[GitHub] [lucene-solr] noblepaul merged pull request #1432: SOLR-14404 CoreContainer level custom requesthandlers

2020-06-24 Thread GitBox
noblepaul merged pull request #1432: URL: https://github.com/apache/lucene-solr/pull/1432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-24 Thread GitBox
ErickErickson commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445269392 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/CloudSolrStream.java ## @@ -491,6 +490,11 @@ public boolean

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-24 Thread GitBox
ErickErickson commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445264830 ## File path: solr/solrj/src/java/org/apache/solr/common/util/ValidatingJsonMap.java ## @@ -348,10 +348,12 @@ public boolean equals(Object

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-24 Thread GitBox
ErickErickson commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445263758 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkNodeProps.java ## @@ -171,8 +167,10 @@ public boolean getBool(String key,

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-24 Thread GitBox
ErickErickson commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445263481 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java ## @@ -153,10 +152,12 @@ public boolean equals(Object o) {

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-24 Thread GitBox
ErickErickson commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445263282 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java ## @@ -383,10 +382,12 @@ public boolean equals(Object that) {

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-24 Thread GitBox
ErickErickson commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445261508 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Policy.java ## @@ -288,10 +287,11 @@ public boolean

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-24 Thread GitBox
ErickErickson commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445260567 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/AutoScalingConfig.java ## @@ -587,11 +585,11 @@ public

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-24 Thread GitBox
ErickErickson commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445257281 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/AutoScalingConfig.java ## @@ -305,10 +303,10 @@ public

[jira] [Resolved] (SOLR-14409) Existing violations allow bypassing policy rules when adding new replicas

2020-06-24 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-14409. --- Resolution: Fixed > Existing violations allow bypassing policy rules when adding new replicas >

[jira] [Commented] (SOLR-14409) Existing violations allow bypassing policy rules when adding new replicas

2020-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144574#comment-17144574 ] ASF subversion and git services commented on SOLR-14409: Commit

[jira] [Commented] (SOLR-14409) Existing violations allow bypassing policy rules when adding new replicas

2020-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144575#comment-17144575 ] ASF subversion and git services commented on SOLR-14409: Commit

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-24 Thread GitBox
ErickErickson commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445252535 ## File path: solr/core/src/java/org/apache/solr/cloud/rule/Rule.java ## @@ -365,7 +365,7 @@ public boolean equals(Object obj) {

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-24 Thread GitBox
ErickErickson commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445252504 ## File path: solr/core/src/java/org/apache/solr/pkg/PackageAPI.java ## @@ -211,7 +211,7 @@ public boolean equals(Object obj) {

[jira] [Created] (SOLR-14592) Upgrade Zookeeper to 3.6.1

2020-06-24 Thread Erick Erickson (Jira)
Erick Erickson created SOLR-14592: - Summary: Upgrade Zookeeper to 3.6.1 Key: SOLR-14592 URL: https://issues.apache.org/jira/browse/SOLR-14592 Project: Solr Issue Type: Bug Security

[jira] [Comment Edited] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key

2020-06-24 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144561#comment-17144561 ] Noble Paul edited comment on SOLR-14576 at 6/25/20, 12:40 AM: -- {quote}Using

[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key

2020-06-24 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144561#comment-17144561 ] Noble Paul commented on SOLR-14576: --- {quote}Using String as a key in an Identity HashMap seems dubious,

[jira] [Commented] (SOLR-14586) replace the second function parameter in Map#computeIfAbsent with static vars

2020-06-24 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144558#comment-17144558 ] Noble Paul commented on SOLR-14586: --- There is no need to rush on this. if anything, this probably is a

[GitHub] [lucene-solr] noblepaul merged pull request #1598: SOLR-14409: Existing violations allow bypassing policy rules when add…

2020-06-24 Thread GitBox
noblepaul merged pull request #1598: URL: https://github.com/apache/lucene-solr/pull/1598 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-14409) Existing violations allow bypassing policy rules when adding new replicas

2020-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144556#comment-17144556 ] ASF subversion and git services commented on SOLR-14409: Commit

[jira] [Commented] (SOLR-14409) Existing violations allow bypassing policy rules when adding new replicas

2020-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144555#comment-17144555 ] ASF subversion and git services commented on SOLR-14409: Commit

[jira] [Resolved] (LUCENE-8716) Test logging can bleed from one suite to another, cause failures due to sysout limits

2020-06-24 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved LUCENE-8716. Resolution: Won't Fix I've essentially given up on this, see the comments in SOLR-13268.

[jira] [Commented] (SOLR-13132) Improve JSON "terms" facet performance when sorted by relatedness

2020-06-24 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144550#comment-17144550 ] Chris M. Hostetter commented on SOLR-13132: --- I pushed a few commits to your branch containing

[GitHub] [lucene-solr] zhaih opened a new pull request #1613: LUCENE-8574 Cache ExpressionFunctionValues

2020-06-24 Thread GitBox
zhaih opened a new pull request #1613: URL: https://github.com/apache/lucene-solr/pull/1613 # Description * Add a new DoubleValuesSource which will enforce only one value per name in dependencies * Add few fields to `ExpressionFunctionValues` to ensure for a given

[jira] [Resolved] (LUCENE-9408) OneMerge#mergeFinish is called multiple times

2020-06-24 Thread Simon Willnauer (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer resolved LUCENE-9408. - Resolution: Fixed > OneMerge#mergeFinish is called multiple times >

[jira] [Updated] (LUCENE-9408) OneMerge#mergeFinish is called multiple times

2020-06-24 Thread Simon Willnauer (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer updated LUCENE-9408: Fix Version/s: 8.6 master (9.0) > OneMerge#mergeFinish is called

[GitHub] [lucene-solr] madrob commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-24 Thread GitBox
madrob commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445188767 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java ## @@ -44,25 +48,20 @@ public boolean

[GitHub] [lucene-solr] madrob opened a new pull request #1612: SOLR-11390 Trie* field javadocs to @see *Point

2020-06-24 Thread GitBox
madrob opened a new pull request #1612: URL: https://github.com/apache/lucene-solr/pull/1612 cc: @cpoerschke I can't tag you as a reviewer for some reason, but this is based on your patch and I added two more changes - fixed spelling and removed back link from DatePoint to TrieDate.

[jira] [Resolved] (LUCENE-6669) PATCH: the the

2020-06-24 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved LUCENE-6669. --- Fix Version/s: master (9.0) Assignee: Mike Drob Resolution: Fixed Saw this while

[jira] [Commented] (LUCENE-6669) PATCH: the the

2020-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144406#comment-17144406 ] ASF subversion and git services commented on LUCENE-6669: - Commit

[jira] [Commented] (SOLR-13688) Make the bin/solr export command to run one thread per shard

2020-06-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144385#comment-17144385 ] David Smiley commented on SOLR-13688: - [~jbernste] just curious; if the ExportTool had been written

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-06-24 Thread Simon Willnauer (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144366#comment-17144366 ] Simon Willnauer commented on LUCENE-8962: - [~sokolov] thanks, I updated the branch with the

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread BARIS KAZAR (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144353#comment-17144353 ] BARIS KAZAR commented on LUCENE-9221: - Ryan,-  i will do that today. Thanks > Lucene Logo

[jira] [Commented] (SOLR-14462) Autoscaling placement wrong with concurrent collection creations

2020-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144259#comment-17144259 ] ASF subversion and git services commented on SOLR-14462: Commit

[jira] [Commented] (SOLR-14462) Autoscaling placement wrong with concurrent collection creations

2020-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144258#comment-17144258 ] ASF subversion and git services commented on SOLR-14462: Commit

[GitHub] [lucene-solr] murblanc merged pull request #1504: SOLR-14462: cache more than one autoscaling session

2020-06-24 Thread GitBox
murblanc merged pull request #1504: URL: https://github.com/apache/lucene-solr/pull/1504 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-9408) OneMerge#mergeFinish is called multiple times

2020-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144231#comment-17144231 ] ASF subversion and git services commented on LUCENE-9408: - Commit

[jira] [Commented] (LUCENE-9408) OneMerge#mergeFinish is called multiple times

2020-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144230#comment-17144230 ] ASF subversion and git services commented on LUCENE-9408: - Commit

[GitHub] [lucene-solr] s1monw merged pull request #1590: LUCENE-9408: Ensure OneMerge#mergeFinished is only called once

2020-06-24 Thread GitBox
s1monw merged pull request #1590: URL: https://github.com/apache/lucene-solr/pull/1590 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-06-24 Thread Ryan Ernst (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144227#comment-17144227 ] Ryan Ernst commented on LUCENE-9221: [~bkazar] I think the Apache text needs to be in each

[jira] [Commented] (SOLR-14329) Add support to choose field for expand component from multiple collapse groups

2020-06-24 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144216#comment-17144216 ] Cassandra Targett commented on SOLR-14329: -- [~munendrasn], Sorry about that, I missed that you

[GitHub] [lucene-solr] atris commented on pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-24 Thread GitBox
atris commented on pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#issuecomment-648995835 @madrob Updated, please see and let me know your thoughts and comments. This is an automated message from the

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-24 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445094485 ## File path: solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java ## @@ -289,6 +295,19 @@ public void

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-24 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445082883 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache

[jira] [Commented] (SOLR-14590) Add support for FeatureField in Solr

2020-06-24 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144109#comment-17144109 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-14590: -- Discussed this briefly with

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-24 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445063185 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] atris merged pull request #1611: Change JoinQuery class's visibility to package again

2020-06-24 Thread GitBox
atris merged pull request #1611: URL: https://github.com/apache/lucene-solr/pull/1611 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] madrob commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-24 Thread GitBox
madrob commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445046053 ## File path: solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java ## @@ -289,6 +295,19 @@ public void

[GitHub] [lucene-solr] atris commented on pull request #1611: Change JoinQuery class's visibility to package again

2020-06-24 Thread GitBox
atris commented on pull request #1611: URL: https://github.com/apache/lucene-solr/pull/1611#issuecomment-648943830 Cool, thanks. Will merge post the CI completion, just to be sure :) This is an automated message from the

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-24 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445038817 ## File path: solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java ## @@ -289,6 +295,19 @@ public void

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-24 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445038316 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] atris opened a new pull request #1611: Fix JoinQuery class's visibility to package again

2020-06-24 Thread GitBox
atris opened a new pull request #1611: URL: https://github.com/apache/lucene-solr/pull/1611 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr] atris commented on pull request #1611: Change JoinQuery class's visibility to package again

2020-06-24 Thread GitBox
atris commented on pull request #1611: URL: https://github.com/apache/lucene-solr/pull/1611#issuecomment-648941896 @dsmiley Updated as per discussion This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene-solr] s1monw commented on pull request #1601: LUCENE-8962: Ensure we don't include fully deleted segments in a commit

2020-06-24 Thread GitBox
s1monw commented on pull request #1601: URL: https://github.com/apache/lucene-solr/pull/1601#issuecomment-648938745 I pushed all the commits and fixes for your comments to this branch https://github.com/apache/lucene-solr/tree/jira/lucene-8962

[GitHub] [lucene-solr] s1monw closed pull request #1601: LUCENE-8962: Ensure we don't include fully deleted segments in a commit

2020-06-24 Thread GitBox
s1monw closed pull request #1601: URL: https://github.com/apache/lucene-solr/pull/1601 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-14591) Move JoinQuery in JoinQParserPlugin to its own class

2020-06-24 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144033#comment-17144033 ] Atri Sharma commented on SOLR-14591: I I made it public since it seems weird to have an independent

[jira] [Commented] (SOLR-14591) Move JoinQuery in JoinQParserPlugin to its own class

2020-06-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144021#comment-17144021 ] David Smiley commented on SOLR-14591: - I this _also_ changed the visibility of JoinQuery from package

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1601: LUCENE-8962: Ensure we don't include fully deleted segments in a commit

2020-06-24 Thread GitBox
s1monw commented on a change in pull request #1601: URL: https://github.com/apache/lucene-solr/pull/1601#discussion_r445021609 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriterMergePolicy.java ## @@ -396,10 +396,12 @@ protected void

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-24 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445015098 ## File path: solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java ## @@ -289,6 +295,19 @@ public void

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-24 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445011734 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1590: LUCENE-9408: Ensure OneMerge#mergeFinished is only called once

2020-06-24 Thread GitBox
s1monw commented on a change in pull request #1590: URL: https://github.com/apache/lucene-solr/pull/1590#discussion_r445010346 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -4286,25 +4287,30 @@ private synchronized void

[jira] [Commented] (SOLR-14591) Move JoinQuery in JoinQParserPlugin to its own class

2020-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143974#comment-17143974 ] ASF subversion and git services commented on SOLR-14591: Commit

[jira] [Commented] (SOLR-14591) Move JoinQuery in JoinQParserPlugin to its own class

2020-06-24 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143971#comment-17143971 ] Erick Erickson commented on SOLR-14591: --- [~atris] This is exactly what I was going to do, so

[GitHub] [lucene-solr] atris commented on pull request #1609: SOLR-14591: Move JoinQuery To Its Own File

2020-06-24 Thread GitBox
atris commented on pull request #1609: URL: https://github.com/apache/lucene-solr/pull/1609#issuecomment-648914229 Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene-solr] atris merged pull request #1609: SOLR-14591: Move JoinQuery To Its Own File

2020-06-24 Thread GitBox
atris merged pull request #1609: URL: https://github.com/apache/lucene-solr/pull/1609 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] ErickErickson commented on pull request #1609: SOLR-14591: Move JoinQuery To Its Own File

2020-06-24 Thread GitBox
ErickErickson commented on pull request #1609: URL: https://github.com/apache/lucene-solr/pull/1609#issuecomment-648913033 OK, I'm messing up the reviewer thing, ignore it. This is exactly what I was going to do, please go ahead and merge it in.

[GitHub] [lucene-solr] atris commented on pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-24 Thread GitBox
atris commented on pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#issuecomment-648911905 > How does this work for distributed requests? When the coordinator node is under memory pressure? When one of the fan out nodes in under memory pressure? I believe the

[jira] [Resolved] (SOLR-8354) RecoveryStrategy retry timing is innaccurate

2020-06-24 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-8354. - Resolution: Duplicate Fixed in 75b183196798232aa6f2dcb117f309119053 > RecoveryStrategy retry timing

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-24 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444994179 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1601: LUCENE-8962: Ensure we don't include fully deleted segments in a commit

2020-06-24 Thread GitBox
mikemccand commented on a change in pull request #1601: URL: https://github.com/apache/lucene-solr/pull/1601#discussion_r444984980 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriterMergePolicy.java ## @@ -396,10 +396,12 @@ protected void

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1608: LUCENE-9379: Encrypting Directory - functional but to optimize

2020-06-24 Thread GitBox
juanka588 commented on a change in pull request #1608: URL: https://github.com/apache/lucene-solr/pull/1608#discussion_r444991113 ## File path: lucene/core/src/java/org/apache/lucene/store/EncryptingDirectory.java ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software

[jira] [Resolved] (SOLR-10027) TestCoreDiscovery.testCoreDirCantRead fails when run as superuser

2020-06-24 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-10027. -- Resolution: Duplicate > TestCoreDiscovery.testCoreDirCantRead fails when run as superuser >

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-24 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444988588 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache

[jira] [Resolved] (SOLR-14524) Harden MultiThreadedOCPTest

2020-06-24 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-14524. -- Resolution: Fixed re-resolving since linked issue is done > Harden MultiThreadedOCPTest >

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1608: LUCENE-9379: Encrypting Directory - functional but to optimize

2020-06-24 Thread GitBox
juanka588 commented on a change in pull request #1608: URL: https://github.com/apache/lucene-solr/pull/1608#discussion_r444988334 ## File path: lucene/core/src/java/org/apache/lucene/store/EncryptingDirectory.java ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] mayya-sharipova opened a new pull request #1610: LUCENE-9384: Backport for field sort optimization

2020-06-24 Thread GitBox
mayya-sharipova opened a new pull request #1610: URL: https://github.com/apache/lucene-solr/pull/1610 Backport for: LUCENE-9280: Collectors to skip noncompetitive documents (#1351) Similar how scorers can update their iterators to skip non-competitive documents, collectors and

[jira] [Commented] (SOLR-14586) replace the second function parameter in Map#computeIfAbsent with static vars

2020-06-24 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143941#comment-17143941 ] Mike Drob commented on SOLR-14586: -- I'm still very interested in hearing from [~ab] when he has time. I

[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key

2020-06-24 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143935#comment-17143935 ] Mike Drob commented on SOLR-14576: -- I'm worried about two things here - 1) Using String as a key in an

[jira] [Commented] (SOLR-14591) Move JoinQuery in JoinQParserPlugin to its own class

2020-06-24 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143933#comment-17143933 ] Atri Sharma commented on SOLR-14591: [~erickerickson] I have raised a PR for this – please take a

  1   2   >