[GitHub] [lucene] zacharymorn commented on a change in pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

2021-08-18 Thread GitBox
zacharymorn commented on a change in pull request #240: URL: https://github.com/apache/lucene/pull/240#discussion_r691795187 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollectorManager.java ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene] gautamworah96 commented on pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-18 Thread GitBox
gautamworah96 commented on pull request #179: URL: https://github.com/apache/lucene/pull/179#issuecomment-901547047 Hey @mikemccand , my apologies for leaving this PR hanging! The unexpected benchmark results threw me off.. I've updated the PR to fix the bug you had previously

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-18 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r691713240 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +349,139 @@ public

[jira] [Created] (LUCENE-10056) Support multiple ToParentBlockJoinQuery instances in a BooleanQuery with Occur == MUST/FILTER

2021-08-18 Thread Greg Miller (Jira)
Greg Miller created LUCENE-10056: Summary: Support multiple ToParentBlockJoinQuery instances in a BooleanQuery with Occur == MUST/FILTER Key: LUCENE-10056 URL: https://issues.apache.org/jira/browse/LUCENE-10056

[jira] [Commented] (LUCENE-10055) Update release scripts and documentation to use new INFRA svn repo

2021-08-18 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401383#comment-17401383 ] Uwe Schindler commented on LUCENE-10055: Thanks Houston for opening the issue. To correct the

[jira] [Commented] (LUCENE-8638) Remove deprecated code in main

2021-08-18 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401330#comment-17401330 ] Michael Sokolov commented on LUCENE-8638: - I see, thanks [~mdrob]. I only noticed that because I

[jira] [Commented] (LUCENE-8638) Remove deprecated code in main

2021-08-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401326#comment-17401326 ] ASF subversion and git services commented on LUCENE-8638: - Commit

[GitHub] [lucene] msokolov merged pull request #247: LUCENE-8638: remove LegacyBM25Similarity

2021-08-18 Thread GitBox
msokolov merged pull request #247: URL: https://github.com/apache/lucene/pull/247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (LUCENE-10055) Update release scripts and documentation to use new INFRA svn repo

2021-08-18 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated LUCENE-10055: Description: Apache infra is deprecating (and soon removing) the SVN repo that we used

[jira] [Created] (LUCENE-10055) Update release scripts and documentation to use new INFRA svn repo

2021-08-18 Thread Houston Putman (Jira)
Houston Putman created LUCENE-10055: --- Summary: Update release scripts and documentation to use new INFRA svn repo Key: LUCENE-10055 URL: https://issues.apache.org/jira/browse/LUCENE-10055 Project:

[GitHub] [lucene] msokolov merged pull request #241: LUCENE-10016: Added KnnVector index/query support to demo

2021-08-18 Thread GitBox
msokolov merged pull request #241: URL: https://github.com/apache/lucene/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] gsmiller closed pull request #233: LUCENE-10045: Extend ConjunctionUtils to support LongValues and DoubleValues

2021-08-18 Thread GitBox
gsmiller closed pull request #233: URL: https://github.com/apache/lucene/pull/233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] gautamworah96 commented on a change in pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-08-18 Thread GitBox
gautamworah96 commented on a change in pull request #242: URL: https://github.com/apache/lucene/pull/242#discussion_r690844493 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -174,6 +174,31 @@ public BulkScorer bulkScorer(LeafReaderContext

[GitHub] [lucene] msokolov merged pull request #246: LUCENE-8638: remove long-deprecated Jaspell suggester

2021-08-18 Thread GitBox
msokolov merged pull request #246: URL: https://github.com/apache/lucene/pull/246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] mikemccand commented on pull request #245: LUCENE-10052: first cut at LTC.newBytesRef methods, and switching a few test cases over

2021-08-18 Thread GitBox
mikemccand commented on pull request #245: URL: https://github.com/apache/lucene/pull/245#issuecomment-900601218 > I like how easy it is to use from tests, just migrate from `new BytesRef(...` to `newBytesRef(...`. Yeah! Just remove the one space character! > As followup

[GitHub] [lucene-solr] xiaoshi2013 closed pull request #2555: Branch 8x zl

2021-08-18 Thread GitBox
xiaoshi2013 closed pull request #2555: URL: https://github.com/apache/lucene-solr/pull/2555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] msokolov commented on pull request #243: LUCENE-8638: remove deprecated code

2021-08-18 Thread GitBox
msokolov commented on pull request #243: URL: https://github.com/apache/lucene/pull/243#issuecomment-900422588 OK I added the haversin() change to CHANGES.txt. I also removed the fixes relating to TermVector refactoring that may be controversial. I'll push this soon. -- This is an

[GitHub] [lucene] msokolov merged pull request #249: LUCENE-8638: remove deprecated FST get by output

2021-08-18 Thread GitBox
msokolov merged pull request #249: URL: https://github.com/apache/lucene/pull/249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] gautamworah96 edited a comment on pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-08-18 Thread GitBox
gautamworah96 edited a comment on pull request #242: URL: https://github.com/apache/lucene/pull/242#issuecomment-900757557 Fixed the `IndexSearcher#count` API > then the top hits collector would not have to collect some documents only for the purpose of counting hits. Not

[GitHub] [lucene-solr] HoustonPutman merged pull request #2554: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-08-18 Thread GitBox
HoustonPutman merged pull request #2554: URL: https://github.com/apache/lucene-solr/pull/2554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] mikemccand merged pull request #245: LUCENE-10052: first cut at LTC.newBytesRef methods, and switching a few test cases over

2021-08-18 Thread GitBox
mikemccand merged pull request #245: URL: https://github.com/apache/lucene/pull/245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] msokolov merged pull request #243: LUCENE-8638: remove deprecated code

2021-08-18 Thread GitBox
msokolov merged pull request #243: URL: https://github.com/apache/lucene/pull/243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] msokolov merged pull request #248: LUCENE-8638: remove unused deprecated methods and related tests

2021-08-18 Thread GitBox
msokolov merged pull request #248: URL: https://github.com/apache/lucene/pull/248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

2021-08-18 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401203#comment-17401203 ] Greg Miller commented on LUCENE-10033: -- I also tried an iteration that lazily applies the GCD and

[GitHub] [lucene] gautamworah96 commented on pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-08-18 Thread GitBox
gautamworah96 commented on pull request #242: URL: https://github.com/apache/lucene/pull/242#issuecomment-900757557 > then the top hits collector would not have to collect some documents only for the purpose of counting hits. Not sure I understand this correctly. IIUC, today,

[GitHub] [lucene] msokolov commented on pull request #249: LUCENE-8638: remove deprecated FST get by output

2021-08-18 Thread GitBox
msokolov commented on pull request #249: URL: https://github.com/apache/lucene/pull/249#issuecomment-901063571 Thanks, Dawid -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [lucene] gsmiller commented on pull request #233: LUCENE-10045: Extend ConjunctionUtils to support LongValues and DoubleValues

2021-08-18 Thread GitBox
gsmiller commented on pull request #233: URL: https://github.com/apache/lucene/pull/233#issuecomment-900434388 @jpountz I think that's a fair view of this work. Apologies for overlooking the past related discussions as well; looks like it does overlap a fair amount with these. From

[GitHub] [lucene-solr] HoustonPutman commented on pull request #2554: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-08-18 Thread GitBox
HoustonPutman commented on pull request #2554: URL: https://github.com/apache/lucene-solr/pull/2554#issuecomment-900692756 `ant test` and `ant precommit` pass, will merge tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Comment Edited] (LUCENE-10054) Handle hierarchy in HNSW graph

2021-08-18 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401172#comment-17401172 ] Mayya Sharipova edited comment on LUCENE-10054 at 8/18/21, 4:12 PM:

[GitHub] [lucene] gautamworah96 commented on a change in pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-08-18 Thread GitBox
gautamworah96 commented on a change in pull request #242: URL: https://github.com/apache/lucene/pull/242#discussion_r691403822 ## File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java ## @@ -414,37 +414,13 @@ public int count(Query query) throws

[jira] [Comment Edited] (LUCENE-10054) Handle hierarchy in HNSW graph

2021-08-18 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401172#comment-17401172 ] Mayya Sharipova edited comment on LUCENE-10054 at 8/18/21, 4:07 PM:

[jira] [Commented] (LUCENE-10054) Handle hierarchy in HNSW graph

2021-08-18 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401172#comment-17401172 ] Mayya Sharipova commented on LUCENE-10054: -- Proposed .vem index file structure:

[GitHub] [lucene-solr] HoustonPutman merged pull request #2554: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-08-18 Thread GitBox
HoustonPutman merged pull request #2554: URL: https://github.com/apache/lucene-solr/pull/2554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-10053) Lucene file deletion seems to hang on Windows Server

2021-08-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401126#comment-17401126 ] Dawid Weiss commented on LUCENE-10053: -- You can try the command line - jps to get the process PID.

[GitHub] [lucene-solr] xiaoshi2013 opened a new pull request #2556: LUCENE-10051 lucene branch_8x run ant run-task error

2021-08-18 Thread GitBox
xiaoshi2013 opened a new pull request #2556: URL: https://github.com/apache/lucene-solr/pull/2556 LUCENE-10051 lucene branch_8x run ant run-task error bugfix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] mayya-sharipova opened a new pull request #250: LUCENE-10054 Make HnswGraph hierarchical

2021-08-18 Thread GitBox
mayya-sharipova opened a new pull request #250: URL: https://github.com/apache/lucene/pull/250 Currently HNSW has only a single layer. This is the first part to make it multi-layered. To keep changes small, this PR only adds multiple layers in the HnswGraph class. TODO

[jira] [Created] (LUCENE-10054) Handle hierarchy in HNSW graph

2021-08-18 Thread Mayya Sharipova (Jira)
Mayya Sharipova created LUCENE-10054: Summary: Handle hierarchy in HNSW graph Key: LUCENE-10054 URL: https://issues.apache.org/jira/browse/LUCENE-10054 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-8638) Remove deprecated code in main

2021-08-18 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401029#comment-17401029 ] Mike Drob commented on LUCENE-8638: --- The assertions are because LuceneTestCase extends Assert and uses

[jira] [Commented] (LUCENE-10053) Lucene file deletion seems to hang on Windows Server

2021-08-18 Thread Rayane (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401027#comment-17401027 ] Rayane commented on LUCENE-10053: - [~dweiss] Thanks for your help ! I tried creating a dump file from

[jira] [Commented] (LUCENE-8638) Remove deprecated code in main

2021-08-18 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401026#comment-17401026 ] Michael Sokolov commented on LUCENE-8638: - I think this is close to "done enough" now. I plan to

[jira] [Commented] (LUCENE-10053) Lucene file deletion seems to hang on Windows Server

2021-08-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401023#comment-17401023 ] Dawid Weiss commented on LUCENE-10053: -- You'd need to dump those stack traces with native frames,

[jira] [Resolved] (LUCENE-10016) VectorReader.search needs rethought, o.a.l.search integration?

2021-08-18 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Sokolov resolved LUCENE-10016. -- Resolution: Fixed [~rcmuir] thanks for opening this; I think we can resolve now. >

[jira] [Comment Edited] (LUCENE-8638) Remove deprecated code in main

2021-08-18 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400540#comment-17400540 ] Michael Sokolov edited comment on LUCENE-8638 at 8/18/21, 12:33 PM:

[jira] [Commented] (LUCENE-8638) Remove deprecated code in main

2021-08-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401016#comment-17401016 ] ASF subversion and git services commented on LUCENE-8638: - Commit

[GitHub] [lucene] msokolov merged pull request #248: LUCENE-8638: remove unused deprecated methods and related tests

2021-08-18 Thread GitBox
msokolov merged pull request #248: URL: https://github.com/apache/lucene/pull/248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-8638) Remove deprecated code in main

2021-08-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401013#comment-17401013 ] ASF subversion and git services commented on LUCENE-8638: - Commit

[GitHub] [lucene] msokolov merged pull request #249: LUCENE-8638: remove deprecated FST get by output

2021-08-18 Thread GitBox
msokolov merged pull request #249: URL: https://github.com/apache/lucene/pull/249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] msokolov commented on pull request #249: LUCENE-8638: remove deprecated FST get by output

2021-08-18 Thread GitBox
msokolov commented on pull request #249: URL: https://github.com/apache/lucene/pull/249#issuecomment-901063571 Thanks, Dawid -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (LUCENE-10016) VectorReader.search needs rethought, o.a.l.search integration?

2021-08-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401010#comment-17401010 ] ASF subversion and git services commented on LUCENE-10016: -- Commit

[GitHub] [lucene] msokolov merged pull request #241: LUCENE-10016: Added KnnVector index/query support to demo

2021-08-18 Thread GitBox
msokolov merged pull request #241: URL: https://github.com/apache/lucene/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (LUCENE-10053) Lucene file deletion seems to hang on Windows Server

2021-08-18 Thread Rayane (Jira)
Rayane created LUCENE-10053: --- Summary: Lucene file deletion seems to hang on Windows Server Key: LUCENE-10053 URL: https://issues.apache.org/jira/browse/LUCENE-10053 Project: Lucene - Core Issue