wormday commented on PR #953:
URL: https://github.com/apache/lucene/pull/953#issuecomment-1152830515
@zhaih @mocobeta
Thanks for everyone's help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552947#comment-17552947
]
Robert Muir commented on LUCENE-10610:
--
and for the same reason, again, we can do something else
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552943#comment-17552943
]
Robert Muir commented on LUCENE-10610:
--
it is much more complicated. I really don't think we
gsmiller commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1152648521
> So again, purely from an API perspective, we tell the user "You give us
long[] at indexing time, we'll give it you back at aggregation time". It's
simple, readable, intuitive.
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552909#comment-17552909
]
Tomoko Uchida edited comment on LUCENE-10610 at 6/10/22 6:25 PM:
-
I may
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552909#comment-17552909
]
Tomoko Uchida commented on LUCENE-10610:
I may completely miss the point so correct me if I'm
gsmiller commented on code in PR #929:
URL: https://github.com/apache/lucene/pull/929#discussion_r894787988
##
lucene/facet/src/java/org/apache/lucene/facet/sortedset/AbstractSortedSetDocValueFacetCounts.java:
##
@@ -74,7 +74,7 @@ public FacetResult getTopChildren(int topN,
mdmarshmallow commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1152603748
>Is this about providing enough information to optimize with KD/R-Trees? If
that's the case, I don't think we want a matches(long[]) method right? We just
need a way for the FSM
mdmarshmallow commented on code in PR #929:
URL: https://github.com/apache/lucene/pull/929#discussion_r894746323
##
lucene/facet/src/java/org/apache/lucene/facet/sortedset/AbstractSortedSetDocValueFacetCounts.java:
##
@@ -74,7 +74,7 @@ public FacetResult getTopChildren(int
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552861#comment-17552861
]
Robert Muir commented on LUCENE-10610:
--
Also i honestly think the current hashcode based on
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552858#comment-17552858
]
Tomoko Uchida commented on LUCENE-10610:
Ah, if my understanding is correct it seems that it's
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552856#comment-17552856
]
Robert Muir commented on LUCENE-10610:
--
A simple/fast improvement might be to incorporate
[
https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552851#comment-17552851
]
Greg Miller commented on LUCENE-10603:
--
OK, thanks [~ChrisLu]! +1 to doing this for consistency.
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552844#comment-17552844
]
Tomoko Uchida commented on LUCENE-10610:
bq. Let's please not go back to trying to implement
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552827#comment-17552827
]
Robert Muir commented on LUCENE-10610:
--
what uses this hashcode (anything?).
Let's please not go
gsmiller opened a new pull request, #954:
URL: https://github.com/apache/lucene/pull/954
This PR is to migrate the facets module to using the newly-added
`SortedSetDocValues#docValueCount()` for iteration, as described in
LUCENE-10603. It doesn't attempt to move all `SSDV` iteration, just
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552733#comment-17552733
]
Uwe Schindler edited comment on LUCENE-10610 at 6/10/22 12:49 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552733#comment-17552733
]
Uwe Schindler commented on LUCENE-10610:
Thanks for finding this. The solution is:
- Make
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552728#comment-17552728
]
Tomoko Uchida commented on LUCENE-10610:
Right, RunAutomaton has no setters - a cached hash
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552727#comment-17552727
]
Uwe Schindler commented on LUCENE-10610:
I checked the code. If you look at equals you see the
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552725#comment-17552725
]
Uwe Schindler commented on LUCENE-10610:
But the RunAutomaton is not modifiable, right. Then
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552723#comment-17552723
]
Tomoko Uchida commented on LUCENE-10610:
Hmm Automaton is mutable even after calling
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552713#comment-17552713
]
Tomoko Uchida commented on LUCENE-10610:
bq. The problem is that it is expensive to create that
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552710#comment-17552710
]
Uwe Schindler commented on LUCENE-10610:
Yes, but Automaton should cache the hashcode.
>
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552709#comment-17552709
]
Tomoko Uchida commented on LUCENE-10610:
Or, it might be a cleaner approach to have
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552702#comment-17552702
]
Uwe Schindler commented on LUCENE-10610:
The hashCode does not need to be unique. If 2 have
mocobeta commented on PR #953:
URL: https://github.com/apache/lucene/pull/953#issuecomment-1152255099
@wormday you are right. For your information, external contributors do not
have to worry about backporting - it's a maintainers' work. Backporting is
often hard for contributions when it
Tomoko Uchida created LUCENE-10610:
--
Summary: RunAutomaton#hashCode() can easily cause hash collision
for different Automatons
Key: LUCENE-10610
URL: https://issues.apache.org/jira/browse/LUCENE-10610
uschindler commented on PR #949:
URL: https://github.com/apache/lucene/pull/949#issuecomment-1152034336
Hi,
I don't think we need to backport to 8.11 now. We will only do bug fixes
anymore and a new release will be seldom. This is not a serious problem, it
fixes no bug leading to
zhaih commented on PR #953:
URL: https://github.com/apache/lucene/pull/953#issuecomment-1151993206
Yeah, perfect! Merged!
You're right, when we decided to release Lucene 10, a new `branch_10_0` and
`branch_10x` will be cut from `main`, and `main` will become development branch
of Lucene
[
https://issues.apache.org/jira/browse/LUCENE-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552572#comment-17552572
]
ASF subversion and git services commented on LUCENE-10605:
--
Commit
zhaih merged PR #953:
URL: https://github.com/apache/lucene/pull/953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
wormday commented on PR #953:
URL: https://github.com/apache/lucene/pull/953#issuecomment-1151988306
@zhaih Am I doing this right?
I seem to understand.
`main` will become `branch_10x` in the future, `branch_9x` and `main` will
not merge with each other.
Or will branch_9x
LuXugang commented on code in PR #950:
URL: https://github.com/apache/lucene/pull/950#discussion_r894179561
##
lucene/core/src/java/org/apache/lucene/search/BooleanWeight.java:
##
@@ -344,6 +344,45 @@ public BulkScorer bulkScorer(LeafReaderContext context)
throws IOException {
34 matches
Mail list logo
