[jira] [Commented] (LUCENE-10272) checkindex: cross-check norms against docCount

2021-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451133#comment-17451133 ] Robert Muir commented on LUCENE-10272: -- >From my quick inspection of {{invert()}}, it seems the

[jira] [Commented] (LUCENE-10272) checkindex: cross-check norms against docCount

2021-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451125#comment-17451125 ] Robert Muir commented on LUCENE-10272: -- See attached patch, I haven't addressed the non-aborting

[jira] [Created] (LUCENE-10272) checkindex: cross-check norms against docCount

2021-11-30 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10272: Summary: checkindex: cross-check norms against docCount Key: LUCENE-10272 URL: https://issues.apache.org/jira/browse/LUCENE-10272 Project: Lucene - Core

[jira] [Updated] (LUCENE-10272) checkindex: cross-check norms against docCount

2021-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10272: - Attachment: LUCENE-10272.patch > checkindex: cross-check norms against docCount >

[jira] [Commented] (LUCENE-10271) norms are inconsistent with postings

2021-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451112#comment-17451112 ] Robert Muir commented on LUCENE-10271: -- I really do strongly believe we should fix this. In

[jira] [Commented] (LUCENE-10271) norms are inconsistent with postings

2021-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451110#comment-17451110 ] Robert Muir commented on LUCENE-10271: -- {quote} These current semantics also have the benefit of

[jira] [Commented] (LUCENE-10271) norms are inconsistent with postings

2021-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451107#comment-17451107 ] Robert Muir commented on LUCENE-10271: -- [~jpountz]: I only disagree with most of it :) If there

[jira] [Commented] (LUCENE-10271) norms are inconsistent with postings

2021-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451096#comment-17451096 ] Robert Muir commented on LUCENE-10271: -- Attached is a quick prototype patch. For *Lucene 10

[jira] [Updated] (LUCENE-10271) norms are inconsistent with postings

2021-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10271: - Attachment: LUCENE-10271_prototype.patch > norms are inconsistent with postings >

[jira] [Commented] (LUCENE-10271) norms are inconsistent with postings

2021-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451066#comment-17451066 ] Robert Muir commented on LUCENE-10271: -- The purpose of the norms is for scoring on the field, if

[jira] [Created] (LUCENE-10271) norms are inconsistent with postings

2021-11-30 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10271: Summary: norms are inconsistent with postings Key: LUCENE-10271 URL: https://issues.apache.org/jira/browse/LUCENE-10271 Project: Lucene - Core Issue Type:

[jira] [Created] (LUCENE-10270) Improve MIGRATE.md

2021-11-29 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10270: Summary: Improve MIGRATE.md Key: LUCENE-10270 URL: https://issues.apache.org/jira/browse/LUCENE-10270 Project: Lucene - Core Issue Type: Task

[jira] [Commented] (LUCENE-10255) Fully embrace the java module system

2021-11-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450639#comment-17450639 ] Robert Muir commented on LUCENE-10255: -- my comment was a genuine question, as I don't yet

[jira] [Commented] (LUCENE-10255) Fully embrace the java module system

2021-11-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450630#comment-17450630 ] Robert Muir commented on LUCENE-10255: -- {quote} Sorry but I remain unconvinced that typing a

[jira] [Commented] (LUCENE-10268) TestFuzzyQuery.testErrorMessage can sometimes run for a hundred seconds

2021-11-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450160#comment-17450160 ] Robert Muir commented on LUCENE-10268: -- an evil way to bypass all this overhead might be something

[jira] [Commented] (LUCENE-10268) TestFuzzyQuery.testErrorMessage can sometimes run for a hundred seconds

2021-11-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450153#comment-17450153 ] Robert Muir commented on LUCENE-10268: -- OK, I've got a better understanding of this. The strings

[jira] [Commented] (LUCENE-10268) TestFuzzyQuery.testErrorMessage can sometimes run for a hundred seconds

2021-11-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450149#comment-17450149 ] Robert Muir commented on LUCENE-10268: -- Use curl to download the patch to reproduce, because your

[jira] [Updated] (LUCENE-10268) TestFuzzyQuery.testErrorMessage can sometimes run for a hundred seconds

2021-11-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10268: - Attachment: LUCENE-10268_test.patch Status: Open (was: Open) >

[jira] [Commented] (LUCENE-10268) TestFuzzyQuery.testErrorMessage can sometimes run for a hundred seconds

2021-11-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450148#comment-17450148 ] Robert Muir commented on LUCENE-10268: -- So for the first seed, here's the state/transition count:

[jira] [Commented] (LUCENE-10268) TestFuzzyQuery.testErrorMessage can sometimes run for a hundred seconds

2021-11-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450123#comment-17450123 ] Robert Muir commented on LUCENE-10268: -- oh, duh, it was that previous insane loop comparing

[jira] [Commented] (LUCENE-10268) TestFuzzyQuery.testErrorMessage can sometimes run for a hundred seconds

2021-11-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450122#comment-17450122 ] Robert Muir commented on LUCENE-10268: -- So, if I patch the test to just use ASCII letters, it just

[jira] [Commented] (LUCENE-10268) TestFuzzyQuery.testErrorMessage can sometimes run for a hundred seconds

2021-11-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450121#comment-17450121 ] Robert Muir commented on LUCENE-10268: -- Here are the strings in question. Sorry if it crashes JIRA

[jira] [Commented] (LUCENE-10268) TestFuzzyQuery.testErrorMessage can sometimes run for a hundred seconds

2021-11-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450118#comment-17450118 ] Robert Muir commented on LUCENE-10268: -- I ran the first seed (just tacked on

[jira] [Updated] (LUCENE-10268) TestFuzzyQuery.testErrorMessage can sometimes run for a hundred seconds

2021-11-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10268: - Description: I ran 6 test runs, and it happened only in one of them: 97.93s

[jira] [Commented] (LUCENE-10268) TestFuzzyQuery.testErrorMessage can sometimes run for a hundred seconds

2021-11-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450115#comment-17450115 ] Robert Muir commented on LUCENE-10268: -- Don't worry about the loss of seed, I'm running it 100

[jira] [Created] (LUCENE-10268) TestFuzzyQuery.testErrorMessage can sometimes run for a hundred seconds

2021-11-28 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10268: Summary: TestFuzzyQuery.testErrorMessage can sometimes run for a hundred seconds Key: LUCENE-10268 URL: https://issues.apache.org/jira/browse/LUCENE-10268 Project:

[jira] [Created] (LUCENE-10257) automation to help prevent slow tests from being added to the codebase

2021-11-24 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10257: Summary: automation to help prevent slow tests from being added to the codebase Key: LUCENE-10257 URL: https://issues.apache.org/jira/browse/LUCENE-10257 Project:

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448307#comment-17448307 ] Robert Muir commented on LUCENE-10250: -- There's also another little mini-hierarchy here with

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448306#comment-17448306 ] Robert Muir commented on LUCENE-10250: -- yeah, i think you did the right thing to get some basic

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448244#comment-17448244 ] Robert Muir commented on LUCENE-10250: -- my suggestion would be, it seems to pay off to do this

[jira] [Commented] (LUCENE-10255) Fully embrace the java module system

2021-11-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448213#comment-17448213 ] Robert Muir commented on LUCENE-10255: -- {quote} Probably the biggest challenge (not covered in the

[jira] [Commented] (LUCENE-10253) Remove BadApple test annotation

2021-11-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448060#comment-17448060 ] Robert Muir commented on LUCENE-10253: -- +1, if a test is flaky, we should just apply

[jira] [Commented] (LUCENE-10243) increase unicode versions of tokenizers to unicode 12.1

2021-11-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447741#comment-17447741 ] Robert Muir commented on LUCENE-10243: -- OK, I see my main problem with the generated conformance

[jira] [Commented] (LUCENE-10243) increase unicode versions of tokenizers to unicode 12.1

2021-11-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447730#comment-17447730 ] Robert Muir commented on LUCENE-10243: -- OK, I looked at this in more detail. Bumped to 10, tests

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447714#comment-17447714 ] Robert Muir commented on LUCENE-10250: -- And in case you are curious, that default implementation

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447712#comment-17447712 ] Robert Muir commented on LUCENE-10250: -- {quote} We would need a general way to determine the

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447684#comment-17447684 ] Robert Muir commented on LUCENE-10250: -- And yes, to be clear, i'm proposing modifying the

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447683#comment-17447683 ] Robert Muir commented on LUCENE-10250: -- If you take the solr approach #1 from that page listed,

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2021-11-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447669#comment-17447669 ] Robert Muir commented on LUCENE-10250: -- I think it would be good to turn the problem around, e.g.

[jira] [Commented] (LUCENE-10168) drop support for 7.0 indexes in 9.0 (master)

2021-11-21 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447025#comment-17447025 ] Robert Muir commented on LUCENE-10168: -- Something to keep in mind, with whatever we do, is that I

[jira] [Commented] (LUCENE-10239) upgrade jflex (1.7.0 -> 1.8.2)

2021-11-19 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446609#comment-17446609 ] Robert Muir commented on LUCENE-10239: -- I manually ran the analyzers benchmark from luceneutil

[jira] [Resolved] (LUCENE-10239) upgrade jflex (1.7.0 -> 1.8.2)

2021-11-19 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10239. -- Resolution: Fixed I've opened LUCENE-10243 to bump the unicode versions of the grammars.

[jira] [Updated] (LUCENE-10239) upgrade jflex (1.7.0 -> 1.8.2)

2021-11-19 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10239: - Fix Version/s: 9.1 > upgrade jflex (1.7.0 -> 1.8.2) > -- > >

[jira] [Commented] (LUCENE-10243) increase unicode versions of tokenizers to unicode 12.1

2021-11-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446161#comment-17446161 ] Robert Muir commented on LUCENE-10243: -- I tried this out on top of LUCENE-10239 branch, and also

[jira] [Created] (LUCENE-10243) increase unicode versions of tokenizers to unicode 12.1

2021-11-17 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10243: Summary: increase unicode versions of tokenizers to unicode 12.1 Key: LUCENE-10243 URL: https://issues.apache.org/jira/browse/LUCENE-10243 Project: Lucene - Core

[jira] [Commented] (LUCENE-10239) upgrade jflex (1.7.0 -> 1.8.2)

2021-11-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445559#comment-17445559 ] Robert Muir commented on LUCENE-10239: -- I'd like to do a "minimal" upgrade for this issue, and

[jira] [Commented] (LUCENE-10240) gradle regenerate fails on java 17

2021-11-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445303#comment-17445303 ] Robert Muir commented on LUCENE-10240: -- Thanks for tracking down the groovy bug. I tried messing

[jira] [Commented] (LUCENE-10240) gradle regenerate fails on java 17

2021-11-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445253#comment-17445253 ] Robert Muir commented on LUCENE-10240: -- Bumping the groovy version fixes the issues with

[jira] [Commented] (LUCENE-10240) gradle regenerate fails on java 17

2021-11-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445194#comment-17445194 ] Robert Muir commented on LUCENE-10240: -- This task passes with this patch: {noformat} iff --git

[jira] [Commented] (LUCENE-10240) gradle regenerate fails on java 17

2021-11-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445189#comment-17445189 ] Robert Muir commented on LUCENE-10240: -- Of course the task that fails is one I am trying to

[jira] [Created] (LUCENE-10240) gradle regenerate fails on java 17

2021-11-17 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10240: Summary: gradle regenerate fails on java 17 Key: LUCENE-10240 URL: https://issues.apache.org/jira/browse/LUCENE-10240 Project: Lucene - Core Issue Type:

[jira] [Created] (LUCENE-10239) upgrade jflex (1.7.0 -> 1.8.2)

2021-11-17 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10239: Summary: upgrade jflex (1.7.0 -> 1.8.2) Key: LUCENE-10239 URL: https://issues.apache.org/jira/browse/LUCENE-10239 Project: Lucene - Core Issue Type: Task

[jira] [Commented] (LUCENE-10238) Update icu4j to 70.1

2021-11-16 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444838#comment-17444838 ] Robert Muir commented on LUCENE-10238: -- all done, everything seems happy. {{hacks -= 2}} > Update

[jira] [Commented] (LUCENE-10238) Update icu4j to 70.1

2021-11-16 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444831#comment-17444831 ] Robert Muir commented on LUCENE-10238: -- I'm fixing the input file for the impacted characters.

[jira] [Commented] (LUCENE-10238) Update icu4j to 70.1

2021-11-16 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444824#comment-17444824 ] Robert Muir commented on LUCENE-10238: -- i'll check out your branch. i don't think this is a bug

[jira] [Commented] (LUCENE-9921) Can ICU regeneration tasks treat icu version as input?

2021-11-16 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444811#comment-17444811 ] Robert Muir commented on LUCENE-9921: - [~dweiss] the older icu is only used for regeneration of

[jira] [Commented] (LUCENE-9921) Can ICU regeneration tasks treat icu version as input?

2021-11-15 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444025#comment-17444025 ] Robert Muir commented on LUCENE-9921: - Sorry you got jar hell because lucene has the outdated

[jira] [Commented] (LUCENE-9921) Can ICU regeneration tasks treat icu version as input?

2021-11-15 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444016#comment-17444016 ] Robert Muir commented on LUCENE-9921: - You can't just override the advertised dependency version and

[jira] [Commented] (LUCENE-9921) Can ICU regeneration tasks treat icu version as input?

2021-11-15 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443972#comment-17443972 ] Robert Muir commented on LUCENE-9921: - I agree, let's not rush this in close to a release. Note that

[jira] [Commented] (LUCENE-10227) FilterPath.resolve(Path) doesn't work

2021-11-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443055#comment-17443055 ] Robert Muir commented on LUCENE-10227: -- We are definitely fucking keeping it strict. There is a

[jira] [Commented] (LUCENE-10227) FilterPath.resolve(Path) doesn't work

2021-11-12 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442753#comment-17442753 ] Robert Muir commented on LUCENE-10227: -- I don't think we need to make a complicated exception

[jira] [Commented] (LUCENE-10227) FilterPath.resolve(Path) doesn't work

2021-11-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17441804#comment-17441804 ] Robert Muir commented on LUCENE-10227: -- And if you want it "with multiple elements cuz it seems

[jira] [Commented] (LUCENE-10227) FilterPath.resolve(Path) doesn't work

2021-11-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17441803#comment-17441803 ] Robert Muir commented on LUCENE-10227: -- Don't use {{Path.of}} which constructs the path from the

[jira] [Commented] (LUCENE-10221) Lower default file handle limit in tests to more reasonable value

2021-11-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439014#comment-17439014 ] Robert Muir commented on LUCENE-10221: -- So I dug in, I tried to make a patch for this, it works

[jira] [Commented] (LUCENE-10221) Lower default file handle limit in tests to more reasonable value

2021-11-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439001#comment-17439001 ] Robert Muir commented on LUCENE-10221: -- yeah, i think it is relative straightforward. just lower

[jira] [Created] (LUCENE-10221) Lower default file handle limit in tests to more reasonable value

2021-11-04 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10221: Summary: Lower default file handle limit in tests to more reasonable value Key: LUCENE-10221 URL: https://issues.apache.org/jira/browse/LUCENE-10221 Project: Lucene

[jira] [Commented] (LUCENE-10120) Lazy initialize FixedBitSet in LRUQueryCache

2021-11-03 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437841#comment-17437841 ] Robert Muir commented on LUCENE-10120: -- I'm concerned about having 3 implementations of bitsets

[jira] [Commented] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-11-01 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436974#comment-17436974 ] Robert Muir commented on LUCENE-10207: -- My line of thinking was just that it might be consistent

[jira] [Commented] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-10-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436292#comment-17436292 ] Robert Muir commented on LUCENE-10207: -- Hmm why would the cost ever be getDocCount() [number of

[jira] [Commented] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-10-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435589#comment-17435589 ] Robert Muir commented on LUCENE-10207: -- Sure [~gsmiller], feel free to take the issue if you want,

[jira] [Commented] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-10-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435292#comment-17435292 ] Robert Muir commented on LUCENE-10207: -- Also the

[jira] [Commented] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-10-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435290#comment-17435290 ] Robert Muir commented on LUCENE-10207: -- Well it also depends on what case we optimize for. If the

[jira] [Commented] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-10-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435116#comment-17435116 ] Robert Muir commented on LUCENE-10207: -- cc [~uschindler] if you get a chance to look at the

[jira] [Commented] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-10-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435115#comment-17435115 ] Robert Muir commented on LUCENE-10207: -- {quote} Should we try to take deletions into account at

[jira] [Commented] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-10-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435109#comment-17435109 ] Robert Muir commented on LUCENE-10207: -- I attached a patch that refactors {{TermInSetQuery}} to

[jira] [Updated] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-10-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10207: - Attachment: LUCENE-10207_multitermquery.patch > Make TermInSetQuery usable with

[jira] [Commented] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-10-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434582#comment-17434582 ] Robert Muir commented on LUCENE-10207: -- Also there is more we can do to better reflect the costs

[jira] [Commented] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-10-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434572#comment-17434572 ] Robert Muir commented on LUCENE-10207: -- I think we can slightly tweak it (still completely safe)

[jira] [Commented] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-10-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434547#comment-17434547 ] Robert Muir commented on LUCENE-10207: -- we may be able to relax it slightly by computing

[jira] [Commented] (LUCENE-10195) Gradle build speed improvement

2021-10-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434390#comment-17434390 ] Robert Muir commented on LUCENE-10195: -- {quote} > I would be happy to just configure a 10MB fixed

[jira] [Commented] (LUCENE-10195) Gradle build speed improvement

2021-10-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434382#comment-17434382 ] Robert Muir commented on LUCENE-10195: -- Sorry, maybe i wasn't clear. It is my understanding, that

[jira] [Commented] (LUCENE-10195) Gradle build speed improvement

2021-10-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434365#comment-17434365 ] Robert Muir commented on LUCENE-10195: -- I agree with Dawid and Uwe. I will just add one thing: I

[jira] [Commented] (LUCENE-9660) gradle task cache should not cache --tests

2021-10-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434059#comment-17434059 ] Robert Muir commented on LUCENE-9660: - my absolute favorite example was some flaky tests in the

[jira] [Commented] (LUCENE-9660) gradle task cache should not cache --tests

2021-10-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434058#comment-17434058 ] Robert Muir commented on LUCENE-9660: - Yes, thank you [~dweiss]. I understand your argument, but I

[jira] [Commented] (LUCENE-9660) gradle task cache should not cache --tests

2021-10-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433444#comment-17433444 ] Robert Muir commented on LUCENE-9660: - I still think my argument holds, what is the use-case for

[jira] [Commented] (LUCENE-9660) gradle task cache should not cache --tests

2021-10-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433443#comment-17433443 ] Robert Muir commented on LUCENE-9660: - [~dweiss] It is pretty common when reproducing test failures

[jira] [Commented] (LUCENE-9660) gradle task cache should not cache --tests

2021-10-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433428#comment-17433428 ] Robert Muir commented on LUCENE-9660: - So we should be using {{cleanTest}} always? There's never a

[jira] [Commented] (LUCENE-10191) Optimize vector functions by precomputing magnitudes

2021-10-20 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17431166#comment-17431166 ] Robert Muir commented on LUCENE-10191: -- Also, talking about storing stuff differently makes it

[jira] [Commented] (LUCENE-10191) Optimize vector functions by precomputing magnitudes

2021-10-20 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17431160#comment-17431160 ] Robert Muir commented on LUCENE-10191: -- do we really need these slower functions? IMO the dot

[jira] [Commented] (LUCENE-10189) Optimize SortedSet/SortedNumeric doc values writers for fields that are effectively single-valued

2021-10-19 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430647#comment-17430647 ] Robert Muir commented on LUCENE-10189: -- For the SortedSetCase, seems like we want to fix the IW

[jira] [Commented] (LUCENE-10185) gradle check fails on java 17 (security manager deprecation)

2021-10-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430221#comment-17430221 ] Robert Muir commented on LUCENE-10185: -- {quote} I can actually see this warning in intellij as

[jira] [Resolved] (LUCENE-10185) gradle check fails on java 17 (security manager deprecation)

2021-10-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10185. -- Fix Version/s: main (9.0) Resolution: Fixed > gradle check fails on java 17 (security

[jira] [Commented] (LUCENE-10185) gradle check fails on java 17 (security manager deprecation)

2021-10-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430196#comment-17430196 ] Robert Muir commented on LUCENE-10185: -- [~dweiss] in the ECJ at least these options are in

[jira] [Commented] (LUCENE-10185) gradle check fails on java 17 (security manager deprecation)

2021-10-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430190#comment-17430190 ] Robert Muir commented on LUCENE-10185: -- I also tried upgrading ecj from 3.25.0 to 3.27.0 (in case

[jira] [Commented] (LUCENE-10185) gradle check fails on java 17 (security manager deprecation)

2021-10-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430189#comment-17430189 ] Robert Muir commented on LUCENE-10185: -- The following patch seems to fix the issues around

[jira] [Created] (LUCENE-10185) gradle check fails on java 17 (security manager deprecation)

2021-10-18 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10185: Summary: gradle check fails on java 17 (security manager deprecation) Key: LUCENE-10185 URL: https://issues.apache.org/jira/browse/LUCENE-10185 Project: Lucene -

[jira] [Commented] (LUCENE-10170) Regression in stored fields compression in 9.0

2021-10-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428891#comment-17428891 ] Robert Muir commented on LUCENE-10170: -- I opened an issue to get it started:

[jira] [Commented] (LUCENE-10170) Regression in stored fields compression in 9.0

2021-10-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428846#comment-17428846 ] Robert Muir commented on LUCENE-10170: -- [~jpountz] maybe we should open an issue to add a simple

[jira] [Commented] (LUCENE-10168) drop support for 7.0 indexes in 9.0 (master)

2021-10-12 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427691#comment-17427691 ] Robert Muir commented on LUCENE-10168: -- And instead of hiding the problem under the rug, we could

[jira] [Commented] (LUCENE-10168) drop support for 7.0 indexes in 9.0 (master)

2021-10-12 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427690#comment-17427690 ] Robert Muir commented on LUCENE-10168: -- The reason they only take 6 minutes on your computer is

<    1   2   3   4   5   6   7   8   9   10   >