[
https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190063#comment-17190063
]
Uwe Schindler commented on LUCENE-9500:
---
Here is a pull request that separates the hack from the
uschindler commented on pull request #1824:
URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686471292
I converted this to a draf, because checks failed with precommit. But this
should stay in for doing quick checks by @jpountz like commented before!
[
https://issues.apache.org/jira/browse/LUCENE-9502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190170#comment-17190170
]
Cassandra Targett commented on LUCENE-9502:
---
I linked SOLR-13230, the issue to figure out what
uschindler commented on pull request #1824:
URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686528216
Hi,
I did further tests (except Java 8, I need to merge first), Results looking
fine:
- OpenJDK JDK 11.0.2 reports **non-buggy**
- AdoptJDK 11.0.5 reports
uschindler merged pull request #1824:
URL: https://github.com/apache/lucene-solr/pull/1824
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190200#comment-17190200
]
ASF subversion and git services commented on LUCENE-9500:
-
Commit
dweiss commented on a change in pull request #1824:
URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482922248
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene87/DeflateWithPresetDictCompressionMode.java
##
@@ -155,16 +155,15 @@ public
uschindler commented on pull request #1824:
URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686468187
Hi, I added detectction in my latest commit:
```
C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr1>java -version
openjdk version "11.0.2" 2019-01-15
jpountz commented on a change in pull request #1824:
URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482963038
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene87/BugfixDeflater_JDK8252739.java
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the
jpountz commented on a change in pull request #1824:
URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482962830
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene87/BugfixDeflater_JDK8252739.java
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the
jpountz commented on a change in pull request #1824:
URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482960153
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene87/BugfixDeflater_JDK8252739.java
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the
uschindler commented on pull request #1824:
URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686427056
This effectively reverts @jpountz's hotfix commit, but as he moved classes
around in the meantime, I had to do it manually.
[
https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190203#comment-17190203
]
ASF subversion and git services commented on LUCENE-9500:
-
Commit
dsmiley commented on pull request #29:
URL: https://github.com/apache/lucene-site/pull/29#issuecomment-686556863
Updated. I didn't add "Vendor" which seems pointless. Where did this
template/convention come from?
This is
uschindler commented on a change in pull request #1824:
URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482923181
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene87/DeflateWithPresetDictCompressionMode.java
##
@@ -155,16 +155,15 @@ public
[
https://issues.apache.org/jira/browse/SOLR-13230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190168#comment-17190168
]
Cassandra Targett commented on SOLR-13230:
--
Linking a very old issue SOLR-6178 which was for
[
https://issues.apache.org/jira/browse/SOLR-14827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-14827:
--
Labels: perfomance (was: )
> Refactor schema loading to not use XPath
>
Noble Paul created SOLR-14827:
-
Summary: Refactor schema loading to not use XPath
Key: SOLR-14827
URL: https://issues.apache.org/jira/browse/SOLR-14827
Project: Solr
Issue Type: Task
[
https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reassigned LUCENE-9500:
-
Assignee: Uwe Schindler
> Did we hit a DEFLATE bug?
> -
>
>
uschindler commented on a change in pull request #1824:
URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482952318
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene87/DeflateWithPresetDictCompressionMode.java
##
@@ -155,16 +155,15 @@ public
[
https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-9500.
---
Resolution: Fixed
> Did we hit a DEFLATE bug?
> -
>
>
[
https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9500:
--
Fix Version/s: 8.7
8.x
> Did we hit a DEFLATE bug?
>
[
https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9500:
--
Priority: Critical (was: Minor)
> Did we hit a DEFLATE bug?
> -
>
>
[
https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9500:
--
Fix Version/s: master (9.0)
> Did we hit a DEFLATE bug?
> -
>
>
[
https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190207#comment-17190207
]
Uwe Schindler commented on LUCENE-9500:
---
Thanks to all for help!
> Did we hit a DEFLATE bug?
>
[
https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9500:
--
Affects Version/s: 8.7
8.x
> Did we hit a DEFLATE bug?
>
uschindler commented on a change in pull request #1824:
URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482923181
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene87/DeflateWithPresetDictCompressionMode.java
##
@@ -155,16 +155,15 @@ public
Tomoko Uchida created SOLR-14826:
Summary: Clean up package name conflicts between modules (split
packages)
Key: SOLR-14826
URL: https://issues.apache.org/jira/browse/SOLR-14826
Project: Solr
Henning Andersen created LUCENE-9503:
Summary: Fix comment explaining reason for 8KB buffered/chunked
writes
Key: LUCENE-9503
URL: https://issues.apache.org/jira/browse/LUCENE-9503
Project:
uschindler commented on pull request #1824:
URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686556365
Short info: After backporting to 8.x, of course JDK 8u192 was detected as
**non-buggy**.
This is an
[
https://issues.apache.org/jira/browse/SOLR-11875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Rafalovitch reassigned SOLR-11875:
Assignee: Alexandre Rafalovitch
> merge SolrConfigXml wiki into Solr
[
https://issues.apache.org/jira/browse/SOLR-11875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190166#comment-17190166
]
Alexandre Rafalovitch commented on SOLR-11875:
--
Could we revisit this issue for 9 and with
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190318#comment-17190318
]
Erick Erickson commented on SOLR-14723:
---
Please do!
Find all of the solrconfig.xml files (unix
[
https://issues.apache.org/jira/browse/SOLR-14658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190346#comment-17190346
]
ASF subversion and git services commented on SOLR-14658:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-14658.
-
Fix Version/s: 8.7
Resolution: Fixed
Thanks Andy!
> SolrJ COLSTATUS interface returns
cpoerschke opened a new pull request #1825:
URL: https://github.com/apache/lucene-solr/pull/1825
https://issues.apache.org/jira/browse/SOLR-14828
This is an automated message from the Apache Git Service.
To respond to the
Mike Drob created LUCENE-9504:
-
Summary: DocumentsWriterDeleteQueue.forceApplyGlobalSlice has
needless locking
Key: LUCENE-9504
URL: https://issues.apache.org/jira/browse/LUCENE-9504
Project: Lucene -
dsmiley commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686588314
I am a conflict-avoider (not a good thing) but need to say I fully agree
with @sigram 's impression of the tone. I can tell, personally, as a
subjective measure in how my
Christine Poerschke created SOLR-14828:
--
Summary: reduce 'error' logging noise in
BaseCloudSolrClient.requestWithRetryOnStaleState
Key: SOLR-14828
URL: https://issues.apache.org/jira/browse/SOLR-14828
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190304#comment-17190304
]
Shashank Shekhar commented on SOLR-14723:
-
As a newdev I am enthusiastic to take this up. Hoping
vthacker commented on pull request #1816:
URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686719941
> but I'd like to see how to mark valid code with suppressions first so that
we can correct the errors, exclude false-positives somehow and then enable this
plugin to run
madrob opened a new pull request #1826:
URL: https://github.com/apache/lucene-solr/pull/1826
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190342#comment-17190342
]
Ankur edited comment on LUCENE-9444 at 9/3/20, 6:09 PM:
Patch has been available
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190342#comment-17190342
]
Ankur commented on LUCENE-9444:
---
Patch has been available for 1+ day, not sure why automated patch testing
[
https://issues.apache.org/jira/browse/SOLR-14658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190345#comment-17190345
]
ASF subversion and git services commented on SOLR-14658:
Commit
dsmiley merged pull request #1687:
URL: https://github.com/apache/lucene-solr/pull/1687
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190401#comment-17190401
]
Erick Erickson commented on SOLR-14579:
---
[~uschindler]
bq. why did you re-apply the 8.x comments?
[
https://issues.apache.org/jira/browse/LUCENE-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190420#comment-17190420
]
Brian Coverstone commented on LUCENE-9418:
--
I believe this may still be an issue in 8.6.0, as
[
https://issues.apache.org/jira/browse/LUCENE-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190420#comment-17190420
]
Brian Coverstone edited comment on LUCENE-9418 at 9/3/20, 10:43 PM:
[
https://issues.apache.org/jira/browse/LUCENE-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190420#comment-17190420
]
Brian Coverstone edited comment on LUCENE-9418 at 9/3/20, 10:44 PM:
[
https://issues.apache.org/jira/browse/LUCENE-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190420#comment-17190420
]
Brian Coverstone edited comment on LUCENE-9418 at 9/3/20, 10:44 PM:
[
https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johannes Baiter updated SOLR-14829:
---
Description:
In the reference guide, the list of search components that are enabled by
[
https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johannes Baiter updated SOLR-14829:
---
Priority: Minor (was: Major)
> Default components are missing facet_module and terms in
[
https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190430#comment-17190430
]
Ishan Chattopadhyaya commented on SOLR-14829:
-
Thanks [~jbaiter]. I'll take a look soon
tflobbe commented on pull request #1816:
URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686831857
Hey, just in case you haven't seen it, there is a related email in the dev
list about static analysis using a Github App. See
tflobbe commented on a change in pull request #1815:
URL: https://github.com/apache/lucene-solr/pull/1815#discussion_r483251942
##
File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java
##
@@ -81,8 +81,7 @@ public final ConfigSet loadConfigSet(CoreDescriptor
Johannes Baiter created SOLR-14829:
--
Summary: Default components are missing facet_module and terms in
documentation
Key: SOLR-14829
URL: https://issues.apache.org/jira/browse/SOLR-14829
Project:
[
https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johannes Baiter updated SOLR-14829:
---
Description:
The list of search components that are enabled by default is missing the
[
https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johannes Baiter updated SOLR-14829:
---
Attachment: SOLR-14829.patch
> Default components are missing facet_module and terms in
chatman edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686808345
> Wow. I'm not even sure that would be polite to say to a junior engineer
(that may be presumed to not know concurrency) than a very senior one here.
I don't
chatman commented on a change in pull request #1827:
URL: https://github.com/apache/lucene-solr/pull/1827#discussion_r483335351
##
File path: solr/example/files/conf/lang/stemdict_nl.txt
##
@@ -1,6 +0,0 @@
-# Set of overrides for the dutch stemmer
-# TODO: load this as a
tflobbe commented on a change in pull request #1815:
URL: https://github.com/apache/lucene-solr/pull/1815#discussion_r483251942
##
File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java
##
@@ -81,8 +81,7 @@ public final ConfigSet loadConfigSet(CoreDescriptor
[
https://issues.apache.org/jira/browse/LUCENE-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190420#comment-17190420
]
Brian Coverstone edited comment on LUCENE-9418 at 9/3/20, 10:46 PM:
[
https://issues.apache.org/jira/browse/LUCENE-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190420#comment-17190420
]
Brian Coverstone edited comment on LUCENE-9418 at 9/3/20, 10:46 PM:
chatman commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686808345
> Wow. I'm not even sure that would be polite to say to a junior engineer
(that may be presumed to not know concurrency) than a very senior one here. I
think you know full
[
https://issues.apache.org/jira/browse/LUCENE-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob reassigned LUCENE-9504:
-
Assignee: Mike Drob
> DocumentsWriterDeleteQueue.forceApplyGlobalSlice has needless locking
>
[
https://issues.apache.org/jira/browse/SOLR-14776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190410#comment-17190410
]
Mike Drob commented on SOLR-14776:
--
Thinking about this more, is the big win that we compute our own
[
https://issues.apache.org/jira/browse/SOLR-14776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190408#comment-17190408
]
Mike Drob commented on SOLR-14776:
--
Is there a chance that the core is changing between subsequent calls
[
https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johannes Baiter updated SOLR-14829:
---
Description:
In the reference guide, the list of search components that are enabled by
vthacker commented on a change in pull request #1816:
URL: https://github.com/apache/lucene-solr/pull/1816#discussion_r483318383
##
File path: build.gradle
##
@@ -127,6 +128,9 @@ apply from: file('gradle/ide/intellij-idea.gradle')
apply from: file('gradle/ide/eclipse.gradle')
[
https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ishan Chattopadhyaya reassigned SOLR-14829:
---
Assignee: Ishan Chattopadhyaya
> Default components are missing
Ishan Chattopadhyaya created SOLR-14830:
---
Summary: Synchronizing reference and master branches
Key: SOLR-14830
URL: https://issues.apache.org/jira/browse/SOLR-14830
Project: Solr
Issue
vthacker commented on pull request #1816:
URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686774814
Latest change applies errorprone to all modules ( thanks
`forbidden-apis.gradle` for the example )
Also explicitly disable all warnings
[
https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Rafalovitch updated SOLR-14829:
-
Component/s: examples
> Default components are missing facet_module and terms in
noblepaul commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686839493
I see a consistent theme here. We are always combing through comments with a
lens to see if the tone is correct, if somebody uses the correct case in typing
or if the
erikhatcher opened a new pull request #1827:
URL: https://github.com/apache/lucene-solr/pull/1827
# Description
Remove VelocityResponseWriter and its references and usages.
# Solution
Removed contrib/velocity and all related uses.
# Tests
Will
[
https://issues.apache.org/jira/browse/SOLR-14802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-14802:
Component/s: (was: query)
spatial
Affects Version/s: (was:
[
https://issues.apache.org/jira/browse/SOLR-13652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190551#comment-17190551
]
David Smiley commented on SOLR-13652:
-
I'd think your SIP-10 should have this "learning config"
[
https://issues.apache.org/jira/browse/SOLR-12298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190530#comment-17190530
]
David Smiley commented on SOLR-12298:
-
> Question on this work: if a child document is stored in a
dweiss commented on pull request #1816:
URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686928388
I'll take a look later as to why this doesn't build. The problem with
individual suppressions remains though - you can go by category but I think
there will be still places
[
https://issues.apache.org/jira/browse/SOLR-14802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190535#comment-17190535
]
David Smiley commented on SOLR-14802:
-
I think you're right; this ought to be supported and isn't
dweiss commented on a change in pull request #1816:
URL: https://github.com/apache/lucene-solr/pull/1816#discussion_r483402573
##
File path: build.gradle
##
@@ -127,6 +128,9 @@ apply from: file('gradle/ide/intellij-idea.gradle')
apply from: file('gradle/ide/eclipse.gradle')
dweiss commented on a change in pull request #1816:
URL: https://github.com/apache/lucene-solr/pull/1816#discussion_r483402784
##
File path: gradle/validation/error-prone.gradle
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[
https://issues.apache.org/jira/browse/LUCENE-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190048#comment-17190048
]
ASF subversion and git services commented on LUCENE-9486:
-
Commit
s1monw merged pull request #1789:
URL: https://github.com/apache/lucene-solr/pull/1789
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
sigram commented on pull request #1813:
URL: https://github.com/apache/lucene-solr/pull/1813#issuecomment-686410621
> Honestly nobody will do that. People would rather happily do the
computation in client code
Really? This is like saying that we only ever need collection admin APIs
[
https://issues.apache.org/jira/browse/LUCENE-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190049#comment-17190049
]
ASF subversion and git services commented on LUCENE-9486:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-9486.
--
Fix Version/s: 8.7
Resolution: Fixed
> Explore using preset dictionaries with LZ4 for
[
https://issues.apache.org/jira/browse/LUCENE-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-9483.
--
Resolution: Fixed
> Disable per-thread caching of buffers for stored fields
>
sigram edited a comment on pull request #1813:
URL: https://github.com/apache/lucene-solr/pull/1813#issuecomment-686410621
> Honestly nobody will do that. People would rather happily do the
computation in client code
Really? This is like saying that we only ever need collection
[
https://issues.apache.org/jira/browse/LUCENE-9484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190053#comment-17190053
]
ASF subversion and git services commented on LUCENE-9484:
-
Commit
uschindler opened a new pull request #1824:
URL: https://github.com/apache/lucene-solr/pull/1824
A factory method allows to return a different instance depending on Java
version (for now everything after Java 11 is disallowed).
We can improve this when we exactly know which versions
chatman commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686308531
> You need to make a realistic proposal here IMO @noblepaul.
> And we need something that already exists. If placement plugins depend on
some
> future rehaul of
sigram commented on pull request #1816:
URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686274891
While some warnings are disputable, most of these point to genuine errors or
deficiencies - this looks very useful!
dweiss commented on pull request #1816:
URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686292245
bq. While some warnings are disputable, most of these point to genuine
errors or deficiencies - this looks very useful!
Right. This is always my problem with static
dweiss commented on a change in pull request #1816:
URL: https://github.com/apache/lucene-solr/pull/1816#discussion_r482745406
##
File path: gradle/validation/error-prone.gradle
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
s1monw commented on a change in pull request #1789:
URL: https://github.com/apache/lucene-solr/pull/1789#discussion_r482740267
##
File path:
lucene/core/src/java/org/apache/lucene/index/BinaryDocValuesWriter.java
##
@@ -202,4 +203,63 @@ public BytesRef binaryValue() {
uschindler commented on pull request #1816:
URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686302137
Is there a way to enable/disable checks using a config file?
Things like ReferenceEquality in Lucene Code is annoying. It should be
disabled there.
I love
Simon Willnauer created LUCENE-9502:
---
Summary: Can we remove JaspellLookup?
Key: LUCENE-9502
URL: https://issues.apache.org/jira/browse/LUCENE-9502
Project: Lucene - Core
Issue Type: Wish
noblepaul commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686318299
> don't like an explosion of classes but I think this is highly mitigated by
them being defined as simple inner classes of one outer class, as Ilan has done.
Yeah,
1 - 100 of 162 matches
Mail list logo