[jira] [Commented] (LUCENE-9843) Remove compression option on doc values

2021-05-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339863#comment-17339863 ] Robert Muir commented on LUCENE-9843: - +1 to your latest patch [~jdconradson]. I ran all tests,

[jira] [Commented] (LUCENE-9950) Support both single- and multi-value string fields in facet counting (non-taxonomy based approaches)

2021-05-06 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340242#comment-17340242 ] Robert Muir commented on LUCENE-9950: - +1 to add a "normal" facet method here, and deprecate this

[jira] [Resolved] (LUCENE-9843) Remove compression option on doc values

2021-05-06 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9843. - Fix Version/s: main (9.0) Resolution: Fixed Thanks [~jdconradson]! > Remove compression

[jira] [Created] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-28 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9981: --- Summary: CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit Key: LUCENE-9981 URL:

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2021-05-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353644#comment-17353644 ] Robert Muir commented on LUCENE-9379: - Sorry, the above comment is really wrong. Please see my

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2021-05-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353645#comment-17353645 ] Robert Muir commented on LUCENE-9379: - As always, you can count on arch to have some good user-level

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353637#comment-17353637 ] Robert Muir commented on LUCENE-9981: - Before we {{det(reverse())}} this automaton to compute the

[jira] [Updated] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9981: Attachment: LUCENE-9981_test.patch > CompiledAutomaton.getCommonSuffix can be extraordinarily

[jira] [Commented] (LUCENE-9987) JVM 11.0.6 crash while trying to read term vectors in CheckIndex?

2021-06-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355694#comment-17355694 ] Robert Muir commented on LUCENE-9987: - ZAC though. Workaround: don't use ZGC > JVM 11.0.6 crash

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353696#comment-17353696 ] Robert Muir commented on LUCENE-9379: - Your argument is even more uneducated, the "i can do better

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353742#comment-17353742 ] Robert Muir commented on LUCENE-9981: - Hi [~oridool]. This issue isn't a security issue. I won't add

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353762#comment-17353762 ] Robert Muir commented on LUCENE-9981: - Nope, but exposing very slow queries (via DSL) to

[jira] [Comment Edited] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353908#comment-17353908 ] Robert Muir edited comment on LUCENE-9981 at 5/30/21, 12:01 AM: cc:

[jira] [Commented] (LUCENE-9867) CorruptIndexException after failed segment merge caused by No space left on device

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353906#comment-17353906 ] Robert Muir commented on LUCENE-9867: - Sorry for the dyslexic commit > CorruptIndexException after

[jira] [Commented] (LUCENE-9687) Hunspell support improvements

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353907#comment-17353907 ] Robert Muir commented on LUCENE-9687: - I think we should be good now. The only other change we

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353994#comment-17353994 ] Robert Muir commented on LUCENE-9981: - Even with no API break, I don't want these changes rushed in

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353972#comment-17353972 ] Robert Muir commented on LUCENE-9981: - It is probably enough bits? I originally liked the type

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353956#comment-17353956 ] Robert Muir commented on LUCENE-9981: - There's no reason to rush fixes/backports for these

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353861#comment-17353861 ] Robert Muir commented on LUCENE-9981: - I updated the patch, changes: * Add simple unit tests for the

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353910#comment-17353910 ] Robert Muir commented on LUCENE-9981: - Another tweak: its great that we give a compile-time break

[jira] [Updated] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9981: Attachment: LUCENE-9981_nfaprefix.patch > CompiledAutomaton.getCommonSuffix can be

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353830#comment-17353830 ] Robert Muir commented on LUCENE-9981: - I attached LUCENE-9981_nfa_prefix.patch, which uses an NFA

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353852#comment-17353852 ] Robert Muir commented on LUCENE-9981: - Patch looks great! I really like how it is clear that the

[jira] [Updated] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9981: Attachment: LUCENE-9981.patch > CompiledAutomaton.getCommonSuffix can be extraordinarily slow,

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353908#comment-17353908 ] Robert Muir commented on LUCENE-9981: - cc: [~dweiss] in case you have thoughts. Quick Summary if you

[jira] [Comment Edited] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353908#comment-17353908 ] Robert Muir edited comment on LUCENE-9981 at 5/30/21, 12:10 AM: cc:

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-06-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357410#comment-17357410 ] Robert Muir commented on LUCENE-9981: - +1. glad this test is happy! >

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377541#comment-17377541 ] Robert Muir commented on LUCENE-10023: -- I actually think it is useful for the user to do this

[jira] [Commented] (LUCENE-8638) Remove deprecated code in master

2021-06-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17372278#comment-17372278 ] Robert Muir commented on LUCENE-8638: - What are these {{lucene-deprecations.txt}} files? Please,

[jira] [Commented] (LUCENE-9855) Reconsider names for ANN related format and APIs

2021-06-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17372001#comment-17372001 ] Robert Muir commented on LUCENE-9855: - I really do think this is correctly a blocker issue. Renaming

[jira] [Created] (LUCENE-10015) Remove VectorValues.SimilarityFunction, remove NONE

2021-06-30 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10015: Summary: Remove VectorValues.SimilarityFunction, remove NONE Key: LUCENE-10015 URL: https://issues.apache.org/jira/browse/LUCENE-10015 Project: Lucene - Core

[jira] [Updated] (LUCENE-10016) VectorReader.search needs rethought, o.a.l.search integration?

2021-06-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10016: - Fix Version/s: 9.0 > VectorReader.search needs rethought, o.a.l.search integration? >

[jira] [Created] (LUCENE-10016) VectorReader.search needs rethought, o.a.l.search integration?

2021-06-30 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10016: Summary: VectorReader.search needs rethought, o.a.l.search integration? Key: LUCENE-10016 URL: https://issues.apache.org/jira/browse/LUCENE-10016 Project: Lucene -

[jira] [Updated] (LUCENE-10015) Remove VectorValues.SimilarityFunction, remove NONE

2021-06-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10015: - Fix Version/s: 9.0 > Remove VectorValues.SimilarityFunction, remove NONE >

[jira] [Commented] (LUCENE-10016) VectorReader.search needs rethought, o.a.l.search integration?

2021-06-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17372057#comment-17372057 ] Robert Muir commented on LUCENE-10016: -- [~sokolov] let's not make these assumptions in such an

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17378142#comment-17378142 ] Robert Muir commented on LUCENE-10023: -- A big part of my concern is adding this code directly to

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377769#comment-17377769 ] Robert Muir commented on LUCENE-10023: -- {quote} I guess the essence of the question is whether the

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377636#comment-17377636 ] Robert Muir commented on LUCENE-10023: -- {quote} In contrast, the current PR only runs analysis

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377639#comment-17377639 ] Robert Muir commented on LUCENE-10023: -- {quote} In contrast, the current PR only runs analysis

[jira] [Updated] (LUCENE-9878) enable redundantNullCheck in ecjLint

2021-04-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9878: Fix Version/s: main (9.0) > enable redundantNullCheck in ecjLint >

[jira] [Resolved] (LUCENE-9878) enable redundantNullCheck in ecjLint

2021-04-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9878. - Resolution: Fixed yes, oops! thanks [~mikemccand] > enable redundantNullCheck in ecjLint >

[jira] [Commented] (LUCENE-9939) Proper ASCII folding of Danish/Norwegian characters Ø, Å

2021-04-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17333128#comment-17333128 ] Robert Muir commented on LUCENE-9939: - This isn't the way to go: these aren't the only languages

[jira] [Commented] (LUCENE-9946) Support multi-value fields in range facet counting

2021-04-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337498#comment-17337498 ] Robert Muir commented on LUCENE-9946: - I'm confused, why make the user provide a {{multivalued}}

[jira] [Commented] (LUCENE-9946) Support multi-value fields in range facet counting

2021-05-01 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337741#comment-17337741 ] Robert Muir commented on LUCENE-9946: - {quote} I was aiming for consistency with the approach taken

[jira] [Resolved] (LUCENE-9188) Add jacoco code coverage support to gradle build

2021-05-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9188. - Fix Version/s: main (9.0) Resolution: Fixed > Add jacoco code coverage support to gradle

[jira] [Commented] (LUCENE-9948) Automatically detect multi- vs. single-valued cases in LongValueFacetCounts

2021-05-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338091#comment-17338091 ] Robert Muir commented on LUCENE-9948: - For 9.0, i wouldnt add back compat at all or deprecations. I

[jira] [Resolved] (LUCENE-9928) speed up analysis/icu regeneration

2021-04-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9928. - Fix Version/s: main (9.0) Resolution: Fixed > speed up analysis/icu regeneration >

[jira] [Commented] (LUCENE-9948) Automatically detect multi- vs. single-valued cases in LongValueFacetCounts

2021-05-03 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338443#comment-17338443 ] Robert Muir commented on LUCENE-9948: - Thanks [~gsmiller] for taking care of this! > Automatically

[jira] [Commented] (LUCENE-9843) Remove compression option on doc values

2021-05-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339374#comment-17339374 ] Robert Muir commented on LUCENE-9843: - looks like we can do the same trick for binary case. remove

[jira] [Updated] (LUCENE-9843) Remove compression option on doc values

2021-05-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9843: Attachment: LUCENE-9843.patch mods.patch Status: Open (was: Open)

[jira] [Resolved] (LUCENE-9948) Automatically detect multi- vs. single-valued cases in LongValueFacetCounts

2021-05-03 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9948. - Fix Version/s: main (9.0) Resolution: Fixed > Automatically detect multi- vs.

[jira] [Commented] (LUCENE-9843) Remove compression option on doc values

2021-05-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339084#comment-17339084 ] Robert Muir commented on LUCENE-9843: - +1 let's simplify and have better test coverage. it does not

[jira] [Commented] (LUCENE-9741) Add optimization for sequential access of stored fields

2021-02-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281690#comment-17281690 ] Robert Muir commented on LUCENE-9741: - The getMergeInstance() is already optimized for this case

[jira] [Commented] (LUCENE-9747) Missing package-info.java causes NPE in MissingDoclet.java

2021-02-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282163#comment-17282163 ] Robert Muir commented on LUCENE-9747: - whoah, nice work [~epugh] [~dweiss]. thanks for debugging

[jira] [Commented] (LUCENE-9754) ICU Tokenizer: letter-space-number-letter tokenized inconsistently

2021-02-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283075#comment-17283075 ] Robert Muir commented on LUCENE-9754: - Yes, the issue is because of the chunking. Put aside long

[jira] [Commented] (LUCENE-9754) ICU Tokenizer: letter-space-number-letter tokenized inconsistently

2021-02-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283102#comment-17283102 ] Robert Muir commented on LUCENE-9754: - Just to be clear, I'm thinking something like "subclass

[jira] [Commented] (LUCENE-9754) ICU Tokenizer: letter-space-number-letter tokenized inconsistently

2021-02-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283116#comment-17283116 ] Robert Muir commented on LUCENE-9754: - We just use unicode properties for that stuff which is

[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306549#comment-17306549 ] Robert Muir commented on LUCENE-9861: - Also the "-times" can be removed from the patch. I was using

[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306627#comment-17306627 ] Robert Muir commented on LUCENE-9861: - Another way to look at it, if you see that, you've set gradle

[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306536#comment-17306536 ] Robert Muir commented on LUCENE-9861: - Not forking is fine too. But forking with C2 enabled in order

[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306625#comment-17306625 ] Robert Muir commented on LUCENE-9861: - If you have 87 cores, you can afford to spend a bunch of

[jira] [Commented] (LUCENE-9860) explore disabling ecj javadocs processing

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306533#comment-17306533 ] Robert Muir commented on LUCENE-9860: - yes, i closed it as won't fix > explore disabling ecj

[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306558#comment-17306558 ] Robert Muir commented on LUCENE-9861: - {quote} But for stuff that works perfectly fine in the Gradle

[jira] [Created] (LUCENE-9862) gradlew regenerate doesnt invoke jflexStandardTokenizerImpl

2021-03-22 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9862: --- Summary: gradlew regenerate doesnt invoke jflexStandardTokenizerImpl Key: LUCENE-9862 URL: https://issues.apache.org/jira/browse/LUCENE-9862 Project: Lucene - Core

[jira] [Commented] (LUCENE-9856) Improve static analysis to catch dead code and other potential bugs

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306677#comment-17306677 ] Robert Muir commented on LUCENE-9856: - While wrestling with the PR, I found out about

[jira] [Commented] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307914#comment-17307914 ] Robert Muir commented on LUCENE-9863: - As an example, I opened this issue because of LUCENE-9856 PR.

[jira] [Created] (LUCENE-9866) regenerate kuromoji dict in regenerate

2021-03-24 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9866: --- Summary: regenerate kuromoji dict in regenerate Key: LUCENE-9866 URL: https://issues.apache.org/jira/browse/LUCENE-9866 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307946#comment-17307946 ] Robert Muir commented on LUCENE-9863: - I agree, I don't want to sound like a complainer, I really

[jira] [Commented] (LUCENE-9862) gradlew regenerate doesnt invoke jflexStandardTokenizerImpl

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307938#comment-17307938 ] Robert Muir commented on LUCENE-9862: - Thank you for the improvements here [~dweiss]! I really did

[jira] [Commented] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307909#comment-17307909 ] Robert Muir commented on LUCENE-9863: - I think my issue is that there is no agreed-upon standard of

[jira] [Commented] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307925#comment-17307925 ] Robert Muir commented on LUCENE-9863: - Also given there is no standard, i tend to lean towards what

[jira] [Created] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-23 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9863: --- Summary: run spotless across groovy (e.g. gradle) code too Key: LUCENE-9863 URL: https://issues.apache.org/jira/browse/LUCENE-9863 Project: Lucene - Core

[jira] [Commented] (LUCENE-9862) gradlew regenerate doesnt invoke jflexStandardTokenizerImpl

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307951#comment-17307951 ] Robert Muir commented on LUCENE-9862: - Yes, that one triggered the OOM killer on my machine, so I

[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306997#comment-17306997 ] Robert Muir commented on LUCENE-9861: - Thank you [~dweiss], this one really helps my computer. >

[jira] [Commented] (LUCENE-9862) gradlew regenerate doesnt invoke jflexStandardTokenizerImpl

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307122#comment-17307122 ] Robert Muir commented on LUCENE-9862: - I must have messed it up the last time I upgraded, that is my

[jira] [Commented] (LUCENE-9862) gradlew regenerate doesnt invoke jflexStandardTokenizerImpl

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307111#comment-17307111 ] Robert Muir commented on LUCENE-9862: - Oh man, it is probably a bug. This thing is pretty hacky.

[jira] [Commented] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307033#comment-17307033 ] Robert Muir commented on LUCENE-9863: - Does it just need more maturity before it can be used? To me

[jira] [Resolved] (LUCENE-9856) Improve static analysis to catch dead code and other potential bugs

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9856. - Resolution: Fixed Thanks [~uschindler] for cleaning up the long tail here! > Improve static

[jira] [Resolved] (LUCENE-9856) Improve static analysis to catch dead code and other potential bugs

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9856. - Fix Version/s: main (9.0) Resolution: Fixed > Improve static analysis to catch dead code

[jira] [Commented] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307177#comment-17307177 ] Robert Muir commented on LUCENE-9827: - [~jpountz] As far as the "1% dirty docs", it was equally

[jira] [Created] (LUCENE-9882) better synchronize eclipse formatter with spotless

2021-03-26 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9882: --- Summary: better synchronize eclipse formatter with spotless Key: LUCENE-9882 URL: https://issues.apache.org/jira/browse/LUCENE-9882 Project: Lucene - Core

[jira] [Created] (LUCENE-9881) synchronize ECJ linter with eclipse IDE

2021-03-26 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9881: --- Summary: synchronize ECJ linter with eclipse IDE Key: LUCENE-9881 URL: https://issues.apache.org/jira/browse/LUCENE-9881 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-9880) Task ordering can be incorrect for gradlew clean [...]

2021-03-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309391#comment-17309391 ] Robert Muir commented on LUCENE-9880: - I don't know if it helps, but if you pass "-verbose" to ecj

[jira] [Commented] (LUCENE-9866) regenerate kuromoji dict in regenerate

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308512#comment-17308512 ] Robert Muir commented on LUCENE-9866: - [~dweiss] we package mecab by default with lucene in the

[jira] [Commented] (LUCENE-9867) CorruptIndexException after failed segment merge caused by No space left on device

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308510#comment-17308510 ] Robert Muir commented on LUCENE-9867: - [~sqshq] the general problem is files getting deleted that

[jira] [Commented] (LUCENE-9867) CorruptIndexException after failed segment merge caused by No space left on device

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308538#comment-17308538 ] Robert Muir commented on LUCENE-9867: - I'm really not worried about XFS yet. I first want to know it

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308794#comment-17308794 ] Robert Muir commented on LUCENE-9864: - I only saw issues with snowball generated code: I updated the

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308826#comment-17308826 ] Robert Muir commented on LUCENE-9864: - I'm working on the queryparser pieces. It is just slow

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308812#comment-17308812 ] Robert Muir commented on LUCENE-9864: - Sorry, I missed seeing the modified queryparser sources

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308844#comment-17308844 ] Robert Muir commented on LUCENE-9864: - Thank you [~dweiss]. Congratulations, you made it into

[jira] [Resolved] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9864. - Resolution: Fixed > Enforce @Override annotation with ecj static analysis configuration >

[jira] [Commented] (LUCENE-9868) Verify checksums on generated files

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308997#comment-17308997 ] Robert Muir commented on LUCENE-9868: - I think hashing could be extremely difficult to debug, if

[jira] [Commented] (LUCENE-9888) Re-instate CheckIndex's attempts to confirm index sort is consistent across all segments

2021-03-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309981#comment-17309981 ] Robert Muir commented on LUCENE-9888: - yeah this is a wtf that checker found. i mechanically removed

[jira] [Created] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-25 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9879: --- Summary: errorprone cause large slowdown of compileJava/compileTestJava Key: LUCENE-9879 URL: https://issues.apache.org/jira/browse/LUCENE-9879 Project: Lucene - Core

[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309136#comment-17309136 ] Robert Muir commented on LUCENE-9879: - In an ideal world I think, we'd let javac do

[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309138#comment-17309138 ] Robert Muir commented on LUCENE-9879: - Related issue, particularly this comment:

[jira] [Resolved] (LUCENE-9893) Document or fix CodecUtil's codec requirements/limitations

2021-03-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9893. - Resolution: Not A Problem Not a limitation: this is a utility class, either you use it or you

[jira] [Commented] (LUCENE-9890) Retire @lucene.experimental tag and enforce @since tag for public classes

2021-03-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311454#comment-17311454 ] Robert Muir commented on LUCENE-9890: - I think the api is almost a lost cause at this point.

[jira] [Commented] (LUCENE-9855) Reconsider codec name VectorFormat

2021-04-06 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315813#comment-17315813 ] Robert Muir commented on LUCENE-9855: - {quote} For postings and doc values, we make it relatively

[jira] [Created] (LUCENE-9910) maximize javac lint

2021-04-06 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9910: --- Summary: maximize javac lint Key: LUCENE-9910 URL: https://issues.apache.org/jira/browse/LUCENE-9910 Project: Lucene - Core Issue Type: Task

<    3   4   5   6   7   8   9   10   11   12   >