[GitHub] [maven] gnodet merged pull request #612: [MNG-7129] - Cache extension from db

2021-11-17 Thread GitBox
gnodet merged pull request #612: URL: https://github.com/apache/maven/pull/612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-resolver-ant-tasks] arturobernalg commented on pull request #10: MRESOLVER-212 - Use final variable when is possible 1

2021-11-17 Thread GitBox
arturobernalg commented on pull request #10: URL: https://github.com/apache/maven-resolver-ant-tasks/pull/10#issuecomment-972554364 > @arturobernalg Please rebase on top of master... HI @michael-o Fixed. TY -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (MRESOLVER-224) DefaultVersionResolver is inflicting ArtifactNotFoundException for classifiers with SNAPSHOT version

2021-11-17 Thread Tuomas Kiviaho (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445639#comment-17445639 ] Tuomas Kiviaho commented on MRESOLVER-224: -- > Are you certain that this is done by Resolver

[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request #79: Bump plexus-archiver from 4.2.5 to 4.2.6

2021-11-17 Thread GitBox
dependabot[bot] opened a new pull request #79: URL: https://github.com/apache/maven-jlink-plugin/pull/79 Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 4.2.5 to 4.2.6. Release notes Sourced from

[jira] [Updated] (MASSEMBLY-955) dependencySet includes filter with classifier breaks include of artifacts without classifier

2021-11-17 Thread Jira
[ https://issues.apache.org/jira/browse/MASSEMBLY-955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Václav Haisman updated MASSEMBLY-955: - Description: I have created a demonstration repo for this issue at

[jira] [Updated] (MASSEMBLY-955) dependencySet includes filter with classifier breaks include of artifacts without classifier

2021-11-17 Thread Jira
[ https://issues.apache.org/jira/browse/MASSEMBLY-955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Václav Haisman updated MASSEMBLY-955: - Description: I have created a demonstration repo for this issue at

[GitHub] [maven] AlexanderAshitkin commented on pull request #612: [MNG-7129] - Cache extension from db

2021-11-17 Thread GitBox
AlexanderAshitkin commented on pull request #612: URL: https://github.com/apache/maven/pull/612#issuecomment-972110745 looks good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven] ctrueden commented on pull request #121: [MNG-6206] display deprecation build warning in case when dependencies use metaversions (LATEST or RELEASE)

2021-11-17 Thread GitBox
ctrueden commented on pull request #121: URL: https://github.com/apache/maven/pull/121#issuecomment-972108495 @dejan2609 @khmarbaise I use LATEST and RELEASE a lot for various purposes, such as CLI tooling that automatically synthesizes POMs to perform various tasks. I personally feel

[GitHub] [maven] AlexanderAshitkin commented on pull request #612: [MNG-7129] - Cache extension from db

2021-11-17 Thread GitBox
AlexanderAshitkin commented on pull request #612: URL: https://github.com/apache/maven/pull/612#issuecomment-972006008 > Could you fix the unit tests please ? fixed, should be in sync shortly -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (MRESOLVER-224) DefaultVersionResolver is inflicting ArtifactNotFoundException for classifiers with SNAPSHOT version

2021-11-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445484#comment-17445484 ] Michael Osipov commented on MRESOLVER-224: -- Are you certain that this is done by Resolver and

[GitHub] [maven] gnodet commented on pull request #612: [MNG-7129] - Cache extension from db

2021-11-17 Thread GitBox
gnodet commented on pull request #612: URL: https://github.com/apache/maven/pull/612#issuecomment-971974831 Could you fix the unit tests please ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven] andrey-petrenko-db commented on a change in pull request #607: [MNG-7129] Import maven caching system

2021-11-17 Thread GitBox
andrey-petrenko-db commented on a change in pull request #607: URL: https://github.com/apache/maven/pull/607#discussion_r751591392 ## File path: maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java ## @@ -492,6 +492,21 @@ private void

[GitHub] [maven] andrey-petrenko-db opened a new pull request #612: MNG-7129/cache extension from db

2021-11-17 Thread GitBox
andrey-petrenko-db opened a new pull request #612: URL: https://github.com/apache/maven/pull/612 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed

[GitHub] [maven-scm] pzygielo commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
pzygielo commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971879439 I don't understand how this shall help, as `plugin.xml` _already_ has following: ```xml tag ... false ... ``` As there is no

[GitHub] [maven-scm] michael-o commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
michael-o commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971865405 I think @pzygielo is right, this likely needs to be applied to all mojos separately. Though, have not verified it. -- This is an automated message from the Apache Git

[GitHub] [maven-resolver] cstamas merged pull request #133: Use maven-gh-actions-shared

2021-11-17 Thread GitBox
cstamas merged pull request #133: URL: https://github.com/apache/maven-resolver/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-scm] pzygielo commented on a change in pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
pzygielo commented on a change in pull request #107: URL: https://github.com/apache/maven-scm/pull/107#discussion_r751454937 ## File path: maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/AbstractScmMojo.java ## @@ -57,6 +58,9 @@ * @author Emmanuel Venisse *

[GitHub] [maven-scm] pzygielo commented on a change in pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
pzygielo commented on a change in pull request #107: URL: https://github.com/apache/maven-scm/pull/107#discussion_r751454226 ## File path: maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/AbstractScmMojo.java ## @@ -57,6 +58,9 @@ * @author Emmanuel Venisse *

[GitHub] [maven-scm] rmannibucau commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
rmannibucau commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971782876 @Lonzak I'd like 1 and 2 to merge as the default when nothing is specified in our plugin tools stack, this way we are always in a safe runtime zone. The runtime warning

[jira] [Commented] (MNG-7323) Make opt-in as easy as possible using a command line option / system property

2021-11-17 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445352#comment-17445352 ] Guillaume Nodet commented on MNG-7323: -- I don't the point of making it an extension if it's released

[GitHub] [maven] gnodet commented on a change in pull request #607: [MNG-7129] Import maven caching system

2021-11-17 Thread GitBox
gnodet commented on a change in pull request #607: URL: https://github.com/apache/maven/pull/607#discussion_r751422112 ## File path: maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java ## @@ -492,6 +492,21 @@ private void

[GitHub] [maven] gnodet commented on a change in pull request #607: [MNG-7129] Import maven caching system

2021-11-17 Thread GitBox
gnodet commented on a change in pull request #607: URL: https://github.com/apache/maven/pull/607#discussion_r751418767 ## File path: maven-caching/src/main/java/org/apache/maven/caching/ProjectUtils.java ## @@ -0,0 +1,200 @@ +package org.apache.maven.caching; + +/* + *

[GitHub] [maven] gnodet commented on pull request #610: [MNG-7129] - Changes in maven core required to support incremental mave…

2021-11-17 Thread GitBox
gnodet commented on pull request #610: URL: https://github.com/apache/maven/pull/610#issuecomment-971738075 I've merge this branch to `MNG-7129-master`. We can continue working on `MNG-7129-master` and when the state is satisfying, we can come back to this PR to merge to master and

[GitHub] [maven-enforcer] dependabot[bot] opened a new pull request #126: Bump mockito-junit-jupiter from 3.12.4 to 4.0.0

2021-11-17 Thread GitBox
dependabot[bot] opened a new pull request #126: URL: https://github.com/apache/maven-enforcer/pull/126 Bumps [mockito-junit-jupiter](https://github.com/mockito/mockito) from 3.12.4 to 4.0.0. Release notes Sourced from

[jira] [Commented] (MRESOLVER-224) DefaultVersionResolver is inflicting ArtifactNotFoundException for classifiers with SNAPSHOT version

2021-11-17 Thread Tuomas Kiviaho (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445308#comment-17445308 ] Tuomas Kiviaho commented on MRESOLVER-224: -- The problem is that even though metadata's {{}}

[GitHub] [maven-scm] Lonzak edited a comment on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
Lonzak edited a comment on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971673991 Same here - I didn't get your last part. I'll try to explain it again: I would like to have the threadSafe annotation defined (true or false) to avoid any

[GitHub] [maven-scm] Lonzak edited a comment on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
Lonzak edited a comment on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971673991 Same here - I didn't get your last part. I'll try to explain it again: I would like to have the threadSafe annotation defined (true or false) to avoid any

[GitHub] [maven-scm] Lonzak commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
Lonzak commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971673991 Same here - I didn't get your last part. I'll try to explain it again: I would like to have the threadSafe annotation defined (true or false) to avoid any misbehavior.

[jira] [Created] (MRESOLVER-224) DefaultVersionResolver is inflicting ArtifactNotFoundException for classifiers with SNAPSHOT version

2021-11-17 Thread Tuomas Kiviaho (Jira)
Tuomas Kiviaho created MRESOLVER-224: Summary: DefaultVersionResolver is inflicting ArtifactNotFoundException for classifiers with SNAPSHOT version Key: MRESOLVER-224 URL:

[GitHub] [maven-scm] rmannibucau commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
rmannibucau commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971622055 @Lonzak not sure I got the first part, it is always possible to say it is not thread safe when not specified. Worse case you become sequential when it would be possible to

[jira] [Comment Edited] (MASSEMBLY-955) dependencySet includes filter with classifier breaks include of artifacts without classifier

2021-11-17 Thread Jira
[ https://issues.apache.org/jira/browse/MASSEMBLY-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444828#comment-17444828 ] Václav Haisman edited comment on MASSEMBLY-955 at 11/17/21, 11:56 AM:

[jira] [Updated] (MASSEMBLY-955) dependencySet includes filter with classifier breaks include of artifacts without classifier

2021-11-17 Thread Jira
[ https://issues.apache.org/jira/browse/MASSEMBLY-955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Václav Haisman updated MASSEMBLY-955: - Labels: pull-request-available (was: ) > dependencySet includes filter with

[jira] [Updated] (ARCHETYPE-621) integration-test execution fails during release build when custom settingsFile is used

2021-11-17 Thread Maik Ebert (Jira)
[ https://issues.apache.org/jira/browse/ARCHETYPE-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maik Ebert updated ARCHETYPE-621: - Description: We use a company internal Nexus repository server. Through a custom user

[jira] [Created] (ARCHETYPE-621) integration-test execution fails during release build when custom settingsFile is used

2021-11-17 Thread Maik Ebert (Jira)
Maik Ebert created ARCHETYPE-621: Summary: integration-test execution fails during release build when custom settingsFile is used Key: ARCHETYPE-621 URL: https://issues.apache.org/jira/browse/ARCHETYPE-621

[GitHub] [maven-scm] Lonzak edited a comment on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
Lonzak edited a comment on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971342688 I don't think it is a noop even though the default is false. > threadSafe - @threadSafe - Default: false > Marks this mojo as being thread-safe, i.e. the mojo

[GitHub] [maven-scm] Lonzak commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
Lonzak commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971468083 @rmannibucau In an ideal world I would like to have support for case3 (cp. above) which can be called in parallel. But as I understand that is currently not possible since

[GitHub] [maven-enforcer] timtebeek commented on pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency

2021-11-17 Thread GitBox
timtebeek commented on pull request #125: URL: https://github.com/apache/maven-enforcer/pull/125#issuecomment-971467759 Went through the `mvn dependency:analyze` output once more and removed all unused declared dependencies. -- This is an automated message from the Apache Git Service.

[GitHub] [maven-scm] Lonzak edited a comment on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
Lonzak edited a comment on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971342688 I don't think it is a noop even though the default is false. > threadSafe - @threadSafe - Default: false > Marks this mojo as being thread-safe, i.e. the mojo

[GitHub] [maven-apache-parent] slawekjaranowski edited a comment on pull request #56: [MPOM-275] Shared GitHub Actions

2021-11-17 Thread GitBox
slawekjaranowski edited a comment on pull request #56: URL: https://github.com/apache/maven-apache-parent/pull/56#issuecomment-971430344 Is there any comments for this PR, can be merged? @slachiewicz, @hboutemy, @olamy -- This is an automated message from the Apache Git Service.

[GitHub] [maven-apache-parent] slawekjaranowski commented on pull request #56: [MPOM-275] Shared GitHub Actions

2021-11-17 Thread GitBox
slawekjaranowski commented on pull request #56: URL: https://github.com/apache/maven-apache-parent/pull/56#issuecomment-971430344 There is any comments for this PR, can be merged? @slachiewicz, @hboutemy, @olamy -- This is an automated message from the Apache Git Service. To

[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency

2021-11-17 Thread GitBox
slawekjaranowski commented on pull request #125: URL: https://github.com/apache/maven-enforcer/pull/125#issuecomment-971406915 For many components from the same project please use property as version and will be one update by dependabot. Please also check if

[GitHub] [maven-scm] rmannibucau commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
rmannibucau commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971362262 @Lonzak goal would be to be defensive by default, ie make it work even if you call -T but in degraded mode (not really parallel at the execution), think it is better than a

[GitHub] [maven-scm] Lonzak edited a comment on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
Lonzak edited a comment on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971342688 I don't think it is a noop even though the default is false. > threadSafe - @threadSafe - Default: false > Marks this mojo as being thread-safe, i.e. the mojo

[GitHub] [maven-scm] michael-o commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
michael-o commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971349942 Added this to 1.21.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (SCM-883) ScmFileSet DEFAULT_EXCLUDES too restrictive

2021-11-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SCM-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SCM-883: --- Fix Version/s: 1.12.1 > ScmFileSet DEFAULT_EXCLUDES too restrictive >

[jira] [Commented] (MDEP-761) Tree plugin does not terminate with 3.2.0

2021-11-17 Thread Jan (Jira)
[ https://issues.apache.org/jira/browse/MDEP-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445003#comment-17445003 ] Jan commented on MDEP-761: -- [~slachiewicz] Thanks for fixing! Will this issue be updated with the actual release

[jira] [Updated] (SCM-946) Making the maven-scm-plugin fit for parallel execution (@threadSafe)

2021-11-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SCM-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SCM-946: --- Fix Version/s: 1.12.1 2.0.0-M1 > Making the maven-scm-plugin fit for parallel

[jira] [Assigned] (SCM-946) Making the maven-scm-plugin fit for parallel execution (@threadSafe)

2021-11-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SCM-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned SCM-946: -- Assignee: Michael Osipov > Making the maven-scm-plugin fit for parallel execution (@threadSafe)

[GitHub] [maven-scm] Lonzak edited a comment on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
Lonzak edited a comment on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971342688 I don't think it is a noop even though the default is false. > threadSafe - @threadSafe - Default: false > Marks this mojo as being thread-safe, i.e. the mojo

[GitHub] [maven-scm] Lonzak edited a comment on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
Lonzak edited a comment on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971342688 I don't think it is a noop even though the default is false. > threadSafe - @threadSafe - Default: false > Marks this mojo as being thread-safe, i.e. the mojo

[GitHub] [maven-scm] Lonzak commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-17 Thread GitBox
Lonzak commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971342688 I don't think it is a noop even though the default is false. > threadSafe - @threadSafe - Default: false > Marks this mojo as being thread-safe, i.e. the mojo safely

[GitHub] [maven] rfscholte commented on a change in pull request #607: [MNG-7129] Import maven caching system

2021-11-17 Thread GitBox
rfscholte commented on a change in pull request #607: URL: https://github.com/apache/maven/pull/607#discussion_r750985445 ## File path: maven-caching/src/main/java/org/apache/maven/caching/checksum/DigestUtils.java ## @@ -0,0 +1,189 @@ +package

[GitHub] [maven] rfscholte commented on a change in pull request #607: [MNG-7129] Import maven caching system

2021-11-17 Thread GitBox
rfscholte commented on a change in pull request #607: URL: https://github.com/apache/maven/pull/607#discussion_r750984599 ## File path: maven-caching/src/main/java/org/apache/maven/caching/Utils.java ## @@ -0,0 +1,87 @@ +package org.apache.maven.caching; + +/* + * Licensed to