Re: [PR] Use 4.0.99 as as intermediate model to keep 4.1.0 for the Maven 4.x model [maven]

2023-11-06 Thread via GitHub
cstamas commented on code in PR #1297: URL: https://github.com/apache/maven/pull/1297#discussion_r1383907491 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -387,7 +388,7 @@ - 4.0.0/4.1.0 + 4.0.0/4.0.99 Review Comment: Sadly,

Re: [PR] Change build pom naming from xxx-build.pom to xxx-build-pom.xml [maven]

2023-11-06 Thread via GitHub
gnodet commented on PR #1298: URL: https://github.com/apache/maven/pull/1298#issuecomment-1795431208 > > > This does not look wrong. What is the motivation behind this? > > > > > > The problem seems to be that sonatype oss release validation fail staging repositories deployed

[PR] Bump org.junit:junit-bom from 5.10.0 to 5.10.1 [maven-enforcer]

2023-11-06 Thread via GitHub
dependabot[bot] opened a new pull request, #296: URL: https://github.com/apache/maven-enforcer/pull/296 Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.10.0 to 5.10.1. Release notes Sourced from

Re: [PR] Bump org.junit.jupiter:junit-jupiter-engine from 5.9.1 to 5.10.0 [maven-antrun-plugin]

2023-11-06 Thread via GitHub
slachiewicz closed pull request #86: Bump org.junit.jupiter:junit-jupiter-engine from 5.9.1 to 5.10.0 URL: https://github.com/apache/maven-antrun-plugin/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Bump org.junit.jupiter:junit-jupiter-engine from 5.9.1 to 5.10.0 [maven-antrun-plugin]

2023-11-06 Thread via GitHub
dependabot[bot] commented on PR #86: URL: https://github.com/apache/maven-antrun-plugin/pull/86#issuecomment-1795613407 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

Re: [PR] [MPLUGINTESTING-90] Get rid of maven-compat [maven-plugin-testing]

2023-11-04 Thread via GitHub
slawekjaranowski merged PR #36: URL: https://github.com/apache/maven-plugin-testing/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump xmlunit-core from 2.9.0 to 2.9.1 [maven-antrun-plugin]

2023-11-06 Thread via GitHub
slachiewicz commented on PR #84: URL: https://github.com/apache/maven-antrun-plugin/pull/84#issuecomment-1795798951 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump xmlunit-matchers from 2.9.0 to 2.9.1 [maven-antrun-plugin]

2023-11-06 Thread via GitHub
slachiewicz commented on PR #83: URL: https://github.com/apache/maven-antrun-plugin/pull/83#issuecomment-1795800107 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump xmlunit-core from 2.9.0 to 2.9.1 [maven-antrun-plugin]

2023-11-06 Thread via GitHub
elharo merged PR #84: URL: https://github.com/apache/maven-antrun-plugin/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump xmlunit-matchers from 2.9.0 to 2.9.1 [maven-antrun-plugin]

2023-11-06 Thread via GitHub
elharo merged PR #83: URL: https://github.com/apache/maven-antrun-plugin/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [MANTRUN-239] Upgrade parent pom to 40 [maven-antrun-plugin]

2023-11-06 Thread via GitHub
slachiewicz merged PR #88: URL: https://github.com/apache/maven-antrun-plugin/pull/88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Bump org.junit:junit-bom from 5.9.3 to 5.10.1 [maven-surefire]

2023-11-06 Thread via GitHub
dependabot[bot] opened a new pull request, #685: URL: https://github.com/apache/maven-surefire/pull/685 Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.9.3 to 5.10.1. Release notes Sourced from

Re: [PR] Bump org.junit:junit-bom from 5.9.3 to 5.10.0 [maven-surefire]

2023-11-06 Thread via GitHub
dependabot[bot] commented on PR #679: URL: https://github.com/apache/maven-surefire/pull/679#issuecomment-1796041223 Superseded by #685. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump org.junit:junit-bom from 5.9.3 to 5.10.0 [maven-surefire]

2023-11-06 Thread via GitHub
dependabot[bot] closed pull request #679: Bump org.junit:junit-bom from 5.9.3 to 5.10.0 URL: https://github.com/apache/maven-surefire/pull/679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [MANTRUN-241] Bump org.junit.jupiter:junit-jupiter-engine to 5.10.1 [maven-antrun-plugin]

2023-11-06 Thread via GitHub
slachiewicz merged PR #89: URL: https://github.com/apache/maven-antrun-plugin/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Use 4.0.99 as as intermediate model to keep 4.1.0 for the Maven 4.x model [maven]

2023-11-06 Thread via GitHub
gnodet merged PR #1297: URL: https://github.com/apache/maven/pull/1297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [MSHARED-1326] Improve (documentation on) MavenReport interface [maven-reporting-api]

2023-11-06 Thread via GitHub
asfgit closed pull request #19: [MSHARED-1326] Improve (documentation on) MavenReport interface URL: https://github.com/apache/maven-reporting-api/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [MSHARED-1326] Improve (documentation on) AbstractMavenReport class [maven-reporting-impl]

2023-11-06 Thread via GitHub
asfgit closed pull request #25: [MSHARED-1326] Improve (documentation on) AbstractMavenReport class URL: https://github.com/apache/maven-reporting-impl/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [MSHARED-1327] Change output directory default [maven-reporting-impl]

2023-11-06 Thread via GitHub
michael-o commented on PR #26: URL: https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1796462318 @kriegaex I have rebased this PR. Here is the output when there is no subdir: ``` D:\Entwicklung\Projekte\maven-reporting-impl [patch-1 ≡ +2 ~0 -0 !]> ls

Re: [PR] MNGSITE-527 broken link to settings-1.3.0.xsd [maven-site]

2023-11-06 Thread via GitHub
gnodet commented on PR #464: URL: https://github.com/apache/maven-site/pull/464#issuecomment-1796639967 The two missing XSDs should now be available by building maven master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] Bump org.codehaus.plexus:plexus-archiver from 4.8.0 to 4.9.0 [maven-dependency-plugin]

2023-11-06 Thread via GitHub
dependabot[bot] opened a new pull request, #348: URL: https://github.com/apache/maven-dependency-plugin/pull/348 Bumps [org.codehaus.plexus:plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 4.8.0 to 4.9.0. Release notes Sourced from

Re: [PR] [MNG-7909] Upgrade to Resolver 2.0.0-alpha-1 [maven]

2023-11-06 Thread via GitHub
cstamas commented on PR #1282: URL: https://github.com/apache/maven/pull/1282#issuecomment-1796837365 On Java 11 IT failures are: ``` Error: Failures: Error:

Re: [PR] MNGSITE-527 broken link to settings-1.3.0.xsd [maven-site]

2023-11-06 Thread via GitHub
gnodet commented on PR #464: URL: https://github.com/apache/maven-site/pull/464#issuecomment-1796832812 The `plugin-[version].xsd` schemas are currently not published, so don't bother with those. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Mvnd fails to clean after first install was successfull [maven-mvnd]

2023-10-30 Thread via GitHub
ppalaga commented on issue #900: URL: https://github.com/apache/maven-mvnd/issues/900#issuecomment-1785206966 This kind of issues has to do with caching plugin class loaders that happen to require some files from target folders. @popcristianvlad do you know which plugin depends on

Re: [PR] [MPOM-440] Add maven-checkstyle-plugin to pluginManagement [maven-apache-parent]

2023-10-27 Thread via GitHub
slawekjaranowski merged PR #173: URL: https://github.com/apache/maven-apache-parent/pull/173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [MPOM-438] Bump maven-plugin-plugin from 3.9.0 to 3.10.1 [maven-apache-parent]

2023-10-27 Thread via GitHub
slawekjaranowski commented on PR #170: URL: https://github.com/apache/maven-apache-parent/pull/170#issuecomment-1783492751 @slachiewicz I have checked this versions with Maven 3.9.5 and 4.x ... and I don't any issues - generated plugin descriptor is the same - documentation site is

Re: [PR] [MPOM-438] Bump maven-plugin-plugin from 3.9.0 to 3.10.1 [maven-apache-parent]

2023-10-27 Thread via GitHub
slachiewicz commented on PR #170: URL: https://github.com/apache/maven-apache-parent/pull/170#issuecomment-1783564236 If it works for you, that's good. I can see only that we pulled the below dependencies: [INFO] | | \- org.apache.maven:maven-xml-impl:jar:4.0.0-alpha-5:compile

[PR] [MPOM-437] Bump maven-dependency-plugin from 3.6.0 to 3.6.1 [maven-apache-parent]

2023-10-26 Thread via GitHub
slawekjaranowski opened a new pull request, #169: URL: https://github.com/apache/maven-apache-parent/pull/169 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [MPOM-438] Bump maven-plugin-plugin from 3.9.0 to 3.10.1 [maven-apache-parent]

2023-10-26 Thread via GitHub
slawekjaranowski opened a new pull request, #170: URL: https://github.com/apache/maven-apache-parent/pull/170 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [MPOM-439] Bump maven-surefire from 3.1.2 to 3.2.1 [maven-apache-parent]

2023-10-26 Thread via GitHub
slawekjaranowski opened a new pull request, #171: URL: https://github.com/apache/maven-apache-parent/pull/171 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [MPOM-399] Set minimalMavenBuildVersion to 3.6.3 - the minimum used by plugins [maven-apache-parent]

2023-10-26 Thread via GitHub
slawekjaranowski opened a new pull request, #172: URL: https://github.com/apache/maven-apache-parent/pull/172 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [MPOM-440] Add maven-checkstyle-plugin to pluginManagement [maven-apache-parent]

2023-10-26 Thread via GitHub
slawekjaranowski opened a new pull request, #173: URL: https://github.com/apache/maven-apache-parent/pull/173 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [MWRAPPER-114] - Maven wrapper relative distributionUrl does not work… [maven-wrapper]

2023-10-28 Thread via GitHub
melbeltagy commented on PR #107: URL: https://github.com/apache/maven-wrapper/pull/107#issuecomment-1783851515 I don't have access to leave this comment on https://issues.apache.org/jira/projects/MWRAPPER/issues/MWRAPPER-114.. so, I'll leave it here for now till I get access. The

Re: [PR] [MSHARED-1327] Change output directory default [maven-reporting-impl]

2023-10-25 Thread via GitHub
kriegaex commented on code in PR #26: URL: https://github.com/apache/maven-reporting-impl/pull/26#discussion_r1371585628 ## src/main/java/org/apache/maven/reporting/AbstractMavenReport.java: ## @@ -74,11 +74,16 @@ */ public abstract class AbstractMavenReport extends

Re: [PR] [MCLEAN-111] Fix fast delete feature for filesets [maven-clean-plugin]

2023-10-18 Thread via GitHub
slawekjaranowski merged PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [MCLEAN-111] Fix fast delete feature for filesets [maven-clean-plugin]

2023-10-18 Thread via GitHub
slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769522737 @wilx - thanks for fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Use the same branch name for ITs on Jenkins - 3.9.x [maven]

2023-10-17 Thread via GitHub
slawekjaranowski opened a new pull request, #1288: URL: https://github.com/apache/maven/pull/1288 (cherry picked from commit 882c8dd9746f2fb7bec1c2b7b6ece4b85c75f701) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.0 [maven-clean-plugin]

2023-10-19 Thread via GitHub
dependabot[bot] opened a new pull request, #35: URL: https://github.com/apache/maven-clean-plugin/pull/35 Bumps [org.codehaus.plexus:plexus-xml](https://github.com/codehaus-plexus/plexus-xml) from 3.0.0 to 4.0.0. Release notes Sourced from

Re: [PR] [3.9.x] [MNG-7913] Upgrade Sisu version [maven]

2023-10-17 Thread via GitHub
cstamas commented on PR #1286: URL: https://github.com/apache/maven/pull/1286#issuecomment-1766951141 I agree with @kwin: just keep it simple with Maven 3.9, let it go up to Java 21 but we don't want to "future proof" it, as there is maven4 -- This is an automated message from the Apache

Re: [PR] [3.9.x] [MNG-7913] Upgrade Sisu version [maven]

2023-10-17 Thread via GitHub
gnodet commented on PR #1286: URL: https://github.com/apache/maven/pull/1286#issuecomment-1766894060 > To version that supports gleaning JSR330 component classes up to Java 21. The reasoning of this change is only to allow 3rd party Maven plugins/Maven extensions/other JSR330 components

[PR] PMC += henning [maven-parent]

2023-10-18 Thread via GitHub
hgschmie opened a new pull request, #143: URL: https://github.com/apache/maven-parent/pull/143 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [MNG-7772] Allow to register maven core extension in .m2 directory in… [maven]

2023-10-17 Thread via GitHub
juulhobert closed pull request #1287: [MNG-7772] Allow to register maven core extension in .m2 directory in… URL: https://github.com/apache/maven/pull/1287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [MNG-6437] Better support for path and uri in property interpolation [maven]

2023-10-17 Thread via GitHub
gnodet merged PR #812: URL: https://github.com/apache/maven/pull/812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [3.9.x] [MNG-7913] Upgrade Sisu version [maven]

2023-10-17 Thread via GitHub
kwin commented on PR #1286: URL: https://github.com/apache/maven/pull/1286#issuecomment-1766904173 I think supporting Java up to 19 is enough for Maven 3.9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] [MNG-7772] Allow to register maven core extension in .m2 directory in… [maven]

2023-10-17 Thread via GitHub
juulhobert opened a new pull request, #1287: URL: https://github.com/apache/maven/pull/1287 …stead of MAVEN_HOME Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

Re: [PR] [MNG-7891] Abstract ExtensionConfigurationModule from CliRequest [maven]

2023-10-17 Thread via GitHub
gnodet merged PR #1272: URL: https://github.com/apache/maven/pull/1272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Add mthmulders as PMC Member [maven-parent]

2023-10-19 Thread via GitHub
mthmulders opened a new pull request, #144: URL: https://github.com/apache/maven-parent/pull/144 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add mthmulders as PMC Member [maven-parent]

2023-10-19 Thread via GitHub
mthmulders closed pull request #144: Add mthmulders as PMC Member URL: https://github.com/apache/maven-parent/pull/144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [MNG-7899] Various memory usage improvements 4 [maven]

2023-10-19 Thread via GitHub
gnodet commented on code in PR #1269: URL: https://github.com/apache/maven/pull/1269#discussion_r1365000724 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java: ## @@ -135,7 +136,7 @@ public synchronized void

Re: [PR] [MNG-7899] Various memory usage improvements 5 [maven]

2023-10-19 Thread via GitHub
gnodet commented on code in PR #1270: URL: https://github.com/apache/maven/pull/1270#discussion_r1365012668 ## maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java: ## @@ -71,8 +78,13 @@ private void printStackTrace(Throwable t, PrintStream stream, String

Re: [PR] [MNG-6847] Use diamond operator [maven]

2023-10-19 Thread via GitHub
gnodet merged PR #1264: URL: https://github.com/apache/maven/pull/1264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.0 [maven-clean-plugin]

2023-10-19 Thread via GitHub
slachiewicz commented on PR #35: URL: https://github.com/apache/maven-clean-plugin/pull/35#issuecomment-1770208196 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.0 [maven-clean-plugin]

2023-10-19 Thread via GitHub
dependabot[bot] commented on PR #35: URL: https://github.com/apache/maven-clean-plugin/pull/35#issuecomment-1770208262 OK, I won't notify you about version 4.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.0 [maven-clean-plugin]

2023-10-19 Thread via GitHub
dependabot[bot] closed pull request #35: Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.0 URL: https://github.com/apache/maven-clean-plugin/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-common-artifact-filters] elharo merged pull request #34: [MSHARED-1302] upgrade commons-io to 2.13.0

2023-09-19 Thread via GitHub
elharo merged PR #34: URL: https://github.com/apache/maven-common-artifact-filters/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-shade-plugin] dependabot[bot] commented on pull request #194: Bump org.vafer:jdependency from 2.8.0 to 2.9.0

2023-09-19 Thread via GitHub
dependabot[bot] commented on PR #194: URL: https://github.com/apache/maven-shade-plugin/pull/194#issuecomment-1725239530 Looks like org.vafer:jdependency is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-shade-plugin] dependabot[bot] closed pull request #194: Bump org.vafer:jdependency from 2.8.0 to 2.9.0

2023-09-19 Thread via GitHub
dependabot[bot] closed pull request #194: Bump org.vafer:jdependency from 2.8.0 to 2.9.0 URL: https://github.com/apache/maven-shade-plugin/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-gh-actions-shared] slachiewicz merged pull request #80: Bump actions/checkout from 3 to 4

2023-09-19 Thread via GitHub
slachiewicz merged PR #80: URL: https://github.com/apache/maven-gh-actions-shared/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-gh-actions-shared] slachiewicz merged pull request #78: Bump actions/checkout from 3 to 4

2023-09-19 Thread via GitHub
slachiewicz merged PR #78: URL: https://github.com/apache/maven-gh-actions-shared/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-remote-resources-plugin] dependabot[bot] opened a new pull request, #45: Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.2

2023-09-17 Thread via GitHub
dependabot[bot] opened a new pull request, #45: URL: https://github.com/apache/maven-remote-resources-plugin/pull/45 Bumps [org.codehaus.plexus:plexus-xml](https://github.com/codehaus-plexus/plexus-xml) from 3.0.0 to 4.0.2. Release notes Sourced from

[GitHub] [maven-shade-plugin] slawekjaranowski commented on a diff in pull request #196: Adjust to test also with Java 21

2023-09-19 Thread via GitHub
slawekjaranowski commented on code in PR #196: URL: https://github.com/apache/maven-shade-plugin/pull/196#discussion_r1330029074 ## pom.xml: ## @@ -365,5 +366,44 @@ + + + + java11+ + +[11,) + + + +

[GitHub] [maven-shade-plugin] slachiewicz commented on a diff in pull request #196: Adjust to test also with Java 21

2023-09-19 Thread via GitHub
slachiewicz commented on code in PR #196: URL: https://github.com/apache/maven-shade-plugin/pull/196#discussion_r1330032550 ## pom.xml: ## @@ -365,5 +366,44 @@ + + + + java11+ + +[11,) + + + + +

[GitHub] [maven-shade-plugin] slachiewicz merged pull request #196: [MSHADE-459] Adjust to test also with Java 21

2023-09-19 Thread via GitHub
slachiewicz merged PR #196: URL: https://github.com/apache/maven-shade-plugin/pull/196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-shade-plugin] slawekjaranowski opened a new pull request, #197: [MSHADE-458] Refresh download page

2023-09-19 Thread via GitHub
slawekjaranowski opened a new pull request, #197: URL: https://github.com/apache/maven-shade-plugin/pull/197 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA

[GitHub] [maven-shade-plugin] dependabot[bot] closed pull request #132: Bump junit from 4.7 to 4.13.1 in /src/it/projects/shading-with-java-8-sources

2023-09-19 Thread via GitHub
dependabot[bot] closed pull request #132: Bump junit from 4.7 to 4.13.1 in /src/it/projects/shading-with-java-8-sources URL: https://github.com/apache/maven-shade-plugin/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [maven-shade-plugin] dependabot[bot] commented on pull request #132: Bump junit from 4.7 to 4.13.1 in /src/it/projects/shading-with-java-8-sources

2023-09-19 Thread via GitHub
dependabot[bot] commented on PR #132: URL: https://github.com/apache/maven-shade-plugin/pull/132#issuecomment-1726461942 Looks like junit:junit is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [maven-shade-plugin] slawekjaranowski commented on pull request #132: Bump junit from 4.7 to 4.13.1 in /src/it/projects/shading-with-java-8-sources

2023-09-19 Thread via GitHub
slawekjaranowski commented on PR #132: URL: https://github.com/apache/maven-shade-plugin/pull/132#issuecomment-1726461671 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven] gnodet commented on a diff in pull request #1249: [MNG-7820] Get rid of plexus-utils Os class

2023-09-19 Thread via GitHub
gnodet commented on code in PR #1249: URL: https://github.com/apache/maven/pull/1249#discussion_r1330580638 ## maven-model-builder/src/main/java/org/apache/maven/utils/Os.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [maven-shade-plugin] dependabot[bot] commented on pull request #135: Bump junit from 4.7 to 4.13.1 in /src/it/projects/shading-with-release-sources

2023-09-19 Thread via GitHub
dependabot[bot] commented on PR #135: URL: https://github.com/apache/maven-shade-plugin/pull/135#issuecomment-1726465256 Looks like junit:junit is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [maven-shade-plugin] dependabot[bot] closed pull request #135: Bump junit from 4.7 to 4.13.1 in /src/it/projects/shading-with-release-sources

2023-09-19 Thread via GitHub
dependabot[bot] closed pull request #135: Bump junit from 4.7 to 4.13.1 in /src/it/projects/shading-with-release-sources URL: https://github.com/apache/maven-shade-plugin/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [maven-shade-plugin] dependabot[bot] commented on pull request #134: Bump junit from 4.10 to 4.13.1 in /src/it/projects/project-with-reactors-included

2023-09-19 Thread via GitHub
dependabot[bot] commented on PR #134: URL: https://github.com/apache/maven-shade-plugin/pull/134#issuecomment-1726464024 Looks like junit:junit is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [maven-shade-plugin] dependabot[bot] closed pull request #134: Bump junit from 4.10 to 4.13.1 in /src/it/projects/project-with-reactors-included

2023-09-19 Thread via GitHub
dependabot[bot] closed pull request #134: Bump junit from 4.10 to 4.13.1 in /src/it/projects/project-with-reactors-included URL: https://github.com/apache/maven-shade-plugin/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven-shade-plugin] slawekjaranowski commented on pull request #135: Bump junit from 4.7 to 4.13.1 in /src/it/projects/shading-with-release-sources

2023-09-19 Thread via GitHub
slawekjaranowski commented on PR #135: URL: https://github.com/apache/maven-shade-plugin/pull/135#issuecomment-1726464996 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-shade-plugin] dependabot[bot] commented on pull request #144: Bump plexus-utils from 1.4.1 to 3.0.16 in /src/it/projects/MSHADE-36-inject-dep-reduced-pom-in-final

2023-09-19 Thread via GitHub
dependabot[bot] commented on PR #144: URL: https://github.com/apache/maven-shade-plugin/pull/144#issuecomment-1726487641 Looks like org.codehaus.plexus:plexus-utils is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [maven-shade-plugin] dependabot[bot] closed pull request #144: Bump plexus-utils from 1.4.1 to 3.0.16 in /src/it/projects/MSHADE-36-inject-dep-reduced-pom-in-final

2023-09-19 Thread via GitHub
dependabot[bot] closed pull request #144: Bump plexus-utils from 1.4.1 to 3.0.16 in /src/it/projects/MSHADE-36-inject-dep-reduced-pom-in-final URL: https://github.com/apache/maven-shade-plugin/pull/144 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-shade-plugin] slawekjaranowski commented on pull request #136: Bump commons-io from 1.4 to 2.7 in /src/it/projects/MSHADE-105/shaded-jar

2023-09-19 Thread via GitHub
slawekjaranowski commented on PR #136: URL: https://github.com/apache/maven-shade-plugin/pull/136#issuecomment-1726479410 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-shade-plugin] dependabot[bot] commented on pull request #136: Bump commons-io from 1.4 to 2.7 in /src/it/projects/MSHADE-105/shaded-jar

2023-09-19 Thread via GitHub
dependabot[bot] commented on PR #136: URL: https://github.com/apache/maven-shade-plugin/pull/136#issuecomment-1726481782 Looks like commons-io:commons-io is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-shade-plugin] dependabot[bot] closed pull request #136: Bump commons-io from 1.4 to 2.7 in /src/it/projects/MSHADE-105/shaded-jar

2023-09-19 Thread via GitHub
dependabot[bot] closed pull request #136: Bump commons-io from 1.4 to 2.7 in /src/it/projects/MSHADE-105/shaded-jar URL: https://github.com/apache/maven-shade-plugin/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [maven-shade-plugin] dependabot[bot] commented on pull request #133: Bump junit from 4.7 to 4.13.1 in /src/it/projects/users-shader-impl

2023-09-19 Thread via GitHub
dependabot[bot] commented on PR #133: URL: https://github.com/apache/maven-shade-plugin/pull/133#issuecomment-1726463473 Looks like junit:junit is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [maven-shade-plugin] dependabot[bot] closed pull request #133: Bump junit from 4.7 to 4.13.1 in /src/it/projects/users-shader-impl

2023-09-19 Thread via GitHub
dependabot[bot] closed pull request #133: Bump junit from 4.7 to 4.13.1 in /src/it/projects/users-shader-impl URL: https://github.com/apache/maven-shade-plugin/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [maven-shade-plugin] slawekjaranowski commented on pull request #133: Bump junit from 4.7 to 4.13.1 in /src/it/projects/users-shader-impl

2023-09-19 Thread via GitHub
slawekjaranowski commented on PR #133: URL: https://github.com/apache/maven-shade-plugin/pull/133#issuecomment-1726463147 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven] gnodet commented on a diff in pull request #1249: [MNG-7820] Get rid of plexus-utils Os class

2023-09-19 Thread via GitHub
gnodet commented on code in PR #1249: URL: https://github.com/apache/maven/pull/1249#discussion_r1330553298 ## maven-model-builder/src/main/java/org/apache/maven/utils/Os.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [maven-shade-plugin] slawekjaranowski opened a new pull request, #198: [MSHADE-457] Upgrade Parent to 40

2023-09-19 Thread via GitHub
slawekjaranowski opened a new pull request, #198: URL: https://github.com/apache/maven-shade-plugin/pull/198 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA

[GitHub] [maven-shade-plugin] dependabot[bot] commented on pull request #137: Bump commons-io from 1.4 to 2.7 in /src/it/projects/MSHADE-391_noRelocationKeepOriginalClasses

2023-09-19 Thread via GitHub
dependabot[bot] commented on PR #137: URL: https://github.com/apache/maven-shade-plugin/pull/137#issuecomment-1726478524 Looks like commons-io:commons-io is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-shade-plugin] dependabot[bot] closed pull request #137: Bump commons-io from 1.4 to 2.7 in /src/it/projects/MSHADE-391_noRelocationKeepOriginalClasses

2023-09-19 Thread via GitHub
dependabot[bot] closed pull request #137: Bump commons-io from 1.4 to 2.7 in /src/it/projects/MSHADE-391_noRelocationKeepOriginalClasses URL: https://github.com/apache/maven-shade-plugin/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [maven-shade-plugin] slawekjaranowski commented on pull request #137: Bump commons-io from 1.4 to 2.7 in /src/it/projects/MSHADE-391_noRelocationKeepOriginalClasses

2023-09-19 Thread via GitHub
slawekjaranowski commented on PR #137: URL: https://github.com/apache/maven-shade-plugin/pull/137#issuecomment-1726477160 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven] gnodet commented on a diff in pull request #812: [MNG-6437] Better support for path and uri in property interpolation

2023-09-22 Thread via GitHub
gnodet commented on code in PR #812: URL: https://github.com/apache/maven/pull/812#discussion_r1334753117 ## maven-core/src/main/java/org/apache/maven/plugin/ReflectionValueExtractor.java: ## @@ -261,22 +265,14 @@ private static Object getPropertyValue(Object value, String

[GitHub] [maven] gnodet commented on pull request #812: [MNG-6437] Better support for path and uri in property interpolation

2023-09-22 Thread via GitHub
gnodet commented on PR #812: URL: https://github.com/apache/maven/pull/812#issuecomment-1731994316 > > What am I doing wrong? > > The PR only tackles plugin configuration injection, not model interpolation. I'll see if/how that can be done... Actually, this is not the

[GitHub] [maven] JurrianFahner commented on a diff in pull request #878: [MNG-7541] Implement powershell command

2023-09-22 Thread via GitHub
JurrianFahner commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1334825689 ## apache-maven/src/assembly/shared/mvnvalidate.ps1: ## @@ -0,0 +1,7 @@ +# check mvn home +$MAVEN_HOME = (Get-Item $PSScriptRoot).Parent + +# check if maven command

[GitHub] [maven] JurrianFahner commented on a diff in pull request #878: [MNG-7541] Implement powershell command

2023-09-22 Thread via GitHub
JurrianFahner commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1334826314 ## apache-maven/src/assembly/shared/run.ps1: ## @@ -0,0 +1,13 @@ +& $JAVACMD ` + $MAVEN_OPTS ` + $MAVEN_DEBUG_OPTS ` + -classpath $LAUNCHER_JAR ` Review Comment:

[GitHub] [maven] michael-o commented on a diff in pull request #878: [MNG-7541] Implement powershell command

2023-09-22 Thread via GitHub
michael-o commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1334834141 ## apache-maven/src/assembly/shared/mvnvalidate.ps1: ## @@ -0,0 +1,7 @@ +# check mvn home +$MAVEN_HOME = (Get-Item $PSScriptRoot).Parent + +# check if maven command

[GitHub] [maven] michael-o commented on a diff in pull request #878: [MNG-7541] Implement powershell command

2023-09-22 Thread via GitHub
michael-o commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1334833714 ## apache-maven/src/assembly/maven/bin/mvnDebug.ps1: ## @@ -0,0 +1,42 @@ +<# +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license

[GitHub] [maven] JurrianFahner commented on a diff in pull request #878: [MNG-7541] Implement powershell command

2023-09-22 Thread via GitHub
JurrianFahner commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1334839636 ## apache-maven/src/assembly/maven/bin/mvnDebug.ps1: ## @@ -0,0 +1,42 @@ +<# +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license

[GitHub] [maven] gnodet commented on pull request #812: [MNG-6437] Better support for path and uri in property interpolation

2023-09-22 Thread via GitHub
gnodet commented on PR #812: URL: https://github.com/apache/maven/pull/812#issuecomment-1731946609 > Well, built your branch and tested on: > > ``` > osipovmi@deblndw011x:/tmp/ма вен (MNG-6437 =) > $ ../apache-maven-4.0.0-alpha-8-SNAPSHOT/bin/mvn -v > Apache Maven

[GitHub] [maven] JurrianFahner commented on a diff in pull request #878: [MNG-7541] Implement powershell command

2023-09-22 Thread via GitHub
JurrianFahner commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1334818771 ## apache-maven/src/assembly/maven/bin/mvnDebug.ps1: ## @@ -0,0 +1,42 @@ +<# +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license

[GitHub] [maven] JurrianFahner commented on a diff in pull request #878: [MNG-7541] Implement powershell command

2023-09-22 Thread via GitHub
JurrianFahner commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1334818771 ## apache-maven/src/assembly/maven/bin/mvnDebug.ps1: ## @@ -0,0 +1,42 @@ +<# +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license

[GitHub] [maven-javadoc-plugin] elharo opened a new pull request, #243: [MJAVADOC-726] exclude velocity

2023-09-21 Thread via GitHub
elharo opened a new pull request, #243: URL: https://github.com/apache/maven-javadoc-plugin/pull/243 Alternate appioach to keeping log4j out of the tree by excluding veliocty-tools. Nuked log4j from my .m2/repo and veriifed that the sample project now only downloads 1.2.17 when

[GitHub] [maven-site] gnodet commented on a diff in pull request #451: [MNG-7879] Document the new bom packaging

2023-09-21 Thread via GitHub
gnodet commented on code in PR #451: URL: https://github.com/apache/maven-site/pull/451#discussion_r133269 ## content/apt/guides/introduction/introduction-to-dependency-mechanism.apt: ## @@ -822,6 +822,48 @@ Introduction to the Dependency Mechanism artifact may not

[GitHub] [maven-site] slawekjaranowski commented on pull request #451: [MNG-7879] Document the new bom packaging

2023-09-21 Thread via GitHub
slawekjaranowski commented on PR #451: URL: https://github.com/apache/maven-site/pull/451#issuecomment-1729011182 Can we add example when and why use new packaging `bom` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [maven] michael-o commented on pull request #812: [MNG-6437] Better support for path and uri in property interpolation

2023-09-22 Thread via GitHub
michael-o commented on PR #812: URL: https://github.com/apache/maven/pull/812#issuecomment-1731960950 > > Well, built your branch and tested on: > > ``` > > osipovmi@deblndw011x:/tmp/ма вен (MNG-6437 =) > > $ ../apache-maven-4.0.0-alpha-8-SNAPSHOT/bin/mvn -v > > Apache Maven

<    4   5   6   7   8   9   10   11   12   13   >