[jira] [Commented] (MESOS-4114) Add field VIP to message Port

2016-01-06 Thread Jie Yu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086006#comment-15086006 ] Jie Yu commented on MESOS-4114: --- Cool, I'll then revert the patch set above. cc [~adam-mesos] > Add field

[jira] [Commented] (MESOS-4114) Add field VIP to message Port

2016-01-06 Thread Sargun Dhillon (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085845#comment-15085845 ] Sargun Dhillon commented on MESOS-4114: --- I think we should just do a label on ports. In order to

[jira] [Commented] (MESOS-4114) Add field VIP to message Port

2016-01-06 Thread Jie Yu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086432#comment-15086432 ] Jie Yu commented on MESOS-4114: --- Reverted the patches. Marked this ticket as won't fix. > Add field VIP to

[jira] [Commented] (MESOS-4114) Add field VIP to message Port

2016-01-04 Thread Jie Yu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082060#comment-15082060 ] Jie Yu commented on MESOS-4114: --- Based on the code committed, here are my thoughts and questions: 1) The

[jira] [Commented] (MESOS-4114) Add field VIP to message Port

2015-12-14 Thread Avinash Sridharan (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056254#comment-15056254 ] Avinash Sridharan commented on MESOS-4114: -- So the concensus is to have a repeated "vip" field in

[jira] [Commented] (MESOS-4114) Add field VIP to message Port

2015-12-12 Thread Avinash Sridharan (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054661#comment-15054661 ] Avinash Sridharan commented on MESOS-4114: -- [~sargun] , [~tknaup] so what is the final consensus

[jira] [Commented] (MESOS-4114) Add field VIP to message Port

2015-12-11 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053596#comment-15053596 ] Tobi Knaup commented on MESOS-4114: --- [~sargun] DiscoveryInfo was meant to be the thing that clients or

[jira] [Commented] (MESOS-4114) Add field VIP to message Port

2015-12-11 Thread Sargun Dhillon (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053110#comment-15053110 ] Sargun Dhillon commented on MESOS-4114: --- Isn’t the port on DiscoveryInfo.Ports.Port the local port

[jira] [Commented] (MESOS-4114) Add field VIP to message Port

2015-12-11 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053092#comment-15053092 ] Tobi Knaup commented on MESOS-4114: --- Can you explain why the VIP should go into Port vs. DiscoveryInfo?

[jira] [Commented] (MESOS-4114) Add field VIP to message Port

2015-12-11 Thread Adam B (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052413#comment-15052413 ] Adam B commented on MESOS-4114: --- If we had labels from MESOS-3962, would you really need VIP as a