[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292091#comment-15292091
]
Greg Mann commented on MESOS-5060:
--
[~dongdong], great thanks! I tested the patch in the webui, and the
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288196#comment-15288196
]
zhou xing commented on MESOS-5060:
--
have updated the patch, thanks Greg for your time:)
> Requesting
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288164#comment-15288164
]
Greg Mann commented on MESOS-5060:
--
Great, thanks [~dongdong]!! No worries about the delay, I've been
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288151#comment-15288151
]
zhou xing commented on MESOS-5060:
--
Have updated the patch, [~greggomann], please take a look
>
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284386#comment-15284386
]
zhou xing commented on MESOS-5060:
--
[~greggomann], sorry about the late response, I'm now busy with the
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278957#comment-15278957
]
Greg Mann commented on MESOS-5060:
--
Hi [~dongdong]! My mistake: your current patch actually breaks the
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273636#comment-15273636
]
zhou xing commented on MESOS-5060:
--
[~bmahler], I have rebased the code, would you please take a look at
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273634#comment-15273634
]
zhou xing commented on MESOS-5060:
--
Added MESOS-5334 to further resolve the code logic issue.
>
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255838#comment-15255838
]
Greg Mann commented on MESOS-5060:
--
[~dongdong], yea I think it's a great idea to open up another ticket
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249323#comment-15249323
]
zhou xing commented on MESOS-5060:
--
[~greggomann], sure, have updated the review request to only fix the
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248623#comment-15248623
]
Greg Mann commented on MESOS-5060:
--
Hi [~dongdong], thanks for the patch! Sorry that I didn't get back to
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247354#comment-15247354
]
zhou xing commented on MESOS-5060:
--
[~greggomann] and [~bmahler], I submitted a draft review request
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245232#comment-15245232
]
zhou xing commented on MESOS-5060:
--
Hi Greg, I took a look at the code today and based on your
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244474#comment-15244474
]
zhou xing commented on MESOS-5060:
--
Hi Greg, thanks a lot for the information! it's really a helpful hint
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15243420#comment-15243420
]
Greg Mann commented on MESOS-5060:
--
[~dongdong], I had a look at this code with BenM and there is a clear
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240278#comment-15240278
]
Greg Mann commented on MESOS-5060:
--
Yep, I'm happy to help review! Thanks [~bmahler], [~dongdong].
>
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236611#comment-15236611
]
zhou xing commented on MESOS-5060:
--
Hi Greg, thanks for your reminder! Is that ok for you to help
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232876#comment-15232876
]
Greg Mann commented on MESOS-5060:
--
[~dongdong], thanks for taking on this ticket! Could you find a
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222026#comment-15222026
]
Greg Mann commented on MESOS-5060:
--
I was able to reproduce this on the current tip of master. Thanks for
19 matches
Mail list logo