[jira] [Commented] (METRON-1800) Increment metron-bro-plugin-kafka version

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645751#comment-16645751 ] ASF GitHub Bot commented on METRON-1800: Github user nickwallen commented on the issue:

[GitHub] metron-bro-plugin-kafka issue #10: METRON-1800: Increment metron-bro-plugin-...

2018-10-10 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/10 +1 thanks ---

[jira] [Commented] (METRON-1800) Increment metron-bro-plugin-kafka version

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645716#comment-16645716 ] ASF GitHub Bot commented on METRON-1800: Github user JonZeolla commented on the issue:

[GitHub] metron-bro-plugin-kafka issue #10: METRON-1800: Increment metron-bro-plugin-...

2018-10-10 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/10 bump. @nickwallen do you have a spare minute to review? ---

[jira] [Commented] (METRON-1817) Remove bro package dependency on bro source

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645472#comment-16645472 ] ASF GitHub Bot commented on METRON-1817: GitHub user JonZeolla opened a pull request:

[GitHub] metron-bro-plugin-kafka pull request #12: [ON HOLD] METRON-1817: Remove bro ...

2018-10-10 Thread JonZeolla
GitHub user JonZeolla opened a pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/12 [ON HOLD] METRON-1817: Remove bro package dependency on bro source This depends on a version of bro that is currently still in beta, but as of 2.6 bro will no longer depend on the

[jira] [Commented] (METRON-1818) Remove config_files from bro-pkg.meta

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645470#comment-16645470 ] ASF GitHub Bot commented on METRON-1818: GitHub user JonZeolla opened a pull request:

[GitHub] metron-bro-plugin-kafka pull request #11: METRON-1818: Remove config_files f...

2018-10-10 Thread JonZeolla
GitHub user JonZeolla opened a pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/11 METRON-1818: Remove config_files from bro-pkg.meta Remove the `config_files` line from `bro-pkg.meta`, as it is [not

[jira] [Updated] (METRON-1818) Remove config_files from bro-pkg.meta

2018-10-10 Thread Jon Zeolla (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Zeolla updated METRON-1818: --- Summary: Remove config_files from bro-pkg.meta (was: Fix bro-pkg.meta config_files) > Remove

[jira] [Updated] (METRON-1817) Remove bro package dependency on bro source

2018-10-10 Thread Jon Zeolla (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Zeolla updated METRON-1817: --- Summary: Remove bro package dependency on bro source (was: Update the instructions for Bro 2.6) >

[jira] [Created] (METRON-1819) Refactor bro plugin instructions to use bro-pkg

2018-10-10 Thread Jon Zeolla (JIRA)
Jon Zeolla created METRON-1819: -- Summary: Refactor bro plugin instructions to use bro-pkg Key: METRON-1819 URL: https://issues.apache.org/jira/browse/METRON-1819 Project: Metron Issue Type:

[jira] [Commented] (METRON-1769) Script creation of a release candidate

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645463#comment-16645463 ] ASF GitHub Bot commented on METRON-1769: Github user asfgit closed the pull request at:

[GitHub] metron pull request #1188: METRON-1769: Script creation of a release candida...

2018-10-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1188 ---

[jira] [Created] (METRON-1818) Fix bro-pkg.meta config_files

2018-10-10 Thread Jon Zeolla (JIRA)
Jon Zeolla created METRON-1818: -- Summary: Fix bro-pkg.meta config_files Key: METRON-1818 URL: https://issues.apache.org/jira/browse/METRON-1818 Project: Metron Issue Type: Task

[jira] [Created] (METRON-1817) Update the instructions for Bro 2.6

2018-10-10 Thread Jon Zeolla (JIRA)
Jon Zeolla created METRON-1817: -- Summary: Update the instructions for Bro 2.6 Key: METRON-1817 URL: https://issues.apache.org/jira/browse/METRON-1817 Project: Metron Issue Type: Task

[jira] [Commented] (METRON-1803) Integrate Cypress with Travis

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645272#comment-16645272 ] ASF GitHub Bot commented on METRON-1803: Github user mmiklavc commented on the issue:

[GitHub] metron issue #1226: METRON-1803: Integrate Cypress with Travis

2018-10-10 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1226 @nickwallen is this what you're looking for? I have some questions about what I'm looking at here. Are the checkmarks only indicating that a test has run, not that it has passed? I'm assuming the

[jira] [Commented] (METRON-1803) Integrate Cypress with Travis

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645261#comment-16645261 ] ASF GitHub Bot commented on METRON-1803: Github user mmiklavc commented on a diff in the pull

[jira] [Commented] (METRON-1803) Integrate Cypress with Travis

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645262#comment-16645262 ] ASF GitHub Bot commented on METRON-1803: Github user mmiklavc commented on a diff in the pull

[GitHub] metron pull request #1226: METRON-1803: Integrate Cypress with Travis

2018-10-10 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1226#discussion_r224157600 --- Diff: metron-interface/metron-alerts/cypress/integration/pcap/pcap.spec.js --- @@ -0,0 +1,228 @@ +/// --- End diff -- Can this line

[jira] [Commented] (METRON-1761) Allow a grok statement to be applied to each line in a file.

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645206#comment-16645206 ] ASF GitHub Bot commented on METRON-1761: Github user asfgit closed the pull request at:

[GitHub] metron pull request #1184: METRON-1761, allow application of grok statement ...

2018-10-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1184 ---

[jira] [Commented] (METRON-1761) Allow a grok statement to be applied to each line in a file.

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645154#comment-16645154 ] ASF GitHub Bot commented on METRON-1761: Github user merrimanr commented on the issue:

[GitHub] metron issue #1184: METRON-1761, allow application of grok statement multipl...

2018-10-10 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1184 +1 from me too. I will merge this into https://github.com/apache/metron/pull/1213 once it's in master and we can continue moving forward there. Parsing is getting an upgrade! ---

[jira] [Commented] (METRON-1761) Allow a grok statement to be applied to each line in a file.

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645151#comment-16645151 ] ASF GitHub Bot commented on METRON-1761: Github user ottobackwards commented on the issue:

[GitHub] metron issue #1184: METRON-1761, allow application of grok statement multipl...

2018-10-10 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1184 @merrimanr any comment? ---

[jira] [Commented] (METRON-1761) Allow a grok statement to be applied to each line in a file.

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645149#comment-16645149 ] ASF GitHub Bot commented on METRON-1761: Github user mmiklavc commented on the issue:

[GitHub] metron issue #1184: METRON-1761, allow application of grok statement multipl...

2018-10-10 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1184 This is great @ottobackwards, thanks for taking the time. +1 by inspection. ---

[GitHub] metron issue #1184: METRON-1761, allow application of grok statement multipl...

2018-10-10 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1184 @mmiklavc please see latest commit ---

[jira] [Commented] (METRON-1761) Allow a grok statement to be applied to each line in a file.

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645125#comment-16645125 ] ASF GitHub Bot commented on METRON-1761: Github user ottobackwards commented on the issue:

[jira] [Commented] (METRON-1790) Unsubscribe from every observable in the pcap panel UI component

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645111#comment-16645111 ] ASF GitHub Bot commented on METRON-1790: Github user nickwallen commented on a diff in the pull

[jira] [Commented] (METRON-1790) Unsubscribe from every observable in the pcap panel UI component

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645110#comment-16645110 ] ASF GitHub Bot commented on METRON-1790: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1208: METRON-1790: Unsubscribe from every observable in...

2018-10-10 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1208#discussion_r224110745 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.ts --- @@ -81,26 +81,28 @@ export class PcapPanelComponent

[jira] [Commented] (METRON-1816) Date format Stellar function

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645106#comment-16645106 ] ASF GitHub Bot commented on METRON-1816: GitHub user merrimanr opened a pull request:

[GitHub] metron pull request #1208: METRON-1790: Unsubscribe from every observable in...

2018-10-10 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1208#discussion_r224114432 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.ts --- @@ -35,40 +35,40 @@ export class PcapPanelComponent

[GitHub] metron pull request #1233: METRON-1816: Date format Stellar function

2018-10-10 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1233 METRON-1816: Date format Stellar function ## Contributor Comments This PR adds a Stellar function that wraps the Java SimpleDateFormat class. The first argument is a date format string and

[jira] [Commented] (METRON-1761) Allow a grok statement to be applied to each line in a file.

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645048#comment-16645048 ] ASF GitHub Bot commented on METRON-1761: Github user mmiklavc commented on the issue:

[GitHub] metron issue #1184: METRON-1761, allow application of grok statement multipl...

2018-10-10 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1184 This looks good to me @ottobackwards. I think the only thing left is some docs telling users how to add both existing and custom parsers to take advantage of this feature. ---

[jira] [Commented] (METRON-1681) Decouple the ParserBolt from the Parse execution logic

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645006#comment-16645006 ] ASF GitHub Bot commented on METRON-1681: Github user nickwallen commented on a diff in the pull

[jira] [Commented] (METRON-1681) Decouple the ParserBolt from the Parse execution logic

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645008#comment-16645008 ] ASF GitHub Bot commented on METRON-1681: Github user nickwallen commented on a diff in the pull

[jira] [Commented] (METRON-1681) Decouple the ParserBolt from the Parse execution logic

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645007#comment-16645007 ] ASF GitHub Bot commented on METRON-1681: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1213: METRON-1681: Decouple the ParserBolt from the Par...

2018-10-10 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1213#discussion_r224090659 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/ParserResult.java --- @@ -0,0 +1,84 @@ +/** + * Licensed to

[GitHub] metron pull request #1213: METRON-1681: Decouple the ParserBolt from the Par...

2018-10-10 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1213#discussion_r224091127 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/ParserRunnerImpl.java --- @@ -0,0 +1,216 @@ +/** + * Licensed

[GitHub] metron pull request #1213: METRON-1681: Decouple the ParserBolt from the Par...

2018-10-10 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1213#discussion_r224090753 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/ParserRunner.java --- @@ -0,0 +1,34 @@ +/** + * Licensed to

[jira] [Commented] (METRON-1813) Stellar REPL Not Initialized with Client JAAS

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644990#comment-16644990 ] ASF GitHub Bot commented on METRON-1813: Github user asfgit closed the pull request at:

[GitHub] metron pull request #1232: METRON-1813 Stellar REPL Not Initialized with Cli...

2018-10-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1232 ---

[jira] [Created] (METRON-1816) Date format Stellar function

2018-10-10 Thread Ryan Merriman (JIRA)
Ryan Merriman created METRON-1816: - Summary: Date format Stellar function Key: METRON-1816 URL: https://issues.apache.org/jira/browse/METRON-1816 Project: Metron Issue Type: Improvement

[jira] [Created] (METRON-1815) Separate metron-parsers into metron-parsers-common and metron-parsers-storm

2018-10-10 Thread Justin Leet (JIRA)
Justin Leet created METRON-1815: --- Summary: Separate metron-parsers into metron-parsers-common and metron-parsers-storm Key: METRON-1815 URL: https://issues.apache.org/jira/browse/METRON-1815 Project:

[jira] [Commented] (METRON-1813) Stellar REPL Not Initialized with Client JAAS

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644952#comment-16644952 ] ASF GitHub Bot commented on METRON-1813: Github user nickwallen commented on the issue:

[jira] [Commented] (METRON-1681) Decouple the ParserBolt from the Parse execution logic

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644953#comment-16644953 ] ASF GitHub Bot commented on METRON-1681: Github user justinleet commented on the issue:

[GitHub] metron issue #1213: METRON-1681: Decouple the ParserBolt from the Parse exec...

2018-10-10 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1213 I'm +1, assuming @mmiklavc is good with the changes from his review. ---

[GitHub] metron issue #1232: METRON-1813 Stellar REPL Not Initialized with Client JAA...

2018-10-10 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1232 > @mmiklavc: just curious about the proposed test which says to source the metron env script. You don't have to source /etc/default/metron before running the stellar script. I only

[jira] [Commented] (METRON-1769) Script creation of a release candidate

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644947#comment-16644947 ] ASF GitHub Bot commented on METRON-1769: Github user nickwallen commented on the issue:

[GitHub] metron issue #1188: METRON-1769: Script creation of a release candidate

2018-10-10 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1188 Yes. I expected we would just do a follow-on when we have cycles. Take the win! :) ---

[jira] [Commented] (METRON-1769) Script creation of a release candidate

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644943#comment-16644943 ] ASF GitHub Bot commented on METRON-1769: Github user justinleet commented on the issue:

[GitHub] metron issue #1188: METRON-1769: Script creation of a release candidate

2018-10-10 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1188 @nickwallen @mmiklavc @ottobackwards While I'm loath to look gift +1's in the mouth, the KEYS file issue still isn't resolved. Is everyone okay with me making a follow-on ticket to address it

[jira] [Commented] (METRON-1796) [UI] Migrate off moment.js

2018-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644635#comment-16644635 ] ASF GitHub Bot commented on METRON-1796: Github user ruffle1986 commented on a diff in the pull

[GitHub] metron pull request #1219: METRON-1796: [UI] Migrate off moment.js

2018-10-10 Thread ruffle1986
Github user ruffle1986 commented on a diff in the pull request: https://github.com/apache/metron/pull/1219#discussion_r223984152 --- Diff: metron-interface/metron-alerts/package.json --- @@ -22,17 +22,17 @@ "@angular/platform-browser": "^6.1.6",