[GitHub] metron issue #1269: METRON-1879 Allow Elasticsearch to Auto-Generate the Doc...

2018-12-04 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1269 Refresh me on this - prior to this change, did we provide both a doc id and a guid that were identical? And now with this change you would expect to see guid != doc id (bc guid generated by

[jira] [Commented] (METRON-1849) Elasticsearch Index Write Functionality Should be Shared

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709401#comment-16709401 ] ASF GitHub Bot commented on METRON-1849: Github user mmiklavc commented on a diff in the pull

[jira] [Commented] (METRON-1849) Elasticsearch Index Write Functionality Should be Shared

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709398#comment-16709398 ] ASF GitHub Bot commented on METRON-1849: Github user mmiklavc commented on a diff in the pull

[GitHub] metron pull request #1254: METRON-1849 Elasticsearch Index Write Functionali...

2018-12-04 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1254#discussion_r238883436 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -196,7 +196,7 @@ public

[GitHub] metron pull request #1254: METRON-1849 Elasticsearch Index Write Functionali...

2018-12-04 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1254#discussion_r238881060 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/writer/ElasticsearchWriter.java --- @@ -56,90 +60,111 @@

[jira] [Commented] (METRON-1849) Elasticsearch Index Write Functionality Should be Shared

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709402#comment-16709402 ] ASF GitHub Bot commented on METRON-1849: Github user mmiklavc commented on a diff in the pull

[jira] [Commented] (METRON-1849) Elasticsearch Index Write Functionality Should be Shared

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709399#comment-16709399 ] ASF GitHub Bot commented on METRON-1849: Github user mmiklavc commented on a diff in the pull

[jira] [Commented] (METRON-1849) Elasticsearch Index Write Functionality Should be Shared

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709400#comment-16709400 ] ASF GitHub Bot commented on METRON-1849: Github user mmiklavc commented on a diff in the pull

[GitHub] metron pull request #1254: METRON-1849 Elasticsearch Index Write Functionali...

2018-12-04 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1254#discussion_r238876879 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/update/Document.java --- @@ -89,46 +91,29 @@ public void

[GitHub] metron pull request #1254: METRON-1849 Elasticsearch Index Write Functionali...

2018-12-04 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1254#discussion_r238882021 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/writer/ElasticsearchWriterTest.java --- @@ -18,170 +18,241

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709290#comment-16709290 ] ASF GitHub Bot commented on METRON-1911: Github user ottobackwards commented on a diff in the

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709291#comment-16709291 ] ASF GitHub Bot commented on METRON-1911: Github user ottobackwards commented on a diff in the

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238851540 --- Diff: docker/example_script.sh --- @@ -0,0 +1,177 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709292#comment-16709292 ] ASF GitHub Bot commented on METRON-1911: Github user ottobackwards commented on a diff in the

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238850336 --- Diff: docker/example_script.sh --- @@ -0,0 +1,177 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238850284 --- Diff: docker/example_script.sh --- @@ -0,0 +1,177 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238850232 --- Diff: docker/scripts/cleanup_containers.sh --- @@ -0,0 +1,30 @@ +#!/usr/bin/env bash + +# +# Licensed to the

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709281#comment-16709281 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238848648 --- Diff: docker/example_script.sh --- @@ -0,0 +1,177 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709279#comment-16709279 ] ASF GitHub Bot commented on METRON-1911: Github user ottobackwards commented on a diff in the

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238848200 --- Diff: docker/example_script.sh --- @@ -0,0 +1,177 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709259#comment-16709259 ] ASF GitHub Bot commented on METRON-1911: Github user ottobackwards commented on the issue:

[GitHub] metron-bro-plugin-kafka issue #21: METRON-1911 [WIP] Docker setup for testin...

2018-12-04 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/21 @ottobackwards for permissions I would do something like 0755 ---

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709270#comment-16709270 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on the issue:

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709266#comment-16709266 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709264#comment-16709264 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238844401 --- Diff: docker/scripts/cleanup_containers.sh --- @@ -0,0 +1,30 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709263#comment-16709263 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709261#comment-16709261 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238844199 --- Diff: docker/example_script.sh --- @@ -0,0 +1,177 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238844073 --- Diff: docker/example_script.sh --- @@ -0,0 +1,177 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software

[GitHub] metron-bro-plugin-kafka issue #21: METRON-1911 [WIP] Docker setup for testin...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/21 @JonZeolla , I was going to ask you about that, what do you think the best practice is for these permissions? ---

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709257#comment-16709257 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on the issue:

[GitHub] metron-bro-plugin-kafka issue #21: METRON-1911 [WIP] Docker setup for testin...

2018-12-04 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/21 Is there a reason the scripts in `scripts/` have inconsistent permissions? Should `example_script.sh` have execute, or maybe even just call it `run_test.sh` off the bat? ---

[jira] [Commented] (METRON-1867) Remove `/api/v1/update/replace` endpoint

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709250#comment-16709250 ] ASF GitHub Bot commented on METRON-1867: Github user nickwallen commented on the issue:

[GitHub] metron issue #1284: METRON-1867 Remove `/api/v1/update/replace` endpoint

2018-12-04 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1284 > Is this endpoint superseded by another implementation, or just removed altogether? The endpoint has been removed completely. It is not being used by anything in Metron currently.

[jira] [Commented] (METRON-1867) Remove `/api/v1/update/replace` endpoint

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709237#comment-16709237 ] ASF GitHub Bot commented on METRON-1867: Github user mmiklavc commented on the issue:

[GitHub] metron issue #1284: METRON-1867 Remove `/api/v1/update/replace` endpoint

2018-12-04 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1284 +1 by inspection pending details on the following: - Is this endpoint superseded by another implementation, or just removed altogether? - Any users of the REST API using this directly

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709225#comment-16709225 ] ASF GitHub Bot commented on METRON-1911: Github user ottobackwards commented on a diff in the

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238827202 --- Diff: docker/run_test.sh.template --- @@ -0,0 +1,199 @@ +#!/usr/bin/env bash --- End diff -- i changed it ---

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709223#comment-16709223 ] ASF GitHub Bot commented on METRON-1911: Github user ottobackwards commented on a diff in the

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238826943 --- Diff: docker/scripts/process_data_docker.sh --- @@ -0,0 +1,29 @@ +#!/usr/bin/env bash + +# +# Licensed to the

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709219#comment-16709219 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238825786 --- Diff: docker/scripts/download_sample_pcaps.sh --- @@ -0,0 +1,101 @@ +#!/usr/bin/env bash + +# +# Licensed to the

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709218#comment-16709218 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238824961 --- Diff: docker/run_test.sh.template --- @@ -0,0 +1,199 @@ +#!/usr/bin/env bash --- End diff -- Hmm ok, as long as it's

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709212#comment-16709212 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238822684 --- Diff: docker/scripts/download_sample_pcaps.sh --- @@ -0,0 +1,101 @@ +#!/usr/bin/env bash + +# +# Licensed to the

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709211#comment-16709211 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238822338 --- Diff: docker/in_docker_scripts/wait-for-it.sh --- @@ -0,0 +1,161 @@ +#!/usr/bin/env bash +# Use this script to test if a

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709210#comment-16709210 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238821774 --- Diff: docker/scripts/process_data_docker.sh --- @@ -0,0 +1,29 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709177#comment-16709177 ] ASF GitHub Bot commented on METRON-1911: Github user ottobackwards commented on a diff in the

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238806017 --- Diff: docker/scripts/download_sample_pcaps.sh --- @@ -0,0 +1,101 @@ +#!/usr/bin/env bash + +# +# Licensed to the

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709174#comment-16709174 ] ASF GitHub Bot commented on METRON-1911: Github user ottobackwards commented on a diff in the

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709175#comment-16709175 ] ASF GitHub Bot commented on METRON-1911: Github user ottobackwards commented on a diff in the

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238805671 --- Diff: docker/scripts/download_sample_pcaps.sh --- @@ -0,0 +1,101 @@ +#!/usr/bin/env bash + +# +# Licensed to the

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238805529 --- Diff: docker/scripts/create_docker_network.sh --- @@ -0,0 +1,73 @@ +#!/usr/bin/env bash + +# +# Licensed to the

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709172#comment-16709172 ] ASF GitHub Bot commented on METRON-1911: Github user ottobackwards commented on a diff in the

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238805123 --- Diff: docker/in_docker_scripts/wait-for-it.sh --- @@ -0,0 +1,161 @@ +#!/usr/bin/env bash +# Use this script to test if a

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709170#comment-16709170 ] ASF GitHub Bot commented on METRON-1911: Github user ottobackwards commented on a diff in the

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238804842 --- Diff: docker/in_docker_scripts/build_bro_plugin.sh --- @@ -0,0 +1,39 @@ +#!/usr/bin/env bash + +# +# Licensed to

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238804501 --- Diff: docker/in_docker_scripts/build_bro_plugin.sh --- @@ -0,0 +1,39 @@ +#!/usr/bin/env bash + +# +# Licensed to

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709151#comment-16709151 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709164#comment-16709164 ] ASF GitHub Bot commented on METRON-1911: Github user ottobackwards commented on a diff in the

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709134#comment-16709134 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238803331 --- Diff: docker/run_test.sh.template --- @@ -0,0 +1,199 @@ +#!/usr/bin/env bash --- End diff -- so the idea is that

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709163#comment-16709163 ] ASF GitHub Bot commented on METRON-1911: Github user ottobackwards commented on a diff in the

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238803083 --- Diff: docker/in_docker_scripts/wait-for-it.sh --- @@ -0,0 +1,161 @@ +#!/usr/bin/env bash +# Use this script to test if a

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709160#comment-16709160 ] ASF GitHub Bot commented on METRON-1911: Github user ottobackwards commented on a diff in the

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238802060 --- Diff: docker/in_docker_scripts/wait-for-it.sh --- @@ -0,0 +1,161 @@ +#!/usr/bin/env bash +# Use this script to test if a

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709158#comment-16709158 ] ASF GitHub Bot commented on METRON-1911: Github user ottobackwards commented on a diff in the

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238801412 --- Diff: docker/in_docker_scripts/process_data_dir.sh --- @@ -0,0 +1,32 @@ +#!/usr/bin/env bash + +# +# Licensed to

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709147#comment-16709147 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709127#comment-16709127 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709126#comment-16709126 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709150#comment-16709150 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709138#comment-16709138 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709137#comment-16709137 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709135#comment-16709135 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709136#comment-16709136 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709142#comment-16709142 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709152#comment-16709152 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709149#comment-16709149 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709139#comment-16709139 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709131#comment-16709131 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238796266 --- Diff: docker/in_docker_scripts/build_bro_plugin.sh --- @@ -0,0 +1,39 @@ +#!/usr/bin/env bash + +# +# Licensed to the

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709153#comment-16709153 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238794511 --- Diff: docker/logs/bro-test-Tue_Dec__4_12:10:42_EST_2018.log --- @@ -0,0 +1,2 @@ +Apache::Kafka - Writes logs to Kafka (dynamic,

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709129#comment-16709129 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709130#comment-16709130 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238797889 --- Diff: docker/scripts/create_docker_network.sh --- @@ -0,0 +1,73 @@ +#!/usr/bin/env bash + +# +# Licensed to the

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238798965 --- Diff: docker/scripts/download_sample_pcaps.sh --- @@ -0,0 +1,101 @@ +#!/usr/bin/env bash + +# +# Licensed to the

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238794488 --- Diff: docker/logs/bro-test-Tue_Dec__4_12:12:39_EST_2018.log --- @@ -0,0 +1,3 @@ +Apache::Kafka - Writes logs to Kafka (dynamic,

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709145#comment-16709145 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709146#comment-16709146 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...

2018-12-04 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238795456 --- Diff: docker/in_docker_scripts/build_bro_plugin.sh --- @@ -0,0 +1,39 @@ +#!/usr/bin/env bash + +# +# Licensed to the

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709141#comment-16709141 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709154#comment-16709154 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

[jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro

2018-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709132#comment-16709132 ] ASF GitHub Bot commented on METRON-1911: Github user JonZeolla commented on a diff in the pull

  1   2   >