Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1085
Conflict resolved.
---
GitHub user tiborm reopened a pull request:
https://github.com/apache/metron/pull/1085
METRON-1636: Fix broken unit test setup in metron-alerts
## Contributor Comments
I made changes in the unit tests of the metron-alert UI to make test
runnable.
All the dependencies
Github user tiborm closed the pull request at:
https://github.com/apache/metron/pull/1085
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1085
Reopening to trigger new travis build.
---
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1077#discussion_r197785973
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.ts
---
@@ -99,16 +99,15 @@ export class AlertDetailsComponent
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1077#discussion_r197785684
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.ts
---
@@ -224,20 +223,22 @@ export class
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1077#discussion_r197804428
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.ts
---
@@ -223,21 +222,23 @@ export class
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1077#discussion_r197804645
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.ts
---
@@ -223,21 +222,23 @@ export class
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1077
+1
---
GitHub user tiborm opened a pull request:
https://github.com/apache/metron/pull/1085
Metron 1636
I made changes in the unit tests of the metron-alert UI to make test
runnable.
I also removed Router from table-view.component and tree-view.component
because it was just
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1077
+1 nice improvement
---
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1118#discussion_r207506822
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.ts
---
@@ -22,33 +22,35 @@ import { PcapRequest } from '../model
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1118#discussion_r207506818
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.ts
---
@@ -22,33 +22,35 @@ import { PcapRequest } from '../model
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1118
Thanks Guys!
---
Github user tiborm closed the pull request at:
https://github.com/apache/metron/pull/1118
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1122
Opened a PR for pcap-packet-line.component.spec.ts. Component covered with
unit test. Size of test data aligned to the needs of the unit tests and shared
across pcap-packet and pcap-packet-line
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1103
@mmiklavc The list of the sequential PR's in order are the following:
METRON-1671: Initial PCAP UI
https://github.com/apache/metron/pull/1103
METRON-1662: Adding download button
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1103
@cestella We added the license headers for all new files.
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1118
@cestella license headers added.
---
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r205732629
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-packet-line/pcap-packet-line.component.ts
---
@@ -0,0 +1,55 @@
+/**
+ * Licensed
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1103
@mmiklavc Thanks for the comment! I extended the JIRA ticket with user
story like test scenarios.
Also added a short description of to the PR description about how to spin
up a full dev
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1103
As part of the latest commits I removed commented code blocks, and fixed
the variable naming issues in pcap-packet-line.component.ts.
This PR and the followup ones are updated by the latest
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r205721365
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-packet/pcap-packet.component.ts
---
@@ -0,0 +1,22 @@
+import { Component, OnInit, Input
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r205722021
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.ts
---
@@ -0,0 +1,65 @@
+import { Component, OnInit, Input } from
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r205721981
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.spec.ts
---
@@ -0,0 +1,51 @@
+import { async, ComponentFixture
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1118
@mmiklavc I updated the JIRA ticket with instructions for testing.
https://issues.apache.org/jira/browse/METRON-1662
---
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r205715003
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-list/pcap-list.component.spec.ts
---
@@ -0,0 +1,53 @@
+import { async, ComponentFixture
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r205714935
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -0,0 +1,24 @@
+import { Component, OnInit, Input
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r205714876
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.spec.ts
---
@@ -0,0 +1,29 @@
+import { async
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1119
@mmiklavc test instructions added to the PR description and the jira ticket
as well
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1119
@justinleet User able to select a year or month by opening the time
selector drop-down and clicking on the year of month values on the top. We
reused metron's date-picker component. This behavior
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1103
Thanks to everyone for the feedback and comments!
---
Github user tiborm closed the pull request at:
https://github.com/apache/metron/pull/1103
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1143
@merrimanr Yes, it contains the latest state of METRON-1712 and
feature/METRON-1554-pcap-query-panel.
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1142
Thanks for the review!
---
Github user tiborm closed the pull request at:
https://github.com/apache/metron/pull/1142
---
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1156#discussion_r208919679
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.ts
---
@@ -44,7 +44,23 @@ export class PcapPanelComponent
Github user tiborm closed the pull request at:
https://github.com/apache/metron/pull/1143
---
GitHub user tiborm opened a pull request:
https://github.com/apache/metron/pull/1165
METRON-1724: Date/time validation missing in PCAP query
## Contributor Comments
This PR contains date range validation. We also added validation messages
with hints for the user how to correct
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1165
Thanks for reviewing! Please test this PR carefully becasue of the large
amount of merge conflicts we solved part of this. We tested manually too, but
it would be great to double check
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1159
Thanks guys for the reviews! It seems too many issue with the PR with it's
current state. I close it and open another one later we solved bad merges etc.
---
Github user tiborm closed the pull request at:
https://github.com/apache/metron/pull/1165
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1165
Thank you guys for the reivew! It seems there is too many issue with the
PR. I'm going to close it and open a new one after we fixed the merge issues
etc.
---
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1165#discussion_r210379924
--- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts
---
@@ -17,13 +17,13 @@
*/
export class PcapRequest
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1119
Thanks Ryan!
---
Github user tiborm closed the pull request at:
https://github.com/apache/metron/pull/1119
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1119
@merrimanr I fixed the license header typo. It's a copy/paste issue so
we'll try to find where is it comes from. Thanks!
---
GitHub user tiborm opened a pull request:
https://github.com/apache/metron/pull/1142
Metron-1712: Input validation
## Contributor Comments
This PR contains the input validation for ipSrcAdr, ipSrcPort, ipDestAdr,
ipDestPort fiels.
Please find the details in the
https
GitHub user tiborm opened a pull request:
https://github.com/apache/metron/pull/1143
METRON-1713: Adding "cancel query" button
## Contributor Comments
This PR contains the implementation of the cancel button of a running pcap
query.
ht
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1142
Thanks, Justin! I replaced the regexp for IP validation and added new tests
to cover that functionality. Nice catch!
I was unable to reproduce the port validation issue you reported. However
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1143
Thanks, Justin! I updated the PR with a small fix.
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1142
You're right. Copy paste issue. Fixed. Thanks!
---
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1142#discussion_r208695454
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.spec.ts
---
@@ -331,13 +337,60 @@ describe('PcapFiltersComponent
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212383664
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.spec.ts
---
@@ -179,19 +172,6 @@ describe('PcapFiltersComponent
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212369764
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-packet-line/pcap-packet-line.component.spec.ts
---
@@ -143,38 +132,4 @@ describe
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1172
As a result of the followup discussion about the placing of the transform
functions, I moved them back to the filter component.
---
Github user tiborm closed the pull request at:
https://github.com/apache/metron/pull/1172
---
GitHub user tiborm reopened a pull request:
https://github.com/apache/metron/pull/1172
METRON-1724: Date/time validation missing in PCAP query
## Contributor Comments
This PR contains date range validation. We added validation messages with
hints also, to help the user correct
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1172
@merrimanr Tha bug you find was very interesting. We tried two different
approaches to fix, but I think @ruffle1986 solution is more suitable and
elegant here. I merged it. Please take a look
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212196734
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License
GitHub user tiborm opened a pull request:
https://github.com/apache/metron/pull/1172
METRON-1724: Date/time validation missing in PCAP query
## Contributor Comments
This PR contains date range validation. We added validation messages with
hints also, to help the user correct
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211990573
--- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts
---
@@ -17,13 +17,13 @@
*/
export class PcapRequest
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211979831
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211989622
--- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts
---
@@ -17,13 +17,13 @@
*/
export class PcapRequest
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1172
@sardell @ruffle1986 I made the following changes based on your feedback:
- default values for the timestamps removed
- DEFAULT_START_TIME and DEFAULT_END_TIME moved to constants.ts
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1103
@mmiklavc The 10k+ line spec file is a working unit test which contains
mock data as well.
Unfortunately, some other unit tests failing in this PR. We already to a
separate ticket for fixing
GitHub user tiborm reopened a pull request:
https://github.com/apache/metron/pull/1103
METRON-1554: Initial PCAP UI
## Contributor Comments
This PR contains the initial cut of PCAP UI.
https://user-images.githubusercontent.com/2437400/42747095-28d510bc-88db-11e8-8501
GitHub user tiborm opened a pull request:
https://github.com/apache/metron/pull/1116
METRON-1676: Adding download link for PCAP page files
## Contributor Comments
PR contains the implementation of the PCAP download button.
https://user-images.githubusercontent.com
GitHub user tiborm opened a pull request:
https://github.com/apache/metron/pull/1118
Metron 1662
## Contributor Comments
PR contains the implementation of the PCAP download button.
https://user-images.githubusercontent.com/2437400/42957053-cd694afa-8b81-11e8-91d9
Github user tiborm closed the pull request at:
https://github.com/apache/metron/pull/1116
---
GitHub user tiborm opened a pull request:
https://github.com/apache/metron/pull/1119
METRON-1676: Adding date range selector to PCAP filter bar
## Contributor Comments
PR adding the missing date range selector to the PCAP filter bar.
https://user
GitHub user tiborm reopened a pull request:
https://github.com/apache/metron/pull/1103
METRON-1671: Initial PCAP UI
## Contributor Comments
This PR contains the initial cut of PCAP UI.
https://user-images.githubusercontent.com/2437400/42747095-28d510bc-88db-11e8-8501
Github user tiborm closed the pull request at:
https://github.com/apache/metron/pull/1103
---
Github user tiborm closed the pull request at:
https://github.com/apache/metron/pull/1117
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1109
Is it necessary to have /{user}/{jobType}/ in the output url?
Right now our UI calling this:
/apps/metron/pcap/output/{jobId}/{pageId}
On our side, pageId is a simple int
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1109
I see, thanks. Is there an endpoint for the PDML output?
Or it is out of the scope of this PR?
---
GitHub user tiborm opened a pull request:
https://github.com/apache/metron/pull/1117
METRON-1676: Adding date range selector to PCAP filter bar
## Contributor Comments
PR adding the missing date range selector to the PCAP filter bar.
https://user
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1103
@mmiklavc We had to update a package-lock.json file because of the original
one contained a package collision. npm ci command just failed on that.
---
GitHub user tiborm opened a pull request:
https://github.com/apache/metron/pull/1180
removing missleading and unnecessary @Input annotations
## Contributor Comments
The following fields are annotated as inputs fields in pcap-panel, but
actually, they don't.
@Input
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1096
@justinleet @sardell Just to double check I made a full dev rebuild after
fix for metron.spec added. UI builds fine and looks healthy.
---
GitHub user tiborm opened a pull request:
https://github.com/apache/metron/pull/1095
METRON-1651: Fixing faIling protractor e2e tests
## Contributor Comments
The PR contains fixes for METRON-1651 and some small improvements stabilize
protractor tests.
- alert
Github user tiborm closed the pull request at:
https://github.com/apache/metron/pull/1095
---
GitHub user tiborm reopened a pull request:
https://github.com/apache/metron/pull/1095
METRON-1651: Fixing faIling protractor e2e tests
## Contributor Comments
The PR contains fixes for METRON-1651 and some small improvements stabilize
protractor tests.
- alert
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1096
Reviewed +1
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1088
Thanks @cestella! I asked @sardell to review.
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1085
Fixed the title. Checking why travis check fails...
---
GitHub user tiborm opened a pull request:
https://github.com/apache/metron/pull/1088
Metron 1621 - Sorting alerts table by score
## Contributor Comments
Tests added for sorting by Score and ip_src_addr columns.
## Pull Request Checklist
Thank you
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1226#discussion_r224759531
--- Diff: metron-interface/metron-alerts/cypress/support/commands.js ---
@@ -0,0 +1,43 @@
+/**
--- End diff --
Some files look like
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1226#discussion_r224761311
--- Diff:
metron-interface/metron-alerts/cypress/integration/pcap/pcap.spec.js ---
@@ -0,0 +1,228 @@
+///
--- End diff --
This turns
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1226
I just made some more improvement on this:
- I was able to remove one big fixture file
- removed unused support and plugin files (also found configs to prevent
cypress to regenerate them)
---
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1226#discussion_r225446653
--- Diff: metron-interface/metron-alerts/package.json ---
@@ -5,12 +5,14 @@
"angular-cli": {},
"scripts": {
&quo
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1226
@mmiklavc Yes, that's the main file. Cypress.conf.json contains 4 line of
configs and package.json 3 lines of changes required by the integration.
Anything else is test response data.
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1208
@nickwallen The concept here is observable is a stream of events. The basic
rule is to unsubscribe when you no longer want to know about new values from a
particular stream. (RxJs/Angular handling
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1240
Thanks, Shane. +1
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1226
@mmiklavc I had to roll back that last improvement. For some reason, some
tests are failing with mocked time but just on Travis. I wasn't able to figure
out why.
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1226
You are right @mmiklavc, this is an additional step to our build process.
So it makes our build slightly slower. However, the two minutes come from the
nature of PCAP. It has a built-in 10-second
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1226
@mmiklavc @justinleet I created a ticket to track the migration of
protractor tests to cypress.
https://issues.apache.org/jira/browse/METRON-1848
All the existing tests are collected
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1240#discussion_r226576832
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.ts
---
@@ -249,8 +249,8 @@ export class AlertDetailsComponent
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1240#discussion_r226589395
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/table-view/table-view.component.ts
---
@@ -72,15 +72,15 @@ export class
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1240#discussion_r226597922
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.ts
---
@@ -421,10 +423,13 @@ export class
1 - 100 of 116 matches
Mail list logo
