mattyb149 opened a new pull request #4717:
URL: https://github.com/apache/nifi/pull/4717
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Apply the performance improvement from
Matt Burgess created NIFI-8080:
--
Summary: Apply ScriptedTransformRecord approach to Jython for
other scripted components
Key: NIFI-8080
URL: https://issues.apache.org/jira/browse/NIFI-8080
Project:
mtien-apache commented on pull request #4673:
URL: https://github.com/apache/nifi/pull/4673#issuecomment-741499574
+1 LGTM. I ran a full build and ran each test class that was changed with:
- JDK 8u231
- AdoptOpenJDK 8 Update 275
- JDK 11.0.5
I debugged
exceptionfactory commented on pull request #4712:
URL: https://github.com/apache/nifi/pull/4712#issuecomment-741487912
Thanks! It looks like the MacOS build failed on an unrelated unit test that
is also impacting other recent builds.
thenatog commented on pull request #4216:
URL: https://github.com/apache/nifi/pull/4216#issuecomment-741136069
Unless there's any objections, to get some progress on this one I might take
these changes and rebase with the latest TLS + Zookeeper changes that have
already been merged, and
mark-weghorst commented on pull request #4508:
URL: https://github.com/apache/nifi/pull/4508#issuecomment-741103015
@pvillard31 yes I'm still planning on re-working this to address the code
review comments from @alopresto
Unfortunately, I haven't had the time to revisit this due to
thenatog commented on a change in pull request #4715:
URL: https://github.com/apache/nifi/pull/4715#discussion_r538839172
##
File path:
nifi-toolkit/nifi-toolkit-encrypt-config/src/test/groovy/org/apache/nifi/properties/ConfigEncryptionToolTest.groovy
##
@@ -4053,18 +4062,158
thenatog commented on a change in pull request #4715:
URL: https://github.com/apache/nifi/pull/4715#discussion_r538839172
##
File path:
nifi-toolkit/nifi-toolkit-encrypt-config/src/test/groovy/org/apache/nifi/properties/ConfigEncryptionToolTest.groovy
##
@@ -4053,18 +4062,158
thenatog commented on a change in pull request #4715:
URL: https://github.com/apache/nifi/pull/4715#discussion_r538836447
##
File path:
nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy
##
@@ -64,8 +68,8 @@ class
[
https://issues.apache.org/jira/browse/NIFI-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi updated NIFI-8066:
--
Status: Patch Available (was: Open)
> Bump GRPC dependency versions
>
turcsanyip opened a new pull request #4716:
URL: https://github.com/apache/nifi/pull/4716
https://issues.apache.org/jira/browse/NIFI-8066
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
exceptionfactory commented on a change in pull request #4715:
URL: https://github.com/apache/nifi/pull/4715#discussion_r538821132
##
File path:
nifi-toolkit/nifi-toolkit-encrypt-config/src/test/groovy/org/apache/nifi/properties/ConfigEncryptionToolTest.groovy
##
@@ -4053,18
exceptionfactory commented on pull request #4712:
URL: https://github.com/apache/nifi/pull/4712#issuecomment-741050871
Thanks for the confirmation. I refactored the approach to perform the check
in `customValidate()` with the `FileSystem.getDefaultUri()` method, which
performs some
bbende commented on a change in pull request #4676:
URL: https://github.com/apache/nifi/pull/4676#discussion_r538811709
##
File path:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java
##
@@ -199,6 +206,26 @@
[
https://issues.apache.org/jira/browse/NIFI-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Bende updated NIFI-7884:
--
Fix Version/s: 1.13.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
>
[
https://issues.apache.org/jira/browse/NIFI-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246142#comment-17246142
]
ASF subversion and git services commented on NIFI-7884:
---
Commit
bbende merged pull request #4713:
URL: https://github.com/apache/nifi/pull/4713
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
bbende commented on pull request #4712:
URL: https://github.com/apache/nifi/pull/4712#issuecomment-740996110
Ah that is a good point that I had not considered. I think we can say that
for all the processors we provide we are ensuring none of them circumvent the
check in
exceptionfactory edited a comment on pull request #4712:
URL: https://github.com/apache/nifi/pull/4712#issuecomment-740983198
@bbende Thanks for the review and feedback. The `resetHDFSResources()`
method handles Kerberos setup options prior to calling `getFileSystemAsUser()`,
which
exceptionfactory commented on pull request #4712:
URL: https://github.com/apache/nifi/pull/4712#issuecomment-740983198
@bbende Thanks for the review and feedback. The `resetHDFSResources()`
method handles Kerberos setup options prior to calling `getFileSystemAsUser()`,
which includes
thenatog commented on pull request #4715:
URL: https://github.com/apache/nifi/pull/4715#issuecomment-740937392
Updated PR to remove junk comments and improve readability etc. as per your
recommendation.
This is an automated
bbende commented on pull request #4712:
URL: https://github.com/apache/nifi/pull/4712#issuecomment-740930522
Code looks good, also built and tested this and seems to be working as
described.
With the check inside `getFileSystemAsUser`, that first gets called during
`onScheduled` so
exceptionfactory commented on a change in pull request #4714:
URL: https://github.com/apache/nifi/pull/4714#discussion_r538744071
##
File path:
nifi-nar-bundles/nifi-splunk-bundle/nifi-splunk-processors/src/main/java/org/apache/nifi/processors/splunk/SplunkAPICall.java
##
@@
arpadboda closed pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
szaszm commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r538697896
##
File path: libminifi/include/utils/GeneralUtils.h
##
@@ -49,6 +49,14 @@ constexpr T intdiv_ceil(T numerator, T denominator) {
: numerator
NissimShiman commented on a change in pull request #4620:
URL: https://github.com/apache/nifi/pull/4620#discussion_r538713027
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutSFTP.java
##
@@
thenatog commented on pull request #4599:
URL: https://github.com/apache/nifi/pull/4599#issuecomment-740829245
Will review
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
szaszm commented on pull request #920:
URL: https://github.com/apache/nifi-minifi-cpp/pull/920#issuecomment-740814917
35999e0 (on main) broke the build
This is an automated message from the Apache Git Service.
To respond to
szaszm commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r538647760
##
File path: libminifi/src/utils/tls/ExtendedKeyUsage.cpp
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
fgerlits commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r538641311
##
File path: libminifi/src/utils/tls/ExtendedKeyUsage.cpp
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
szaszm commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r538636172
##
File path: libminifi/src/controllers/SSLContextService.cpp
##
@@ -128,16 +149,239 @@ bool SSLContextService::configure_ssl_context(SSL_CTX
*ctx)
szaszm commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r538632918
##
File path: libminifi/src/utils/tls/ExtendedKeyUsage.cpp
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
fgerlits commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r538631795
##
File path: libminifi/src/controllers/SSLContextService.cpp
##
@@ -128,16 +149,239 @@ bool SSLContextService::configure_ssl_context(SSL_CTX
fgerlits commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r538629206
##
File path: libminifi/src/utils/tls/ExtendedKeyUsage.cpp
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
fgerlits commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r538627427
##
File path: libminifi/src/utils/tls/ExtendedKeyUsage.cpp
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
hunyadi-dev commented on pull request #953:
URL: https://github.com/apache/nifi-minifi-cpp/pull/953#issuecomment-740697359
@arpadboda
This is the inheritance hierarchy:
```c++
class VerifyC2DescribeJstack : public VerifyC2Describe {
class VerifyC2Describe : public
Ferenc Gerlits created MINIFICPP-1422:
-
Summary: MiNiFi should be able to get certs from the Openssl
truststore on Linux
Key: MINIFICPP-1422
URL: https://issues.apache.org/jira/browse/MINIFICPP-1422
[
https://issues.apache.org/jira/browse/NIFI-7896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Gyori closed NIFI-7896.
-
> Add support for GET request in ListenHTTP
> -
>
>
[
https://issues.apache.org/jira/browse/NIFI-7896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Gyori resolved NIFI-7896.
---
Resolution: Implemented
> Add support for GET request in ListenHTTP
>
[
https://issues.apache.org/jira/browse/NIFI-7896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Gyori updated NIFI-7896:
--
Status: Open (was: Patch Available)
Support for GET has been handled in
pgyori commented on pull request #4581:
URL: https://github.com/apache/nifi/pull/4581#issuecomment-740668143
Support for GET has been implemented in
https://github.com/apache/nifi/pull/4603
Closing this pull request.
pgyori closed pull request #4581:
URL: https://github.com/apache/nifi/pull/4581
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hunyadi-dev commented on pull request #924:
URL: https://github.com/apache/nifi-minifi-cpp/pull/924#issuecomment-740658317
@fgerlits @szaszm updated the transitive licenses.
This is an automated message from the Apache Git
szaszm commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r538274424
##
File path: libminifi/src/utils/tls/ExtendedKeyUsage.cpp
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
exceptionfactory commented on a change in pull request #4715:
URL: https://github.com/apache/nifi/pull/4715#discussion_r538391803
##
File path:
nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy
##
@@ -64,8 +68,8 @@
markap14 commented on pull request #4714:
URL: https://github.com/apache/nifi/pull/4714#issuecomment-740642509
Will Review.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
szaszm commented on pull request #837:
URL: https://github.com/apache/nifi-minifi-cpp/pull/837#issuecomment-740638136
There are some compilation errors caused by the last change
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/MINIFICPP-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Gyimesi reassigned MINIFICPP-1419:
Assignee: Gabor Gyimesi
> Stabilize docker tests in Github Actions
>
[
https://issues.apache.org/jira/browse/MINIFICPP-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Gyimesi resolved MINIFICPP-1419.
--
Resolution: Fixed
> Stabilize docker tests in Github Actions
>
[
https://issues.apache.org/jira/browse/MINIFICPP-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi resolved MINIFICPP-1121.
-
Fix Version/s: (was: 1.0.0)
0.9.0
Resolution: Fixed
>
[
https://issues.apache.org/jira/browse/MINIFICPP-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi resolved MINIFICPP-1344.
-
Resolution: Fixed
> Investigate and fix FlowConfiguration payload URLs
>
[
https://issues.apache.org/jira/browse/MINIFICPP-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi updated MINIFICPP-1121:
Comment: was deleted
(was: (flag) Flag added
Waiting for review)
> Upgrade spdlog
>
[
https://issues.apache.org/jira/browse/MINIFICPP-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi resolved MINIFICPP-1405.
-
Fix Version/s: 0.9.0
Resolution: Fixed
> Fix improperly defined warning flags
[
https://issues.apache.org/jira/browse/MINIFICPP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi resolved MINIFICPP-1420.
-
Resolution: Fixed
> Add alternate mirrors for libsodium
>
[
https://issues.apache.org/jira/browse/MINIFICPP-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi updated MINIFICPP-1421:
Issue Type: Bug (was: Improvement)
> Investigate and fix C2JstackTest
>
arpadboda closed pull request #949:
URL: https://github.com/apache/nifi-minifi-cpp/pull/949
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r538358865
##
File path: libminifi/test/TestBase.h
##
@@ -200,7 +199,7 @@ class LogTestController {
}
my_properties_->set("logger.root",
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r538356594
##
File path: extensions/librdkafka/ConsumeKafka.h
##
@@ -0,0 +1,197 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/MINIFICPP-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Gyimesi resolved MINIFICPP-1409.
--
Resolution: Fixed
> Add default credential provider chain support to AWS
hunyadi-dev opened a new pull request #953:
URL: https://github.com/apache/nifi-minifi-cpp/pull/953
C2JstackTest is currently looks for a log line that contains the word
"SchedulingAgent". This line however is only present due to the
LogTestController logs that log lines from the
[
https://issues.apache.org/jira/browse/MINIFICPP-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi updated MINIFICPP-1421:
Description:
*Background:*
C2JstackTest is currently looks for a log line that
[
https://issues.apache.org/jira/browse/MINIFICPP-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi updated MINIFICPP-1421:
Description:
*Background:*
C2JstackTest is currently looks for a log line that
Adam Hunyadi created MINIFICPP-1421:
---
Summary: Investigate and fix C2JstackTest
Key: MINIFICPP-1421
URL: https://issues.apache.org/jira/browse/MINIFICPP-1421
Project: Apache NiFi MiNiFi C++
63 matches
Mail list logo
