[GitHub] [nifi] pvillard31 edited a comment on pull request #4768: NIFI-8155 - add banner text in page title

2021-01-20 Thread GitBox
pvillard31 edited a comment on pull request #4768: URL: https://github.com/apache/nifi/pull/4768#issuecomment-764453581 Thanks for looking into this @exceptionfactory. As far as I can tell the other places you mentioned are not "really" opening new windows and this not impacting the

[GitHub] [nifi] pvillard31 commented on pull request #4768: NIFI-8155 - add banner text in page title

2021-01-20 Thread GitBox
pvillard31 commented on pull request #4768: URL: https://github.com/apache/nifi/pull/4768#issuecomment-764453581 Thanks for looking into this @exceptionfactory. As far as I can tell the other places you mentioned are not "really" opening new windows and this not impacting the overall page

[jira] [Commented] (NIFI-7263) Add a No tracking Strategy to ListFile/ListFTP

2021-01-20 Thread Jens M Kofoed (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269099#comment-17269099 ] Jens M Kofoed commented on NIFI-7263: - I have 2 cases. Case 1: We have a 2 networks which is

[jira] [Created] (NIFI-8158) Extensibility of NiFi itself

2021-01-20 Thread Jira
Maciej Gromuł created NIFI-8158: --- Summary: Extensibility of NiFi itself Key: NIFI-8158 URL: https://issues.apache.org/jira/browse/NIFI-8158 Project: Apache NiFi Issue Type: Improvement

[jira] [Commented] (NIFI-8156) PutCassandraRecord does not wrap byte arrays with a ByteBuffer, causing write failures

2021-01-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269086#comment-17269086 ] ASF subversion and git services commented on NIFI-8156: --- Commit

[jira] [Resolved] (NIFI-8156) PutCassandraRecord does not wrap byte arrays with a ByteBuffer, causing write failures

2021-01-20 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-8156. -- Resolution: Fixed > PutCassandraRecord does not wrap byte arrays with a ByteBuffer, causing

[GitHub] [nifi] asfgit closed pull request #4771: NIFI-8156 Fixed byte handling bug in cassandra.

2021-01-20 Thread GitBox
asfgit closed pull request #4771: URL: https://github.com/apache/nifi/pull/4771 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (NIFI-8043) PutDatabaseRecord Postgres Upsert On Conflict keys not quoted

2021-01-20 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-8043: - Fix Version/s: 1.13.0 Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Commented] (NIFI-8043) PutDatabaseRecord Postgres Upsert On Conflict keys not quoted

2021-01-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269085#comment-17269085 ] ASF subversion and git services commented on NIFI-8043: --- Commit

[GitHub] [nifi] asfgit closed pull request #4772: NIFI-8043: Quote update key column names in PutDatabaseRecord

2021-01-20 Thread GitBox
asfgit closed pull request #4772: URL: https://github.com/apache/nifi/pull/4772 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] pvillard31 commented on a change in pull request #4594: NIFI-3669 Add SSL Support to CaptureChangeMySQL

2021-01-20 Thread GitBox
pvillard31 commented on a change in pull request #4594: URL: https://github.com/apache/nifi/pull/4594#discussion_r561646469 ## File path:

[jira] [Created] (NIFI-8157) Adding support for other kinds of Parameter Contexts

2021-01-20 Thread Jira
Maciej Gromuł created NIFI-8157: --- Summary: Adding support for other kinds of Parameter Contexts Key: NIFI-8157 URL: https://issues.apache.org/jira/browse/NIFI-8157 Project: Apache NiFi Issue

[jira] [Updated] (NIFI-8043) PutDatabaseRecord Postgres Upsert On Conflict keys not quoted

2021-01-20 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-8043: --- Status: Patch Available (was: In Progress) > PutDatabaseRecord Postgres Upsert On Conflict keys not

[jira] [Updated] (NIFI-8043) PutDatabaseRecord Postgres Upsert On Conflict keys not quoted

2021-01-20 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-8043: --- Affects Version/s: (was: 1.12.0) > PutDatabaseRecord Postgres Upsert On Conflict keys not quoted

[GitHub] [nifi] mtien-apache commented on a change in pull request #4767: NIFI-1355 Implemented new methods in KeyStoreUtils to programmatical…

2021-01-20 Thread GitBox
mtien-apache commented on a change in pull request #4767: URL: https://github.com/apache/nifi/pull/4767#discussion_r561433596 ## File path: nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/util/KeyStoreUtils.java ## @@ -245,7 +322,7 @@ public static

[GitHub] [nifi] mattyb149 opened a new pull request #4772: NIFI-8043: Quote update key column names in PutDatabaseRecord

2021-01-20 Thread GitBox
mattyb149 opened a new pull request #4772: URL: https://github.com/apache/nifi/pull/4772 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR The "Quote Column Names" property was not being

[jira] [Commented] (NIFI-8043) PutDatabaseRecord Postgres Upsert On Conflict keys not quoted

2021-01-20 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268952#comment-17268952 ] Matt Burgess commented on NIFI-8043: The key column names don't get quoted in PutDatabaseRecord before

[jira] [Assigned] (NIFI-8043) PutDatabaseRecord Postgres Upsert On Conflict keys not quoted

2021-01-20 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-8043: -- Assignee: Matt Burgess > PutDatabaseRecord Postgres Upsert On Conflict keys not quoted >

[GitHub] [nifi] thenatog commented on pull request #4753: NIFI-7356 - Enable TLS for embedded Zookeeper when NiFi has TLS enabled

2021-01-20 Thread GitBox
thenatog commented on pull request #4753: URL: https://github.com/apache/nifi/pull/4753#issuecomment-764042674 I've also updated the admin-guide similar to requested above. Let me know if any further changes are required.

[GitHub] [nifi] turcsanyip commented on a change in pull request #4738: NIFI-7890 - Added record support to ConsumeMQTT processor

2021-01-20 Thread GitBox
turcsanyip commented on a change in pull request #4738: URL: https://github.com/apache/nifi/pull/4738#discussion_r561332768 ## File path: nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java ## @@ -334,14

[jira] [Updated] (NIFI-8154) AvroParquetHDFSRecordReader fails to read parquet file containing nested structs

2021-01-20 Thread Glenn Jones (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Glenn Jones updated NIFI-8154: -- Status: Patch Available (was: Open) > AvroParquetHDFSRecordReader fails to read parquet file

[jira] [Updated] (NIFI-8154) AvroParquetHDFSRecordReader fails to read parquet file containing nested structs

2021-01-20 Thread Glenn Jones (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Glenn Jones updated NIFI-8154: -- Attachment: 0001-NIFI-8154-upversion-parquet-avro-to-1.11.1-and-add-u.patch >

[jira] [Resolved] (NIFI-8150) Change "Download flow" context menu selection for PGs to "Download flow definition"

2021-01-20 Thread Bryan Bende (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFI-8150. --- Fix Version/s: 1.13.0 Resolution: Fixed > Change "Download flow" context menu selection for

[GitHub] [nifi] bbende merged pull request #4766: NIFI-8150 Change Download flow to Download flow definition for proces…

2021-01-20 Thread GitBox
bbende merged pull request #4766: URL: https://github.com/apache/nifi/pull/4766 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (NIFI-8150) Change "Download flow" context menu selection for PGs to "Download flow definition"

2021-01-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268870#comment-17268870 ] ASF subversion and git services commented on NIFI-8150: --- Commit

[GitHub] [nifi] bbende commented on pull request #4766: NIFI-8150 Change Download flow to Download flow definition for proces…

2021-01-20 Thread GitBox
bbende commented on pull request #4766: URL: https://github.com/apache/nifi/pull/4766#issuecomment-763942429 +1 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (NIFI-8154) AvroParquetHDFSRecordReader fails to read parquet file containing nested structs

2021-01-20 Thread Glenn Jones (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268869#comment-17268869 ] Glenn Jones commented on NIFI-8154: --- The test fails because it expects a field in the Record produced by

[GitHub] [nifi] thenatog commented on pull request #4753: NIFI-7356 - Enable TLS for embedded Zookeeper when NiFi has TLS enabled

2021-01-20 Thread GitBox
thenatog commented on pull request #4753: URL: https://github.com/apache/nifi/pull/4753#issuecomment-763911925 Updated again. Thanks to both of you for your reviews! This is an automated message from the Apache Git Service.

[GitHub] [nifi] mtien-apache commented on a change in pull request #4767: NIFI-1355 Implemented new methods in KeyStoreUtils to programmatical…

2021-01-20 Thread GitBox
mtien-apache commented on a change in pull request #4767: URL: https://github.com/apache/nifi/pull/4767#discussion_r561247262 ## File path: nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/util/KeyStoreUtils.java ## @@ -125,6 +146,63 @@ public static

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4767: NIFI-1355 Implemented new methods in KeyStoreUtils to programmatical…

2021-01-20 Thread GitBox
exceptionfactory commented on a change in pull request #4767: URL: https://github.com/apache/nifi/pull/4767#discussion_r561195875 ## File path: nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/util/KeyStoreUtils.java ## @@ -125,6 +146,63 @@ public

[GitHub] [nifi] jfrazee commented on pull request #4753: NIFI-7356 - Enable TLS for embedded Zookeeper when NiFi has TLS enabled

2021-01-20 Thread GitBox
jfrazee commented on pull request #4753: URL: https://github.com/apache/nifi/pull/4753#issuecomment-763887511 I did a full round of testing yesterday and everything looked good. Will do another round today with the updates. On the docs side of things I think we need a stronger call

[GitHub] [nifi] jfrazee edited a comment on pull request #4753: NIFI-7356 - Enable TLS for embedded Zookeeper when NiFi has TLS enabled

2021-01-20 Thread GitBox
jfrazee edited a comment on pull request #4753: URL: https://github.com/apache/nifi/pull/4753#issuecomment-763887511 I did a full round of testing yesterday and everything looked good. Will do another round today with the updates. On the docs side of things I think we need a

[GitHub] [nifi] jfrazee commented on a change in pull request #4753: NIFI-7356 - Enable TLS for embedded Zookeeper when NiFi has TLS enabled

2021-01-20 Thread GitBox
jfrazee commented on a change in pull request #4753: URL: https://github.com/apache/nifi/pull/4753#discussion_r561228356 ## File path: nifi-docs/src/main/asciidoc/administration-guide.adoc ## @@ -2246,6 +2246,53 @@ _true_. Once Netty is enabled, you should see log messages

[GitHub] [nifi] turcsanyip commented on a change in pull request #4746: NIFI-8034: Fixed PropertyValue.isExpressionLanguagePresent always ret…

2021-01-20 Thread GitBox
turcsanyip commented on a change in pull request #4746: URL: https://github.com/apache/nifi/pull/4746#discussion_r561226467 ## File path: nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestStandardPreparedQuery.java ## @@

[GitHub] [nifi] jfrazee commented on a change in pull request #4753: NIFI-7356 - Enable TLS for embedded Zookeeper when NiFi has TLS enabled

2021-01-20 Thread GitBox
jfrazee commented on a change in pull request #4753: URL: https://github.com/apache/nifi/pull/4753#discussion_r561224503 ## File path: nifi-docs/src/main/asciidoc/administration-guide.adoc ## @@ -2246,6 +2246,53 @@ _true_. Once Netty is enabled, you should see log messages

[GitHub] [nifi] thenatog commented on a change in pull request #4753: NIFI-7356 - Enable TLS for embedded Zookeeper when NiFi has TLS enabled

2021-01-20 Thread GitBox
thenatog commented on a change in pull request #4753: URL: https://github.com/apache/nifi/pull/4753#discussion_r561219030 ## File path:

[GitHub] [nifi] jfrazee commented on a change in pull request #4753: NIFI-7356 - Enable TLS for embedded Zookeeper when NiFi has TLS enabled

2021-01-20 Thread GitBox
jfrazee commented on a change in pull request #4753: URL: https://github.com/apache/nifi/pull/4753#discussion_r561157059 ## File path:

[GitHub] [nifi] exceptionfactory commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-20 Thread GitBox
exceptionfactory commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-763865777 @adenes After evaluating the unit tests mentioned, I found that each one was performing date conversion in order to compare the expected results. The conversion changed

[jira] [Resolved] (NIFI-8146) Allow RecordPath to be used for specifying operation type and data fields when using PutDatabaseRecord

2021-01-20 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess resolved NIFI-8146. Resolution: Fixed > Allow RecordPath to be used for specifying operation type and data fields >

[jira] [Commented] (NIFI-8146) Allow RecordPath to be used for specifying operation type and data fields when using PutDatabaseRecord

2021-01-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268778#comment-17268778 ] ASF subversion and git services commented on NIFI-8146: --- Commit

[GitHub] [nifi] mattyb149 closed pull request #4770: NIFI-8146: Ensure that we close the Connection/Statement/PreparedStat…

2021-01-20 Thread GitBox
mattyb149 closed pull request #4770: URL: https://github.com/apache/nifi/pull/4770 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] mattyb149 commented on pull request #4770: NIFI-8146: Ensure that we close the Connection/Statement/PreparedStat…

2021-01-20 Thread GitBox
mattyb149 commented on pull request #4770: URL: https://github.com/apache/nifi/pull/4770#issuecomment-763856888 +1 LGTM, tested scenarios with debugger and verified connections and statements were closed. Thanks for the fix! Merging to main

[GitHub] [nifi] markap14 commented on a change in pull request #4746: NIFI-8034: Fixed PropertyValue.isExpressionLanguagePresent always ret…

2021-01-20 Thread GitBox
markap14 commented on a change in pull request #4746: URL: https://github.com/apache/nifi/pull/4746#discussion_r561166527 ## File path: nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestStandardPreparedQuery.java ## @@

[jira] [Commented] (NIFI-8154) AvroParquetHDFSRecordReader fails to read parquet file containing nested structs

2021-01-20 Thread Glenn Jones (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268733#comment-17268733 ] Glenn Jones commented on NIFI-8154: --- I see what you mean [~pvillard].  I think the failure in 

[GitHub] [nifi] mtien-apache commented on pull request #4767: NIFI-1355 Implemented new methods in KeyStoreUtils to programmatical…

2021-01-20 Thread GitBox
mtien-apache commented on pull request #4767: URL: https://github.com/apache/nifi/pull/4767#issuecomment-763823481 Fixing the build failure now. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nifi] turcsanyip commented on a change in pull request #4746: NIFI-8034: Fixed PropertyValue.isExpressionLanguagePresent always ret…

2021-01-20 Thread GitBox
turcsanyip commented on a change in pull request #4746: URL: https://github.com/apache/nifi/pull/4746#discussion_r561153888 ## File path: nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestStandardPreparedQuery.java ## @@

[GitHub] [nifi] andrewmlim commented on pull request #4766: NIFI-8150 Change Download flow to Download flow definition for proces…

2021-01-20 Thread GitBox
andrewmlim commented on pull request #4766: URL: https://github.com/apache/nifi/pull/4766#issuecomment-763813787 Thanks for taking a look @exceptionfactory! Appreciate it! This is an automated message from the Apache Git

[GitHub] [nifi] exceptionfactory commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-20 Thread GitBox
exceptionfactory commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-763806901 > @exceptionfactory , thanks for the follow-up commits. I ran the tests with CET system TZ and unfortunately some test cases fail: > > ``` > [ERROR] Failures:

[GitHub] [nifi] markap14 commented on a change in pull request #4730: NIFI-8095: Created StatelessNiFi Sink Connector and Source Connector.…

2021-01-20 Thread GitBox
markap14 commented on a change in pull request #4730: URL: https://github.com/apache/nifi/pull/4730#discussion_r561138544 ## File path: nifi-external/nifi-kafka-connect/nifi-kafka-connector/src/main/java/org/apache/nifi/kafka/connect/StatelessNiFiSourceTask.java ## @@ -0,0

[GitHub] [nifi] markap14 commented on a change in pull request #4730: NIFI-8095: Created StatelessNiFi Sink Connector and Source Connector.…

2021-01-20 Thread GitBox
markap14 commented on a change in pull request #4730: URL: https://github.com/apache/nifi/pull/4730#discussion_r561138442 ## File path: nifi-external/nifi-kafka-connect/nifi-kafka-connector/src/main/java/org/apache/nifi/kafka/connect/StatelessNiFiSourceTask.java ## @@ -0,0

[GitHub] [nifi] adenes commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-20 Thread GitBox
adenes commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-763799131 @exceptionfactory , thanks for the follow-up commits. I ran the tests with CET system TZ and unfortunately some test cases fail: ``` [ERROR] Failures: [ERROR]

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4753: NIFI-7356 - Enable TLS for embedded Zookeeper when NiFi has TLS enabled

2021-01-20 Thread GitBox
exceptionfactory commented on a change in pull request #4753: URL: https://github.com/apache/nifi/pull/4753#discussion_r561113641 ## File path:

[GitHub] [nifi] urbandan commented on a change in pull request #4730: NIFI-8095: Created StatelessNiFi Sink Connector and Source Connector.…

2021-01-20 Thread GitBox
urbandan commented on a change in pull request #4730: URL: https://github.com/apache/nifi/pull/4730#discussion_r561128503 ## File path: nifi-external/nifi-kafka-connect/nifi-kafka-connector/src/main/java/org/apache/nifi/kafka/connect/StatelessNiFiSourceTask.java ## @@ -0,0

[GitHub] [nifi] markap14 commented on a change in pull request #4730: NIFI-8095: Created StatelessNiFi Sink Connector and Source Connector.…

2021-01-20 Thread GitBox
markap14 commented on a change in pull request #4730: URL: https://github.com/apache/nifi/pull/4730#discussion_r561112193 ## File path: nifi-external/nifi-kafka-connect/nifi-kafka-connector/src/main/java/org/apache/nifi/kafka/connect/StatelessNiFiSourceTask.java ## @@ -0,0

[GitHub] [nifi] markap14 commented on a change in pull request #4730: NIFI-8095: Created StatelessNiFi Sink Connector and Source Connector.…

2021-01-20 Thread GitBox
markap14 commented on a change in pull request #4730: URL: https://github.com/apache/nifi/pull/4730#discussion_r561109996 ## File path: nifi-external/nifi-kafka-connect/nifi-kafka-connector/src/main/java/org/apache/nifi/kafka/connect/StatelessNiFiSinkTask.java ## @@ -0,0

[GitHub] [nifi] urbandan commented on a change in pull request #4730: NIFI-8095: Created StatelessNiFi Sink Connector and Source Connector.…

2021-01-20 Thread GitBox
urbandan commented on a change in pull request #4730: URL: https://github.com/apache/nifi/pull/4730#discussion_r561093484 ## File path: nifi-external/nifi-kafka-connect/nifi-kafka-connector/src/main/java/org/apache/nifi/kafka/connect/StatelessNiFiSinkTask.java ## @@ -0,0

[GitHub] [nifi] exceptionfactory commented on pull request #4768: NIFI-8155 - add banner text in page title

2021-01-20 Thread GitBox
exceptionfactory commented on pull request #4768: URL: https://github.com/apache/nifi/pull/4768#issuecomment-763755846 This change looks straightforward as it stands, but there are several other places where the `document.title` is set when opening new windows, such as Provenance contents

[GitHub] [nifi] thenatog commented on pull request #4753: NIFI-7356 - Enable TLS for embedded Zookeeper when NiFi has TLS enabled

2021-01-20 Thread GitBox
thenatog commented on pull request #4753: URL: https://github.com/apache/nifi/pull/4753#issuecomment-763753967 Addressing your first two points: > - TLS is required for the embedded ZK when cluster TLS is enabled but NiFi won't try to connect securely unless

[GitHub] [nifi] markap14 commented on a change in pull request #4746: NIFI-8034: Fixed PropertyValue.isExpressionLanguagePresent always ret…

2021-01-20 Thread GitBox
markap14 commented on a change in pull request #4746: URL: https://github.com/apache/nifi/pull/4746#discussion_r561092480 ## File path: nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestStandardPreparedQuery.java ## @@

[GitHub] [nifi] joewitt commented on pull request #4771: NIFI-8156 Fixed byte handling bug in cassandra.

2021-01-20 Thread GitBox
joewitt commented on pull request #4771: URL: https://github.com/apache/nifi/pull/4771#issuecomment-763714975 Ha! Me too. I trust it was broken and you've verified your fix ;) But yeah thanks for sharing and thanks for tackling. Will monitor the build. Tagged to 1.13 so I wont

[GitHub] [nifi] MikeThomsen commented on pull request #4771: NIFI-8156 Fixed byte handling bug in cassandra.

2021-01-20 Thread GitBox
MikeThomsen commented on pull request #4771: URL: https://github.com/apache/nifi/pull/4771#issuecomment-763711741 @joewitt cool, but I'm a believer in "trust, but verify" so here is a screenshot of my terminal showing queries against the table matching the steps I showed:

[GitHub] [nifi] joewitt commented on pull request #4771: NIFI-8156 Fixed byte handling bug in cassandra.

2021-01-20 Thread GitBox
joewitt commented on pull request #4771: URL: https://github.com/apache/nifi/pull/4771#issuecomment-763708883 I will simply review code and trust you validated it. We're good if the build is good on this in my view. This

[GitHub] [nifi] MikeThomsen edited a comment on pull request #4771: NIFI-8156 Fixed byte handling bug in cassandra.

2021-01-20 Thread GitBox
MikeThomsen edited a comment on pull request #4771: URL: https://github.com/apache/nifi/pull/4771#issuecomment-763707997 @joewitt here are test instructions: ``` docker run -p 7000:7000 -p 9042:9042 --name cassandra -d cassandra:3 ``` ``` CREATE KEYSPACE byte_test

[GitHub] [nifi] MikeThomsen commented on pull request #4771: NIFI-8156 Fixed byte handling bug in cassandra.

2021-01-20 Thread GitBox
MikeThomsen commented on pull request #4771: URL: https://github.com/apache/nifi/pull/4771#issuecomment-763707997 @joewitt here are test instructions: ``` docker run -p 7000:7000 -p 9042:9042 --name cassandra -d cassandra:3 ``` ``` CREATE KEYSPACE byte_test WITH

[GitHub] [nifi] markap14 commented on a change in pull request #4760: NIFI-8142 Add "on conflict do nothing" feature to PutDatabaseRecord

2021-01-20 Thread GitBox
markap14 commented on a change in pull request #4760: URL: https://github.com/apache/nifi/pull/4760#discussion_r561045998 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java ##

[jira] [Commented] (NIFI-8156) PutCassandraRecord does not wrap byte arrays with a ByteBuffer, causing write failures

2021-01-20 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268641#comment-17268641 ] Joe Witt commented on NIFI-8156: pr is up. i'll give it a look and assuming build is good get it merged

[jira] [Updated] (NIFI-8156) PutCassandraRecord does not wrap byte arrays with a ByteBuffer, causing write failures

2021-01-20 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-8156: --- Fix Version/s: 1.13.0 > PutCassandraRecord does not wrap byte arrays with a ByteBuffer, causing write >

[GitHub] [nifi] joewitt commented on pull request #4771: NIFI-8156 Fixed byte handling bug in cassandra.

2021-01-20 Thread GitBox
joewitt commented on pull request #4771: URL: https://github.com/apache/nifi/pull/4771#issuecomment-763703079 assuming build is happy i'll merge This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nifi] MikeThomsen opened a new pull request #4771: NIFI-8156 Fixed byte handling bug in cassandra.

2021-01-20 Thread GitBox
MikeThomsen opened a new pull request #4771: URL: https://github.com/apache/nifi/pull/4771 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR _Enables X functionality; fixes bug NIFI-._

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #955: MINIFICPP-1414 Create in-memory compressed logs

2021-01-20 Thread GitBox
adamdebreceni commented on a change in pull request #955: URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r561038296 ## File path: libminifi/test/unit/LoggerTests.cpp ## @@ -107,3 +110,71 @@ TEST_CASE("Test ShortenNames", "[ttl6]") {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #955: MINIFICPP-1414 Create in-memory compressed logs

2021-01-20 Thread GitBox
adamdebreceni commented on a change in pull request #955: URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r561037947 ## File path: libminifi/include/core/logging/internal/LogBuffer.h ## @@ -0,0 +1,62 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #955: MINIFICPP-1414 Create in-memory compressed logs

2021-01-20 Thread GitBox
adamdebreceni commented on a change in pull request #955: URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r561037821 ## File path: libminifi/src/core/logging/LoggerConfiguration.cpp ## @@ -85,6 +108,7 @@ LoggerConfiguration::LoggerConfiguration() void

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #955: MINIFICPP-1414 Create in-memory compressed logs

2021-01-20 Thread GitBox
adamdebreceni commented on a change in pull request #955: URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r561037369 ## File path: libminifi/include/io/BufferStream.h ## @@ -42,6 +42,14 @@ class BufferStream : public BaseStream {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #955: MINIFICPP-1414 Create in-memory compressed logs

2021-01-20 Thread GitBox
adamdebreceni commented on a change in pull request #955: URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r561011823 ## File path: libminifi/include/core/logging/internal/LogBuffer.h ## @@ -0,0 +1,62 @@ +/** + * + * Licensed to the Apache Software Foundation

[jira] [Created] (NIFI-8156) PutCassandraRecord does not wrap byte arrays with a ByteBuffer, causing write failures

2021-01-20 Thread Mike Thomsen (Jira)
Mike Thomsen created NIFI-8156: -- Summary: PutCassandraRecord does not wrap byte arrays with a ByteBuffer, causing write failures Key: NIFI-8156 URL: https://issues.apache.org/jira/browse/NIFI-8156

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #955: MINIFICPP-1414 Create in-memory compressed logs

2021-01-20 Thread GitBox
adamdebreceni commented on a change in pull request #955: URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r561008200 ## File path: libminifi/include/core/logging/internal/LogBuffer.h ## @@ -0,0 +1,62 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #955: MINIFICPP-1414 Create in-memory compressed logs

2021-01-20 Thread GitBox
szaszm commented on a change in pull request #955: URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r561009640 ## File path: libminifi/include/core/logging/internal/LogBuffer.h ## @@ -0,0 +1,62 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #955: MINIFICPP-1414 Create in-memory compressed logs

2021-01-20 Thread GitBox
adamdebreceni commented on a change in pull request #955: URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r561008200 ## File path: libminifi/include/core/logging/internal/LogBuffer.h ## @@ -0,0 +1,62 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #955: MINIFICPP-1414 Create in-memory compressed logs

2021-01-20 Thread GitBox
adamdebreceni commented on a change in pull request #955: URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r561008200 ## File path: libminifi/include/core/logging/internal/LogBuffer.h ## @@ -0,0 +1,62 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #955: MINIFICPP-1414 Create in-memory compressed logs

2021-01-20 Thread GitBox
szaszm commented on a change in pull request #955: URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r560995043 ## File path: libminifi/src/core/logging/LoggerConfiguration.cpp ## @@ -85,6 +108,7 @@ LoggerConfiguration::LoggerConfiguration() void

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #955: MINIFICPP-1414 Create in-memory compressed logs

2021-01-20 Thread GitBox
adamdebreceni commented on a change in pull request #955: URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r560993751 ## File path: libminifi/src/core/logging/LoggerConfiguration.cpp ## @@ -85,6 +108,7 @@ LoggerConfiguration::LoggerConfiguration() void

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #975: MINIFICPP-1400 Create ListS3 processor

2021-01-20 Thread GitBox
adamdebreceni commented on a change in pull request #975: URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r560987684 ## File path: extensions/aws/s3/S3Wrapper.cpp ## @@ -30,46 +37,253 @@ namespace minifi { namespace aws { namespace s3 {

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-20 Thread GitBox
szaszm commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r560987064 ## File path: extensions/librdkafka/rdkafka_utils.h ## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #955: MINIFICPP-1414 Create in-memory compressed logs

2021-01-20 Thread GitBox
szaszm commented on a change in pull request #955: URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r558340027 ## File path: libminifi/src/core/logging/LoggerConfiguration.cpp ## @@ -85,6 +108,7 @@ LoggerConfiguration::LoggerConfiguration() void

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #975: MINIFICPP-1400 Create ListS3 processor

2021-01-20 Thread GitBox
adamdebreceni commented on a change in pull request #975: URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r560982313 ## File path: extensions/aws/s3/S3Wrapper.cpp ## @@ -30,46 +37,253 @@ namespace minifi { namespace aws { namespace s3 {

[GitHub] [nifi] markap14 opened a new pull request #4770: NIFI-8146: Ensure that we close the Connection/Statement/PreparedStat…

2021-01-20 Thread GitBox
markap14 opened a new pull request #4770: URL: https://github.com/apache/nifi/pull/4770 …ement objects in finally blocks or try-with-resources Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of

[jira] [Reopened] (NIFI-8146) Allow RecordPath to be used for specifying operation type and data fields when using PutDatabaseRecord

2021-01-20 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne reopened NIFI-8146: -- Re-opening issue because I realized that we don't always close the JDBC Statements / Connection objects.

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #975: MINIFICPP-1400 Create ListS3 processor

2021-01-20 Thread GitBox
adamdebreceni commented on a change in pull request #975: URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r560970459 ## File path: extensions/aws/s3/S3Wrapper.cpp ## @@ -30,46 +37,253 @@ namespace minifi { namespace aws { namespace s3 {

[GitHub] [nifi] exceptionfactory commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-20 Thread GitBox
exceptionfactory commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-763605759 @markap14 Thanks for the review and additional feedback, I pushed an update to address your comments. There still appear to be some edge cases for some record-oriented

[jira] [Commented] (NIFI-8154) AvroParquetHDFSRecordReader fails to read parquet file containing nested structs

2021-01-20 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268566#comment-17268566 ] Pierre Villard commented on NIFI-8154: -- Hi [~jonesgh], Looks like just upgrading the dependency is

[jira] [Assigned] (NIFI-8154) AvroParquetHDFSRecordReader fails to read parquet file containing nested structs

2021-01-20 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard reassigned NIFI-8154: Assignee: (was: Pierre Villard) > AvroParquetHDFSRecordReader fails to read parquet

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-20 Thread GitBox
exceptionfactory commented on a change in pull request #4734: URL: https://github.com/apache/nifi/pull/4734#discussion_r560952390 ## File path: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java ## @@ -1085,6 +1180,31 @@

[jira] [Updated] (NIFI-8154) AvroParquetHDFSRecordReader fails to read parquet file containing nested structs

2021-01-20 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-8154: - Status: Open (was: Patch Available) > AvroParquetHDFSRecordReader fails to read parquet file

[GitHub] [nifi] pvillard31 commented on pull request #4769: NIFI-8154 - upgrade parquet-avro from 1.10.0 to 1.11.1

2021-01-20 Thread GitBox
pvillard31 commented on pull request #4769: URL: https://github.com/apache/nifi/pull/4769#issuecomment-763599719 Tests are failing, will need to revisit when time permits. This is an automated message from the Apache Git

[GitHub] [nifi] pvillard31 closed pull request #4769: NIFI-8154 - upgrade parquet-avro from 1.10.0 to 1.11.1

2021-01-20 Thread GitBox
pvillard31 closed pull request #4769: URL: https://github.com/apache/nifi/pull/4769 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-20 Thread GitBox
exceptionfactory commented on a change in pull request #4734: URL: https://github.com/apache/nifi/pull/4734#discussion_r560951664 ## File path: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java ## @@ -1040,6 +1049,93 @@

[jira] [Commented] (NIFI-7263) Add a No tracking Strategy to ListFile/ListFTP

2021-01-20 Thread humpfhumpf (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268565#comment-17268565 ] humpfhumpf commented on NIFI-7263: -- In our production case, files are available on SFTP server without

[GitHub] [nifi] ChrisSamo632 commented on a change in pull request #4755: NIFI-8133 Add ability to suppress null/empty values in ElasticSearchCl…

2021-01-20 Thread GitBox
ChrisSamo632 commented on a change in pull request #4755: URL: https://github.com/apache/nifi/pull/4755#discussion_r560939470 ## File path:

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #975: MINIFICPP-1400 Create ListS3 processor

2021-01-20 Thread GitBox
adamdebreceni commented on a change in pull request #975: URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r560938789 ## File path: extensions/aws/processors/ListS3.cpp ## @@ -0,0 +1,294 @@ +/** + * @file ListS3.cpp + * ListS3 class implementation + * + *

[jira] [Updated] (NIFI-8154) AvroParquetHDFSRecordReader fails to read parquet file containing nested structs

2021-01-20 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-8154: - Status: Patch Available (was: Open) > AvroParquetHDFSRecordReader fails to read parquet file

  1   2   >