[GitHub] [nifi] mattyb149 commented on a change in pull request #5116: NIFI-8625: Refactor scripted components to use ScriptRunner to fix concurrency issues

2021-06-04 Thread GitBox
mattyb149 commented on a change in pull request #5116: URL: https://github.com/apache/nifi/pull/5116#discussion_r645878908 ## File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/rules/handlers/script/ScriptedActionHandler.java

[jira] [Commented] (NIFI-8658) Allow for filtering functions to be used as top-level functions for RecordPath

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357649#comment-17357649 ] ASF subversion and git services commented on NIFI-8658: --- Commit

[GitHub] [nifi] mattyb149 commented on a change in pull request #5116: NIFI-8625: Refactor scripted components to use ScriptRunner to fix concurrency issues

2021-06-04 Thread GitBox
mattyb149 commented on a change in pull request #5116: URL: https://github.com/apache/nifi/pull/5116#discussion_r645878547 ## File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/rules/handlers/script/ScriptedActionHandler.java

[GitHub] [nifi] mattyb149 commented on a change in pull request #5116: NIFI-8625: Refactor scripted components to use ScriptRunner to fix concurrency issues

2021-06-04 Thread GitBox
mattyb149 commented on a change in pull request #5116: URL: https://github.com/apache/nifi/pull/5116#discussion_r645878298 ## File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/record/sink/script/ScriptedRecordSink.java

[GitHub] [nifi] mattyb149 commented on a change in pull request #5116: NIFI-8625: Refactor scripted components to use ScriptRunner to fix concurrency issues

2021-06-04 Thread GitBox
mattyb149 commented on a change in pull request #5116: URL: https://github.com/apache/nifi/pull/5116#discussion_r645877344 ## File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ExecuteScript.java ## @@

[jira] [Commented] (NIFI-8658) Allow for filtering functions to be used as top-level functions for RecordPath

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357650#comment-17357650 ] ASF subversion and git services commented on NIFI-8658: --- Commit

[jira] [Updated] (NIFI-8658) Allow for filtering functions to be used as top-level functions for RecordPath

2021-06-04 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-8658: --- Fix Version/s: 1.14.0 Resolution: Fixed Status: Resolved (was: Patch Available) >

[GitHub] [nifi] mattyb149 closed pull request #5125: NIFI-8658: Allow Filter Functions and expressions to be specified as …

2021-06-04 Thread GitBox
mattyb149 closed pull request #5125: URL: https://github.com/apache/nifi/pull/5125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] mattyb149 commented on pull request #5125: NIFI-8658: Allow Filter Functions and expressions to be specified as …

2021-06-04 Thread GitBox
mattyb149 commented on pull request #5125: URL: https://github.com/apache/nifi/pull/5125#issuecomment-855020170 +1 LGTM, tested with PartitionRecord and UpdateRecord and verified the expected behavior. Thanks for the improvement! Merging to main -- This is an automated message from the

[jira] [Updated] (NIFI-8654) Intermittent Test Failures in SNMP Request Tests

2021-06-04 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-8654: - Fix Version/s: 1.14.0 > Intermittent Test Failures in SNMP Request Tests >

[jira] [Commented] (NIFI-8654) Intermittent Test Failures in SNMP Request Tests

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357629#comment-17357629 ] ASF subversion and git services commented on NIFI-8654: --- Commit

[GitHub] [nifi] asfgit closed pull request #5120: NIFI-8654 Changed SNMP TestAgent to use getAvailableUdpPort()

2021-06-04 Thread GitBox
asfgit closed pull request #5120: URL: https://github.com/apache/nifi/pull/5120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (NIFI-8661) Update Record Reader/Writer lookup services to not require specific attributes exist

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357602#comment-17357602 ] ASF subversion and git services commented on NIFI-8661: --- Commit

[jira] [Updated] (NIFI-8661) Update Record Reader/Writer lookup services to not require specific attributes exist

2021-06-04 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-8661: --- Fix Version/s: 1.14.0 Resolution: Fixed Status: Resolved (was: Patch Available) >

[GitHub] [nifi] mattyb149 closed pull request #5129: NIFI-8661: Updated ReaderLookup and RecordSetWriterLookup to use a pr…

2021-06-04 Thread GitBox
mattyb149 closed pull request #5129: URL: https://github.com/apache/nifi/pull/5129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] mattyb149 commented on pull request #5129: NIFI-8661: Updated ReaderLookup and RecordSetWriterLookup to use a pr…

2021-06-04 Thread GitBox
mattyb149 commented on pull request #5129: URL: https://github.com/apache/nifi/pull/5129#issuecomment-854978824 +1 LGTM, tried with the default (backwards-compatible) value using Parameters and also with a hard-coded value, both worked as expected. Thanks for the improvement! Merging to

[jira] [Updated] (NIFI-8661) Update Record Reader/Writer lookup services to not require specific attributes exist

2021-06-04 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-8661: --- Status: Patch Available (was: Open) > Update Record Reader/Writer lookup services to not require

[GitHub] [nifi] Lehel44 commented on pull request #5120: NIFI-8654 Changed SNMP TestAgent to use getAvailableUdpPort()

2021-06-04 Thread GitBox
Lehel44 commented on pull request #5120: URL: https://github.com/apache/nifi/pull/5120#issuecomment-854959472 > @exceptionfactory Yes, I'll check it tomorrow. Thank you for the improvement! -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Assigned] (NIFI-7111) JoltTransformRecord should have an Advanced UI like JoltTransformJSON

2021-06-04 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-7111: -- Assignee: Matt Burgess > JoltTransformRecord should have an Advanced UI like JoltTransformJSON

[GitHub] [nifi] mattyb149 commented on pull request #5125: NIFI-8658: Allow Filter Functions and expressions to be specified as …

2021-06-04 Thread GitBox
mattyb149 commented on pull request #5125: URL: https://github.com/apache/nifi/pull/5125#issuecomment-854940998 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi] markap14 opened a new pull request #5129: NIFI-8661: Updated ReaderLookup and RecordSetWriterLookup to use a pr…

2021-06-04 Thread GitBox
markap14 opened a new pull request #5129: URL: https://github.com/apache/nifi/pull/5129 …operty that indicates which reader/writer to use instead of requiring a specific attribute be provided Thank you for submitting a contribution to Apache NiFi. Please provide a short

[jira] [Commented] (NIFI-8662) Failed to parse AWS region from VPCE endpoint URL in AbstractAWSProcessor

2021-06-04 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357561#comment-17357561 ] Peter Turcsanyi commented on NIFI-8662: --- [~sivaprasanna], [~amcdonald] You worked on NIFI-5893. Can

[jira] [Updated] (NIFI-8662) Failed to parse AWS region from VPCE endpoint URL in AbstractAWSProcessor

2021-06-04 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-8662: -- Description: The AWS client library cannot parse the region from custom endpoint URLs

[jira] [Created] (NIFI-8662) Failed to parse AWS region from VPCE endpoint URL in AbstractAWSProcessor

2021-06-04 Thread Peter Turcsanyi (Jira)
Peter Turcsanyi created NIFI-8662: - Summary: Failed to parse AWS region from VPCE endpoint URL in AbstractAWSProcessor Key: NIFI-8662 URL: https://issues.apache.org/jira/browse/NIFI-8662 Project:

[jira] [Created] (NIFI-8661) Update Record Reader/Writer lookup services to not require specific attributes exist

2021-06-04 Thread Mark Payne (Jira)
Mark Payne created NIFI-8661: Summary: Update Record Reader/Writer lookup services to not require specific attributes exist Key: NIFI-8661 URL: https://issues.apache.org/jira/browse/NIFI-8661 Project:

[jira] [Updated] (NIFI-8499) implement encrypted version of FlowFileSwapManager

2021-06-04 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-8499: --- Issue Type: New Feature (was: Task) > implement encrypted version of FlowFileSwapManager >

[GitHub] [nifi] markap14 commented on a change in pull request #5126: NIFI-8659: Support multiple output records in JoltTransformRecord

2021-06-04 Thread GitBox
markap14 commented on a change in pull request #5126: URL: https://github.com/apache/nifi/pull/5126#discussion_r645743107 ## File path: nifi-nar-bundles/nifi-jolt-record-bundle/nifi-jolt-record-processors/src/main/java/org/apache/nifi/processors/jolt/record/JoltTransformRecord.java

[GitHub] [nifi] markap14 commented on a change in pull request #5126: NIFI-8659: Support multiple output records in JoltTransformRecord

2021-06-04 Thread GitBox
markap14 commented on a change in pull request #5126: URL: https://github.com/apache/nifi/pull/5126#discussion_r645742746 ## File path: nifi-nar-bundles/nifi-jolt-record-bundle/nifi-jolt-record-processors/src/main/java/org/apache/nifi/processors/jolt/record/JoltTransformRecord.java

[jira] [Commented] (NIFI-8499) implement encrypted version of FlowFileSwapManager

2021-06-04 Thread Paul Grey (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357515#comment-17357515 ] Paul Grey commented on NIFI-8499: - PR up. > implement encrypted version of FlowFileSwapManager >

[jira] [Updated] (NIFI-7111) JoltTransformRecord should have an Advanced UI like JoltTransformJSON

2021-06-04 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-7111: --- Affects Version/s: (was: 1.11.1) > JoltTransformRecord should have an Advanced UI like

[GitHub] [nifi] emiliosetiadarma opened a new pull request #5128: NIFI-6667 added variable to accept nifi.sensitive.props.key in docker…

2021-06-04 Thread GitBox
emiliosetiadarma opened a new pull request #5128: URL: https://github.com/apache/nifi/pull/5128 …hub and dockermaven start.sh Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR

[GitHub] [nifi] mtien-apache commented on pull request #5107: NIFIREG-395 - Implemented the ability to import and export versioned …

2021-06-04 Thread GitBox
mtien-apache commented on pull request #5107: URL: https://github.com/apache/nifi/pull/5107#issuecomment-854886715 Here is the JIRA ([NIFI-8660](https://issues.apache.org/jira/browse/NIFI-8660)) to allow adding Comments when importing a new flow. -- This is an automated message from

[GitHub] [nifi] sjyang18 opened a new pull request #5127: NIFI-8652: patch to handle high volume of record-oriented insertion to azure cosmos db

2021-06-04 Thread GitBox
sjyang18 opened a new pull request #5127: URL: https://github.com/apache/nifi/pull/5127 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR patch to handle high volume of

[GitHub] [nifi] jfrazee commented on a change in pull request #5098: NIFI-8248 Modify PutAzureDataLakeStorage processor to use temp file

2021-06-04 Thread GitBox
jfrazee commented on a change in pull request #5098: URL: https://github.com/apache/nifi/pull/5098#discussion_r645674083 ## File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureDataLakeStorage.java

[GitHub] [nifi] mattyb149 opened a new pull request #5126: NIFI-8659: Support multiple output records in JoltTransformRecord

2021-06-04 Thread GitBox
mattyb149 opened a new pull request #5126: URL: https://github.com/apache/nifi/pull/5126 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Adds support for a single input record being

[jira] [Created] (NIFI-8660) NiFi Registry - Add a Comments field when importing a new flow

2021-06-04 Thread M Tien (Jira)
M Tien created NIFI-8660: Summary: NiFi Registry - Add a Comments field when importing a new flow Key: NIFI-8660 URL: https://issues.apache.org/jira/browse/NIFI-8660 Project: Apache NiFi Issue

[jira] [Assigned] (NIFI-8659) JoltTransformRecord should support transformation of one record to multiple output records

2021-06-04 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-8659: -- Assignee: Matt Burgess > JoltTransformRecord should support transformation of one record to

[jira] [Commented] (NIFI-8634) Create Controller Services that allows user to choose between Record Readers/Writers based on Expression Language

2021-06-04 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357492#comment-17357492 ] Mark Payne commented on NIFI-8634: -- Wow, I completely missed that. Thanks [~jsizzle]! I thought we had

[jira] [Resolved] (NIFI-8634) Create Controller Services that allows user to choose between Record Readers/Writers based on Expression Language

2021-06-04 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne resolved NIFI-8634. -- Resolution: Duplicate > Create Controller Services that allows user to choose between Record >

[jira] [Created] (NIFI-8659) JoltTransformRecord should support transformation of one record to multiple output records

2021-06-04 Thread Matt Burgess (Jira)
Matt Burgess created NIFI-8659: -- Summary: JoltTransformRecord should support transformation of one record to multiple output records Key: NIFI-8659 URL: https://issues.apache.org/jira/browse/NIFI-8659

[jira] [Updated] (NIFI-8658) Allow for filtering functions to be used as top-level functions for RecordPath

2021-06-04 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-8658: - Status: Patch Available (was: Open) > Allow for filtering functions to be used as top-level functions

[GitHub] [nifi] markap14 opened a new pull request #5125: NIFI-8658: Allow Filter Functions and expressions to be specified as …

2021-06-04 Thread GitBox
markap14 opened a new pull request #5125: URL: https://github.com/apache/nifi/pull/5125 …a RecordPaths Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR _Enables X functionality;

[GitHub] [nifi-minifi-cpp] martinzink commented on pull request #1100: MINIFICPP-1583 windows build fix

2021-06-04 Thread GitBox
martinzink commented on pull request #1100: URL: https://github.com/apache/nifi-minifi-cpp/pull/1100#issuecomment-854843410 The problem was caused by https://github.com/apache/nifi-minifi-cpp/commit/05ae25c1aae280767206b641f8c35d485aa85245 refactoring the test and

[GitHub] [nifi-minifi-cpp] martinzink commented on pull request #1098: MINIFICPP-1581: set cmake policy CMP0096 to NEW to preserve the leadi…

2021-06-04 Thread GitBox
martinzink commented on pull request #1098: URL: https://github.com/apache/nifi-minifi-cpp/pull/1098#issuecomment-854842379 Unrelated ci failures https://issues.apache.org/jira/browse/MINIFICPP-1583 https://issues.apache.org/jira/browse/MINIFICPP-1582 -- This is an automated

[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request #1100: MINIFICPP-1583 windows build fix

2021-06-04 Thread GitBox
martinzink opened a new pull request #1100: URL: https://github.com/apache/nifi-minifi-cpp/pull/1100 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [nifi] pgyori commented on a change in pull request #5116: NIFI-8625: Refactor scripted components to use ScriptRunner to fix concurrency issues

2021-06-04 Thread GitBox
pgyori commented on a change in pull request #5116: URL: https://github.com/apache/nifi/pull/5116#discussion_r645662468 ## File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ExecuteScript.java ## @@

[GitHub] [nifi] ottobackwards merged pull request #5124: NIFI-8137 Rename RecordPath un/escape JSON functions

2021-06-04 Thread GitBox
ottobackwards merged pull request #5124: URL: https://github.com/apache/nifi/pull/5124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Created] (MINIFICPP-1583) Build failure in windows ci jobs

2021-06-04 Thread Martin Zink (Jira)
Martin Zink created MINIFICPP-1583: -- Summary: Build failure in windows ci jobs Key: MINIFICPP-1583 URL: https://issues.apache.org/jira/browse/MINIFICPP-1583 Project: Apache NiFi MiNiFi C++

[jira] [Commented] (NIFI-8620) NullPointerException on commit with multiple ProcessSession

2021-06-04 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357457#comment-17357457 ] Mark Payne commented on NIFI-8620: -- (y) > NullPointerException on commit with multiple ProcessSession >

[jira] [Updated] (NIFI-8647) Update VersionedPropertyDescriptor to include Resource References

2021-06-04 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-8647: - Fix Version/s: 1.14.0 Status: Patch Available (was: Open) > Update

[jira] [Updated] (NIFI-8644) Update Stateless so that a ParameterProviderDefinition is provided to dataflow instead of ParameterProvider

2021-06-04 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-8644: - Fix Version/s: 1.14.0 Status: Patch Available (was: Open) > Update Stateless so that a

[GitHub] [nifi-minifi-cpp] martinzink edited a comment on pull request #1099: MINIFICPP-1582 fixing build failure in centos ci job

2021-06-04 Thread GitBox
martinzink edited a comment on pull request #1099: URL: https://github.com/apache/nifi-minifi-cpp/pull/1099#issuecomment-854753345 Unfortunately this wont make the job green due to a new centos8 cmake bug. (reported today 2021.06.04) https://bugs.centos.org/view.php?id=18212 That

[GitHub] [nifi-minifi-cpp] martinzink edited a comment on pull request #1099: MINIFICPP-1582 fixing build failure in centos ci job

2021-06-04 Thread GitBox
martinzink edited a comment on pull request #1099: URL: https://github.com/apache/nifi-minifi-cpp/pull/1099#issuecomment-854753345 Unfortunately this wont make the job green due to a new centos cmake bug. (reported today 2021.06.04) https://bugs.centos.org/view.php?id=18212 That

[GitHub] [nifi-minifi-cpp] martinzink commented on pull request #1099: MINIFICPP-1582 fixing build failure in centos ci job

2021-06-04 Thread GitBox
martinzink commented on pull request #1099: URL: https://github.com/apache/nifi-minifi-cpp/pull/1099#issuecomment-854753345 Unfortunatly this wont make the job green due to a new centos cmake bug. (reported today 2021.06.04) https://bugs.centos.org/view.php?id=18212 That issue can be

[GitHub] [nifi-minifi-cpp] martinzink edited a comment on pull request #1099: MINIFICPP-1582 fixing build failure in centos ci job

2021-06-04 Thread GitBox
martinzink edited a comment on pull request #1099: URL: https://github.com/apache/nifi-minifi-cpp/pull/1099#issuecomment-854753345 Unfortunately this wont make the job green due to a new centos8 cmake bug. (reported today 2021.06.04) https://bugs.centos.org/view.php?id=18212 That

[GitHub] [nifi] thenatog commented on pull request #5079: NIFI-8025 - Refactored AccessResource SAML and OIDC endpoints into separate classes

2021-06-04 Thread GitBox
thenatog commented on pull request #5079: URL: https://github.com/apache/nifi/pull/5079#issuecomment-854745318 Updated PR to address latest feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request #1099: MINIFICPP-1582 fixing build falure in centos ci job

2021-06-04 Thread GitBox
martinzink opened a new pull request #1099: URL: https://github.com/apache/nifi-minifi-cpp/pull/1099 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[jira] [Created] (MINIFICPP-1582) Build failure in centos ci job

2021-06-04 Thread Martin Zink (Jira)
Martin Zink created MINIFICPP-1582: -- Summary: Build failure in centos ci job Key: MINIFICPP-1582 URL: https://issues.apache.org/jira/browse/MINIFICPP-1582 Project: Apache NiFi MiNiFi C++

[GitHub] [nifi] ChrisSamo632 commented on pull request #5124: NIFI-8137 Rename RecordPath un/escape JSON functions

2021-06-04 Thread GitBox
ChrisSamo632 commented on pull request #5124: URL: https://github.com/apache/nifi/pull/5124#issuecomment-854738667 @ottobackwards / @markap14 FYI - follow on from earlier PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [nifi] ChrisSamo632 opened a new pull request #5124: NIFI-8137 Rename RecordPath un/escape JSON functions

2021-06-04 Thread GitBox
ChrisSamo632 opened a new pull request #5124: URL: https://github.com/apache/nifi/pull/5124 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Renamed RecordPath un/escape JSON functions

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5098: NIFI-8248 Modify PutAzureDataLakeStorage processor to use temp file

2021-06-04 Thread GitBox
exceptionfactory commented on a change in pull request #5098: URL: https://github.com/apache/nifi/pull/5098#discussion_r645581206 ## File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureDataLakeStorage.java

[jira] [Commented] (MINIFICPP-1577) Separate build and test steps in ubuntu-20.04 ci job

2021-06-04 Thread Martin Zink (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357363#comment-17357363 ] Martin Zink commented on MINIFICPP-1577:

[jira] [Resolved] (MINIFICPP-1577) Separate build and test steps in ubuntu-20.04 ci job

2021-06-04 Thread Martin Zink (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink resolved MINIFICPP-1577. Resolution: Fixed > Separate build and test steps in ubuntu-20.04 ci job >

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5111: NIFI-8645: Disable LongRunningTaskMonitor by default

2021-06-04 Thread GitBox
exceptionfactory commented on a change in pull request #5111: URL: https://github.com/apache/nifi/pull/5111#discussion_r645567361 ## File path: nifi-docs/src/main/asciidoc/administration-guide.adoc ## @@ -3732,6 +3732,21 @@ These properties determine the behavior of the

[jira] [Commented] (NIFI-8137) Record Path functions to un/escape JSON

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357354#comment-17357354 ] ASF subversion and git services commented on NIFI-8137: --- Commit

[jira] [Commented] (NIFI-8137) Record Path functions to un/escape JSON

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357355#comment-17357355 ] ASF subversion and git services commented on NIFI-8137: --- Commit

[GitHub] [nifi] ottobackwards merged pull request #4756: NIFI-8137 Record Path EscapeJson/UnescapeJson functions

2021-06-04 Thread GitBox
ottobackwards merged pull request #4756: URL: https://github.com/apache/nifi/pull/4756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [nifi] ChrisSamo632 commented on pull request #4756: NIFI-8137 Record Path EscapeJson/UnescapeJson functions

2021-06-04 Thread GitBox
ChrisSamo632 commented on pull request #4756: URL: https://github.com/apache/nifi/pull/4756#issuecomment-854718192 > @ChrisSamo632 wow. The example that I gave of `Base64Decode` does in fact match the convention you used :) Generally we would use though such as escapeJson, unescapeJson.

[jira] [Created] (NIFI-8658) Allow for filtering functions to be used as top-level functions for RecordPath

2021-06-04 Thread Mark Payne (Jira)
Mark Payne created NIFI-8658: Summary: Allow for filtering functions to be used as top-level functions for RecordPath Key: NIFI-8658 URL: https://issues.apache.org/jira/browse/NIFI-8658 Project: Apache

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5119: NIFI-8656: Support expression language for SAS Token in the ADLS Gen2…

2021-06-04 Thread GitBox
exceptionfactory commented on a change in pull request #5119: URL: https://github.com/apache/nifi/pull/5119#discussion_r645561156 ## File path:

[GitHub] [nifi] markap14 commented on pull request #4756: NIFI-8137 Record Path EscapeJson/UnescapeJson functions

2021-06-04 Thread GitBox
markap14 commented on pull request #4756: URL: https://github.com/apache/nifi/pull/4756#issuecomment-854714572 @ChrisSamo632 wow. The example that I gave of `Base64Decode` does in fact match the convention you used :) Generally we would use though such as escapeJson, unescapeJson. Just

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5122: NIFI-8499 - encrypted flow repository swap file implementation

2021-06-04 Thread GitBox
exceptionfactory commented on a change in pull request #5122: URL: https://github.com/apache/nifi/pull/5122#discussion_r645540468 ## File path: nifi-docs/src/main/asciidoc/administration-guide.adoc ## @@ -2961,7 +2961,8 @@ available again. These properties govern how that

[GitHub] [nifi] ChrisSamo632 edited a comment on pull request #4756: NIFI-8137 Record Path EscapeJson/UnescapeJson functions

2021-06-04 Thread GitBox
ChrisSamo632 edited a comment on pull request #4756: URL: https://github.com/apache/nifi/pull/4756#issuecomment-854706875 > @ChrisSamo632 any reason that these methods are called `jsonEscape` and `jsonUnescape`? I think `escapeJson` and `unescapeJson` make more sense and would be more

[GitHub] [nifi] ChrisSamo632 commented on pull request #4756: NIFI-8137 Record Path EscapeJson/UnescapeJson functions

2021-06-04 Thread GitBox
ChrisSamo632 commented on pull request #4756: URL: https://github.com/apache/nifi/pull/4756#issuecomment-854706875 > @ChrisSamo632 any reason that these methods are called `jsonEscape` and `jsonUnescape`? I think `escapeJson` and `unescapeJson` make more sense and would be more consistent

[GitHub] [nifi] markap14 commented on pull request #4756: NIFI-8137 Record Path EscapeJson/UnescapeJson functions

2021-06-04 Thread GitBox
markap14 commented on pull request #4756: URL: https://github.com/apache/nifi/pull/4756#issuecomment-854704222 @ChrisSamo632 any reason that these methods are called `jsonEscape` and `jsonUnescape`? I think `escapeJson` and `unescapeJson` make more sense and would be more consistent with

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1073: MINIFICPP-1541 Move ODBC dependent SQL testing to the docker integration tests

2021-06-04 Thread GitBox
adamdebreceni commented on a change in pull request #1073: URL: https://github.com/apache/nifi-minifi-cpp/pull/1073#discussion_r645542861 ## File path: libminifi/include/utils/StringUtils.h ## @@ -137,6 +137,7 @@ class StringUtils { static std::vector split(const

[jira] [Resolved] (MINIFICPP-1457) Implement InputRequirements

2021-06-04 Thread Jira
[ https://issues.apache.org/jira/browse/MINIFICPP-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ádám Markovics resolved MINIFICPP-1457. --- Resolution: Fixed Merged in

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1096: MINIFICPP-1580 Fix Tensorflow extension build

2021-06-04 Thread GitBox
lordgamez commented on pull request #1096: URL: https://github.com/apache/nifi-minifi-cpp/pull/1096#issuecomment-854681163 Keeping the PR in draft until #1028 is merged, and will rebase and fix the BaseStream return types afterwards. -- This is an automated message from the Apache Git

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-06-04 Thread GitBox
szaszm closed pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [nifi] ottobackwards commented on pull request #4756: NIFI-8137 Record Path EscapeJson/UnescapeJson functions

2021-06-04 Thread GitBox
ottobackwards commented on pull request #4756: URL: https://github.com/apache/nifi/pull/4756#issuecomment-854673243 @ChrisSamo632, thanks for the contribution, this looks good to me. +1 I will merge when the builds finish -- This is an automated message from the Apache Git Service.

[jira] [Commented] (NIFIREG-455) Update jgit version used by NiFi Registry

2021-06-04 Thread Chris Sampson (Jira)
[ https://issues.apache.org/jira/browse/NIFIREG-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357322#comment-17357322 ] Chris Sampson commented on NIFIREG-455: --- Raised https://github.com/apache/nifi/pull/5123 (can't

[GitHub] [nifi] ChrisSamo632 opened a new pull request #5123: NIFIREG-455 upgrade jgit version for nifi-registry GitFlowPersistence…

2021-06-04 Thread GitBox
ChrisSamo632 opened a new pull request #5123: URL: https://github.com/apache/nifi/pull/5123 …Provider Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR NIFIREG-455 upgrade jgit

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1073: MINIFICPP-1541 Move ODBC dependent SQL testing to the docker integration tests

2021-06-04 Thread GitBox
szaszm commented on a change in pull request #1073: URL: https://github.com/apache/nifi-minifi-cpp/pull/1073#discussion_r645517495 ## File path: libminifi/include/utils/StringUtils.h ## @@ -137,6 +137,7 @@ class StringUtils { static std::vector split(const std::string ,

[jira] [Updated] (NIFI-8137) Record Path functions to un/escape JSON

2021-06-04 Thread Chris Sampson (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Sampson updated NIFI-8137: Attachment: Record_Path_JSON.json > Record Path functions to un/escape JSON >

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1073: MINIFICPP-1541 Move ODBC dependent SQL testing to the docker integration tests

2021-06-04 Thread GitBox
lordgamez commented on a change in pull request #1073: URL: https://github.com/apache/nifi-minifi-cpp/pull/1073#discussion_r645489479 ## File path: libminifi/include/utils/StringUtils.h ## @@ -137,6 +137,7 @@ class StringUtils { static std::vector split(const std::string

[jira] [Resolved] (MINIFICPP-1578) Update versions in the docker-based package builders

2021-06-04 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits resolved MINIFICPP-1578. --- Resolution: Fixed Fixed by https://github.com/apache/nifi-minifi-cpp/pull/1093

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1098: MINIFICPP-1581: set cmake policy CMP0096 to NEW to preserve the leadi…

2021-06-04 Thread GitBox
szaszm commented on pull request #1098: URL: https://github.com/apache/nifi-minifi-cpp/pull/1098#issuecomment-854619539 libminifi and probably nanofi are separate projects with their corresponding root CMakeLists.txt files. You may want to apply the change there as well. -- This is an

[GitHub] [nifi] BioQwer commented on a change in pull request #5057: NIFI-8338 NIFI-7997 NIFI-6266 fix ftp using proxy bug

2021-06-04 Thread GitBox
BioQwer commented on a change in pull request #5057: URL: https://github.com/apache/nifi/pull/5057#discussion_r645484545 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/FTPTransfer.java ## @@

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #1085: MINIFICPP-1568 Retry PDH processor run to fix test flakiness

2021-06-04 Thread GitBox
arpadboda closed pull request #1085: URL: https://github.com/apache/nifi-minifi-cpp/pull/1085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1073: MINIFICPP-1541 Move ODBC dependent SQL testing to the docker integration tests

2021-06-04 Thread GitBox
szaszm commented on a change in pull request #1073: URL: https://github.com/apache/nifi-minifi-cpp/pull/1073#discussion_r645454687 ## File path: libminifi/include/utils/StringUtils.h ## @@ -137,6 +137,7 @@ class StringUtils { static std::vector split(const std::string ,

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1089: MINIFICPP-1567 enable linter checks in extensions (part 1)

2021-06-04 Thread GitBox
szaszm commented on a change in pull request #1089: URL: https://github.com/apache/nifi-minifi-cpp/pull/1089#discussion_r645450031 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -127,8 +129,8 @@ core::Property

[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request #1098: MINIFICPP-1581: set cmake policy CMP0096 to NEW to preserve the leadi…

2021-06-04 Thread GitBox
martinzink opened a new pull request #1098: URL: https://github.com/apache/nifi-minifi-cpp/pull/1098 …ng zeros in project version Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #1095: MINIFICPP-1577: Separate build and test steps in ubuntu-20.04 ci job

2021-06-04 Thread GitBox
arpadboda closed pull request #1095: URL: https://github.com/apache/nifi-minifi-cpp/pull/1095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #1093: MINIFICPP-1578 Upgrade OS versions in docker builds

2021-06-04 Thread GitBox
arpadboda closed pull request #1093: URL: https://github.com/apache/nifi-minifi-cpp/pull/1093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [nifi] ChrisSamo632 commented on a change in pull request #4756: NIFI-8137 Record Path EscapeJson/UnescapeJson functions

2021-06-04 Thread GitBox
ChrisSamo632 commented on a change in pull request #4756: URL: https://github.com/apache/nifi/pull/4756#discussion_r645359626 ## File path: nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/functions/EscapeJson.java ## @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1094: MINIFICPP-1576 Allow build of all extensions in docker and cleanup docker files

2021-06-04 Thread GitBox
lordgamez commented on a change in pull request #1094: URL: https://github.com/apache/nifi-minifi-cpp/pull/1094#discussion_r645346834 ## File path: cmake/DockerConfig.cmake ## @@ -65,10 +65,19 @@ add_custom_target( COMMAND ${CMAKE_SOURCE_DIR}/docker/DockerBuild.sh

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1073: MINIFICPP-1541 Move ODBC dependent SQL testing to the docker integration tests

2021-06-04 Thread GitBox
lordgamez commented on a change in pull request #1073: URL: https://github.com/apache/nifi-minifi-cpp/pull/1073#discussion_r644668234 ## File path: libminifi/test/sql-tests/mocks/MockConnectors.cpp ## @@ -0,0 +1,386 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi] mtien-apache commented on pull request #5107: NIFIREG-395 - Implemented the ability to import and export versioned …

2021-06-04 Thread GitBox
mtien-apache commented on pull request #5107: URL: https://github.com/apache/nifi/pull/5107#issuecomment-854126581 > One minor thing I noticed while doing another test... in the first import, there is no box to specify Comments for the first version, but there is Flow Description which

[GitHub] [nifi] pgyori edited a comment on pull request #5121: NIFI-8498: Optional removal of fields with UpdateRecord

2021-06-04 Thread GitBox
pgyori edited a comment on pull request #5121: URL: https://github.com/apache/nifi/pull/5121#issuecomment-854002406 [UpdateRecord_field_removal.xml.zip](https://github.com/apache/nifi/files/6593186/UpdateRecord_field_removal.xml.zip) At this point the PR is a draft. NiFi

[GitHub] [nifi] joewitt commented on pull request #5117: NIFI-8655 Intermittent test failures in TestUnpackContent#testThreadSafetyUsingAutoDetect

2021-06-04 Thread GitBox
joewitt commented on pull request #5117: URL: https://github.com/apache/nifi/pull/5117#issuecomment-853918449 Thanks for looking into and knocking this out! +1 from me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

  1   2   >