greyp9 commented on a change in pull request #5386:
URL: https://github.com/apache/nifi/pull/5386#discussion_r709650194
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-event-transport/src/main/java/org/apache/nifi/event/transport/configuration/ShutdownQuietPeriod.java
greyp9 commented on a change in pull request #5386:
URL: https://github.com/apache/nifi/pull/5386#discussion_r709650143
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-event-transport/src/main/java/org/apache/nifi/event/transport/configuration/ShutdownTimeout.java
##
[
https://issues.apache.org/jira/browse/NIFI-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Bende updated NIFI-9217:
--
Fix Version/s: 1.15.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
>
[
https://issues.apache.org/jira/browse/NIFI-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17415715#comment-17415715
]
ASF subversion and git services commented on NIFI-9217:
---
Commit
bbende merged pull request #5390:
URL: https://github.com/apache/nifi/pull/5390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
bbende commented on pull request #5390:
URL: https://github.com/apache/nifi/pull/5390#issuecomment-920322786
Looks good, going to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
exceptionfactory commented on a change in pull request #5386:
URL: https://github.com/apache/nifi/pull/5386#discussion_r709479591
##
File path:
exceptionfactory commented on a change in pull request #5386:
URL: https://github.com/apache/nifi/pull/5386#discussion_r709479368
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-event-transport/src/main/java/org/apache/nifi/event/transport/configuration/ShutdownTimeout.java
greyp9 commented on a change in pull request #5386:
URL: https://github.com/apache/nifi/pull/5386#discussion_r709457887
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-event-transport/src/main/java/org/apache/nifi/event/transport/netty/NettyEventServer.java
##
@@
markobean commented on a change in pull request #5267:
URL: https://github.com/apache/nifi/pull/5267#discussion_r709399380
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DistributeLoad.java
##
@@
markobean commented on a change in pull request #5267:
URL: https://github.com/apache/nifi/pull/5267#discussion_r709399380
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DistributeLoad.java
##
@@
markobean commented on a change in pull request #5267:
URL: https://github.com/apache/nifi/pull/5267#discussion_r709399380
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DistributeLoad.java
##
@@
pgyori commented on pull request #5388:
URL: https://github.com/apache/nifi/pull/5388#issuecomment-920219046
@exceptionfactory I added unit tests and found 2 more places where
useLogicalTypes had to be considered. I pushed all my modifications to this PR.
--
This is an automated message
[
https://issues.apache.org/jira/browse/NIFI-9076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Denes Arvay updated NIFI-9076:
--
Fix Version/s: 1.15.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> In
markobean commented on pull request #5307:
URL: https://github.com/apache/nifi/pull/5307#issuecomment-920170784
I updated the README with a clarification that a full build is required
initially before using the optional build paramenters. The Developer Guide is
more high level; it
[
https://issues.apache.org/jira/browse/NIFI-9218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Hogue updated NIFI-9218:
Description: The email processing bundle supports extracting email headers
and attachments but not
Michael Hogue created NIFI-9218:
---
Summary: Extend ExtractEmailAttachments to optionally extract
email content
Key: NIFI-9218
URL: https://issues.apache.org/jira/browse/NIFI-9218
Project: Apache NiFi
fgerlits commented on a change in pull request #1170:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1170#discussion_r709315815
##
File path: extensions/standard-processors/processors/ReplaceText.h
##
@@ -0,0 +1,102 @@
+/**
+ * Licensed to the Apache Software Foundation
fgerlits closed pull request #1138:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mtien-apache commented on pull request #5371:
URL: https://github.com/apache/nifi/pull/5371#issuecomment-920103606
Nice work, @mcgilman! I was able to successfully build on openjdk version
1.8.0_282. So far, the UI runs well. I'm able to create parameter contexts, add
and remove the
venotyCap commented on pull request #2047:
URL: https://github.com/apache/nifi/pull/2047#issuecomment-920097694
Hi,
According to [this merged PR]
(https://github.com/apache/nifi-registry/pull/296), Nifi Registry has support
for open id connect. I had check the documentation but I
adamdebreceni commented on pull request #1138:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#issuecomment-920042078
the aws extension is now dynamically loaded into all tests (unless otherwise
specified), which then tries to fetch metadata causing C2 tests to take longer,
thus
pgyori commented on pull request #5388:
URL: https://github.com/apache/nifi/pull/5388#issuecomment-920007319
Thank you for reviewing, @exceptionfactory ! You are right, the unit tests
for this modification are missing from this PR. I'm working on them and will
commit them in a couple of
pgyori commented on a change in pull request #5388:
URL: https://github.com/apache/nifi/pull/5388#discussion_r709172676
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-database-utils/src/main/java/org/apache/nifi/util/db/JdbcCommon.java
##
@@ -189,6 +189,10 @@ public
exceptionfactory commented on a change in pull request #5388:
URL: https://github.com/apache/nifi/pull/5388#discussion_r709161399
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-database-utils/src/main/java/org/apache/nifi/util/db/JdbcCommon.java
##
@@ -189,6 +189,10
lordgamez commented on a change in pull request #1158:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1158#discussion_r709161984
##
File path: extensions/azure/processors/PutAzureDataLakeStorage.cpp
##
@@ -0,0 +1,167 @@
+/**
+ * @file PutAzureDataLakeStorage.cpp
+ *
lordgamez commented on a change in pull request #1158:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1158#discussion_r709161726
##
File path: extensions/azure/processors/PutAzureDataLakeStorage.h
##
@@ -0,0 +1,106 @@
+/**
+ * @file PutAzureDataLakeStorage.h
+ *
lordgamez commented on a change in pull request #1158:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1158#discussion_r709161278
##
File path: extensions/azure/processors/AzureStorageProcessor.h
##
@@ -0,0 +1,51 @@
+/**
+ * @file AzureStorageProcessor.h
+ *
michael81877 commented on pull request #5307:
URL: https://github.com/apache/nifi/pull/5307#issuecomment-919989183
I feel like it's okay that `-DexcludeNiFiRegistry` on a clean pull doesn't
build successfully as long as that's documented somewhere fairly visible, such
as the developer
michael81877 commented on a change in pull request #5267:
URL: https://github.com/apache/nifi/pull/5267#discussion_r709146978
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DistributeLoad.java
##
[
https://issues.apache.org/jira/browse/NIFI-9170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nadeem updated NIFI-9170:
-
Fix Version/s: 1.15.0
> Upgrade commons-beanutils to 1.9.4 to mitigate CVE-2019-10086
>
[
https://issues.apache.org/jira/browse/NIFI-9170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nadeem updated NIFI-9170:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Upgrade commons-beanutils to 1.9.4 to
szaszm commented on a change in pull request #1173:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1173#discussion_r709086900
##
File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp
##
@@ -306,3 +291,97 @@ TEST_CASE("HTTPTestsPostNoResourceClaim", "[httptest1]")
aminadinari19 commented on a change in pull request #1173:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1173#discussion_r709076342
##
File path: extensions/http-curl/processors/InvokeHTTP.cpp
##
@@ -443,6 +447,7 @@ void InvokeHTTP::route(const
std::shared_ptr , const
aminadinari19 commented on a change in pull request #1173:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1173#discussion_r709073806
##
File path: docker/test/integration/features/http.feature
##
@@ -8,7 +8,6 @@ Feature: Sending data using InvokeHTTP to a receiver using
aminadinari19 commented on a change in pull request #1173:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1173#discussion_r709070296
##
File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp
##
@@ -306,3 +291,97 @@ TEST_CASE("HTTPTestsPostNoResourceClaim",
lordgamez commented on a change in pull request #1158:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1158#discussion_r709067304
##
File path: .github/workflows/ci.yml
##
@@ -35,7 +35,7 @@ jobs:
export LDFLAGS="-L/usr/local/opt/flex/lib"
export
fgerlits commented on a change in pull request #1158:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1158#discussion_r709000677
##
File path: extensions/azure/processors/AzureStorageProcessor.h
##
@@ -0,0 +1,51 @@
+/**
+ * @file AzureStorageProcessor.h
+ *
OIUE closed pull request #5357:
URL: https://github.com/apache/nifi/pull/5357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lordgamez edited a comment on pull request #1138:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#issuecomment-919821985
Currently the C2 tests fail locally when I try to run them, have you
encountered this before?
The following tests FAILED:
95 - C2JstackTest
lordgamez commented on a change in pull request #1138:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r708994802
##
File path: thirdparty/aws-sdk-cpp/dll-export-injection.patch
##
@@ -0,0 +1,52 @@
+diff -rupN aws-sdk-cpp-src/aws-cpp-sdk-core/CMakeLists.txt
adamdebreceni commented on a change in pull request #1138:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r708983717
##
File path: thirdparty/aws-sdk-cpp/dll-export-injection.patch
##
@@ -0,0 +1,52 @@
+diff -rupN
adamdebreceni commented on a change in pull request #1138:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r708983346
##
File path: extensions/jni/JNILoader.cpp
##
@@ -15,16 +15,24 @@
* See the License for the specific language governing permissions and
adamdebreceni commented on a change in pull request #1138:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r708980201
##
File path: extensions/azure/CMakeLists.txt
##
@@ -34,6 +34,10 @@ target_link_libraries(minifi-azure ${LIBMINIFI}
Threads::Threads)
adamdebreceni commented on a change in pull request #1138:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r708980062
##
File path: cmake/BundledAwsSdkCpp.cmake
##
@@ -110,6 +119,9 @@ function(use_bundled_libaws SOURCE_DIR BINARY_DIR)
lordgamez commented on pull request #1138:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#issuecomment-919821985
Currently the C2 tests fail locally when I try to run them, have you
encountered this before?
The following tests FAILED:
95 - C2JstackTest (Child
lordgamez commented on a change in pull request #1138:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r708935767
##
File path: extensions/azure/CMakeLists.txt
##
@@ -34,6 +34,10 @@ target_link_libraries(minifi-azure ${LIBMINIFI}
Threads::Threads)
fgerlits commented on pull request #1171:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1171#issuecomment-919775552
Yes, I agree on the variability. My results don't really show that the
compilation on my computer on the compile-time branch is slower, but it does
show that it is
48 matches
Mail list logo
