[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1543: MINIFICPP-2074 Fix time-period/integer validated properties during lo…

2023-04-03 Thread via GitHub
martinzink commented on code in PR #1543: URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1155852620 ## libminifi/include/utils/StringUtils.h: ## @@ -505,7 +505,7 @@ class StringUtils { */ static bool matchesSequence(std::string_view str, const

[jira] [Created] (NIFI-11373) ConsumeAzureEventHub is keep on opening files and leaving it when configured it with wrong eventhub name

2023-04-03 Thread Mahendra hegde (Jira)
Mahendra hegde created NIFI-11373: - Summary: ConsumeAzureEventHub is keep on opening files and leaving it when configured it with wrong eventhub name Key: NIFI-11373 URL:

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1543: MINIFICPP-2074 Fix time-period/integer validated properties during lo…

2023-04-03 Thread via GitHub
martinzink commented on code in PR #1543: URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1155850661 ## libminifi/src/properties/Properties.cpp: ## @@ -62,8 +63,100 @@ int Properties::getInt(const std::string , int default_value) const { return it !=

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1543: MINIFICPP-2074 Fix time-period/integer validated properties during lo…

2023-04-03 Thread via GitHub
martinzink commented on code in PR #1543: URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1155850024 ## libminifi/src/properties/Properties.cpp: ## @@ -62,8 +63,100 @@ int Properties::getInt(const std::string , int default_value) const { return it !=

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1543: MINIFICPP-2074 Fix time-period/integer validated properties during lo…

2023-04-03 Thread via GitHub
martinzink commented on code in PR #1543: URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1155849770 ## libminifi/src/c2/C2Agent.cpp: ## @@ -180,17 +180,18 @@ void C2Agent::configure(const std::shared_ptr , bool reconf try { if (auto

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1543: MINIFICPP-2074 Fix time-period/integer validated properties during lo…

2023-04-03 Thread via GitHub
martinzink commented on code in PR #1543: URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1155849368 ## libminifi/include/utils/TimeUtil.h: ## @@ -201,38 +203,17 @@ std::optional cast_to_matching_unit(std::string& unit, const int ((result =

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1543: MINIFICPP-2074 Fix time-period/integer validated properties during lo…

2023-04-03 Thread via GitHub
martinzink commented on code in PR #1543: URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1155849080 ## libminifi/include/properties/Properties.h: ## @@ -113,7 +113,7 @@ class Properties { * Load configure file * @param fileName path of the

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1543: MINIFICPP-2074 Fix time-period/integer validated properties during lo…

2023-04-03 Thread via GitHub
martinzink commented on code in PR #1543: URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1155848804 ## libminifi/include/core/TypedValues.h: ## @@ -110,20 +110,26 @@ class DataSizeValue : public TransformableValue, public state::response::UInt64V :

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1543: MINIFICPP-2074 Fix time-period/integer validated properties during lo…

2023-04-03 Thread via GitHub
martinzink commented on code in PR #1543: URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1155848273 ## libminifi/include/core/TypedValues.h: ## @@ -110,20 +110,26 @@ class DataSizeValue : public TransformableValue, public state::response::UInt64V :

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1543: MINIFICPP-2074 Fix time-period/integer validated properties during lo…

2023-04-03 Thread via GitHub
martinzink commented on code in PR #1543: URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1155847706 ## libminifi/include/core/TypedValues.h: ## @@ -110,20 +110,26 @@ class DataSizeValue : public TransformableValue, public state::response::UInt64V :

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1543: MINIFICPP-2074 Fix time-period/integer validated properties during lo…

2023-04-03 Thread via GitHub
martinzink commented on code in PR #1543: URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1155846613 ## extensions/standard-processors/tests/unit/ConfigurationTests.cpp: ## @@ -53,4 +54,130 @@ TEST_CASE("Configuration can validate values to be assigned to

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1543: MINIFICPP-2074 Fix time-period/integer validated properties during lo…

2023-04-03 Thread via GitHub
martinzink commented on code in PR #1543: URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1155847165 ## libminifi/include/EventDrivenSchedulingAgent.h: ## @@ -38,11 +38,15 @@ class EventDrivenSchedulingAgent : public ThreadedSchedulingAgent {

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1543: MINIFICPP-2074 Fix time-period/integer validated properties during lo…

2023-04-03 Thread via GitHub
martinzink commented on code in PR #1543: URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1155846054 ## extensions/http-curl/tests/HTTPHandlers.h: ## @@ -556,18 +556,18 @@ class HeartbeatHandler : public ServerAwareHandler { std::vector>

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1543: MINIFICPP-2074 Fix time-period/integer validated properties during lo…

2023-04-03 Thread via GitHub
martinzink commented on code in PR #1543: URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1155844438 ## libminifi/src/Configuration.cpp: ## @@ -17,135 +17,135 @@ #include #include "properties/Configuration.h" -#include "core/PropertyBuilder.h"

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1547: MINIFICPP-2090 Update version number to 0.14.0

2023-04-03 Thread via GitHub
lordgamez opened a new pull request, #1547: URL: https://github.com/apache/nifi-minifi-cpp/pull/1547 https://issues.apache.org/jira/browse/MINIFICPP-2090 - Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of

[jira] [Created] (MINIFICPP-2090) Update version number to 0.14.0

2023-04-03 Thread Jira
Gábor Gyimesi created MINIFICPP-2090: Summary: Update version number to 0.14.0 Key: MINIFICPP-2090 URL: https://issues.apache.org/jira/browse/MINIFICPP-2090 Project: Apache NiFi MiNiFi C++

[jira] [Resolved] (MINIFICPP-2019) Fix the auto-generation of Processor docs

2023-04-03 Thread Jira
[ https://issues.apache.org/jira/browse/MINIFICPP-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi resolved MINIFICPP-2019. -- Resolution: Fixed > Fix the auto-generation of Processor docs >

[jira] [Resolved] (MINIFICPP-2021) Enable auto-generation of everything in PROCESSORS.md

2023-04-03 Thread Jira
[ https://issues.apache.org/jira/browse/MINIFICPP-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi resolved MINIFICPP-2021. -- Fix Version/s: 0.14.0 Resolution: Fixed > Enable auto-generation of

[GitHub] [nifi-minifi-cpp] lordgamez closed pull request #1492: MINIFICPP-2021 Auto-generate extra doc sections in PROCESSORS.md

2023-04-03 Thread via GitHub
lordgamez closed pull request #1492: MINIFICPP-2021 Auto-generate extra doc sections in PROCESSORS.md URL: https://github.com/apache/nifi-minifi-cpp/pull/1492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nifi-minifi-cpp] lordgamez closed pull request #1483: MINIFICPP-2019 Fix auto-generation of PROCESSORS.md

2023-04-03 Thread via GitHub
lordgamez closed pull request #1483: MINIFICPP-2019 Fix auto-generation of PROCESSORS.md URL: https://github.com/apache/nifi-minifi-cpp/pull/1483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (NIFI-11344) Improve FIPS-140 compatibility in MiNiFi

2023-04-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707893#comment-17707893 ] ASF subversion and git services commented on NIFI-11344: Commit

[jira] [Resolved] (MINIFICPP-2068) Flaky test case in ExpressionLanguageTests

2023-04-03 Thread Martin Zink (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink resolved MINIFICPP-2068. Resolution: Fixed https://issues.apache.org/jira/browse/MINIFICPP-2084 > Flaky test

[jira] [Commented] (MINIFICPP-2068) Flaky test case in ExpressionLanguageTests

2023-04-03 Thread Martin Zink (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707875#comment-17707875 ] Martin Zink commented on MINIFICPP-2068: The root cause seemed different so I've already

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1541: MINIFICPP-2084 Fix flaky Reverse DNS timeout test

2023-04-03 Thread via GitHub
martinzink commented on code in PR #1541: URL: https://github.com/apache/nifi-minifi-cpp/pull/1541#discussion_r1155644875 ## extensions/expression-language/tests/ExpressionLanguageTests.cpp: ## @@ -1342,13 +1342,18 @@ TEST_CASE("Reverse DNS lookup with valid timeout

[jira] [Updated] (MINIFICPP-2089) Revisit CWEL EventData format in flattened JSON output

2023-04-03 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2089: Description: In flattened JSON, the data in an EventData tag is duplicated: Once in

[jira] [Created] (MINIFICPP-2089) Revisit CWEL EventData format in flattened JSON output

2023-04-03 Thread Marton Szasz (Jira)
Marton Szasz created MINIFICPP-2089: --- Summary: Revisit CWEL EventData format in flattened JSON output Key: MINIFICPP-2089 URL: https://issues.apache.org/jira/browse/MINIFICPP-2089 Project: Apache

[jira] [Created] (MINIFICPP-2088) InvokeHTTP should check whether it needs to run before retrieving the HttpClient

2023-04-03 Thread Marton Szasz (Jira)
Marton Szasz created MINIFICPP-2088: --- Summary: InvokeHTTP should check whether it needs to run before retrieving the HttpClient Key: MINIFICPP-2088 URL: https://issues.apache.org/jira/browse/MINIFICPP-2088

<    1   2