martinzink commented on code in PR #1543:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1155852620
##########
libminifi/include/utils/StringUtils.h:
##########
@@ -505,7 +505,7 @@ class StringUtils {
*/
static bool matchesSequence(std::string_view str, const
std::vector<std::string>& patterns);
- private:
+ static bool splitToUnitAndValue(std::string_view input, std::string& unit,
int64_t& value);
Review Comment:
sure thing, I've changed the name aswell to better reflect the order of the
arguments in
https://github.com/apache/nifi-minifi-cpp/pull/1543/commits/64c5975e3fda0911820465778fa4d73f16d12002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
