simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1424892774
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb-status-history/src/main/java/org/apache/nifi/controller/status/history/questdb/StatusHistoryStorage.java:
##
@@ -0,
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1424889502
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb-status-history/src/main/java/org/apache/nifi/controller/status/history/questdb/EmbeddedQuestDbStatusHistoryRepositoryDefini
[
https://issues.apache.org/jira/browse/NIFI-12508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Bence updated NIFI-12508:
---
Status: Patch Available (was: In Progress)
https://github.com/apache/nifi/pull/8153
> Cleanin up re
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1424884706
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb-status-history/src/main/java/org/apache/nifi/controller/status/history/questdb/EmbeddedQuestDbStatusHistoryRepositoryDefini
simonbence opened a new pull request, #8153:
URL: https://github.com/apache/nifi/pull/8153
# Summary
[NIFI-12508](https://issues.apache.org/jira/browse/NIFI-12508)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tra
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1424882496
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb-status-history/src/main/java/org/apache/nifi/controller/status/history/questdb/CapturedStatus.java:
##
@@ -0,0 +1,5
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1424878344
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-status-history-shared/pom.xml:
##
@@ -30,5 +30,9 @@
org.apache.nifi
ni
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1424876658
##
nifi-docs/src/main/asciidoc/administration-guide.adoc:
##
@@ -3538,15 +3538,19 @@ of 576.
Persistent repository
-If the value of the property
`nifi.compon
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1424874235
##
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/retry/NoReturnCallable.java:
##
@@ -14,25 +14,16 @@
* See the License for the specific language governing per
simonbence commented on PR #8152:
URL: https://github.com/apache/nifi/pull/8152#issuecomment-1853298122
> Thanks for creating the new pull request and making the adjustments
@simonbence. I have yet not review the entire implementation, but I noted a few
recommendations.
>
> Having th
Simon Bence created NIFI-12508:
--
Summary: Cleanin up remainders of the event driven thread
Key: NIFI-12508
URL: https://issues.apache.org/jira/browse/NIFI-12508
Project: Apache NiFi
Issue Type:
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1424815114
##
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/retry/NoReturnCallable.java:
##
@@ -14,25 +14,16 @@
* See the License for the specific language governi
[
https://issues.apache.org/jira/browse/NIFI-12496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12496:
Fix Version/s: 2.0.0
Resolution: Fixed
Status: Resolved (was: Patch Avail
[
https://issues.apache.org/jira/browse/NIFI-12496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795989#comment-17795989
]
ASF subversion and git services commented on NIFI-12496:
Commit 4
exceptionfactory closed pull request #8148: NIFI-12496 - move python extensions
unpacking to common.xml
URL: https://github.com/apache/nifi/pull/8148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
exceptionfactory commented on code in PR #8151:
URL: https://github.com/apache/nifi/pull/8151#discussion_r1424788213
##
minifi/minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/service/MiNiFiExecCommandProvider.java:
##
@@ -116,8 +134,14 @@ public List getMiNiFiExe
exceptionfactory commented on code in PR #8136:
URL: https://github.com/apache/nifi/pull/8136#discussion_r1424783911
##
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/csrf/StandardCsrfTokenRequestAttributeHandler
exceptionfactory commented on code in PR #8136:
URL: https://github.com/apache/nifi/pull/8136#discussion_r1424783483
##
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/csrf/CsrfRequestMatcher.java:
##
@@ -
exceptionfactory commented on code in PR #78:
URL: https://github.com/apache/nifi-site/pull/78#discussion_r1424767986
##
content/projects/minifi/minifi-toolkit.md:
##
@@ -1,7 +1,10 @@
---
title: Apache NiFi MiNiFi Toolkit Guide
-menu: minifi-topbar.html
-containerEnabled:
Aerilym closed pull request #8127: NIFI-7505 Add InvokeHTTPRecord processor
URL: https://github.com/apache/nifi/pull/8127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
Aerilym commented on PR #8127:
URL: https://github.com/apache/nifi/pull/8127#issuecomment-1853080846
Thank you for your thorough review and the time you've taken to give
feedback and comment again, your tact is appreciated :) I understand the work
in its current form being rejected and the
[
https://issues.apache.org/jira/browse/NIFI-12501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795960#comment-17795960
]
Marton Szasz edited comment on NIFI-12501 at 12/12/23 11:57 PM:
---
[
https://issues.apache.org/jira/browse/NIFI-12501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795960#comment-17795960
]
Marton Szasz edited comment on NIFI-12501 at 12/12/23 11:54 PM:
---
[
https://issues.apache.org/jira/browse/NIFI-12501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795960#comment-17795960
]
Marton Szasz commented on NIFI-12501:
-
[~exceptionfactory] The Jira tracking the mini
szaszm commented on PR #1703:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1703#issuecomment-1853035680
rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
szaszm commented on code in PR #1681:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1424686652
##
bootstrap/system_dependency.py:
##
@@ -0,0 +1,55 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
Arti Wadhwani created NIFI-12507:
Summary: Update Documentation for PutHive3Streaming processor
Key: NIFI-12507
URL: https://issues.apache.org/jira/browse/NIFI-12507
Project: Apache NiFi
Issu
dan-s1 commented on code in PR #8146:
URL: https://github.com/apache/nifi/pull/8146#discussion_r1424500623
##
nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/ConsumeAMQP.java:
##
@@ -112,6 +112,16 @@ public class ConsumeAMQP e
dan-s1 commented on code in PR #8146:
URL: https://github.com/apache/nifi/pull/8146#discussion_r1424437510
##
nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/test/java/org/apache/nifi/amqp/processors/AMQPConsumerTest.java:
##
@@ -55,7 +55,7 @@ public void testResponse
dan-s1 commented on code in PR #8146:
URL: https://github.com/apache/nifi/pull/8146#discussion_r1424500623
##
nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/ConsumeAMQP.java:
##
@@ -112,6 +112,16 @@ public class ConsumeAMQP e
dan-s1 commented on code in PR #8146:
URL: https://github.com/apache/nifi/pull/8146#discussion_r1424438916
##
nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/test/java/org/apache/nifi/amqp/processors/AMQPConsumerTest.java:
##
@@ -80,30 +80,30 @@ public void testConsum
dan-s1 commented on code in PR #8136:
URL: https://github.com/apache/nifi/pull/8136#discussion_r1424400190
##
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/csrf/CsrfRequestMatcher.java:
##
@@ -0,0 +1,45
simonbence opened a new pull request, #8152:
URL: https://github.com/apache/nifi/pull/8152
This is a refined PR for NIFI-12236 after feedback and discussion on [PR
8123](https://github.com/apache/nifi/pull/8123). The general approach and
purpose remained the same: the PR aims to refine erro
emiliosetiadarma commented on code in PR #8125:
URL: https://github.com/apache/nifi/pull/8125#discussion_r1424253228
##
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/DeleteHDFS.java:
##
@@ -139,6 +137,7 @@ public void on
bbende commented on code in PR #8125:
URL: https://github.com/apache/nifi/pull/8125#discussion_r1424091461
##
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/DeleteHDFS.java:
##
@@ -139,6 +137,7 @@ public void onTrigger(Pr
martinzink commented on code in PR #1681:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1424034289
##
bootstrap/system_dependency.py:
##
@@ -0,0 +1,55 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreement
martinzink commented on code in PR #1681:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1424035886
##
bootstrap/main.py:
##
@@ -0,0 +1,56 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the N
ferencerdei opened a new pull request, #8151:
URL: https://github.com/apache/nifi/pull/8151
# Summary
[NIFI-12501](https://issues.apache.org/jira/browse/NIFI-12501)
This change makes it possible to encrypt bootstrap.conf file.
adamdebreceni commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1423923909
##
extensions/standard-processors/utils/JoltUtils.cpp:
##
@@ -0,0 +1,1134 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
adamdebreceni commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1423922940
##
extensions/standard-processors/utils/JoltUtils.cpp:
##
@@ -0,0 +1,1134 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
adamdebreceni commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1423921251
##
extensions/standard-processors/utils/JoltUtils.cpp:
##
@@ -0,0 +1,1134 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
adamdebreceni commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1423912281
##
libminifi/test/Utils.h:
##
@@ -48,23 +48,45 @@ using namespace std::literals::chrono_literals;
namespace org::apache::nifi::minifi::test::utils {
adamdebreceni commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1423912541
##
libminifi/test/Utils.h:
##
@@ -48,23 +48,45 @@ using namespace std::literals::chrono_literals;
namespace org::apache::nifi::minifi::test::utils {
adamdebreceni commented on code in PR #1640:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1640#discussion_r1423872205
##
libminifi/include/core/ContentSession.h:
##
@@ -39,6 +52,12 @@ class ContentSession {
virtual void rollback() = 0;
virtual ~ContentSession() =
martinzink commented on PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#issuecomment-1851843244
@adamdebreceni Could you rebase and fix conflicts from
https://github.com/apache/nifi-minifi-cpp/pull/1693 ?
--
This is an automated message from the Apache Git Service.
To r
martinzink commented on PR #1682:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1682#issuecomment-1851841261
Could you rebase and fix conflicts from
https://github.com/apache/nifi-minifi-cpp/pull/1693 ?
--
This is an automated message from the Apache Git Service.
To respond to the m
martinzink commented on PR #1703:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1703#issuecomment-1851842349
@szaszm Could you rebase and fix conflicts from
https://github.com/apache/nifi-minifi-cpp/pull/1693 ?
--
This is an automated message from the Apache Git Service.
To respond
simonbence closed pull request #8123: NIFI-12236 Improving fault tolerancy of
the QuestDB backed metrics repository
URL: https://github.com/apache/nifi/pull/8123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
simonbence commented on PR #8123:
URL: https://github.com/apache/nifi/pull/8123#issuecomment-1851737367
As the changes discussed on the ticket and were resulted by NIFI-12492 would
make this PR hard to follow, I close it and will open a new one
--
This is an automated message from the Apa
martinzink commented on PR #1707:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1707#issuecomment-1851594569
Similarly to https://github.com/apache/nifi-minifi-cpp/pull/1693 I'd ask you
to be a bit more lenient with the clang tidy results. I'd rather not refactor
the whole codebase in
50 matches
Mail list logo