Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/133#discussion_r138110601
--- Diff: libminifi/include/processors/BinFiles.h ---
@@ -0,0 +1,295 @@
+/**
+ * @file BinFiles.h
+ * BinFiles class declaration
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/133#discussion_r138110287
--- Diff: libminifi/include/processors/BinFiles.h ---
@@ -0,0 +1,295 @@
+/**
+ * @file BinFiles.h
+ * BinFiles class declaration
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/133#discussion_r138110422
--- Diff: libminifi/include/processors/BinFiles.h ---
@@ -0,0 +1,295 @@
+/**
+ * @file BinFiles.h
+ * BinFiles class declaration
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/133#discussion_r138110384
--- Diff: libminifi/include/processors/BinFiles.h ---
@@ -0,0 +1,295 @@
+/**
+ * @file BinFiles.h
+ * BinFiles class declaration
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/133#discussion_r138109572
--- Diff: libminifi/include/processors/BinFiles.h ---
@@ -0,0 +1,295 @@
+/**
+ * @file BinFiles.h
+ * BinFiles class declaration
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/133#discussion_r138109269
--- Diff: libminifi/include/processors/BinFiles.h ---
@@ -0,0 +1,295 @@
+/**
+ * @file BinFiles.h
+ * BinFiles class declaration
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/133#discussion_r138108806
--- Diff: libminifi/include/processors/BinFiles.h ---
@@ -0,0 +1,295 @@
+/**
+ * @file BinFiles.h
+ * BinFiles class declaration
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137859968
--- Diff: libminifi/include/c2/C2Payload.h ---
@@ -0,0 +1,187 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137858437
--- Diff: libminifi/include/c2/C2Payload.h ---
@@ -0,0 +1,187 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137857666
--- Diff: libminifi/include/ResourceClaim.h ---
@@ -55,23 +58,20 @@ class ResourceClaim : public
std::enable_shared_from_this
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/133
Please review and provide feedback.
---
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/133
Merge Content processor
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/123
@phrocker the CI build is failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/117
[config.txt](https://github.com/apache/nifi-minifi-cpp/files/1166193/config.txt)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/117
@phrocker the normal flow that i run is attached. one get file connected to
a RPG
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/117
overall looks good. may be some optimization for the queue.
Please some tests in long duration to make sure it is not breaking the
master because it is big change.
---
If your
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/117#discussion_r128773288
--- Diff: libminifi/include/utils/ThreadPool.h ---
@@ -246,15 +349,67 @@ void ThreadPool::startWorkers() {
template
void ThreadPool
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/117#discussion_r128621371
--- Diff: libminifi/include/utils/ThreadPool.h ---
@@ -246,15 +349,67 @@ void ThreadPool::startWorkers() {
template
void ThreadPool
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/117#discussion_r128620813
--- Diff: libminifi/include/utils/ThreadPool.h ---
@@ -246,15 +349,67 @@ void ThreadPool::startWorkers() {
template
void ThreadPool
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
@phrocker looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/119
@phrocker it is passed now after i retrigger the same.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/119
@phrocker it is run OK in my MAC. run OK in Xcode 7.3 and fail in 8.3 in
travis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user benqiu2016 closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/114
@phrocker used https://github.com/apache/nifi-minifi-cpp/pull/119 which has
a single merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/119
MINIFI-70: enhance site2site port negotiation
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/114
Thanks for the review. Can we merge the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/114
@phrocker @kevdoran use lock, extract token code, set default port. we need
to support /nifi-api/controller which is common to 1.x and 0.x.
---
If your project is set up for it, you
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/114
@phrocker if we use a stack based lock guard, in order to control the
period of lock, i need to add scope for the lock guard inside {}. it make code
less readable.
Anyway. i can
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126240211
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -20,6 +20,9 @@
#include "../include/RemoteProcessorGroupP
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126239506
--- Diff: libminifi/include/utils/HTTPUtils.h ---
@@ -88,6 +90,40 @@ struct HTTPRequestResponse {
};
+static void parse_url
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126211327
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -150,6 +194,87 @@ void
RemoteProcessorGroupPort::onTrigger(core::ProcessContext
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126210180
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -150,6 +194,87 @@ void
RemoteProcessorGroupPort::onTrigger(core::ProcessContext
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126209183
--- Diff: libminifi/include/Site2SiteClientProtocol.h ---
@@ -387,6 +387,15 @@ class DataPacket {
};
+/**
+ * Site2Site
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126208386
--- Diff: libminifi/include/utils/HTTPUtils.h ---
@@ -88,6 +90,40 @@ struct HTTPRequestResponse {
};
+static void parse_url
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/114
@phrocker please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/114
@phrocker please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123530192
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -314,10 +314,8 @@ void
YamlConfiguration::parseProvenanceReportingYaml(YAML::Node
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123529970
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -344,7 +427,8 @@ int
Site2SiteClientProtocol::readRequestType(RequestType
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123529541
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -319,6 +344,64 @@ void Site2SiteClientProtocol::tearDown() {
_peerState = IDLE
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123529125
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -150,6 +147,87 @@ void
RemoteProcessorGroupPort::onTrigger(core::ProcessContext
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123528501
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -278,26 +301,28 @@ bool Site2SiteClientProtocol::handShake
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123528403
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -38,7 +39,8 @@ namespace minifi {
bool Site2SiteClientProtocol::establish
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123527545
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -76,27 +89,20 @@ void
RemoteProcessorGroupPort::returnProtocol(std::unique_ptr
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123527427
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -54,19 +57,29 @@ bool create = true) {
std::unique_ptr nextProtocol = nullptr
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123526843
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -54,19 +57,29 @@ bool create = true) {
std::unique_ptr nextProtocol = nullptr
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114
site2site port negotiation
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
it is a very large commit. Overall looks good .
Couple of comments over all
1) for the volatile repo, have we run the some test over night and monitor
the memory to see whether we
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/110#discussion_r123119696
--- Diff: libminifi/include/core/repository/AtomicRepoEntries.h ---
@@ -0,0 +1,501 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/110#discussion_r123118428
--- Diff: libminifi/include/core/repository/VolatileRepository.h ---
@@ -331,22 +132,240 @@ class VolatileRepository : public core::Repository
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/110#discussion_r123110689
--- Diff: libminifi/include/core/FlowFile.h ---
@@ -224,6 +224,10 @@ class FlowFile {
void setStoredToRepository(bool
Github user benqiu2016 closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/107
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/107
@phrocker
https://github.com/apache/nifi-minifi-cpp/pull/112 for a single commit
close this one for now
---
If your project is set up for it, you can reply to this email
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/112
MINIFI-262: Configuration Listener
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/107
@phrocker add test case, use condition variable, please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r120533380
--- Diff: libminifi/src/FlowController.cpp ---
@@ -163,6 +174,31 @@ FlowController::~FlowController() {
provenance_repo_ = nullptr
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/107
@phrocker please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r120017101
--- Diff: libminifi/src/FlowController.cpp ---
@@ -175,7 +211,7 @@ void FlowController::stop(bool force) {
this->flow_file_repo_-&g
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r120017104
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -32,16 +32,25 @@ namespace core {
core::ProcessGroup *YamlConfiguration
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r120017069
--- Diff: libminifi/src/FlowController.cpp ---
@@ -163,6 +174,31 @@ FlowController::~FlowController() {
provenance_repo_ = nullptr
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r120017020
--- Diff: libminifi/src/ConfigurationListener.cpp ---
@@ -0,0 +1,130 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r120017002
--- Diff: libminifi/include/core/repository/FlowFileRepository.h ---
@@ -36,7 +36,7 @@ namespace repository {
#define
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r120017010
--- Diff: libminifi/src/ConfigurationListener.cpp ---
@@ -0,0 +1,130 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107
Configuration listener
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/93
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/89
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/90#discussion_r114691577
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -417,29 +405,27 @@ void YamlConfiguration::parseConnectionYaml
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/90#discussion_r114679611
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -450,27 +436,24 @@ void YamlConfiguration::parseConnectionYaml
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/90#discussion_r114679460
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -417,29 +405,27 @@ void YamlConfiguration::parseConnectionYaml
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/82
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/81
@apiri fix the provenance report not defined case. Thanks for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/81
@apiri refactor based on your above comments. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/81#discussion_r113841544
--- Diff: libminifi/test/unit/SerializationTests.cpp ---
@@ -16,130 +16,237 @@
* limitations under the License
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/81#discussion_r113841446
--- Diff: libminifi/test/unit/SiteToSiteHelper.h ---
@@ -0,0 +1,156 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/81#discussion_r113841440
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -339,7 +339,7 @@ void YamlConfiguration::parseProvenanceReportingYaml
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/81
@apiri please review and merge. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/81
MINIFI-269: Add Site2Site Test case
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/74
@apiri Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r111843708
--- Diff: libminifi/include/core/Processor.h ---
@@ -239,12 +242,21 @@ class Processor : public Connectable, public
ConfigurableComponent
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/75
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/77
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/74
@apiri i addressed your above review comments. Adding the new test case to
support full site2site is not as easy as we thought, we need to support hand
shake/CRC/two phase commit to make
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/74
@phrocker it looks like the travis for MAC is OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/74
my MAC build linter is OKW12612:build binqiu$ make linter
/Users/binqiu/report/nifi-minifi-cpp/libminifi/include//Connection.h,/Users/binqiu/report/nifi-minifi-cpp/libminifi/include
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/74
@phrocker
97%] Building C object
thirdparty/civetweb-1.9.1/src/CMakeFiles/c-executable.dir/main.c.o
Linking C executable civetweb
/usr/include/x86_64-linux-gnu/bits/stdio2.h
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r110006513
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -1240,6 +1257,88 @@ void Site2SiteClientProtocol::transferFlowFiles(
return
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r110004694
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -1240,6 +1257,88 @@ void Site2SiteClientProtocol::transferFlowFiles(
return
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r110004494
--- Diff: libminifi/src/provenance/ProvenanceTaskReport.cpp ---
@@ -0,0 +1,221 @@
+/**
+ * @file ProvenanceTaskReport.cpp
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109958322
--- Diff: libminifi/src/provenance/ProvenanceRepository.cpp ---
@@ -36,6 +36,7 @@ void ProvenanceRepository::run() {
uint64_t curTime
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109956092
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -1240,6 +1257,88 @@ void Site2SiteClientProtocol::transferFlowFiles(
return
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109955536
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -682,6 +682,7 @@ bool Site2SiteClientProtocol::receive(std::string
transactionID
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109954861
--- Diff: thirdparty/jsoncpp/devtools/batchbuild.py ---
@@ -0,0 +1,278 @@
+from __future__ import print_function
--- End diff
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109954793
--- Diff: libminifi/src/provenance/ProvenanceTaskReport.cpp ---
@@ -0,0 +1,221 @@
+/**
+ * @file ProvenanceTaskReport.cpp
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109954528
--- Diff: libminifi/src/provenance/ProvenanceTaskReport.cpp ---
@@ -0,0 +1,221 @@
+/**
+ * @file ProvenanceTaskReport.cpp
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109761443
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -682,6 +682,7 @@ bool Site2SiteClientProtocol::receive(std::string
transactionID
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109760197
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -1240,6 +1257,88 @@ void Site2SiteClientProtocol::transferFlowFiles(
return
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109759205
--- Diff: thirdparty/jsoncpp/devtools/batchbuild.py ---
@@ -0,0 +1,278 @@
+from __future__ import print_function
--- End diff
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109758846
--- Diff: libminifi/src/provenance/ProvenanceRepository.cpp ---
@@ -36,6 +36,7 @@ void ProvenanceRepository::run() {
uint64_t curTime
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109758278
--- Diff: libminifi/src/provenance/ProvenanceTaskReport.cpp ---
@@ -0,0 +1,221 @@
+/**
+ * @file ProvenanceTaskReport.cpp
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109757748
--- Diff: libminifi/src/provenance/ProvenanceTaskReport.cpp ---
@@ -0,0 +1,221 @@
+/**
+ * @file ProvenanceTaskReport.cpp
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74
Minifi 227
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps
1 - 100 of 155 matches
Mail list logo
